[Intel-gfx] [PATCH] drm/i915/opregion: Fix CONFIG_ACPI=n builds adding missing intel_opregion_cleanup() prototype

[Intel-gfx] [PATCH] drm/i915/opregion: Fix CONFIG_ACPI=n builds adding missing intel_opregion_cleanup() prototype

[Imre Deak]

Add the missing intel_opregion_cleanup() prototype fixing CONFIG_ACPI=n
builds.

Fixes: 3e226e4a2180 ("drm/i915/opregion: Cleanup opregion after errors during driver loading")
Cc: Jani Nikula <jani.nikula@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202303141610.6L1VO7Gw-lkp@intel.com/
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_opregion.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h
index 181eb3e9abbf3..fd2ea8ef0fa20 100644
--- a/drivers/gpu/drm/i915/display/intel_opregion.h
+++ b/drivers/gpu/drm/i915/display/intel_opregion.h
@@ -86,6 +86,10 @@ static inline int intel_opregion_setup(struct drm_i915_private *dev_priv)
 	return 0;
 }
 
+static inline void intel_opregion_cleanup(struct drm_i915_private *i915)
+{
+}
+
 static inline void intel_opregion_register(struct drm_i915_private *dev_priv)
 {
 }
-- 
2.37.1

Re: [Intel-gfx] [PATCH] drm/i915/opregion: Fix CONFIG_ACPI=n builds adding missing intel_opregion_cleanup() prototype

[Das, Nirmoy]

On 3/14/2023 10:27 AM, Imre Deak wrote:
> Add the missing intel_opregion_cleanup() prototype fixing CONFIG_ACPI=n
> builds.
>
> Fixes: 3e226e4a2180 ("drm/i915/opregion: Cleanup opregion after errors during driver loading")
> Cc: Jani Nikula <jani.nikula@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303141610.6L1VO7Gw-lkp@intel.com/
> Signed-off-by: Imre Deak <imre.deak@intel.com>


Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

> ---
>   drivers/gpu/drm/i915/display/intel_opregion.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h
> index 181eb3e9abbf3..fd2ea8ef0fa20 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.h
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.h
> @@ -86,6 +86,10 @@ static inline int intel_opregion_setup(struct drm_i915_private *dev_priv)
>   	return 0;
>   }
>   
> +static inline void intel_opregion_cleanup(struct drm_i915_private *i915)
> +{
> +}
> +
>   static inline void intel_opregion_register(struct drm_i915_private *dev_priv)
>   {
>   }

Re: [Intel-gfx] [PATCH] drm/i915/opregion: Fix CONFIG_ACPI=n builds adding missing intel_opregion_cleanup() prototype

[Imre Deak]

On Tue, Mar 14, 2023 at 10:43:50AM +0100, Das, Nirmoy wrote:
> 
> On 3/14/2023 10:27 AM, Imre Deak wrote:
> > Add the missing intel_opregion_cleanup() prototype fixing CONFIG_ACPI=n
> > builds.
> > 
> > Fixes: 3e226e4a2180 ("drm/i915/opregion: Cleanup opregion after errors during driver loading")
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202303141610.6L1VO7Gw-lkp@intel.com/
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

Thanks for the review, pushed the patch to din.

> > ---
> >   drivers/gpu/drm/i915/display/intel_opregion.h | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h
> > index 181eb3e9abbf3..fd2ea8ef0fa20 100644
> > --- a/drivers/gpu/drm/i915/display/intel_opregion.h
> > +++ b/drivers/gpu/drm/i915/display/intel_opregion.h
> > @@ -86,6 +86,10 @@ static inline int intel_opregion_setup(struct drm_i915_private *dev_priv)
> >   	return 0;
> >   }
> > +static inline void intel_opregion_cleanup(struct drm_i915_private *i915)
> > +{
> > +}
> > +
> >   static inline void intel_opregion_register(struct drm_i915_private *dev_priv)
> >   {
> >   }