* [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register
@ 2023-09-26 21:58 Nirmoy Das
2023-09-26 22:15 ` Matt Roper
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Nirmoy Das @ 2023-09-26 21:58 UTC (permalink / raw)
To: intel-gfx; +Cc: matthew.d.roper, dri-devel, Nirmoy Das
On MTL GEN12_RING_FAULT_REG is not replicated so don't
do mcr based operation for this register.
v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt).
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt.c | 13 ++++++++++++-
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 +
drivers/gpu/drm/i915/i915_gpu_error.c | 10 +++++++++-
3 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index 93062c35e072..430738607f61 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -262,10 +262,21 @@ intel_gt_clear_error_registers(struct intel_gt *gt,
I915_MASTER_ERROR_INTERRUPT);
}
- if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
+ /*
+ * for media tile this ring fault register is not replicated
+ * so skip doing mcr ops on it.
+ */
+ if (MEDIA_VER(i915) == 13 && gt->type == GT_MEDIA) {
+ intel_uncore_rmw(uncore, XELPMP_RING_FAULT_REG,
+ RING_FAULT_VALID, 0);
+ intel_uncore_posting_read(uncore,
+ XELPMP_RING_FAULT_REG);
+
+ } else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
intel_gt_mcr_multicast_rmw(gt, XEHP_RING_FAULT_REG,
RING_FAULT_VALID, 0);
intel_gt_mcr_read_any(gt, XEHP_RING_FAULT_REG);
+
} else if (GRAPHICS_VER(i915) >= 12) {
intel_uncore_rmw(uncore, GEN12_RING_FAULT_REG, RING_FAULT_VALID, 0);
intel_uncore_posting_read(uncore, GEN12_RING_FAULT_REG);
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
index cca4bac8f8b0..eecd0a87a647 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
@@ -1084,6 +1084,7 @@
#define GEN12_RING_FAULT_REG _MMIO(0xcec4)
#define XEHP_RING_FAULT_REG MCR_REG(0xcec4)
+#define XELPMP_RING_FAULT_REG _MMIO(0xcec4)
#define GEN8_RING_FAULT_ENGINE_ID(x) (((x) >> 12) & 0x7)
#define RING_FAULT_GTTSEL_MASK (1 << 11)
#define RING_FAULT_SRCID(x) (((x) >> 3) & 0xff)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index f4ebcfb70289..f0b691ea3a6e 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1234,7 +1234,15 @@ static void engine_record_registers(struct intel_engine_coredump *ee)
if (GRAPHICS_VER(i915) >= 6) {
ee->rc_psmi = ENGINE_READ(engine, RING_PSMI_CTL);
- if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
+ /*
+ * for media tile this ring fault register is not replicated
+ * so skip doing mcr ops on it.
+ */
+ if (MEDIA_VER(i915) == 13 && engine->gt->type == GT_MEDIA)
+ ee->fault_reg = intel_uncore_read(engine->uncore,
+ XELPMP_RING_FAULT_REG);
+
+ else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
ee->fault_reg = intel_gt_mcr_read_any(engine->gt,
XEHP_RING_FAULT_REG);
else if (GRAPHICS_VER(i915) >= 12)
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register
2023-09-26 21:58 [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Nirmoy Das
@ 2023-09-26 22:15 ` Matt Roper
2023-09-27 3:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Skip MCR ops for ring fault register (rev2) Patchwork
2023-09-27 7:04 ` [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Andi Shyti
2 siblings, 0 replies; 5+ messages in thread
From: Matt Roper @ 2023-09-26 22:15 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx, dri-devel
On Tue, Sep 26, 2023 at 11:58:02PM +0200, Nirmoy Das wrote:
> On MTL GEN12_RING_FAULT_REG is not replicated so don't
> do mcr based operation for this register.
>
> v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt).
>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt.c | 13 ++++++++++++-
> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 +
> drivers/gpu/drm/i915/i915_gpu_error.c | 10 +++++++++-
> 3 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> index 93062c35e072..430738607f61 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -262,10 +262,21 @@ intel_gt_clear_error_registers(struct intel_gt *gt,
> I915_MASTER_ERROR_INTERRUPT);
> }
>
> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> + /*
> + * for media tile this ring fault register is not replicated
Nitpicks: s/tile/gt/ and either write it as "For the media GT..."
(singular) or "For media GTs..." (plural). Same with the other copy of
this comment farther down.
> + * so skip doing mcr ops on it.
> + */
> + if (MEDIA_VER(i915) == 13 && gt->type == GT_MEDIA) {
I guess for now we should probably make this (and the one farther down)
a ">=" instead of "==" under the assumption future media versions will
do the same in case we get some kind of refresh platform down the road
with a slightly higher version number.
Aside from those minor tweaks,
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> + intel_uncore_rmw(uncore, XELPMP_RING_FAULT_REG,
> + RING_FAULT_VALID, 0);
> + intel_uncore_posting_read(uncore,
> + XELPMP_RING_FAULT_REG);
> +
> + } else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> intel_gt_mcr_multicast_rmw(gt, XEHP_RING_FAULT_REG,
> RING_FAULT_VALID, 0);
> intel_gt_mcr_read_any(gt, XEHP_RING_FAULT_REG);
> +
> } else if (GRAPHICS_VER(i915) >= 12) {
> intel_uncore_rmw(uncore, GEN12_RING_FAULT_REG, RING_FAULT_VALID, 0);
> intel_uncore_posting_read(uncore, GEN12_RING_FAULT_REG);
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> index cca4bac8f8b0..eecd0a87a647 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> @@ -1084,6 +1084,7 @@
>
> #define GEN12_RING_FAULT_REG _MMIO(0xcec4)
> #define XEHP_RING_FAULT_REG MCR_REG(0xcec4)
> +#define XELPMP_RING_FAULT_REG _MMIO(0xcec4)
> #define GEN8_RING_FAULT_ENGINE_ID(x) (((x) >> 12) & 0x7)
> #define RING_FAULT_GTTSEL_MASK (1 << 11)
> #define RING_FAULT_SRCID(x) (((x) >> 3) & 0xff)
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index f4ebcfb70289..f0b691ea3a6e 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1234,7 +1234,15 @@ static void engine_record_registers(struct intel_engine_coredump *ee)
> if (GRAPHICS_VER(i915) >= 6) {
> ee->rc_psmi = ENGINE_READ(engine, RING_PSMI_CTL);
>
> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
> + /*
> + * for media tile this ring fault register is not replicated
> + * so skip doing mcr ops on it.
> + */
> + if (MEDIA_VER(i915) == 13 && engine->gt->type == GT_MEDIA)
> + ee->fault_reg = intel_uncore_read(engine->uncore,
> + XELPMP_RING_FAULT_REG);
> +
> + else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
> ee->fault_reg = intel_gt_mcr_read_any(engine->gt,
> XEHP_RING_FAULT_REG);
> else if (GRAPHICS_VER(i915) >= 12)
> --
> 2.41.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Skip MCR ops for ring fault register (rev2)
2023-09-26 21:58 [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Nirmoy Das
2023-09-26 22:15 ` Matt Roper
@ 2023-09-27 3:17 ` Patchwork
2023-09-27 7:04 ` [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Andi Shyti
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-09-27 3:17 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8774 bytes --]
== Series Details ==
Series: drm/i915/mtl: Skip MCR ops for ring fault register (rev2)
URL : https://patchwork.freedesktop.org/series/124276/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13682 -> Patchwork_124276v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/index.html
Participating hosts (41 -> 39)
------------------------------
Additional (1): fi-kbl-soraka
Missing (3): bat-dg2-9 fi-snb-2520m fi-kbl-8809g
Known issues
------------
Here are the changes found in Patchwork_124276v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][4] -> [ABORT][5] ([i915#9414])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-mtlp-8/igt@i915_selftest@live@requests.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-rkl-11600: [PASS][6] -> [FAIL][7] ([fdo#103375])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/fi-rkl-11600/igt@i915_suspend@basic-s2idle-without-i915.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/fi-rkl-11600/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-adlp-11: [PASS][8] -> [DMESG-WARN][9] ([i915#6868])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_dsc@dsc-basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271]) +9 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-adlp-9: NOTRUN -> [SKIP][11] ([i915#3546]) +2 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-9/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-c-dp-5:
- bat-adlp-11: [PASS][12] -> [ABORT][13] ([i915#8668])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-c-dp-5.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-c-dp-5.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][14] -> [ABORT][15] ([i915#8668])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
#### Possible fixes ####
* igt@kms_chamelium_edid@hdmi-edid-read:
- {bat-dg2-13}: [DMESG-WARN][16] ([i915#7952]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_chamelium_frames@dp-crc-fast:
- {bat-dg2-13}: [DMESG-WARN][18] ([Intel XE#485]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
* igt@kms_flip@basic-plain-flip@b-dp6:
- bat-adlp-11: [DMESG-WARN][20] ([i915#6868]) -> [PASS][21] +1 other test pass
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_flip@basic-plain-flip@b-dp6.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_flip@basic-plain-flip@b-dp6.html
* igt@kms_flip@basic-plain-flip@c-dp6:
- bat-adlp-11: [FAIL][22] ([i915#6121]) -> [PASS][23] +8 other tests pass
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_flip@basic-plain-flip@c-dp6.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_flip@basic-plain-flip@c-dp6.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-5:
- bat-adlp-11: [DMESG-FAIL][24] ([i915#6868]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-5.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-5.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-dp-5:
- bat-adlp-11: [FAIL][26] ([i915#9047]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-dp-5.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-dp-5.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-dp-6:
- bat-adlp-11: [ABORT][28] ([i915#8668]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-dp-6.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-dp-6.html
#### Warnings ####
* igt@kms_force_connector_basic@force-edid:
- bat-adlp-11: [FAIL][30] ([i915#8803]) -> [SKIP][31] ([i915#4093])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13682/bat-adlp-11/igt@kms_force_connector_basic@force-edid.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/bat-adlp-11/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#485]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/485
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7952]: https://gitlab.freedesktop.org/drm/intel/issues/7952
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8803]: https://gitlab.freedesktop.org/drm/intel/issues/8803
[i915#9047]: https://gitlab.freedesktop.org/drm/intel/issues/9047
[i915#9414]: https://gitlab.freedesktop.org/drm/intel/issues/9414
Build changes
-------------
* Linux: CI_DRM_13682 -> Patchwork_124276v2
CI-20190529: 20190529
CI_DRM_13682: a42554bf0755b80fdfb8e91ca35ae6835bb3534d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7503: 7503
Patchwork_124276v2: a42554bf0755b80fdfb8e91ca35ae6835bb3534d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
481d70d95dbd drm/i915/mtl: Skip MCR ops for ring fault register
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124276v2/index.html
[-- Attachment #2: Type: text/html, Size: 10230 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register
2023-09-26 21:58 [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Nirmoy Das
2023-09-26 22:15 ` Matt Roper
2023-09-27 3:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Skip MCR ops for ring fault register (rev2) Patchwork
@ 2023-09-27 7:04 ` Andi Shyti
2023-09-27 10:26 ` Nirmoy Das
2 siblings, 1 reply; 5+ messages in thread
From: Andi Shyti @ 2023-09-27 7:04 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx, matthew.d.roper, dri-devel
Hi Nirmoy,
On Tue, Sep 26, 2023 at 11:58:02PM +0200, Nirmoy Das wrote:
> On MTL GEN12_RING_FAULT_REG is not replicated so don't
> do mcr based operation for this register.
>
> v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt).
>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
This looks very good!
> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> + /*
> + * for media tile this ring fault register is not replicated
> + * so skip doing mcr ops on it.
Can we spare a few more words on "doing mcr ops on it"?
Andi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register
2023-09-27 7:04 ` [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Andi Shyti
@ 2023-09-27 10:26 ` Nirmoy Das
0 siblings, 0 replies; 5+ messages in thread
From: Nirmoy Das @ 2023-09-27 10:26 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx, matthew.d.roper, dri-devel
On 9/27/2023 9:04 AM, Andi Shyti wrote:
> Hi Nirmoy,
>
> On Tue, Sep 26, 2023 at 11:58:02PM +0200, Nirmoy Das wrote:
>> On MTL GEN12_RING_FAULT_REG is not replicated so don't
>> do mcr based operation for this register.
>>
>> v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt).
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> This looks very good!
My tired brain took it as end of mail.
>
>> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
>> + /*
>> + * for media tile this ring fault register is not replicated
>> + * so skip doing mcr ops on it.
> Can we spare a few more words on "doing mcr ops on it"?
Sent out
https://patchwork.freedesktop.org/patch/559759/?series=124325&rev=1
to improve this.
Thanks,
Nirmoy
>
> Andi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-27 10:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-26 21:58 [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Nirmoy Das
2023-09-26 22:15 ` Matt Roper
2023-09-27 3:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Skip MCR ops for ring fault register (rev2) Patchwork
2023-09-27 7:04 ` [Intel-gfx] [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register Andi Shyti
2023-09-27 10:26 ` Nirmoy Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).