* [PATCH] drm/i915: fix color order for BGR formats on IVB
@ 2012-08-22 6:17 Vijay Purushothaman
2012-08-22 7:49 ` Paul Menzel
0 siblings, 1 reply; 3+ messages in thread
From: Vijay Purushothaman @ 2012-08-22 6:17 UTC (permalink / raw)
To: Intel Graphics
This is already fixed for ILK and SNB but somehow IVB is missed.
Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
Signed-off-by: Ben Lin <ben.y.lin@intel.com>
---
drivers/gpu/drm/i915/intel_sprite.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index cc8df4d..6045a01 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -54,17 +54,17 @@ ivb_update_plane(struct drm_plane *plane, struct drm_framebuffer *fb,
/* Mask out pixel format bits in case we change it */
sprctl &= ~SPRITE_PIXFORMAT_MASK;
- sprctl &= ~SPRITE_RGB_ORDER_RGBX;
+ sprctl &= ~SPRITE_RGB_ORDER_XBGR;
sprctl &= ~SPRITE_YUV_BYTE_ORDER_MASK;
sprctl &= ~SPRITE_TILED;
switch (fb->pixel_format) {
case DRM_FORMAT_XBGR8888:
- sprctl |= SPRITE_FORMAT_RGBX888;
+ sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
pixel_size = 4;
break;
case DRM_FORMAT_XRGB8888:
- sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
+ sprctl |= SPRITE_FORMAT_RGBX888;
pixel_size = 4;
break;
case DRM_FORMAT_YUYV:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: fix color order for BGR formats on IVB
2012-08-22 6:17 [PATCH] drm/i915: fix color order for BGR formats on IVB Vijay Purushothaman
@ 2012-08-22 7:49 ` Paul Menzel
2012-08-22 9:17 ` Vijay Purushothaman
0 siblings, 1 reply; 3+ messages in thread
From: Paul Menzel @ 2012-08-22 7:49 UTC (permalink / raw)
To: Vijay Purushothaman; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 618 bytes --]
Dear Vijay,
Am Mittwoch, den 22.08.2012, 11:47 +0530 schrieb Vijay Purushothaman:
> This is already fixed for ILK and SNB
… in what commits?
> but somehow IVB is missed.
>
> Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
> Signed-off-by: Ben Lin <ben.y.lin@intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
[…]
Please resend as [PATCH v2] with the updated commit message [1].
Thanks,
Paul
[1] http://wireless.kernel.org/en/developers/Documentation/git-guide#Annotating_new_revision
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: fix color order for BGR formats on IVB
2012-08-22 7:49 ` Paul Menzel
@ 2012-08-22 9:17 ` Vijay Purushothaman
0 siblings, 0 replies; 3+ messages in thread
From: Vijay Purushothaman @ 2012-08-22 9:17 UTC (permalink / raw)
To: Paul Menzel; +Cc: intel-gfx
On 8/22/2012 1:19 PM, Paul Menzel wrote:
> Dear Vijay,
>
>
> Am Mittwoch, den 22.08.2012, 11:47 +0530 schrieb Vijay Purushothaman:
>> This is already fixed for ILK and SNB
> … in what commits?
Added the previous commit number which solved this problem on
Sandybridge and description in the second version of the patch.
Thanks much for the review.
Thanks,
Vijay
>> but somehow IVB is missed.
>>
>> Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
>> Signed-off-by: Ben Lin <ben.y.lin@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_sprite.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
> […]
>
> Please resend as [PATCH v2] with the updated commit message [1].
>
>
> Thanks,
>
> Paul
>
>
> [1] http://wireless.kernel.org/en/developers/Documentation/git-guide#Annotating_new_revision
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-22 9:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-22 6:17 [PATCH] drm/i915: fix color order for BGR formats on IVB Vijay Purushothaman
2012-08-22 7:49 ` Paul Menzel
2012-08-22 9:17 ` Vijay Purushothaman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).