From: Matthew Auld <matthew.auld@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait
Date: Fri, 22 Jan 2021 10:27:21 +0000 [thread overview]
Message-ID: <5b188fea-2417-fa6a-7a8c-c2d240b359f7@intel.com> (raw)
In-Reply-To: <20210121232807.16618-1-chris@chris-wilson.co.uk>
On 21/01/2021 23:28, Chris Wilson wrote:
> The first thing the active retirement worker does is decrement the
> i915_active count.
>
> The first thing we do during i915_active_wait is try to increment the
> i915_active count, but only if already active [non-zero].
>
> The wait may see that the retirement is already started and so marked the
> i915_active as idle, and skip waiting for the retirement handler.
> However, the caller of i915_active_wait may immediately free the
> i915_active upon returning (e.g. i915_vma_destroy) so we must not return
> before the concurrent access from the worker are completed. We must
> always flush the worker.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2473
> Fixes: 274cbf20fd10 ("drm/i915: Push the i915_active.retire into a worker")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: <stable@vger.kernel.org> # v5.5+
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-01-22 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 23:28 [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait Chris Wilson
2021-01-22 5:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-22 9:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-22 10:27 ` Matthew Auld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b188fea-2417-fa6a-7a8c-c2d240b359f7@intel.com \
--to=matthew.auld@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).