intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915: disable RC6+ on Sandy Bridge
@ 2011-04-06 16:07 Jesse Barnes
  2011-04-06 18:46 ` Chris Wilson
  0 siblings, 1 reply; 2+ messages in thread
From: Jesse Barnes @ 2011-04-06 16:07 UTC (permalink / raw)
  To: intel-gfx; +Cc: stable

RC6+ can cause trouble, so keep it disabled (this costs us a little
power, around 20mW I think, but better safe than sorry).

Cc: stable@kernel.org
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_display.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 432fc04..b265bd3 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6874,7 +6874,6 @@ void gen6_enable_rps(struct drm_i915_private *dev_priv)
 	I915_WRITE(GEN6_RC6pp_THRESHOLD, 64000); /* unused */
 
 	I915_WRITE(GEN6_RC_CONTROL,
-		   GEN6_RC_CTL_RC6p_ENABLE |
 		   GEN6_RC_CTL_RC6_ENABLE |
 		   GEN6_RC_CTL_EI_MODE(1) |
 		   GEN6_RC_CTL_HW_ENABLE);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/i915: disable RC6+ on Sandy Bridge
  2011-04-06 16:07 [PATCH] drm/i915: disable RC6+ on Sandy Bridge Jesse Barnes
@ 2011-04-06 18:46 ` Chris Wilson
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2011-04-06 18:46 UTC (permalink / raw)
  To: Jesse Barnes, intel-gfx; +Cc: stable

On Wed,  6 Apr 2011 09:07:10 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> RC6+ can cause trouble, so keep it disabled (this costs us a little
> power, around 20mW I think, but better safe than sorry).

Any clues as to the failure mode?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-06 18:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-06 16:07 [PATCH] drm/i915: disable RC6+ on Sandy Bridge Jesse Barnes
2011-04-06 18:46 ` Chris Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).