* [Intel-gfx] [PATCH 1/2] drm/i915: Add DEBUG_GEM to the recommended CI config
@ 2021-01-14 11:34 Chris Wilson
2021-01-14 11:34 ` [Intel-gfx] [PATCH 2/2] drm/i915: Make GEM errors non-fatal by default Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2021-01-14 11:34 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Chris Wilson
Now that i915 compiles cleanly with Werror, we can enforce enabling
DEBUG_GEM when selecting the default debug config.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/Kconfig.debug | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index 0fb7fd0ef717..3701bae5b855 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -39,10 +39,12 @@ config DRM_I915_DEBUG
select DRM_DEBUG_SELFTEST
select DMABUF_SELFTESTS
select SW_SYNC # signaling validation framework (igt/syncobj*)
+ select DRM_I915_WERROR
+ select DRM_I915_DEBUG_GEM
+ select DRM_I915_DEBUG_MMIO
+ select DRM_I915_DEBUG_RUNTIME_PM
select DRM_I915_SW_FENCE_DEBUG_OBJECTS
select DRM_I915_SELFTEST
- select DRM_I915_DEBUG_RUNTIME_PM
- select DRM_I915_DEBUG_MMIO
select BROKEN # for prototype uAPI
default n
help
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: Make GEM errors non-fatal by default
2021-01-14 11:34 [Intel-gfx] [PATCH 1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Chris Wilson
@ 2021-01-14 11:34 ` Chris Wilson
2021-01-19 11:33 ` Mika Kuoppala
2021-01-14 18:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2021-01-14 11:34 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
While immensely convenient for developing to only tackle the first
error, and not be flooded by repeated or secondiary issues, many more
casual testers are not setup to remotely capture debug traces. For those
testers, it is more beneficial to keep the system running in the remote
chance that they are able to extract the original debug logs.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/Kconfig.debug | 16 ++++++++++++++++
drivers/gpu/drm/i915/i915_gem.h | 9 ++++++++-
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index 3701bae5b855..4005f6619bec 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -41,6 +41,7 @@ config DRM_I915_DEBUG
select SW_SYNC # signaling validation framework (igt/syncobj*)
select DRM_I915_WERROR
select DRM_I915_DEBUG_GEM
+ select DRM_I915_DEBUG_GEM_ONCE
select DRM_I915_DEBUG_MMIO
select DRM_I915_DEBUG_RUNTIME_PM
select DRM_I915_SW_FENCE_DEBUG_OBJECTS
@@ -80,6 +81,21 @@ config DRM_I915_DEBUG_GEM
If in doubt, say "N".
+config DRM_I915_DEBUG_GEM_ONCE
+ bool "Make a GEM debug failure fatal"
+ default n
+ depends on DRM_I915_DEBUG_GEM
+ help
+ During development, we often only want the very first failure
+ as that would otherwise be lost in the deluge of subsequent
+ failures. However, more causal testers may not want to trigger
+ a hard BUG_ON and hope that the system remains sufficiently usable
+ to capture a bug report in situ.
+
+ Recommended for driver developers only.
+
+ If in doubt, say "N".
+
config DRM_I915_ERRLOG_GEM
bool "Insert extra logging (very verbose) for common GEM errors"
default n
diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
index a4cad3f154ca..e622aee6e4be 100644
--- a/drivers/gpu/drm/i915/i915_gem.h
+++ b/drivers/gpu/drm/i915/i915_gem.h
@@ -38,11 +38,18 @@ struct drm_i915_private;
#define GEM_SHOW_DEBUG() drm_debug_enabled(DRM_UT_DRIVER)
+#ifdef CONFIG_DRM_I915_DEBUG_GEM_ONCE
+#define __GEM_BUG(cond) BUG()
+#else
+#define __GEM_BUG(cond) \
+ WARN(1, "%s:%d GEM_BUG_ON(%s)\n", __func__, __LINE__, __stringify(cond))
+#endif
+
#define GEM_BUG_ON(condition) do { if (unlikely((condition))) { \
GEM_TRACE_ERR("%s:%d GEM_BUG_ON(%s)\n", \
__func__, __LINE__, __stringify(condition)); \
GEM_TRACE_DUMP(); \
- BUG(); \
+ __GEM_BUG(condition); \
} \
} while(0)
#define GEM_WARN_ON(expr) WARN_ON(expr)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config
2021-01-14 11:34 [Intel-gfx] [PATCH 1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Chris Wilson
2021-01-14 11:34 ` [Intel-gfx] [PATCH 2/2] drm/i915: Make GEM errors non-fatal by default Chris Wilson
@ 2021-01-14 18:42 ` Patchwork
2021-01-14 19:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-15 9:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-01-14 18:42 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config
URL : https://patchwork.freedesktop.org/series/85869/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2ab1c85e3427 drm/i915: Add DEBUG_GEM to the recommended CI config
011954fe6a8a drm/i915: Make GEM errors non-fatal by default
-:59: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#59: FILE: drivers/gpu/drm/i915/i915_gem.h:42:
+#define __GEM_BUG(cond) BUG()
total: 0 errors, 1 warnings, 0 checks, 47 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config
2021-01-14 11:34 [Intel-gfx] [PATCH 1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Chris Wilson
2021-01-14 11:34 ` [Intel-gfx] [PATCH 2/2] drm/i915: Make GEM errors non-fatal by default Chris Wilson
2021-01-14 18:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Patchwork
@ 2021-01-14 19:12 ` Patchwork
2021-01-15 9:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-01-14 19:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2569 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config
URL : https://patchwork.freedesktop.org/series/85869/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9611 -> Patchwork_19357
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/index.html
Known issues
------------
Here are the changes found in Patchwork_19357 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@gem_sync@basic-all:
- fi-tgl-y: [DMESG-WARN][3] ([i915#402]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/fi-tgl-y/igt@gem_sync@basic-all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/fi-tgl-y/igt@gem_sync@basic-all.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [DMESG-WARN][5] ([i915#2868]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (41 -> 38)
------------------------------
Missing (3): fi-ctg-p8600 fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9611 -> Patchwork_19357
CI-20190529: 20190529
CI_DRM_9611: b8541c1dee4c710073a77b3a1ce4d261c420105e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5959: c5cf0734c4f6c1fa17a6a15b5aa721c3a0b8c494 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19357: 011954fe6a8a3590a167c834cee93b6da0b98b15 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
011954fe6a8a drm/i915: Make GEM errors non-fatal by default
2ab1c85e3427 drm/i915: Add DEBUG_GEM to the recommended CI config
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/index.html
[-- Attachment #1.2: Type: text/html, Size: 3299 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config
2021-01-14 11:34 [Intel-gfx] [PATCH 1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Chris Wilson
` (2 preceding siblings ...)
2021-01-14 19:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-01-15 9:09 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-01-15 9:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 19619 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config
URL : https://patchwork.freedesktop.org/series/85869/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9611_full -> Patchwork_19357_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19357_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_userptr_blits@process-exit-mmap-busy@uc:
- shard-skl: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1699]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl2/igt@gem_userptr_blits@process-exit-mmap-busy@uc.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][2] ([i915#454])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl4/igt@i915_pm_dc@dc6-psr.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-180:
- shard-snb: [PASS][3] -> [SKIP][4] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-snb7/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-snb2/igt@kms_big_fb@x-tiled-16bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][5] ([fdo#110725] / [fdo#111614])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-iclb4/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180:
- shard-skl: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111304])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl1/igt@kms_ccs@pipe-c-crc-primary-rotation-180.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-kbl: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-kbl4/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-skl: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl1/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen:
- shard-skl: NOTRUN -> [FAIL][11] ([i915#54]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [PASS][12] -> [FAIL][13] ([i915#2346])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl2/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2598])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#79])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#79])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2122])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2672])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271]) +76 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271]) +38 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-kbl4/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][26] ([i915#265])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-iclb7/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#2437])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl2/igt@kms_writeback@writeback-fb-id.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][32] -> [FAIL][33] ([i915#1542])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl4/igt@perf@polling-parameterized.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl6/igt@perf@polling-parameterized.html
- shard-tglb: [PASS][34] -> [FAIL][35] ([i915#1542])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-tglb8/igt@perf@polling-parameterized.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-tglb5/igt@perf@polling-parameterized.html
* igt@prime_vgem@sync@vcs1:
- shard-tglb: NOTRUN -> [INCOMPLETE][36] ([i915#409])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-tglb1/igt@prime_vgem@sync@vcs1.html
#### Possible fixes ####
* {igt@gem_exec_fair@basic-deadline}:
- shard-glk: [FAIL][37] ([i915#2846]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-glk3/igt@gem_exec_fair@basic-deadline.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* {igt@gem_exec_fair@basic-none-share@rcs0}:
- shard-iclb: [FAIL][39] ([i915#2842]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-apl: [SKIP][41] ([fdo#109271]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-apl8/igt@gem_exec_fair@basic-none-share@rcs0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-apl4/igt@gem_exec_fair@basic-none-share@rcs0.html
* {igt@gem_exec_fair@basic-pace@rcs0}:
- shard-kbl: [FAIL][43] ([i915#2842]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-kbl4/igt@gem_exec_fair@basic-pace@rcs0.html
* {igt@gem_exec_fair@basic-pace@vcs1}:
- shard-tglb: [FAIL][45] ([i915#2842]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-tglb2/igt@gem_exec_fair@basic-pace@vcs1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-tglb8/igt@gem_exec_fair@basic-pace@vcs1.html
* {igt@gem_exec_fair@basic-throttle@rcs0}:
- shard-glk: [FAIL][47] ([i915#2842]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-glk8/igt@gem_exec_fair@basic-throttle@rcs0.html
* {igt@gem_exec_schedule@u-semaphore-codependency}:
- shard-skl: [DMESG-WARN][49] ([i915#1610]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl2/igt@gem_exec_schedule@u-semaphore-codependency.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl1/igt@gem_exec_schedule@u-semaphore-codependency.html
* igt@i915_selftest@live@hangcheck:
- shard-kbl: [INCOMPLETE][51] ([i915#2782]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-kbl4/igt@i915_selftest@live@hangcheck.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-kbl4/igt@i915_selftest@live@hangcheck.html
* igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
- shard-snb: [SKIP][53] ([fdo#109271]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-snb7/igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-snb4/igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- shard-skl: [FAIL][55] ([i915#54]) -> [PASS][56] +10 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-skl: [FAIL][57] ([i915#2346]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_flip@2x-flip-vs-blocking-wf-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][59] ([i915#2122]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-glk7/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@bc-hdmi-a1-hdmi-a2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-glk5/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][61] ([i915#79]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [FAIL][63] ([i915#2122]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][65] ([i915#1188]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][67] ([fdo#108145] / [i915#265]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-iclb7/igt@kms_psr@psr2_sprite_plane_onoff.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_vblank@pipe-a-accuracy-idle:
- shard-skl: [FAIL][71] -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-skl5/igt@kms_vblank@pipe-a-accuracy-idle.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-skl6/igt@kms_vblank@pipe-a-accuracy-idle.html
* igt@perf@polling-parameterized:
- shard-iclb: [FAIL][73] ([i915#1542]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-iclb5/igt@perf@polling-parameterized.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-iclb8/igt@perf@polling-parameterized.html
* igt@prime_vgem@sync@bcs0:
- shard-tglb: [INCOMPLETE][75] ([i915#409]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-tglb5/igt@prime_vgem@sync@bcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-tglb1/igt@prime_vgem@sync@bcs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][77] ([i915#2684]) -> [WARN][78] ([i915#1804] / [i915#2684])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][79], [FAIL][80], [FAIL][81]) ([i915#1436] / [i915#1814] / [i915#2295]) -> ([FAIL][82], [FAIL][83]) ([i915#1814] / [i915#2295])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-kbl7/igt@runner@aborted.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-kbl3/igt@runner@aborted.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9611/shard-kbl4/igt@runner@aborted.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-kbl7/igt@runner@aborted.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/shard-kbl4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1699]: https://gitlab.freedesktop.org/drm/intel/issues/1699
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9611 -> Patchwork_19357
CI-20190529: 20190529
CI_DRM_9611: b8541c1dee4c710073a77b3a1ce4d261c420105e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5959: c5cf0734c4f6c1fa17a6a15b5aa721c3a0b8c494 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19357: 011954fe6a8a3590a167c834cee93b6da0b98b15 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19357/index.html
[-- Attachment #1.2: Type: text/html, Size: 23229 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make GEM errors non-fatal by default
2021-01-14 11:34 ` [Intel-gfx] [PATCH 2/2] drm/i915: Make GEM errors non-fatal by default Chris Wilson
@ 2021-01-19 11:33 ` Mika Kuoppala
0 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2021-01-19 11:33 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Chris Wilson
Chris Wilson <chris@chris-wilson.co.uk> writes:
> While immensely convenient for developing to only tackle the first
> error, and not be flooded by repeated or secondiary issues, many more
> casual testers are not setup to remotely capture debug traces. For those
> testers, it is more beneficial to keep the system running in the remote
> chance that they are able to extract the original debug logs.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/Kconfig.debug | 16 ++++++++++++++++
> drivers/gpu/drm/i915/i915_gem.h | 9 ++++++++-
> 2 files changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index 3701bae5b855..4005f6619bec 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -41,6 +41,7 @@ config DRM_I915_DEBUG
> select SW_SYNC # signaling validation framework (igt/syncobj*)
> select DRM_I915_WERROR
> select DRM_I915_DEBUG_GEM
> + select DRM_I915_DEBUG_GEM_ONCE
> select DRM_I915_DEBUG_MMIO
> select DRM_I915_DEBUG_RUNTIME_PM
> select DRM_I915_SW_FENCE_DEBUG_OBJECTS
> @@ -80,6 +81,21 @@ config DRM_I915_DEBUG_GEM
>
> If in doubt, say "N".
>
> +config DRM_I915_DEBUG_GEM_ONCE
> + bool "Make a GEM debug failure fatal"
> + default n
> + depends on DRM_I915_DEBUG_GEM
> + help
> + During development, we often only want the very first failure
> + as that would otherwise be lost in the deluge of subsequent
> + failures. However, more causal testers may not want to trigger
> + a hard BUG_ON and hope that the system remains sufficiently usable
> + to capture a bug report in situ.
Yes. And also sometimes check the state the hardware had ended up into.
eg. unusual conditions that are not captured by hang/hangcheck.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> +
> + Recommended for driver developers only.
> +
> + If in doubt, say "N".
> +
> config DRM_I915_ERRLOG_GEM
> bool "Insert extra logging (very verbose) for common GEM errors"
> default n
> diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
> index a4cad3f154ca..e622aee6e4be 100644
> --- a/drivers/gpu/drm/i915/i915_gem.h
> +++ b/drivers/gpu/drm/i915/i915_gem.h
> @@ -38,11 +38,18 @@ struct drm_i915_private;
>
> #define GEM_SHOW_DEBUG() drm_debug_enabled(DRM_UT_DRIVER)
>
> +#ifdef CONFIG_DRM_I915_DEBUG_GEM_ONCE
> +#define __GEM_BUG(cond) BUG()
> +#else
> +#define __GEM_BUG(cond) \
> + WARN(1, "%s:%d GEM_BUG_ON(%s)\n", __func__, __LINE__, __stringify(cond))
> +#endif
> +
> #define GEM_BUG_ON(condition) do { if (unlikely((condition))) { \
> GEM_TRACE_ERR("%s:%d GEM_BUG_ON(%s)\n", \
> __func__, __LINE__, __stringify(condition)); \
> GEM_TRACE_DUMP(); \
> - BUG(); \
> + __GEM_BUG(condition); \
> } \
> } while(0)
> #define GEM_WARN_ON(expr) WARN_ON(expr)
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-19 11:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 11:34 [Intel-gfx] [PATCH 1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Chris Wilson
2021-01-14 11:34 ` [Intel-gfx] [PATCH 2/2] drm/i915: Make GEM errors non-fatal by default Chris Wilson
2021-01-19 11:33 ` Mika Kuoppala
2021-01-14 18:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add DEBUG_GEM to the recommended CI config Patchwork
2021-01-14 19:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-15 9:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).