* [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI
@ 2022-11-26 13:27 Mikko Kovanen
2022-11-26 14:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mikko Kovanen @ 2022-11-26 13:27 UTC (permalink / raw)
To: intel-gfx
intel_dsi->ports contains bitmask of enabled ports and correspondingly
logic for selecting port for VBT packet sending must use port specific
bitmask when deciding appropriate port.
Fixes: 08c59dde71b7 ("drm/i915/dsi: fix VBT send packet port selection for ICL+")
Cc: stable@vger.kernel.org
Signed-off-by: Mikko Kovanen <mikko.kovanen@aavamobile.com>
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 75e8cc4337c9..fce69fa446d5 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -137,9 +137,9 @@ static enum port intel_dsi_seq_port_to_port(struct intel_dsi *intel_dsi,
return ffs(intel_dsi->ports) - 1;
if (seq_port) {
- if (intel_dsi->ports & PORT_B)
+ if (intel_dsi->ports & BIT(PORT_B))
return PORT_B;
- else if (intel_dsi->ports & PORT_C)
+ else if (intel_dsi->ports & BIT(PORT_C))
return PORT_C;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dsi: fix VBT send packet port selection for dual link DSI
2022-11-26 13:27 [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI Mikko Kovanen
@ 2022-11-26 14:03 ` Patchwork
2022-11-26 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-28 9:26 ` [Intel-gfx] [PATCH] " Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-11-26 14:03 UTC (permalink / raw)
To: Mikko Kovanen; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dsi: fix VBT send packet port selection for dual link DSI
URL : https://patchwork.freedesktop.org/series/111366/
State : warning
== Summary ==
Error: make htmldocs had i915 warnings
./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead
./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: fix VBT send packet port selection for dual link DSI
2022-11-26 13:27 [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI Mikko Kovanen
2022-11-26 14:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
@ 2022-11-26 14:25 ` Patchwork
2022-11-28 9:26 ` [Intel-gfx] [PATCH] " Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-11-26 14:25 UTC (permalink / raw)
To: Mikko Kovanen; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10700 bytes --]
== Series Details ==
Series: drm/i915/dsi: fix VBT send packet port selection for dual link DSI
URL : https://patchwork.freedesktop.org/series/111366/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12435 -> Patchwork_111366v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/index.html
Participating hosts (36 -> 36)
------------------------------
Additional (1): fi-adl-ddr5
Missing (1): fi-ctg-p8600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111366v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@workarounds:
- {bat-rpls-2}: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/bat-rpls-2/igt@i915_selftest@live@workarounds.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/bat-rpls-2/igt@i915_selftest@live@workarounds.html
Known issues
------------
Here are the changes found in Patchwork_111366v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- fi-adl-ddr5: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@debugfs_test@basic-hwmon.html
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][4] -> [FAIL][5] ([i915#7229])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-adl-ddr5: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_tiled_pread_basic:
- fi-adl-ddr5: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-adl-ddr5: NOTRUN -> [SKIP][8] ([i915#7561])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@module-reload:
- bat-dg1-6: [PASS][9] -> [FAIL][10] ([i915#7530])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/bat-dg1-6/igt@i915_pm_rpm@module-reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/bat-dg1-6/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@hangcheck:
- fi-adl-ddr5: NOTRUN -> [DMESG-WARN][11] ([i915#5591])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@i915_selftest@live@hangcheck.html
- fi-hsw-4770: [PASS][12] -> [INCOMPLETE][13] ([i915#4785])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@dp-edid-read:
- fi-adl-ddr5: NOTRUN -> [SKIP][14] ([fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@kms_chamelium@dp-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-adl-ddr5: NOTRUN -> [SKIP][15] ([i915#4103])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [PASS][16] -> [FAIL][17] ([i915#6298])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-adl-ddr5: NOTRUN -> [SKIP][18] ([fdo#109285])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@cursor_plane_move:
- fi-adl-ddr5: NOTRUN -> [SKIP][19] ([i915#1072]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@kms_psr@cursor_plane_move.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-adl-ddr5: NOTRUN -> [SKIP][20] ([i915#3555])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-adl-ddr5: NOTRUN -> [SKIP][21] ([fdo#109295] / [i915#3301])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- fi-adl-ddr5: NOTRUN -> [SKIP][22] ([fdo#109295] / [i915#3291]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-adl-ddr5/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][23] ([i915#2867]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_module_load@load:
- fi-bsw-kefka: [DMESG-WARN][25] ([i915#1982]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/fi-bsw-kefka/igt@i915_module_load@load.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-bsw-kefka/igt@i915_module_load@load.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][27] ([i915#5334]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_lrc:
- {bat-adln-1}: [INCOMPLETE][29] ([i915#4983]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@migrate:
- {bat-adlp-6}: [INCOMPLETE][31] ([i915#7348]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/bat-adlp-6/igt@i915_selftest@live@migrate.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/bat-adlp-6/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- {bat-rpls-2}: [INCOMPLETE][33] ([i915#6257]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/bat-rpls-2/igt@i915_selftest@live@requests.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/bat-rpls-2/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [FAIL][35] ([fdo#103375]) -> [INCOMPLETE][36] ([i915#4817])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12435/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7530]: https://gitlab.freedesktop.org/drm/intel/issues/7530
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
Build changes
-------------
* Linux: CI_DRM_12435 -> Patchwork_111366v1
CI-20190529: 20190529
CI_DRM_12435: ad232f8a0287b805a7a167eddad30fe33fbec9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7072: 69ba7163475925cdc69aebbdfa0e87453ae165c7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111366v1: ad232f8a0287b805a7a167eddad30fe33fbec9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
1fed2711974c drm/i915/dsi: fix VBT send packet port selection for dual link DSI
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111366v1/index.html
[-- Attachment #2: Type: text/html, Size: 11770 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI
2022-11-26 13:27 [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI Mikko Kovanen
2022-11-26 14:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2022-11-26 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-11-28 9:26 ` Jani Nikula
2022-11-29 9:56 ` Jani Nikula
2 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2022-11-28 9:26 UTC (permalink / raw)
To: Mikko Kovanen, intel-gfx
On Sat, 26 Nov 2022, Mikko Kovanen <mikko.kovanen@aavamobile.com> wrote:
> intel_dsi->ports contains bitmask of enabled ports and correspondingly
> logic for selecting port for VBT packet sending must use port specific
> bitmask when deciding appropriate port.
>
> Fixes: 08c59dde71b7 ("drm/i915/dsi: fix VBT send packet port selection for ICL+")
> Cc: stable@vger.kernel.org
> Signed-off-by: Mikko Kovanen <mikko.kovanen@aavamobile.com>
Holy crap, that's embarrassing! Thanks!
Despite the mistake, it always works for single-link DSI as well as port
A on dual-link DSI, which probably covers most use cases. It's the
commands targeted at port B (VLV+ DSI) or port C (ICL+ DSI) that go
haywire.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> index 75e8cc4337c9..fce69fa446d5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> @@ -137,9 +137,9 @@ static enum port intel_dsi_seq_port_to_port(struct intel_dsi *intel_dsi,
> return ffs(intel_dsi->ports) - 1;
>
> if (seq_port) {
> - if (intel_dsi->ports & PORT_B)
> + if (intel_dsi->ports & BIT(PORT_B))
> return PORT_B;
> - else if (intel_dsi->ports & PORT_C)
> + else if (intel_dsi->ports & BIT(PORT_C))
> return PORT_C;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI
2022-11-28 9:26 ` [Intel-gfx] [PATCH] " Jani Nikula
@ 2022-11-29 9:56 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2022-11-29 9:56 UTC (permalink / raw)
To: Mikko Kovanen, intel-gfx
On Mon, 28 Nov 2022, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Sat, 26 Nov 2022, Mikko Kovanen <mikko.kovanen@aavamobile.com> wrote:
>> intel_dsi->ports contains bitmask of enabled ports and correspondingly
>> logic for selecting port for VBT packet sending must use port specific
>> bitmask when deciding appropriate port.
>>
>> Fixes: 08c59dde71b7 ("drm/i915/dsi: fix VBT send packet port selection for ICL+")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Mikko Kovanen <mikko.kovanen@aavamobile.com>
>
> Holy crap, that's embarrassing! Thanks!
>
> Despite the mistake, it always works for single-link DSI as well as port
> A on dual-link DSI, which probably covers most use cases. It's the
> commands targeted at port B (VLV+ DSI) or port C (ICL+ DSI) that go
> haywire.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Pushed to drm-intel-next, thanks for the patch.
And promptly after pushing I realized I failed to added the link to the
issue in the commit message. Here it is for posterity:
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7601
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> index 75e8cc4337c9..fce69fa446d5 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> @@ -137,9 +137,9 @@ static enum port intel_dsi_seq_port_to_port(struct intel_dsi *intel_dsi,
>> return ffs(intel_dsi->ports) - 1;
>>
>> if (seq_port) {
>> - if (intel_dsi->ports & PORT_B)
>> + if (intel_dsi->ports & BIT(PORT_B))
>> return PORT_B;
>> - else if (intel_dsi->ports & PORT_C)
>> + else if (intel_dsi->ports & BIT(PORT_C))
>> return PORT_C;
>> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI
@ 2022-11-26 13:00 Mikko Kovanen
0 siblings, 0 replies; 6+ messages in thread
From: Mikko Kovanen @ 2022-11-26 13:00 UTC (permalink / raw)
To: intel-gfx
intel_dsi->ports contains bitmask of enabled ports and correspondingly
logic for selecting port for VBT packet sending must use port specific
bitmask when deciding appropriate port.
Fixes: 08c59dde71b7 ("drm/i915/dsi: fix VBT send packet port selection for ICL+")
Cc: stable@vger.kernel.org
Signed-off-by: Mikko Kovanen <mikko.kovanen@aavamobile.com>
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 75e8cc4337c9..fce69fa446d5 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -137,9 +137,9 @@ static enum port intel_dsi_seq_port_to_port(struct intel_dsi *intel_dsi,
return ffs(intel_dsi->ports) - 1;
if (seq_port) {
- if (intel_dsi->ports & PORT_B)
+ if (intel_dsi->ports & BIT(PORT_B))
return PORT_B;
- else if (intel_dsi->ports & PORT_C)
+ else if (intel_dsi->ports & BIT(PORT_C))
return PORT_C;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-29 9:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-26 13:27 [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for dual link DSI Mikko Kovanen
2022-11-26 14:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2022-11-26 14:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-28 9:26 ` [Intel-gfx] [PATCH] " Jani Nikula
2022-11-29 9:56 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2022-11-26 13:00 Mikko Kovanen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).