* [Intel-gfx] [PATCH] drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp
@ 2020-03-25 14:07 Chris Wilson
2020-03-25 15:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2020-03-25 14:07 UTC (permalink / raw)
To: intel-gfx
Avoid using the uninitialised len along the impossible error path to
shut the compiler up:
drivers/gpu/drm/i915/display/intel_dp.c:4928 intel_write_dp_sdp() error: uninitialized symbol 'len'.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 7f1a4e55cda1..c33a39065704 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4922,7 +4922,7 @@ static void intel_write_dp_sdp(struct intel_encoder *encoder,
break;
default:
MISSING_CASE(type);
- break;
+ return;
}
if (drm_WARN_ON(&dev_priv->drm, len < 0))
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp
2020-03-25 14:07 [Intel-gfx] [PATCH] drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp Chris Wilson
@ 2020-03-25 15:15 ` Patchwork
2020-03-25 18:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-26 13:16 ` [Intel-gfx] [PATCH] " Jani Nikula
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-03-25 15:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp
URL : https://patchwork.freedesktop.org/series/75075/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8187 -> Patchwork_17085
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/index.html
Known issues
------------
Here are the changes found in Patchwork_17085 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-icl-dsi: [PASS][1] -> [DMESG-FAIL][2] ([fdo#108569])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/fi-icl-dsi/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/fi-icl-dsi/igt@i915_selftest@live@execlists.html
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (47 -> 35)
------------------------------
Additional (1): fi-hsw-4770r
Missing (13): fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ilk-650 fi-elk-e7500 fi-bsw-kefka fi-skl-lmem fi-blb-e6850 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8187 -> Patchwork_17085
CI-20190529: 20190529
CI_DRM_8187: 8f00a062e7d2e609388afd9e92b5d6d8c22cfb14 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5537: 190245120758e754813d76b2c6c613413a0dba29 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17085: d54cf578ae291862bb0aa386fce316269a03fbef @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d54cf578ae29 drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp
2020-03-25 14:07 [Intel-gfx] [PATCH] drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp Chris Wilson
2020-03-25 15:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-03-25 18:50 ` Patchwork
2020-03-26 13:16 ` [Intel-gfx] [PATCH] " Jani Nikula
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-03-25 18:50 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp
URL : https://patchwork.freedesktop.org/series/75075/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8187_full -> Patchwork_17085_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17085_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110841])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@implicit-read-write-bsd1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [i915#677]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb2/igt@gem_exec_schedule@implicit-read-write-bsd1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb8/igt@gem_exec_schedule@implicit-read-write-bsd1.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +16 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb2/igt@gem_exec_schedule@independent-bsd2.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb3/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb4/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb8/igt@gem_exec_schedule@preempt-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-apl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-iclb: [PASS][15] -> [TIMEOUT][16] ([i915#1284])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb8/igt@kms_flip@flip-vs-suspend-interruptible.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#34])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-skl7/igt@kms_flip@plain-flip-fb-recreate.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-skl10/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#1188])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-apl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [PASS][23] -> [DMESG-WARN][24] ([i915#180] / [i915#93] / [i915#95])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][31] -> [INCOMPLETE][32] ([i915#155])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-skl: [PASS][33] -> [INCOMPLETE][34] ([i915#69])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-skl9/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-skl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#112080]) +13 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb8/igt@perf_pmu@busy-no-semaphores-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [DMESG-WARN][37] ([i915#180]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-apl4/igt@gem_ctx_isolation@bcs0-s3.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-apl2/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_exec_schedule@fifo-bsd1:
- shard-iclb: [SKIP][39] ([fdo#109276]) -> [PASS][40] +12 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb7/igt@gem_exec_schedule@fifo-bsd1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb1/igt@gem_exec_schedule@fifo-bsd1.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [SKIP][41] ([i915#677]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb2/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb8/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +7 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: [DMESG-WARN][45] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-kbl4/igt@i915_suspend@fence-restore-tiled2untiled.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-kbl2/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [FAIL][47] ([i915#34]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][49] ([i915#1188]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [INCOMPLETE][53] ([i915#155]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][55] ([i915#180] / [i915#95]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58] +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@perf_pmu@busy-check-all-vcs1:
- shard-iclb: [SKIP][59] ([fdo#112080]) -> [PASS][60] +13 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-iclb8/igt@perf_pmu@busy-check-all-vcs1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-iclb1/igt@perf_pmu@busy-check-all-vcs1.html
#### Warnings ####
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [DMESG-WARN][61] ([fdo#111870]) -> [DMESG-WARN][62] ([fdo#110789] / [fdo#111870])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8187/shard-hsw8/igt@gem_userptr_blits@sync-unmap.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/shard-hsw8/igt@gem_userptr_blits@sync-unmap.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1284]: https://gitlab.freedesktop.org/drm/intel/issues/1284
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8187 -> Patchwork_17085
CI-20190529: 20190529
CI_DRM_8187: 8f00a062e7d2e609388afd9e92b5d6d8c22cfb14 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5537: 190245120758e754813d76b2c6c613413a0dba29 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17085: d54cf578ae291862bb0aa386fce316269a03fbef @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17085/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp
2020-03-25 14:07 [Intel-gfx] [PATCH] drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp Chris Wilson
2020-03-25 15:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-25 18:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-03-26 13:16 ` Jani Nikula
2 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2020-03-26 13:16 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Wed, 25 Mar 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Avoid using the uninitialised len along the impossible error path to
> shut the compiler up:
>
> drivers/gpu/drm/i915/display/intel_dp.c:4928 intel_write_dp_sdp() error: uninitialized symbol 'len'.
Why am I not seeing this? GCC 8.3.0
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Tpyo in the subject.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7f1a4e55cda1..c33a39065704 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4922,7 +4922,7 @@ static void intel_write_dp_sdp(struct intel_encoder *encoder,
> break;
> default:
> MISSING_CASE(type);
> - break;
> + return;
> }
>
> if (drm_WARN_ON(&dev_priv->drm, len < 0))
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-26 13:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 14:07 [Intel-gfx] [PATCH] drm/i915/display: Return early after MISSING_CSAE for write_dp_sdp Chris Wilson
2020-03-25 15:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-25 18:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-26 13:16 ` [Intel-gfx] [PATCH] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).