intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [2.6.34, patch] i915: fix lock imbalance on error path...
@ 2010-05-17 13:23 Daniel J Blueman
  2010-05-26 20:50 ` Eric Anholt
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel J Blueman @ 2010-05-17 13:23 UTC (permalink / raw)
  To: dri-devel, linux-kernel, intel-gfx; +Cc: Dave Airlie

While investigating Intel i5 Arrandale GPU lockups with -rc4, I
noticed a lock imbalance.

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index cc03537..f5fee1b 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -341,6 +341,7 @@ int i965_reset(struct drm_device *dev, u8 flags)
 		}
 	} else {
 		DRM_ERROR("Error occurred. Don't know how to reset this chip.\n");
+		mutex_unlock(&dev->struct_mutex);
 		return -ENODEV;
 	}

-- 
Daniel J Blueman

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [2.6.34, patch] i915: fix lock imbalance on error path...
  2010-05-17 13:23 [2.6.34, patch] i915: fix lock imbalance on error path Daniel J Blueman
@ 2010-05-26 20:50 ` Eric Anholt
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Anholt @ 2010-05-26 20:50 UTC (permalink / raw)
  To: Daniel J Blueman, dri-devel, linux-kernel, intel-gfx; +Cc: Dave Airlie


[-- Attachment #1.1: Type: text/plain, Size: 271 bytes --]

On Mon, 17 May 2010 14:23:52 +0100, Daniel J Blueman <daniel.blueman@gmail.com> wrote:
> While investigating Intel i5 Arrandale GPU lockups with -rc4, I
> noticed a lock imbalance.
> 
> Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>

Applied.  Thanks!

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-26 20:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-17 13:23 [2.6.34, patch] i915: fix lock imbalance on error path Daniel J Blueman
2010-05-26 20:50 ` Eric Anholt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).