Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/5] drm/i915: check whether the pch is the soulmate of the cpu
Date: Thu, 1 Nov 2012 13:58:04 -0200
Message-ID: <CA+gsUGTfR1uD0-0EQ3+MPazac=knNdJ-TojrsS35anQESsM=tQ@mail.gmail.com> (raw)
In-Reply-To: <1351720351-2688-2-git-send-email-daniel.vetter@ffwll.ch>

Hi

2012/10/31 Daniel Vetter <daniel.vetter@ffwll.ch>:
> We don't really support fancy north display/pch combinations, so
> put a big yelling WARN_ON in there. It /should/ be impossible, but
> alas, the rumours don't stop (mostly due to really early silicon
> sometimes using older PCHs).
>
> v2: Fixup the logic fumble noticed by Paulo Zanoni. I should actually
> try to test run the patch next time around ...
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 6d0afc9..a5ece75 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -423,19 +423,23 @@ void intel_detect_pch(struct drm_device *dev)
>                                 dev_priv->pch_type = PCH_IBX;
>                                 dev_priv->num_pch_pll = 2;
>                                 DRM_DEBUG_KMS("Found Ibex Peak PCH\n");
> +                               WARN_ON(!IS_GEN5(dev));
>                         } else if (id == INTEL_PCH_CPT_DEVICE_ID_TYPE) {
>                                 dev_priv->pch_type = PCH_CPT;
>                                 dev_priv->num_pch_pll = 2;
>                                 DRM_DEBUG_KMS("Found CougarPoint PCH\n");
> +                               WARN_ON(!(IS_GEN6(dev) || IS_IVYBRIDGE(dev)));
>                         } else if (id == INTEL_PCH_PPT_DEVICE_ID_TYPE) {
>                                 /* PantherPoint is CPT compatible */
>                                 dev_priv->pch_type = PCH_CPT;
>                                 dev_priv->num_pch_pll = 2;
>                                 DRM_DEBUG_KMS("Found PatherPoint PCH\n");
> +                               WARN_ON(!(IS_GEN6(dev) || IS_IVYBRIDGE(dev)));
>                         } else if (id == INTEL_PCH_LPT_DEVICE_ID_TYPE) {
>                                 dev_priv->pch_type = PCH_LPT;
>                                 dev_priv->num_pch_pll = 0;
>                                 DRM_DEBUG_KMS("Found LynxPoint PCH\n");
> +                               WARN_ON(!IS_HASWELL(dev));
>                         }
>                         BUG_ON(dev_priv->num_pch_pll > I915_NUM_PLLS);
>                 }
> --
> 1.7.11.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni

  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 21:52 [PATCH 0/5] ivb fdi b/c fixes Daniel Vetter
2012-10-31 21:52 ` [PATCH 1/5] drm/i915: check whether the pch is the soulmate of the cpu Daniel Vetter
2012-11-01 15:58   ` Paulo Zanoni [this message]
2012-10-31 21:52 ` [PATCH 2/5] drm/i915: drop unnecessary check from fdi_link_train code Daniel Vetter
2012-10-31 21:52 ` [PATCH 3/5] drm/i915: CPT/PPT pch transcoder workaround Daniel Vetter
2012-11-01  8:15   ` [PATCH] drm/i915: CPT/PPT pch dp " Daniel Vetter
2012-11-01 14:37     ` Jesse Barnes
2012-11-01 15:33       ` Daniel Vetter
2012-11-01 15:35         ` Jesse Barnes
2012-11-01 16:12     ` Paulo Zanoni
2012-10-31 21:52 ` [PATCH 4/5] drm/i915: implement WADP0ClockGatingDisable Daniel Vetter
2012-11-01 16:18   ` Paulo Zanoni
2012-10-31 21:52 ` [PATCH 5/5] drm/i915: kill pch_init_clock_gating indirection Daniel Vetter
2012-11-01 16:35   ` Paulo Zanoni
2012-11-01 22:03     ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2012-10-29 22:23 [PATCH 1/5] drm/i915: check whether the pch is the soulmate of the cpu Daniel Vetter
2012-10-31 17:31 ` Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+gsUGTfR1uD0-0EQ3+MPazac=knNdJ-TojrsS35anQESsM=tQ@mail.gmail.com' \
    --to=przanoni@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git