* [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression @ 2021-06-30 16:44 Ville Syrjala 2021-06-30 19:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (2 more replies) 0 siblings, 3 replies; 9+ messages in thread From: Ville Syrjala @ 2021-06-30 16:44 UTC (permalink / raw) To: intel-gfx; +Cc: Thomas Hellström, stable From: Ville Syrjälä <ville.syrjala@linux.intel.com> The conversion to ww mutexes failed to address the fence code which already returns -EDEADLK when we run out of fences. Ww mutexes on the other hand treat -EDEADLK as an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns -EDEADLK the higher level code erroneously restarts everything instead of returning the error to userspace as is expected. To remedy this let's switch the fence code to use a different errno value for this. -ENOBUFS seems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to -EDEADLK higher up, but doesn't seem like that's worth the hassle here. Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work. Cc: stable@vger.kernel.org Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Thomas Hellström <thomas.hellstrom@intel.com> Testcase: igt/gem_pread/exhaustion Testcase: igt/gem_pwrite/basic-exhaustion Testcase: igt/gem_fenced_exec_thrash/too-many-fences Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c index cac7f3f44642..f8948de72036 100644 --- a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +++ b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c @@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) if (intel_has_pending_fb_unpin(ggtt->vm.i915)) return ERR_PTR(-EAGAIN); - return ERR_PTR(-EDEADLK); + return ERR_PTR(-ENOBUFS); } int __i915_vma_pin_fence(struct i915_vma *vma) -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix -EDEADLK handling regression 2021-06-30 16:44 [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression Ville Syrjala @ 2021-06-30 19:42 ` Patchwork 2021-07-01 2:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-07-01 7:07 ` [Intel-gfx] [PATCH] " Maarten Lankhorst 2 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2021-06-30 19:42 UTC (permalink / raw) To: Ville Syrjala; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2307 bytes --] == Series Details == Series: drm/i915/gt: Fix -EDEADLK handling regression URL : https://patchwork.freedesktop.org/series/92082/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20497 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/index.html Known issues ------------ Here are the changes found in Patchwork_20497 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_cs_nop@nop-compute0: - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/fi-kbl-soraka/igt@amdgpu/amd_cs_nop@nop-compute0.html * igt@i915_module_load@reload: - fi-kbl-soraka: [PASS][2] -> [DMESG-WARN][3] ([i915#1982]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/fi-kbl-soraka/igt@i915_module_load@reload.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/fi-kbl-soraka/igt@i915_module_load@reload.html * igt@runner@aborted: - fi-bdw-5557u: NOTRUN -> [FAIL][4] ([i915#1602] / [i915#2029]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/fi-bdw-5557u/igt@runner@aborted.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 Participating hosts (39 -> 36) ------------------------------ Missing (3): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10295 -> Patchwork_20497 CI-20190529: 20190529 CI_DRM_10295: 683b7f160eb6993ccfc19e67e3c7111f12946bea @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6124: 357d5477c93f2bdd3354afe91b89ccfd4ee4fd56 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20497: 222d1bd6e1e767781b7db298e0ff45379f78a61d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 222d1bd6e1e7 drm/i915/gt: Fix -EDEADLK handling regression == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/index.html [-- Attachment #1.2: Type: text/html, Size: 2960 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix -EDEADLK handling regression 2021-06-30 16:44 [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression Ville Syrjala 2021-06-30 19:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-07-01 2:48 ` Patchwork 2021-07-01 7:07 ` [Intel-gfx] [PATCH] " Maarten Lankhorst 2 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2021-07-01 2:48 UTC (permalink / raw) To: Ville Syrjala; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30268 bytes --] == Series Details == Series: drm/i915/gt: Fix -EDEADLK handling regression URL : https://patchwork.freedesktop.org/series/92082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20497_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20497_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20497_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20497_full: ### IGT changes ### #### Possible regressions #### * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - shard-skl: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_exec_fair@basic-throttle@rcs0: - {shard-rkl}: NOTRUN -> [FAIL][2] +15 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_dc@dc6-psr: - {shard-rkl}: [FAIL][3] ([i915#2951]) -> [SKIP][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@i915_pm_dc@dc6-psr.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@i915_pm_dc@dc6-psr.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip: - {shard-rkl}: NOTRUN -> [SKIP][5] +61 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html * igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs: - {shard-rkl}: [PASS][6] -> [FAIL][7] +5 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs: - {shard-rkl}: [FAIL][8] -> [SKIP][9] +3 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs.html * igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs: - {shard-rkl}: [SKIP][10] -> [FAIL][11] +10 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html * igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs: - {shard-rkl}: [SKIP][12] ([i915#533]) -> [FAIL][13] +3 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html * igt@kms_content_protection@atomic: - {shard-rkl}: [SKIP][14] ([fdo#109300]) -> [SKIP][15] +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_content_protection@atomic.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_content_protection@atomic.html * igt@kms_content_protection@dp-mst-type-0: - {shard-rkl}: [SKIP][16] ([i915#3116]) -> [SKIP][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_content_protection@dp-mst-type-0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_content_protection@dp-mst-type-0.html * igt@kms_cursor_crc@pipe-a-cursor-32x10-onscreen: - {shard-rkl}: [SKIP][18] ([i915#3359]) -> [SKIP][19] +4 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-32x10-onscreen.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-32x10-onscreen.html * igt@kms_cursor_crc@pipe-b-cursor-128x42-random: - {shard-rkl}: [SKIP][20] ([fdo#112022]) -> [SKIP][21] +14 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html * igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen: - {shard-rkl}: [SKIP][22] ([i915#3319]) -> [SKIP][23] +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen.html * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled: - {shard-rkl}: [SKIP][24] ([fdo#111314]) -> [SKIP][25] +1 similar issue [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile: - {shard-rkl}: [INCOMPLETE][26] -> [SKIP][27] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile: - {shard-rkl}: NOTRUN -> [INCOMPLETE][28] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile: - {shard-rkl}: [SKIP][29] -> [INCOMPLETE][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html * igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt: - {shard-rkl}: [SKIP][31] ([fdo#111825]) -> [SKIP][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt: - {shard-rkl}: [SKIP][33] ([fdo#111825] / [i915#1825]) -> [SKIP][34] +7 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt: - {shard-rkl}: [SKIP][35] ([i915#1849]) -> [SKIP][36] +54 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b: - {shard-rkl}: [PASS][37] -> [SKIP][38] +40 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2: - {shard-rkl}: [SKIP][39] ([i915#658]) -> [SKIP][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html * igt@kms_psr@psr2_primary_render: - {shard-rkl}: [FAIL][41] ([i915#132]) -> [SKIP][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_psr@psr2_primary_render.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_psr@psr2_primary_render.html * igt@kms_psr@sprite_mmap_cpu: - {shard-rkl}: [SKIP][43] ([i915#1072]) -> [SKIP][44] +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@kms_psr@sprite_mmap_cpu.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-1/igt@kms_psr@sprite_mmap_cpu.html Known issues ------------ Here are the changes found in Patchwork_20497_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-snb: NOTRUN -> [DMESG-WARN][45] ([i915#3002]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@gem_create@create-massive.html - shard-apl: NOTRUN -> [DMESG-WARN][46] ([i915#3002]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@gem_create@create-massive.html * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-apl: NOTRUN -> [DMESG-WARN][47] ([i915#180]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@gem_ctx_isolation@preservation-s3@vecs0.html * igt@gem_ctx_persistence@legacy-engines-hostile-preempt: - shard-snb: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#1099]) +2 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb6/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html * igt@gem_ctx_sseu@engines: - shard-tglb: NOTRUN -> [SKIP][49] ([i915#280]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@gem_ctx_sseu@engines.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][50] -> [TIMEOUT][51] ([i915#2369] / [i915#3063] / [i915#3648]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb7/igt@gem_eio@unwedge-stress.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb5/igt@gem_eio@unwedge-stress.html - shard-snb: NOTRUN -> [FAIL][52] ([i915#3354]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-kbl: NOTRUN -> [FAIL][53] ([i915#2842]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][54] -> [FAIL][55] ([i915#2842]) +1 similar issue [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [PASS][56] -> [SKIP][57] ([fdo#109271]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][58] -> [FAIL][59] ([i915#2849]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2190]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@big-copy-odd: - shard-glk: [PASS][61] -> [FAIL][62] ([i915#307]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk9/igt@gem_mmap_gtt@big-copy-odd.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk2/igt@gem_mmap_gtt@big-copy-odd.html * igt@gem_pwrite@basic-exhaustion: - shard-apl: NOTRUN -> [WARN][63] ([i915#2658]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl7/igt@gem_pwrite@basic-exhaustion.html * igt@gem_userptr_blits@coherency-sync: - shard-tglb: NOTRUN -> [SKIP][64] ([fdo#110542]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@gem_userptr_blits@coherency-sync.html * igt@gem_userptr_blits@dmabuf-sync: - shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#3323]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl3/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@vma-merge: - shard-glk: NOTRUN -> [FAIL][66] ([i915#3318]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@gem_userptr_blits@vma-merge.html * igt@gen7_exec_parse@oacontrol-tracking: - shard-glk: NOTRUN -> [SKIP][67] ([fdo#109271]) +40 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@gen7_exec_parse@oacontrol-tracking.html * igt@gen9_exec_parse@allowed-single: - shard-tglb: NOTRUN -> [SKIP][68] ([fdo#112306]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@gen9_exec_parse@allowed-single.html * igt@i915_suspend@sysfs-reader: - shard-skl: [PASS][69] -> [INCOMPLETE][70] ([i915#146] / [i915#198]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl1/igt@i915_suspend@sysfs-reader.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl5/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@linear-16bpp-rotate-90: - shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271]) +215 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl3/igt@kms_big_fb@linear-16bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][72] ([fdo#111615]) +1 similar issue [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html * igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][73] ([i915#3689]) +3 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html * igt@kms_chamelium@hdmi-edid-read: - shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271] / [fdo#111827]) +15 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@kms_chamelium@hdmi-edid-read.html * igt@kms_chamelium@hdmi-mode-timings: - shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [fdo#111827]) +20 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@kms_chamelium@hdmi-mode-timings.html * igt@kms_chamelium@vga-hpd-for-each-pipe: - shard-glk: NOTRUN -> [SKIP][76] ([fdo#109271] / [fdo#111827]) +3 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@kms_chamelium@vga-hpd-for-each-pipe.html * igt@kms_color@pipe-c-ctm-0-25: - shard-skl: [PASS][77] -> [DMESG-WARN][78] ([i915#1982]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl2/igt@kms_color@pipe-c-ctm-0-25.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl3/igt@kms_color@pipe-c-ctm-0-25.html * igt@kms_color_chamelium@pipe-b-degamma: - shard-tglb: NOTRUN -> [SKIP][79] ([fdo#109284] / [fdo#111827]) +1 similar issue [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_color_chamelium@pipe-b-degamma.html * igt@kms_color_chamelium@pipe-c-ctm-0-25: - shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [fdo#111827]) +21 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@kms_color_chamelium@pipe-c-ctm-0-25.html * igt@kms_color_chamelium@pipe-c-degamma: - shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [fdo#111827]) +4 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@kms_color_chamelium@pipe-c-degamma.html * igt@kms_content_protection@atomic: - shard-kbl: NOTRUN -> [TIMEOUT][82] ([i915#1319]) +2 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl1/igt@kms_content_protection@atomic.html * igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][83] ([i915#3319]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement.html * igt@kms_cursor_crc@pipe-d-cursor-suspend: - shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271]) +241 similar issues [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl3/igt@kms_cursor_crc@pipe-d-cursor-suspend.html * igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge: - shard-snb: NOTRUN -> [SKIP][85] ([fdo#109271]) +252 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-snb7/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-skl: [PASS][86] -> [FAIL][87] ([i915#2346]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html * igt@kms_cursor_legacy@pipe-d-torture-bo: - shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#533]) +2 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@kms_cursor_legacy@pipe-d-torture-bo.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][89] -> [DMESG-WARN][90] ([i915#180]) +5 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [PASS][91] -> [DMESG-WARN][92] ([i915#180]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu: - shard-tglb: NOTRUN -> [SKIP][93] ([fdo#111825]) +3 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence: - shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#533]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl6/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: - shard-skl: [PASS][95] -> [INCOMPLETE][96] ([i915#198] / [i915#2828]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#533]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][98] -> [FAIL][99] ([fdo#108145] / [i915#265]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][100] ([fdo#108145] / [i915#265]) +1 similar issue [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-apl: NOTRUN -> [FAIL][101] ([fdo#108145] / [i915#265]) +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html * igt@kms_plane_lowres@pipe-d-tiling-y: - shard-tglb: NOTRUN -> [SKIP][102] ([i915#3536]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_plane_lowres@pipe-d-tiling-y.html * igt@kms_plane_lowres@pipe-d-tiling-yf: - shard-skl: NOTRUN -> [SKIP][103] ([fdo#109271]) +49 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@kms_plane_lowres@pipe-d-tiling-yf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#658]) +4 similar issues [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#658]) +5 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5: - shard-glk: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][107] -> [SKIP][108] ([fdo#109441]) +3 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_psr@psr2_primary_blt: - shard-tglb: NOTRUN -> [FAIL][109] ([i915#132] / [i915#3467]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@kms_psr@psr2_primary_blt.html * igt@kms_writeback@writeback-check-output: - shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2437]) +1 similar issue [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl1/igt@kms_writeback@writeback-check-output.html * igt@kms_writeback@writeback-invalid-parameters: - shard-skl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2437]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@kms_writeback@writeback-invalid-parameters.html - shard-kbl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2437]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl1/igt@kms_writeback@writeback-invalid-parameters.html * igt@kms_writeback@writeback-pixel-formats: - shard-glk: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2437]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk6/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-d-source-rg: - shard-tglb: NOTRUN -> [SKIP][114] ([i915#2530]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@nouveau_crc@pipe-d-source-rg.html * igt@perf_pmu@rc6-suspend: - shard-kbl: NOTRUN -> [DMESG-WARN][115] ([i915#180]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl7/igt@perf_pmu@rc6-suspend.html * igt@prime_nv_api@i915_nv_import_vs_close: - shard-tglb: NOTRUN -> [SKIP][116] ([fdo#109291]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb2/igt@prime_nv_api@i915_nv_import_vs_close.html * igt@sysfs_clients@fair-0: - shard-apl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#2994]) +2 similar issues [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-apl6/igt@sysfs_clients@fair-0.html * igt@sysfs_clients@fair-3: - shard-kbl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#2994]) +3 similar issues [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl1/igt@sysfs_clients@fair-3.html - shard-skl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-skl6/igt@sysfs_clients@fair-3.html #### Possible fixes #### * igt@fbdev@read: - {shard-rkl}: [SKIP][120] ([i915#2582]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@fbdev@read.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@fbdev@read.html * igt@feature_discovery@psr2: - shard-iclb: [SKIP][122] ([i915#658]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb3/igt@feature_discovery@psr2.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb2/igt@feature_discovery@psr2.html * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-kbl: [DMESG-WARN][124] ([i915#180]) -> [PASS][125] +10 similar issues [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@vecs0.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vecs0.html * igt@gem_eio@unwedge-stress: - {shard-rkl}: [TIMEOUT][126] -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@gem_eio@unwedge-stress.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-iclb: [FAIL][128] ([i915#2842]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb5/igt@gem_exec_fair@basic-pace@bcs0.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-iclb7/igt@gem_exec_fair@basic-pace@bcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-glk: [FAIL][130] ([i915#2842]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk1/igt@gem_exec_fair@basic-pace@vcs0.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-glk1/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [SKIP][132] ([i915#2190]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb6/igt@gem_huc_copy@huc-copy.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-tglb1/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@cpuset-medium-copy: - {shard-rkl}: [FAIL][134] ([i915#2428]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@gem_mmap_gtt@cpuset-medium-copy.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@gem_mmap_gtt@cpuset-medium-copy.html * igt@i915_pm_rpm@basic-pci-d3-state: - {shard-rkl}: [SKIP][136] ([fdo#109308]) -> [PASS][137] +1 similar issue [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@i915_pm_rpm@basic-pci-d3-state.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-6/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@system-suspend-execbuf: - {shard-rkl}: [FAIL][138] ([fdo#103375]) -> [PASS][139] +1 similar issue [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@i915_pm_rpm@system-suspend-execbuf.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/shard-rkl-2/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@kms_big_fb@x-tiled-32bpp-rotate-0: - shard-glk: [DMESG-WARN][140] ([i915#118] / [i915#95]) -> [PASS][141] +1 similar issue [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-r == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20497/index.html [-- Attachment #1.2: Type: text/html, Size: 33522 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression 2021-06-30 16:44 [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression Ville Syrjala 2021-06-30 19:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-07-01 2:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2021-07-01 7:07 ` Maarten Lankhorst 2021-07-01 17:00 ` Ville Syrjälä 2021-07-13 19:58 ` Daniel Vetter 2 siblings, 2 replies; 9+ messages in thread From: Maarten Lankhorst @ 2021-07-01 7:07 UTC (permalink / raw) To: Ville Syrjala, intel-gfx; +Cc: Thomas Hellström, stable Op 30-06-2021 om 18:44 schreef Ville Syrjala: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > The conversion to ww mutexes failed to address the fence code which > already returns -EDEADLK when we run out of fences. Ww mutexes on > the other hand treat -EDEADLK as an internal errno value indicating > a need to restart the operation due to a deadlock. So now when the > fence code returns -EDEADLK the higher level code erroneously > restarts everything instead of returning the error to userspace > as is expected. > > To remedy this let's switch the fence code to use a different errno > value for this. -ENOBUFS seems like a semi-reasonable unique choice. > Apart from igt the only user of this I could find is sna, and even > there all we do is dump the current fence registers from debugfs > into the X server log. So no user visible functionality is affected. > If we really cared about preserving this we could of course convert > back to -EDEADLK higher up, but doesn't seem like that's worth > the hassle here. > > Not quite sure which commit specifically broke this, but I'll > just attribute it to the general gem ww mutex work. > > Cc: stable@vger.kernel.org > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Thomas Hellström <thomas.hellstrom@intel.com> > Testcase: igt/gem_pread/exhaustion > Testcase: igt/gem_pwrite/basic-exhaustion > Testcase: igt/gem_fenced_exec_thrash/too-many-fences > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > index cac7f3f44642..f8948de72036 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > @@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) > if (intel_has_pending_fb_unpin(ggtt->vm.i915)) > return ERR_PTR(-EAGAIN); > > - return ERR_PTR(-EDEADLK); > + return ERR_PTR(-ENOBUFS); > } > > int __i915_vma_pin_fence(struct i915_vma *vma) Makes sense.. Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression 2021-07-01 7:07 ` [Intel-gfx] [PATCH] " Maarten Lankhorst @ 2021-07-01 17:00 ` Ville Syrjälä 2021-07-13 19:58 ` Daniel Vetter 1 sibling, 0 replies; 9+ messages in thread From: Ville Syrjälä @ 2021-07-01 17:00 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: intel-gfx, Thomas Hellström, stable On Thu, Jul 01, 2021 at 09:07:27AM +0200, Maarten Lankhorst wrote: > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > The conversion to ww mutexes failed to address the fence code which > > already returns -EDEADLK when we run out of fences. Ww mutexes on > > the other hand treat -EDEADLK as an internal errno value indicating > > a need to restart the operation due to a deadlock. So now when the > > fence code returns -EDEADLK the higher level code erroneously > > restarts everything instead of returning the error to userspace > > as is expected. > > > > To remedy this let's switch the fence code to use a different errno > > value for this. -ENOBUFS seems like a semi-reasonable unique choice. > > Apart from igt the only user of this I could find is sna, and even > > there all we do is dump the current fence registers from debugfs > > into the X server log. So no user visible functionality is affected. > > If we really cared about preserving this we could of course convert > > back to -EDEADLK higher up, but doesn't seem like that's worth > > the hassle here. > > > > Not quite sure which commit specifically broke this, but I'll > > just attribute it to the general gem ww mutex work. > > > > Cc: stable@vger.kernel.org > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Thomas Hellström <thomas.hellstrom@intel.com> > > Testcase: igt/gem_pread/exhaustion > > Testcase: igt/gem_pwrite/basic-exhaustion > > Testcase: igt/gem_fenced_exec_thrash/too-many-fences > > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > index cac7f3f44642..f8948de72036 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > @@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) > > if (intel_has_pending_fb_unpin(ggtt->vm.i915)) > > return ERR_PTR(-EAGAIN); > > > > - return ERR_PTR(-EDEADLK); > > + return ERR_PTR(-ENOBUFS); > > } > > > > int __i915_vma_pin_fence(struct i915_vma *vma) > > Makes sense.. > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks. No idea about the specific commit since I've not actually bisected it. It's just been bugging CI for quite a while now so figured I need to fix it. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression 2021-07-01 7:07 ` [Intel-gfx] [PATCH] " Maarten Lankhorst 2021-07-01 17:00 ` Ville Syrjälä @ 2021-07-13 19:58 ` Daniel Vetter 2021-07-13 19:59 ` Daniel Vetter 1 sibling, 1 reply; 9+ messages in thread From: Daniel Vetter @ 2021-07-13 19:58 UTC (permalink / raw) To: Maarten Lankhorst, dri-devel; +Cc: intel-gfx, Thomas Hellström, stable On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > The conversion to ww mutexes failed to address the fence code which > > already returns -EDEADLK when we run out of fences. Ww mutexes on > > the other hand treat -EDEADLK as an internal errno value indicating > > a need to restart the operation due to a deadlock. So now when the > > fence code returns -EDEADLK the higher level code erroneously > > restarts everything instead of returning the error to userspace > > as is expected. > > > > To remedy this let's switch the fence code to use a different errno > > value for this. -ENOBUFS seems like a semi-reasonable unique choice. > > Apart from igt the only user of this I could find is sna, and even > > there all we do is dump the current fence registers from debugfs > > into the X server log. So no user visible functionality is affected. > > If we really cared about preserving this we could of course convert > > back to -EDEADLK higher up, but doesn't seem like that's worth > > the hassle here. > > > > Not quite sure which commit specifically broke this, but I'll > > just attribute it to the general gem ww mutex work. > > > > Cc: stable@vger.kernel.org > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Thomas Hellström <thomas.hellstrom@intel.com> > > Testcase: igt/gem_pread/exhaustion > > Testcase: igt/gem_pwrite/basic-exhaustion > > Testcase: igt/gem_fenced_exec_thrash/too-many-fences > > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > index cac7f3f44642..f8948de72036 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > @@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) > > if (intel_has_pending_fb_unpin(ggtt->vm.i915)) > > return ERR_PTR(-EAGAIN); > > > > - return ERR_PTR(-EDEADLK); > > + return ERR_PTR(-ENOBUFS); > > } > > > > int __i915_vma_pin_fence(struct i915_vma *vma) > > Makes sense.. > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks. - please cc: dri-devel on anything gem/gt related. - this should probably be ENOSPC or something like that for at least a seeming retention of errno consistentcy: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression 2021-07-13 19:58 ` Daniel Vetter @ 2021-07-13 19:59 ` Daniel Vetter 2021-07-13 20:19 ` Rodrigo Vivi 2021-07-13 20:22 ` Ville Syrjälä 0 siblings, 2 replies; 9+ messages in thread From: Daniel Vetter @ 2021-07-13 19:59 UTC (permalink / raw) To: Maarten Lankhorst, dri-devel; +Cc: intel-gfx, Thomas Hellström, stable On Tue, Jul 13, 2021 at 9:58 PM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst > <maarten.lankhorst@linux.intel.com> wrote: > > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > The conversion to ww mutexes failed to address the fence code which > > > already returns -EDEADLK when we run out of fences. Ww mutexes on > > > the other hand treat -EDEADLK as an internal errno value indicating > > > a need to restart the operation due to a deadlock. So now when the > > > fence code returns -EDEADLK the higher level code erroneously > > > restarts everything instead of returning the error to userspace > > > as is expected. > > > > > > To remedy this let's switch the fence code to use a different errno > > > value for this. -ENOBUFS seems like a semi-reasonable unique choice. > > > Apart from igt the only user of this I could find is sna, and even > > > there all we do is dump the current fence registers from debugfs > > > into the X server log. So no user visible functionality is affected. > > > If we really cared about preserving this we could of course convert > > > back to -EDEADLK higher up, but doesn't seem like that's worth > > > the hassle here. > > > > > > Not quite sure which commit specifically broke this, but I'll > > > just attribute it to the general gem ww mutex work. > > > > > > Cc: stable@vger.kernel.org > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > Cc: Thomas Hellström <thomas.hellstrom@intel.com> > > > Testcase: igt/gem_pread/exhaustion > > > Testcase: igt/gem_pwrite/basic-exhaustion > > > Testcase: igt/gem_fenced_exec_thrash/too-many-fences > > > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > --- > > > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > index cac7f3f44642..f8948de72036 100644 > > > --- a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > @@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) > > > if (intel_has_pending_fb_unpin(ggtt->vm.i915)) > > > return ERR_PTR(-EAGAIN); > > > > > > - return ERR_PTR(-EDEADLK); > > > + return ERR_PTR(-ENOBUFS); > > > } > > > > > > int __i915_vma_pin_fence(struct i915_vma *vma) > > > > Makes sense.. > > > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks. > > - please cc: dri-devel on anything gem/gt related. > - this should probably be ENOSPC or something like that for at least a > seeming retention of errno consistentcy: > > https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values Other option would be to map that back to EDEADLK in the execbuf ioctl somewhere, so we retain a distinct errno code. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression 2021-07-13 19:59 ` Daniel Vetter @ 2021-07-13 20:19 ` Rodrigo Vivi 2021-07-13 20:22 ` Ville Syrjälä 1 sibling, 0 replies; 9+ messages in thread From: Rodrigo Vivi @ 2021-07-13 20:19 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx, Thomas Hellström, stable, dri-devel On Tue, Jul 13, 2021 at 09:59:18PM +0200, Daniel Vetter wrote: > On Tue, Jul 13, 2021 at 9:58 PM Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst > > <maarten.lankhorst@linux.intel.com> wrote: > > > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > > > The conversion to ww mutexes failed to address the fence code which > > > > already returns -EDEADLK when we run out of fences. Ww mutexes on > > > > the other hand treat -EDEADLK as an internal errno value indicating > > > > a need to restart the operation due to a deadlock. So now when the > > > > fence code returns -EDEADLK the higher level code erroneously > > > > restarts everything instead of returning the error to userspace > > > > as is expected. > > > > > > > > To remedy this let's switch the fence code to use a different errno > > > > value for this. -ENOBUFS seems like a semi-reasonable unique choice. > > > > Apart from igt the only user of this I could find is sna, and even > > > > there all we do is dump the current fence registers from debugfs > > > > into the X server log. So no user visible functionality is affected. > > > > If we really cared about preserving this we could of course convert > > > > back to -EDEADLK higher up, but doesn't seem like that's worth > > > > the hassle here. > > > > > > > > Not quite sure which commit specifically broke this, but I'll > > > > just attribute it to the general gem ww mutex work. > > > > > > > > Cc: stable@vger.kernel.org > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > Cc: Thomas Hellström <thomas.hellstrom@intel.com> > > > > Testcase: igt/gem_pread/exhaustion > > > > Testcase: igt/gem_pwrite/basic-exhaustion > > > > Testcase: igt/gem_fenced_exec_thrash/too-many-fences > > > > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > --- > > > > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > > index cac7f3f44642..f8948de72036 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > > @@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) > > > > if (intel_has_pending_fb_unpin(ggtt->vm.i915)) > > > > return ERR_PTR(-EAGAIN); > > > > > > > > - return ERR_PTR(-EDEADLK); > > > > + return ERR_PTR(-ENOBUFS); > > > > } > > > > > > > > int __i915_vma_pin_fence(struct i915_vma *vma) > > > > > > Makes sense.. > > > > > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > > > Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks. > > > > - please cc: dri-devel on anything gem/gt related. > > - this should probably be ENOSPC or something like that for at least a > > seeming retention of errno consistentcy: > > > > https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values > > Other option would be to map that back to EDEADLK in the execbuf ioctl > somewhere, so we retain a distinct errno code. I'm about to push this patch to drm-intel-fixes... I'm assuming if there's any fix it will be a follow-up patch and not a revert or force push, right?! > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression 2021-07-13 19:59 ` Daniel Vetter 2021-07-13 20:19 ` Rodrigo Vivi @ 2021-07-13 20:22 ` Ville Syrjälä 1 sibling, 0 replies; 9+ messages in thread From: Ville Syrjälä @ 2021-07-13 20:22 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx, Thomas Hellström, stable, dri-devel On Tue, Jul 13, 2021 at 09:59:18PM +0200, Daniel Vetter wrote: > On Tue, Jul 13, 2021 at 9:58 PM Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst > > <maarten.lankhorst@linux.intel.com> wrote: > > > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > > > The conversion to ww mutexes failed to address the fence code which > > > > already returns -EDEADLK when we run out of fences. Ww mutexes on > > > > the other hand treat -EDEADLK as an internal errno value indicating > > > > a need to restart the operation due to a deadlock. So now when the > > > > fence code returns -EDEADLK the higher level code erroneously > > > > restarts everything instead of returning the error to userspace > > > > as is expected. > > > > > > > > To remedy this let's switch the fence code to use a different errno > > > > value for this. -ENOBUFS seems like a semi-reasonable unique choice. > > > > Apart from igt the only user of this I could find is sna, and even > > > > there all we do is dump the current fence registers from debugfs > > > > into the X server log. So no user visible functionality is affected. > > > > If we really cared about preserving this we could of course convert > > > > back to -EDEADLK higher up, but doesn't seem like that's worth > > > > the hassle here. > > > > > > > > Not quite sure which commit specifically broke this, but I'll > > > > just attribute it to the general gem ww mutex work. > > > > > > > > Cc: stable@vger.kernel.org > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > Cc: Thomas Hellström <thomas.hellstrom@intel.com> > > > > Testcase: igt/gem_pread/exhaustion > > > > Testcase: igt/gem_pwrite/basic-exhaustion > > > > Testcase: igt/gem_fenced_exec_thrash/too-many-fences > > > > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > --- > > > > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > > index cac7f3f44642..f8948de72036 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c > > > > @@ -348,7 +348,7 @@ static struct i915_fence_reg *fence_find(struct i915_ggtt *ggtt) > > > > if (intel_has_pending_fb_unpin(ggtt->vm.i915)) > > > > return ERR_PTR(-EAGAIN); > > > > > > > > - return ERR_PTR(-EDEADLK); > > > > + return ERR_PTR(-ENOBUFS); > > > > } > > > > > > > > int __i915_vma_pin_fence(struct i915_vma *vma) > > > > > > Makes sense.. > > > > > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > > > Is it a slightly more reent commit? Might probably be the part that converts execbuffer to use ww locks. > > > > - please cc: dri-devel on anything gem/gt related. Thought I did. Apparently got lost somewhere. > > - this should probably be ENOSPC or something like that for at least a > > seeming retention of errno consistentcy: ENOSPC is already used for other things. > > > > https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values > > Other option would be to map that back to EDEADLK in the execbuf ioctl > somewhere, so we retain a distinct errno code. Already mentioned in the commit msg. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-07-13 20:22 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-30 16:44 [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression Ville Syrjala 2021-06-30 19:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-07-01 2:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-07-01 7:07 ` [Intel-gfx] [PATCH] " Maarten Lankhorst 2021-07-01 17:00 ` Ville Syrjälä 2021-07-13 19:58 ` Daniel Vetter 2021-07-13 19:59 ` Daniel Vetter 2021-07-13 20:19 ` Rodrigo Vivi 2021-07-13 20:22 ` Ville Syrjälä
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).