From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Aliased PPGTT size abstraction
Date: Mon, 28 Jan 2013 19:31:43 +0100 [thread overview]
Message-ID: <CAKMK7uGKy86nHkptcW8vonchrFcL_9QD37EX71=zmaxS0e5rXA@mail.gmail.com> (raw)
In-Reply-To: <20130128182611.GA674@lundgren.jf.intel.com>
On Mon, Jan 28, 2013 at 7:26 PM, Ben Widawsky <ben@bwidawsk.net> wrote:
> But as I said above, we really need to calculate how much PD space we
> need. Each PD has PAGE_SIZE of space required
> gtt_size >> 22 >> PAGE_SIZE = gtt_size >> 10
gtt_size >> 22 * PAGE_SIZE
> In hindsight, maybe doing that calculation in the code would have been
> better.
>
> Anyway, to answer the question, I think yes, it should match
> ppgtt->num_pd_entries * PAGE_SIZE
That looks much clearer imo and spells out what happens much better
(we still a pte = full page in the address space for each ppgtt pd).
Can you please apply this bikeshed to the patch?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-01-28 18:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 0:41 [PATCH 0/5] [REPOST] GTT cleanups, rebased Ben Widawsky
2013-01-26 0:41 ` [PATCH 1/5] drm/i915: trivial: kill-agp collateral cleanups Ben Widawsky
2013-01-29 12:49 ` Daniel Vetter
2013-01-29 18:58 ` Ben Widawsky
2013-01-26 0:41 ` [PATCH 2/5] drm/i915: Reclaim GTT space for failed PPGTT Ben Widawsky
2013-01-29 12:51 ` Daniel Vetter
2013-01-26 0:41 ` [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code Ben Widawsky
2013-01-29 12:55 ` Daniel Vetter
2013-01-29 19:00 ` Ben Widawsky
2013-01-26 0:41 ` [PATCH 4/5] drm/i915: Aliased PPGTT size abstraction Ben Widawsky
2013-01-28 12:19 ` Jani Nikula
2013-01-28 18:26 ` Ben Widawsky
2013-01-28 18:31 ` Daniel Vetter [this message]
2013-01-28 20:35 ` [PATCH 4/5 v2] " Ben Widawsky
2013-01-29 12:58 ` Daniel Vetter
2013-01-26 0:41 ` [PATCH 5/5] drm/i915: Dynamically calculate dclv Ben Widawsky
2013-01-28 12:20 ` Jani Nikula
2013-01-28 20:36 ` Ben Widawsky
2013-01-28 21:08 ` Daniel Vetter
2013-01-28 12:24 ` [PATCH 0/5] [REPOST] GTT cleanups, rebased Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2012-12-29 4:27 [PATCH 1/5] drm/i915: trivial: kill-agp collateral cleanups Ben Widawsky
2012-12-29 4:27 ` [PATCH 4/5] drm/i915: Aliased PPGTT size abstraction Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uGKy86nHkptcW8vonchrFcL_9QD37EX71=zmaxS0e5rXA@mail.gmail.com' \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).