* [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes
@ 2021-08-17 20:43 Anisse Astier
2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID Anisse Astier
` (7 more replies)
0 siblings, 8 replies; 12+ messages in thread
From: Anisse Astier @ 2021-08-17 20:43 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Ville Syrjälä,
Hans de Goede, Uma Shankar, Jani Nikula, Daniel Dadap,
Anisse Astier
This patch series is for making the GPD Win Max display usable with
Linux.
The GPD Win Max is a small laptop, and its eDP panel does not send an
EDID over DPCD; the EDID is instead available in the intel opregion, in
mailbox #5 [1]
The first patch is based on Jani's patch series [2] adding support for
the opregion, with changes. I've changed authorship, but I'd be glad to
revert it
The second patch is just to fix the orientation of the panel.
Changes since v1:
- rebased on drm-tip
- squashed patch 1 & 2
- picked up Reviewed-by from Hans de Goede (thanks for the review)
Changes since v2:
- rebased on drm-tip
- updated commit message
When v2 was initially sent [3] Ville Syrjälä suggested that it might be
a good idea to use the ACPI _DDC method instead to get the EDID, to
cover a wider range of hardware. Unfortunately, it doesn't seem
available on GPD Win Max, so I think this work should be done
independently, and this patch series considered separately.
[1]: https://gitlab.freedesktop.org/drm/intel/-/issues/3454
[2]: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/
[3]: https://patchwork.kernel.org/project/intel-gfx/patch/20210531204642.4907-2-anisse@astier.eu/
Anisse Astier (2):
drm/i915/opregion: add support for mailbox #5 EDID
drm: Add orientation quirk for GPD Win Max
.../gpu/drm/drm_panel_orientation_quirks.c | 6 ++
drivers/gpu/drm/i915/display/intel_dp.c | 3 +
drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++-
drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++
4 files changed, 85 insertions(+), 1 deletion(-)
--
2.31.1
^ permalink raw reply [flat|nested] 12+ messages in thread* [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier @ 2021-08-17 20:43 ` Anisse Astier 2021-08-31 9:30 ` Jani Nikula 2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 2/2] drm: Add orientation quirk for GPD Win Max Anisse Astier ` (6 subsequent siblings) 7 siblings, 1 reply; 12+ messages in thread From: Anisse Astier @ 2021-08-17 20:43 UTC (permalink / raw) To: intel-gfx, dri-devel Cc: Ville Syrjälä, Hans de Goede, Uma Shankar, Jani Nikula, Daniel Dadap, Anisse Astier The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be used for the embedded display. Add support for using it via by adding the EDID to the list of available modes on the connector, and use it for eDP when available. If a panel's EDID is broken, there may be an override EDID set in the ACPI OpRegion mailbox #5. Use it if available. Fixes the GPD Win Max laptop display, which seems to only use this mechanism to provide a proper EDID for its eDP screen. It would have been better to provide the EDID through the ACPI _DDC method instead, to have a more generic solution, but it seems the designers of this system did not consider it, and shipped the firmware without it. Based on original patch series by: Jani Nikula <jani.nikula@intel.com> https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ Changes since Jani Nikula's series: - EDID is copied and validated with drm_edid_is_valid - Mode is now added via drm_add_edid_modes instead of using override mechanism - squashed the two patches Cc: Jani Nikula <jani.nikula@intel.com> Cc: Uma Shankar <uma.shankar@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Anisse Astier <anisse@astier.eu> --- drivers/gpu/drm/i915/display/intel_dp.c | 3 + drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 75d4ebc66941..f9254c0df1a2 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5183,6 +5183,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, goto out_vdd_off; } + /* Set up override EDID, if any, from ACPI OpRegion */ + intel_opregion_edid_probe(intel_connector); + mutex_lock(&dev->mode_config.mutex); edid = drm_get_edid(connector, &intel_dp->aux.ddc); if (edid) { diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c index 3855fba70980..b1b87ed758ba 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.c +++ b/drivers/gpu/drm/i915/display/intel_opregion.c @@ -196,6 +196,8 @@ struct opregion_asle_ext { #define ASLE_IUER_WINDOWS_BTN (1 << 1) #define ASLE_IUER_POWER_BTN (1 << 0) +#define ASLE_PHED_EDID_VALID_MASK 0x3 + /* Software System Control Interrupt (SWSCI) */ #define SWSCI_SCIC_INDICATOR (1 << 0) #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 @@ -909,8 +911,10 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) opregion->asle->ardy = ASLE_ARDY_NOT_READY; } - if (mboxes & MBOX_ASLE_EXT) + if (mboxes & MBOX_ASLE_EXT) { drm_dbg(&dev_priv->drm, "ASLE extension supported\n"); + opregion->asle_ext = base + OPREGION_ASLE_EXT_OFFSET; + } if (intel_load_vbt_firmware(dev_priv) == 0) goto out; @@ -1037,6 +1041,68 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) return ret - 1; } +/** + * intel_opregion_edid_probe - Add EDID from ACPI OpRegion mailbox #5 + * @intel_connector: eDP connector + * + * This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed + * to it. + * + * Will take a lock on the DRM mode_config to add the EDID; make sure it isn't + * called with lock taken. + * + */ +void intel_opregion_edid_probe(struct intel_connector *intel_connector) +{ + struct drm_connector *connector = &intel_connector->base; + struct drm_i915_private *i915 = to_i915(connector->dev); + struct intel_opregion *opregion = &i915->opregion; + const void *in_edid; + const struct edid *edid; + struct edid *new_edid; + int len, ret, num; + + if (!opregion->asle_ext || connector->override_edid) + return; + + in_edid = opregion->asle_ext->bddc; + + /* Validity corresponds to number of 128-byte blocks */ + len = (opregion->asle_ext->phed & ASLE_PHED_EDID_VALID_MASK) * 128; + if (!len || !memchr_inv(in_edid, 0, len)) + return; + + edid = in_edid; + + if (len < EDID_LENGTH * (1 + edid->extensions)) { + drm_dbg_kms(&i915->drm, "Invalid EDID in ACPI OpRegion (Mailbox #5)\n"); + return; + } + new_edid = drm_edid_duplicate(edid); + if (!new_edid) { + drm_err(&i915->drm, "Cannot duplicate EDID\n"); + return; + } + if (!drm_edid_is_valid(new_edid)) { + kfree(new_edid); + drm_dbg_kms(&i915->drm, "Cannot validate EDID in ACPI OpRegion (Mailbox #5)\n"); + return; + } + + ret = drm_connector_update_edid_property(connector, new_edid); + if (ret) { + kfree(new_edid); + return; + } + + mutex_lock(&connector->dev->mode_config.mutex); + num = drm_add_edid_modes(connector, new_edid); + mutex_unlock(&connector->dev->mode_config.mutex); + + drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s], added %d mode(s)\n", + connector->base.id, connector->name, num); +} + void intel_opregion_register(struct drm_i915_private *i915) { struct intel_opregion *opregion = &i915->opregion; @@ -1130,6 +1196,7 @@ void intel_opregion_unregister(struct drm_i915_private *i915) opregion->acpi = NULL; opregion->swsci = NULL; opregion->asle = NULL; + opregion->asle_ext = NULL; opregion->vbt = NULL; opregion->lid_state = NULL; } diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h index 4aa68ffbd30e..c1ecfcbb6f55 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.h +++ b/drivers/gpu/drm/i915/display/intel_opregion.h @@ -29,12 +29,14 @@ #include <linux/pci.h> struct drm_i915_private; +struct intel_connector; struct intel_encoder; struct opregion_header; struct opregion_acpi; struct opregion_swsci; struct opregion_asle; +struct opregion_asle_ext; struct intel_opregion { struct opregion_header *header; @@ -43,6 +45,7 @@ struct intel_opregion { u32 swsci_gbda_sub_functions; u32 swsci_sbcb_sub_functions; struct opregion_asle *asle; + struct opregion_asle_ext *asle_ext; void *rvda; void *vbt_firmware; const void *vbt; @@ -71,6 +74,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, pci_power_t state); int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv); +void intel_opregion_edid_probe(struct intel_connector *connector); #else /* CONFIG_ACPI*/ @@ -117,6 +121,10 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) return -ENODEV; } +void intel_opregion_edid_probe(struct intel_connector *connector) +{ +} + #endif /* CONFIG_ACPI */ #endif -- 2.31.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID Anisse Astier @ 2021-08-31 9:30 ` Jani Nikula 2021-09-01 12:06 ` Anisse Astier 0 siblings, 1 reply; 12+ messages in thread From: Jani Nikula @ 2021-08-31 9:30 UTC (permalink / raw) To: Anisse Astier, intel-gfx, dri-devel Cc: Ville Syrjälä, Hans de Goede, Uma Shankar, Daniel Dadap, Anisse Astier On Tue, 17 Aug 2021, Anisse Astier <anisse@astier.eu> wrote: > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > used for the embedded display. Add support for using it via by adding > the EDID to the list of available modes on the connector, and use it for > eDP when available. > > If a panel's EDID is broken, there may be an override EDID set in the > ACPI OpRegion mailbox #5. Use it if available. > > Fixes the GPD Win Max laptop display, which seems to only use this > mechanism to provide a proper EDID for its eDP screen. It would have > been better to provide the EDID through the ACPI _DDC method instead, to > have a more generic solution, but it seems the designers of this system > did not consider it, and shipped the firmware without it. The question is whether the opregion EDID should be used for override or fallback. The patch at hand is kind of neither, it just unconditionally adds the modes from the opregion EDID to the connector. For your display, they apparently end up also being the only mode(s), with one of them being used as the fixed mode. (Otherwise the orientation quirk wouldn't work.) What does drm_get_edid() return for you? Maybe we should do something like this instead: mutex_lock(&dev->mode_config.mutex); edid = drm_get_edid(connector, &intel_dp->aux.ddc); + if (!edid) + edid = intel_opregion_get_edid(intel_connector); if (edid) { if (drm_add_edid_modes(connector, edid)) { drm_connector_update_edid_property(connector, edid); This way we'll actually use all the other bits in the EDID, not just the modes. And if it needs to become override rather than fallback, the solution is: mutex_lock(&dev->mode_config.mutex); - edid = drm_get_edid(connector, &intel_dp->aux.ddc); + edid = intel_opregion_get_edid(intel_connector); + if (!edid) + edid = drm_get_edid(connector, &intel_dp->aux.ddc); if (edid) { if (drm_add_edid_modes(connector, edid)) { drm_connector_update_edid_property(connector, edid); In any case, I think it's just plain wrong to use both the display and opregion EDIDs at the same time. It's probably all around safer to start with fallback. Please find some further comments inline. > Based on original patch series by: Jani Nikula <jani.nikula@intel.com> > https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ > > Changes since Jani Nikula's series: > - EDID is copied and validated with drm_edid_is_valid > - Mode is now added via drm_add_edid_modes instead of using override > mechanism > - squashed the two patches > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Uma Shankar <uma.shankar@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Anisse Astier <anisse@astier.eu> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 3 + > drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ > 3 files changed, 79 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 75d4ebc66941..f9254c0df1a2 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5183,6 +5183,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, > goto out_vdd_off; > } > > + /* Set up override EDID, if any, from ACPI OpRegion */ > + intel_opregion_edid_probe(intel_connector); > + > mutex_lock(&dev->mode_config.mutex); > edid = drm_get_edid(connector, &intel_dp->aux.ddc); > if (edid) { > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c > index 3855fba70980..b1b87ed758ba 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.c > +++ b/drivers/gpu/drm/i915/display/intel_opregion.c > @@ -196,6 +196,8 @@ struct opregion_asle_ext { > #define ASLE_IUER_WINDOWS_BTN (1 << 1) > #define ASLE_IUER_POWER_BTN (1 << 0) > > +#define ASLE_PHED_EDID_VALID_MASK 0x3 > + > /* Software System Control Interrupt (SWSCI) */ > #define SWSCI_SCIC_INDICATOR (1 << 0) > #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 > @@ -909,8 +911,10 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) > opregion->asle->ardy = ASLE_ARDY_NOT_READY; > } > > - if (mboxes & MBOX_ASLE_EXT) > + if (mboxes & MBOX_ASLE_EXT) { > drm_dbg(&dev_priv->drm, "ASLE extension supported\n"); > + opregion->asle_ext = base + OPREGION_ASLE_EXT_OFFSET; > + } > > if (intel_load_vbt_firmware(dev_priv) == 0) > goto out; > @@ -1037,6 +1041,68 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > return ret - 1; > } > > +/** > + * intel_opregion_edid_probe - Add EDID from ACPI OpRegion mailbox #5 > + * @intel_connector: eDP connector > + * > + * This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed > + * to it. > + * > + * Will take a lock on the DRM mode_config to add the EDID; make sure it isn't > + * called with lock taken. > + * > + */ > +void intel_opregion_edid_probe(struct intel_connector *intel_connector) With what I proposed this would become: struct edid *intel_opregion_get_edid(struct intel_connector *intel_connector) > +{ > + struct drm_connector *connector = &intel_connector->base; > + struct drm_i915_private *i915 = to_i915(connector->dev); > + struct intel_opregion *opregion = &i915->opregion; > + const void *in_edid; > + const struct edid *edid; > + struct edid *new_edid; > + int len, ret, num; > + > + if (!opregion->asle_ext || connector->override_edid) I don't think ->override_edid can actually be true at this point. > + return; > + > + in_edid = opregion->asle_ext->bddc; > + > + /* Validity corresponds to number of 128-byte blocks */ > + len = (opregion->asle_ext->phed & ASLE_PHED_EDID_VALID_MASK) * 128; > + if (!len || !memchr_inv(in_edid, 0, len)) > + return; > + > + edid = in_edid; > + > + if (len < EDID_LENGTH * (1 + edid->extensions)) { > + drm_dbg_kms(&i915->drm, "Invalid EDID in ACPI OpRegion (Mailbox #5)\n"); > + return; > + } > + new_edid = drm_edid_duplicate(edid); > + if (!new_edid) { > + drm_err(&i915->drm, "Cannot duplicate EDID\n"); In general, it's useless to try to debug print kmalloc errors. > + return; > + } > + if (!drm_edid_is_valid(new_edid)) { > + kfree(new_edid); > + drm_dbg_kms(&i915->drm, "Cannot validate EDID in ACPI OpRegion (Mailbox #5)\n"); Please just say the EDID is invalid. "Cannot validate" seems like we weren't able to check. > + return; > + } > + > + ret = drm_connector_update_edid_property(connector, new_edid); > + if (ret) { > + kfree(new_edid); > + return; > + } > + > + mutex_lock(&connector->dev->mode_config.mutex); > + num = drm_add_edid_modes(connector, new_edid); > + mutex_unlock(&connector->dev->mode_config.mutex); The above parts would go away with my proposal. > + > + drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s], added %d mode(s)\n", > + connector->base.id, connector->name, num); It's customary to have [CONNECTOR:%d:%s] as the first thing in the debug log; it's easier to look for in dmesg. > +} > + > void intel_opregion_register(struct drm_i915_private *i915) > { > struct intel_opregion *opregion = &i915->opregion; > @@ -1130,6 +1196,7 @@ void intel_opregion_unregister(struct drm_i915_private *i915) > opregion->acpi = NULL; > opregion->swsci = NULL; > opregion->asle = NULL; > + opregion->asle_ext = NULL; > opregion->vbt = NULL; > opregion->lid_state = NULL; > } > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h > index 4aa68ffbd30e..c1ecfcbb6f55 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.h > +++ b/drivers/gpu/drm/i915/display/intel_opregion.h > @@ -29,12 +29,14 @@ > #include <linux/pci.h> > > struct drm_i915_private; > +struct intel_connector; > struct intel_encoder; > > struct opregion_header; > struct opregion_acpi; > struct opregion_swsci; > struct opregion_asle; > +struct opregion_asle_ext; > > struct intel_opregion { > struct opregion_header *header; > @@ -43,6 +45,7 @@ struct intel_opregion { > u32 swsci_gbda_sub_functions; > u32 swsci_sbcb_sub_functions; > struct opregion_asle *asle; > + struct opregion_asle_ext *asle_ext; > void *rvda; > void *vbt_firmware; > const void *vbt; > @@ -71,6 +74,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, > int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, > pci_power_t state); > int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv); > +void intel_opregion_edid_probe(struct intel_connector *connector); > > #else /* CONFIG_ACPI*/ > > @@ -117,6 +121,10 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) > return -ENODEV; > } > > +void intel_opregion_edid_probe(struct intel_connector *connector) > +{ > +} > + static inline > #endif /* CONFIG_ACPI */ > > #endif -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID 2021-08-31 9:30 ` Jani Nikula @ 2021-09-01 12:06 ` Anisse Astier 0 siblings, 0 replies; 12+ messages in thread From: Anisse Astier @ 2021-09-01 12:06 UTC (permalink / raw) To: Jani Nikula Cc: intel-gfx, dri-devel, Ville Syrjälä, Hans de Goede, Uma Shankar, Daniel Dadap Hi, On Tue, Aug 31, 2021 at 11:30 AM Jani Nikula <jani.nikula@intel.com> wrote: > > On Tue, 17 Aug 2021, Anisse Astier <anisse@astier.eu> wrote: > > The ACPI OpRegion Mailbox #5 ASLE extension may contain an EDID to be > > used for the embedded display. Add support for using it via by adding > > the EDID to the list of available modes on the connector, and use it for > > eDP when available. > > > > If a panel's EDID is broken, there may be an override EDID set in the > > ACPI OpRegion mailbox #5. Use it if available. > > > > Fixes the GPD Win Max laptop display, which seems to only use this > > mechanism to provide a proper EDID for its eDP screen. It would have > > been better to provide the EDID through the ACPI _DDC method instead, to > > have a more generic solution, but it seems the designers of this system > > did not consider it, and shipped the firmware without it. > > The question is whether the opregion EDID should be used for override or > fallback. The patch at hand is kind of neither, it just unconditionally > adds the modes from the opregion EDID to the connector. For your > display, they apparently end up also being the only mode(s), with one of > them being used as the fixed mode. (Otherwise the orientation quirk > wouldn't work.) Yes, I agree it should be a fallback, at least for this hardware. > > What does drm_get_edid() return for you? Maybe we should do something > like this instead: > > mutex_lock(&dev->mode_config.mutex); > edid = drm_get_edid(connector, &intel_dp->aux.ddc); > + if (!edid) > + edid = intel_opregion_get_edid(intel_connector); > if (edid) { > if (drm_add_edid_modes(connector, edid)) { > drm_connector_update_edid_property(connector, edid); Yes, I just tried this, it works well since drm_get_edid() does not return an EDID. > > This way we'll actually use all the other bits in the EDID, not just the > modes. And if it needs to become override rather than fallback, the > solution is: > > mutex_lock(&dev->mode_config.mutex); > - edid = drm_get_edid(connector, &intel_dp->aux.ddc); > + edid = intel_opregion_get_edid(intel_connector); > + if (!edid) > + edid = drm_get_edid(connector, &intel_dp->aux.ddc); > if (edid) { > if (drm_add_edid_modes(connector, edid)) { > drm_connector_update_edid_property(connector, edid); > > In any case, I think it's just plain wrong to use both the display and > opregion EDIDs at the same time. It's probably all around safer to start > with fallback. It will be in the next iteration. > > Please find some further comments inline. > > > Based on original patch series by: Jani Nikula <jani.nikula@intel.com> > > https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ > > > > Changes since Jani Nikula's series: > > - EDID is copied and validated with drm_edid_is_valid > > - Mode is now added via drm_add_edid_modes instead of using override > > mechanism > > - squashed the two patches > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > Cc: Uma Shankar <uma.shankar@intel.com> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Signed-off-by: Anisse Astier <anisse@astier.eu> > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 3 + > > drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ > > 3 files changed, 79 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > > index 75d4ebc66941..f9254c0df1a2 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -5183,6 +5183,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, > > goto out_vdd_off; > > } > > > > + /* Set up override EDID, if any, from ACPI OpRegion */ > > + intel_opregion_edid_probe(intel_connector); > > + > > mutex_lock(&dev->mode_config.mutex); > > edid = drm_get_edid(connector, &intel_dp->aux.ddc); > > if (edid) { > > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c > > index 3855fba70980..b1b87ed758ba 100644 > > --- a/drivers/gpu/drm/i915/display/intel_opregion.c > > +++ b/drivers/gpu/drm/i915/display/intel_opregion.c > > @@ -196,6 +196,8 @@ struct opregion_asle_ext { > > #define ASLE_IUER_WINDOWS_BTN (1 << 1) > > #define ASLE_IUER_POWER_BTN (1 << 0) > > > > +#define ASLE_PHED_EDID_VALID_MASK 0x3 > > + > > /* Software System Control Interrupt (SWSCI) */ > > #define SWSCI_SCIC_INDICATOR (1 << 0) > > #define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1 > > @@ -909,8 +911,10 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) > > opregion->asle->ardy = ASLE_ARDY_NOT_READY; > > } > > > > - if (mboxes & MBOX_ASLE_EXT) > > + if (mboxes & MBOX_ASLE_EXT) { > > drm_dbg(&dev_priv->drm, "ASLE extension supported\n"); > > + opregion->asle_ext = base + OPREGION_ASLE_EXT_OFFSET; > > + } > > > > if (intel_load_vbt_firmware(dev_priv) == 0) > > goto out; > > @@ -1037,6 +1041,68 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > > return ret - 1; > > } > > > > +/** > > + * intel_opregion_edid_probe - Add EDID from ACPI OpRegion mailbox #5 > > + * @intel_connector: eDP connector > > + * > > + * This reads the ACPI Opregion mailbox #5 to extract the EDID that is passed > > + * to it. > > + * > > + * Will take a lock on the DRM mode_config to add the EDID; make sure it isn't > > + * called with lock taken. > > + * > > + */ > > +void intel_opregion_edid_probe(struct intel_connector *intel_connector) > > With what I proposed this would become: > > struct edid *intel_opregion_get_edid(struct intel_connector *intel_connector) > > > +{ > > + struct drm_connector *connector = &intel_connector->base; > > + struct drm_i915_private *i915 = to_i915(connector->dev); > > + struct intel_opregion *opregion = &i915->opregion; > > + const void *in_edid; > > + const struct edid *edid; > > + struct edid *new_edid; > > + int len, ret, num; > > + > > + if (!opregion->asle_ext || connector->override_edid) > > I don't think ->override_edid can actually be true at this point. Ok. > > > + return; > > + > > + in_edid = opregion->asle_ext->bddc; > > + > > + /* Validity corresponds to number of 128-byte blocks */ > > + len = (opregion->asle_ext->phed & ASLE_PHED_EDID_VALID_MASK) * 128; > > + if (!len || !memchr_inv(in_edid, 0, len)) > > + return; > > + > > + edid = in_edid; > > + > > + if (len < EDID_LENGTH * (1 + edid->extensions)) { > > + drm_dbg_kms(&i915->drm, "Invalid EDID in ACPI OpRegion (Mailbox #5)\n"); > > + return; > > + } > > + new_edid = drm_edid_duplicate(edid); > > + if (!new_edid) { > > + drm_err(&i915->drm, "Cannot duplicate EDID\n"); > > In general, it's useless to try to debug print kmalloc errors. > > > + return; > > + } > > + if (!drm_edid_is_valid(new_edid)) { > > + kfree(new_edid); > > + drm_dbg_kms(&i915->drm, "Cannot validate EDID in ACPI OpRegion (Mailbox #5)\n"); > > Please just say the EDID is invalid. "Cannot validate" seems like we > weren't able to check. Ok. > > > + return; > > + } > > + > > + ret = drm_connector_update_edid_property(connector, new_edid); > > + if (ret) { > > + kfree(new_edid); > > + return; > > + } > > + > > + mutex_lock(&connector->dev->mode_config.mutex); > > + num = drm_add_edid_modes(connector, new_edid); > > + mutex_unlock(&connector->dev->mode_config.mutex); > > The above parts would go away with my proposal. Ok. > > > + > > + drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s], added %d mode(s)\n", > > + connector->base.id, connector->name, num); > > It's customary to have [CONNECTOR:%d:%s] as the first thing in the debug > log; it's easier to look for in dmesg. Ok. > > > +} > > + > > void intel_opregion_register(struct drm_i915_private *i915) > > { > > struct intel_opregion *opregion = &i915->opregion; > > @@ -1130,6 +1196,7 @@ void intel_opregion_unregister(struct drm_i915_private *i915) > > opregion->acpi = NULL; > > opregion->swsci = NULL; > > opregion->asle = NULL; > > + opregion->asle_ext = NULL; > > opregion->vbt = NULL; > > opregion->lid_state = NULL; > > } > > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h > > index 4aa68ffbd30e..c1ecfcbb6f55 100644 > > --- a/drivers/gpu/drm/i915/display/intel_opregion.h > > +++ b/drivers/gpu/drm/i915/display/intel_opregion.h > > @@ -29,12 +29,14 @@ > > #include <linux/pci.h> > > > > struct drm_i915_private; > > +struct intel_connector; > > struct intel_encoder; > > > > struct opregion_header; > > struct opregion_acpi; > > struct opregion_swsci; > > struct opregion_asle; > > +struct opregion_asle_ext; > > > > struct intel_opregion { > > struct opregion_header *header; > > @@ -43,6 +45,7 @@ struct intel_opregion { > > u32 swsci_gbda_sub_functions; > > u32 swsci_sbcb_sub_functions; > > struct opregion_asle *asle; > > + struct opregion_asle_ext *asle_ext; > > void *rvda; > > void *vbt_firmware; > > const void *vbt; > > @@ -71,6 +74,7 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder, > > int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, > > pci_power_t state); > > int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv); > > +void intel_opregion_edid_probe(struct intel_connector *connector); > > > > #else /* CONFIG_ACPI*/ > > > > @@ -117,6 +121,10 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) > > return -ENODEV; > > } > > > > +void intel_opregion_edid_probe(struct intel_connector *connector) > > +{ > > +} > > + > > static inline Noted. > > > #endif /* CONFIG_ACPI */ > > > > #endif > > -- > Jani Nikula, Intel Open Source Graphics Center Thanks a lot for your review time. Anisse ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v3 2/2] drm: Add orientation quirk for GPD Win Max 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier 2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID Anisse Astier @ 2021-08-17 20:43 ` Anisse Astier 2021-08-17 21:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev4) Patchwork ` (5 subsequent siblings) 7 siblings, 0 replies; 12+ messages in thread From: Anisse Astier @ 2021-08-17 20:43 UTC (permalink / raw) To: intel-gfx, dri-devel Cc: Ville Syrjälä, Hans de Goede, Uma Shankar, Jani Nikula, Daniel Dadap, Anisse Astier Panel is 800x1280, but mounted on a laptop form factor, sideways. Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Anisse Astier <anisse@astier.eu> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 4e965b0f5502..643b55f9a9d1 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -160,6 +160,12 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MicroPC"), }, .driver_data = (void *)&lcd720x1280_rightside_up, + }, { /* GPD Win Max */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1619-01"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, }, { /* * GPD Pocket, note that the the DMI data is less generic then * it seems, devices with a board-vendor of "AMI Corporation" -- 2.31.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev4) 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier 2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID Anisse Astier 2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 2/2] drm: Add orientation quirk for GPD Win Max Anisse Astier @ 2021-08-17 21:30 ` Patchwork 2021-08-17 21:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork ` (4 subsequent siblings) 7 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-08-17 21:30 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx == Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim checkpatch origin/drm-tip b615ccdfa166 drm/i915/opregion: add support for mailbox #5 EDID -:24: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #24: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ total: 0 errors, 1 warnings, 0 checks, 141 lines checked b8a3470e871a drm: Add orientation quirk for GPD Win Max ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for GPD Win Max display fixes (rev4) 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier ` (2 preceding siblings ...) 2021-08-17 21:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev4) Patchwork @ 2021-08-17 21:32 ` Patchwork 2021-08-17 22:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (3 subsequent siblings) 7 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-08-17 21:32 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx == Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1901:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1901:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1901:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/i915_gem_context.c:1374:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1374:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1374:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: expected struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: got struct i915_address_space * +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1392:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1268:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1442:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1496:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for GPD Win Max display fixes (rev4) 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier ` (3 preceding siblings ...) 2021-08-17 21:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork @ 2021-08-17 22:01 ` Patchwork 2021-08-17 23:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork ` (2 subsequent siblings) 7 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-08-17 22:01 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 6269 bytes --] == Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491 -> Patchwork_20837 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/index.html Known issues ------------ Here are the changes found in Patchwork_20837 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@cs-gfx: - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +11 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-kbl-soraka/igt@amdgpu/amd_basic@cs-gfx.html * igt@gem_huc_copy@huc-copy: - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886] / [i915#2291]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@workarounds: - fi-rkl-guc: NOTRUN -> [DMESG-FAIL][4] ([i915#3928]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-rkl-guc/igt@i915_selftest@live@workarounds.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [PASS][6] -> [DMESG-WARN][7] ([i915#2203] / [i915#2868]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#533]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html #### Possible fixes #### * igt@core_hotunplug@unbind-rebind: - fi-rkl-guc: [DMESG-WARN][9] ([i915#3925]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html - fi-ilk-650: [DMESG-WARN][11] ([i915#164]) -> [PASS][12] +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/fi-ilk-650/igt@core_hotunplug@unbind-rebind.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-ilk-650/igt@core_hotunplug@unbind-rebind.html * igt@gem_exec_suspend@basic-s0: - fi-kbl-soraka: [INCOMPLETE][13] ([i915#155]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html * igt@gem_exec_suspend@basic-s3: - fi-tgl-1115g4: [FAIL][15] ([i915#1888]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live@execlists: - {fi-tgl-dsi}: [DMESG-FAIL][17] ([i915#1993]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/fi-tgl-dsi/igt@i915_selftest@live@execlists.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-tgl-dsi/igt@i915_selftest@live@execlists.html #### Warnings #### * igt@runner@aborted: - fi-rkl-guc: [FAIL][19] ([i915#1602]) -> [FAIL][20] ([i915#3928]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/fi-rkl-guc/igt@runner@aborted.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/fi-rkl-guc/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#164]: https://gitlab.freedesktop.org/drm/intel/issues/164 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1993]: https://gitlab.freedesktop.org/drm/intel/issues/1993 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868 [i915#3925]: https://gitlab.freedesktop.org/drm/intel/issues/3925 [i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 Participating hosts (36 -> 34) ------------------------------ Missing (2): fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10491 -> Patchwork_20837 CI-20190529: 20190529 CI_DRM_10491: efa09f306ade4b8550404d7248ac743fc0cb2c7d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6177: f474644e7226dd319195ca03b3cde82ad10ac54c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20837: b8a3470e871a1d498b40b86971d396489990c1bc @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == b8a3470e871a drm: Add orientation quirk for GPD Win Max b615ccdfa166 drm/i915/opregion: add support for mailbox #5 EDID == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/index.html [-- Attachment #2: Type: text/html, Size: 7455 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for GPD Win Max display fixes (rev4) 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier ` (4 preceding siblings ...) 2021-08-17 22:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-08-17 23:22 ` Patchwork 2021-08-30 13:49 ` [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier 2021-08-31 9:33 ` Jani Nikula 7 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2021-08-17 23:22 UTC (permalink / raw) To: Anisse Astier; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30254 bytes --] == Series Details == Series: GPD Win Max display fixes (rev4) URL : https://patchwork.freedesktop.org/series/90483/ State : success == Summary == CI Bug Log - changes from CI_DRM_10491_full -> Patchwork_20837_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_20837_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@display-2x: - shard-iclb: NOTRUN -> [SKIP][1] ([i915#1839]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@feature_discovery@display-2x.html * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][2] ([i915#3002]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl8/igt@gem_create@create-massive.html * igt@gem_ctx_persistence@engines-mixed: - shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-snb5/igt@gem_ctx_persistence@engines-mixed.html * igt@gem_eio@in-flight-suspend: - shard-apl: [PASS][4] -> [DMESG-WARN][5] ([i915#180]) +1 similar issue [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-apl8/igt@gem_eio@in-flight-suspend.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl8/igt@gem_eio@in-flight-suspend.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#3063] / [i915#3648]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-tglb6/igt@gem_eio@unwedge-stress.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb6/igt@gem_eio@unwedge-stress.html - shard-iclb: [PASS][8] -> [TIMEOUT][9] ([i915#2369] / [i915#2481] / [i915#3070]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-iclb5/igt@gem_eio@unwedge-stress.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb1/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-kbl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-glk4/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][14] -> [SKIP][15] ([i915#2190]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-tglb8/igt@gem_huc_copy@huc-copy.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb6/igt@gem_huc_copy@huc-copy.html - shard-kbl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#2190]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@gem_huc_copy@huc-copy.html * igt@gem_pwrite@basic-exhaustion: - shard-apl: NOTRUN -> [WARN][17] ([i915#2658]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl6/igt@gem_pwrite@basic-exhaustion.html - shard-tglb: NOTRUN -> [WARN][18] ([i915#2658]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb5/igt@gem_pwrite@basic-exhaustion.html * igt@gem_render_copy@y-tiled-to-vebox-yf-tiled: - shard-iclb: NOTRUN -> [SKIP][19] ([i915#768]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@gem_render_copy@y-tiled-to-vebox-yf-tiled.html * igt@gem_userptr_blits@dmabuf-sync: - shard-tglb: NOTRUN -> [SKIP][20] ([i915#3323]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@dmabuf-unsync: - shard-iclb: NOTRUN -> [SKIP][21] ([i915#3297]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@gem_userptr_blits@dmabuf-unsync.html * igt@gem_userptr_blits@unsync-unmap-cycles: - shard-tglb: NOTRUN -> [SKIP][22] ([i915#3297]) +3 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@gem_userptr_blits@unsync-unmap-cycles.html * igt@gen3_mixed_blits: - shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109289]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@gen3_mixed_blits.html * igt@gen3_render_tiledx_blits: - shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109289]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@gen3_render_tiledx_blits.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [PASS][25] -> [DMESG-WARN][26] ([i915#1436] / [i915#716]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl1/igt@gen9_exec_parse@allowed-single.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@batch-invalid-length: - shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271]) +432 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-snb2/igt@gen9_exec_parse@batch-invalid-length.html * igt@gen9_exec_parse@bb-start-out: - shard-iclb: NOTRUN -> [SKIP][28] ([i915#2856]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@gen9_exec_parse@bb-start-out.html * igt@gen9_exec_parse@bb-start-param: - shard-tglb: NOTRUN -> [SKIP][29] ([i915#2856]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@gen9_exec_parse@bb-start-param.html * igt@i915_pm_dc@dc6-dpms: - shard-tglb: NOTRUN -> [FAIL][30] ([i915#454]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rpm@modeset-non-lpsp: - shard-iclb: NOTRUN -> [SKIP][31] ([fdo#110892]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@i915_pm_rpm@modeset-non-lpsp.html * igt@kms_addfb_basic@invalid-smem-bo-on-discrete: - shard-tglb: NOTRUN -> [SKIP][32] ([i915#3826]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb3/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html * igt@kms_atomic@plane-primary-overlay-mutable-zpos: - shard-tglb: NOTRUN -> [SKIP][33] ([i915#404]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb3/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-skl: NOTRUN -> [FAIL][34] ([i915#3722]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_big_fb@y-tiled-64bpp-rotate-270: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#110725] / [fdo#111614]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-180: - shard-tglb: NOTRUN -> [SKIP][36] ([fdo#111615]) +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip: - shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3777]) +2 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3777]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +2 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +9 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl3/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs: - shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886]) +5 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl7/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][42] ([i915#3689]) +7 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs.html * igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109278] / [i915#3886]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689] / [i915#3886]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb5/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs: - shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278]) +10 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs.html * igt@kms_cdclk@plane-scaling: - shard-tglb: NOTRUN -> [SKIP][46] ([i915#3742]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb3/igt@kms_cdclk@plane-scaling.html * igt@kms_chamelium@dp-crc-multiple: - shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +14 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl7/igt@kms_chamelium@dp-crc-multiple.html * igt@kms_chamelium@hdmi-crc-nonplanar-formats: - shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109284] / [fdo#111827]) +2 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_chamelium@hdmi-crc-nonplanar-formats.html * igt@kms_chamelium@hdmi-hpd-storm-disable: - shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +7 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@kms_chamelium@hdmi-hpd-storm-disable.html * igt@kms_color@pipe-d-ctm-green-to-red: - shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278] / [i915#1149]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_color@pipe-d-ctm-green-to-red.html * igt@kms_color_chamelium@pipe-b-ctm-0-25: - shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +18 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-snb5/igt@kms_color_chamelium@pipe-b-ctm-0-25.html * igt@kms_color_chamelium@pipe-c-ctm-0-25: - shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +6 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@kms_color_chamelium@pipe-c-ctm-0-25.html * igt@kms_color_chamelium@pipe-c-degamma: - shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109284] / [fdo#111827]) +3 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_color_chamelium@pipe-c-degamma.html * igt@kms_content_protection@atomic: - shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109300] / [fdo#111066]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_content_protection@atomic.html * igt@kms_content_protection@atomic-dpms: - shard-apl: NOTRUN -> [TIMEOUT][55] ([i915#1319]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl3/igt@kms_content_protection@atomic-dpms.html * igt@kms_content_protection@lic: - shard-tglb: NOTRUN -> [SKIP][56] ([fdo#111828]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_content_protection@lic.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-random: - shard-tglb: NOTRUN -> [SKIP][57] ([i915#3319]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-32x32-random.html * igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding: - shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109279] / [i915#3359]) +1 similar issue [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding.html * igt@kms_cursor_crc@pipe-c-cursor-max-size-sliding: - shard-tglb: NOTRUN -> [SKIP][59] ([i915#3359]) +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_cursor_crc@pipe-c-cursor-max-size-sliding.html * igt@kms_cursor_legacy@cursora-vs-flipb-varying-size: - shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109274] / [fdo#109278]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][61] -> [FAIL][62] ([i915#2346]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_cursor_legacy@pipe-d-torture-bo: - shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#533]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl3/igt@kms_cursor_legacy@pipe-d-torture-bo.html * igt@kms_dsc@basic-dsc-enable: - shard-iclb: NOTRUN -> [SKIP][64] ([i915#3840]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_dsc@basic-dsc-enable.html * igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible: - shard-tglb: NOTRUN -> [SKIP][65] ([fdo#111825]) +20 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html * igt@kms_flip@flip-vs-dpms-off-vs-modeset@a-edp1: - shard-skl: [PASS][66] -> [DMESG-WARN][67] ([i915#1982]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl2/igt@kms_flip@flip-vs-dpms-off-vs-modeset@a-edp1.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl8/igt@kms_flip@flip-vs-dpms-off-vs-modeset@a-edp1.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: - shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2672]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109280]) +9 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-msflip-blt: - shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271]) +44 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-msflip-blt.html * igt@kms_multipipe_modeset@basic-max-pipe-crc-check: - shard-tglb: NOTRUN -> [SKIP][71] ([i915#1839]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#533]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d: - shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#533]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [PASS][74] -> [DMESG-WARN][75] ([i915#180]) +2 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-skl: NOTRUN -> [FAIL][76] ([i915#265]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-apl: NOTRUN -> [FAIL][77] ([fdo#108145] / [i915#265]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: - shard-kbl: NOTRUN -> [FAIL][78] ([fdo#108145] / [i915#265]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][79] ([i915#265]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-skl: NOTRUN -> [FAIL][80] ([fdo#108145] / [i915#265]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html * igt@kms_plane_lowres@pipe-d-tiling-x: - shard-tglb: NOTRUN -> [SKIP][81] ([i915#3536]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_plane_lowres@pipe-d-tiling-x.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5: - shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#658]) +3 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2: - shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-2: - shard-tglb: NOTRUN -> [SKIP][84] ([i915#2920]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb3/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html * igt@kms_psr@psr2_cursor_plane_move: - shard-tglb: NOTRUN -> [FAIL][86] ([i915#132] / [i915#3467]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109441]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_psr@psr2_cursor_render.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][88] -> [SKIP][89] ([fdo#109441]) +1 similar issue [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: NOTRUN -> [DMESG-WARN][90] ([i915#180] / [i915#295]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vrr@flipline: - shard-tglb: NOTRUN -> [SKIP][91] ([fdo#109502]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb3/igt@kms_vrr@flipline.html * igt@kms_writeback@writeback-check-output: - shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2437]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl7/igt@kms_writeback@writeback-check-output.html * igt@kms_writeback@writeback-fb-id: - shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2437]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl3/igt@kms_writeback@writeback-fb-id.html * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame: - shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271]) +171 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl7/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html * igt@perf@blocking: - shard-skl: [PASS][95] -> [FAIL][96] ([i915#1542]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl2/igt@perf@blocking.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl8/igt@perf@blocking.html * igt@prime_nv_api@i915_self_import: - shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271]) +85 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@prime_nv_api@i915_self_import.html - shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109291]) +1 similar issue [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@prime_nv_api@i915_self_import.html * igt@prime_nv_test@i915_import_pread_pwrite: - shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109291]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb8/igt@prime_nv_test@i915_import_pread_pwrite.html * igt@sysfs_clients@recycle: - shard-iclb: NOTRUN -> [SKIP][100] ([i915#2994]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@sysfs_clients@recycle.html - shard-skl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#2994]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@sysfs_clients@recycle.html * igt@sysfs_clients@sema-10: - shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#2994]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl3/igt@sysfs_clients@sema-10.html #### Possible fixes #### * igt@gem_create@create-clear: - shard-glk: [FAIL][103] ([i915#1888] / [i915#3160]) -> [PASS][104] [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-glk8/igt@gem_create@create-clear.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-glk4/igt@gem_create@create-clear.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][105] ([i915#2846]) -> [PASS][106] [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-glk7/igt@gem_exec_fair@basic-deadline.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-glk3/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [FAIL][107] ([i915#2842]) -> [PASS][108] +2 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-tglb: [FAIL][109] ([i915#2842]) -> [PASS][110] +2 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-tglb7/igt@gem_exec_fair@basic-pace@bcs0.html * igt@i915_selftest@live@hangcheck: - shard-snb: [INCOMPLETE][111] ([i915#3921]) -> [PASS][112] [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-snb2/igt@i915_selftest@live@hangcheck.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-snb5/igt@i915_selftest@live@hangcheck.html * igt@kms_color@pipe-a-ctm-0-25: - shard-skl: [DMESG-WARN][113] ([i915#1982]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl8/igt@kms_color@pipe-a-ctm-0-25.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl3/igt@kms_color@pipe-a-ctm-0-25.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [FAIL][115] ([i915#2122]) -> [PASS][116] [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-apl: [DMESG-WARN][117] ([i915#180]) -> [PASS][118] +1 similar issue [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: - shard-skl: [INCOMPLETE][119] ([i915#198]) -> [PASS][120] [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl3/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl4/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-edp1: - shard-iclb: [INCOMPLETE][121] ([i915#2910]) -> [PASS][122] [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-iclb3/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb3/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes: - shard-kbl: [DMESG-WARN][123] ([i915#180]) -> [PASS][124] +1 similar issue [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][125] ([fdo#108145] / [i915#265]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_primary_blt: - shard-iclb: [SKIP][127] ([fdo#109441]) -> [PASS][128] [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-iclb6/igt@kms_psr@psr2_primary_blt.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb2/igt@kms_psr@psr2_primary_blt.html * igt@perf@polling: - shard-skl: [FAIL][129] ([i915#1542]) -> [PASS][130] [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-skl3/igt@perf@polling.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-skl10/igt@perf@polling.html #### Warnings #### * igt@i915_suspend@forcewake: - shard-kbl: [INCOMPLETE][131] ([i915#155] / [i915#636]) -> [INCOMPLETE][132] ([i915#636]) [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-kbl4/igt@i915_suspend@forcewake.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-kbl2/igt@i915_suspend@forcewake.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-iclb: [SKIP][133] ([i915#2920]) -> [SKIP][134] ([i915#658]) +1 similar issue [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-0: - shard-iclb: [SKIP][135] ([i915#658]) -> [SKIP][136] ([i915#2920]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10491/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html [136]: == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20837/index.html [-- Attachment #2: Type: text/html, Size: 33796 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier ` (5 preceding siblings ...) 2021-08-17 23:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2021-08-30 13:49 ` Anisse Astier 2021-08-31 9:33 ` Jani Nikula 7 siblings, 0 replies; 12+ messages in thread From: Anisse Astier @ 2021-08-30 13:49 UTC (permalink / raw) To: intel-gfx, dri-devel Cc: Ville Syrjälä, Hans de Goede, Uma Shankar, Jani Nikula, Daniel Dadap Hi, On Tue, Aug 17, 2021 at 10:43 PM Anisse Astier <anisse@astier.eu> wrote: > > This patch series is for making the GPD Win Max display usable with > Linux. > > The GPD Win Max is a small laptop, and its eDP panel does not send an > EDID over DPCD; the EDID is instead available in the intel opregion, in > mailbox #5 [1] > > The first patch is based on Jani's patch series [2] adding support for > the opregion, with changes. I've changed authorship, but I'd be glad to > revert it > > The second patch is just to fix the orientation of the panel. > > Changes since v1: > - rebased on drm-tip > - squashed patch 1 & 2 > - picked up Reviewed-by from Hans de Goede (thanks for the review) > > Changes since v2: > - rebased on drm-tip > - updated commit message > > When v2 was initially sent [3] Ville Syrjälä suggested that it might be > a good idea to use the ACPI _DDC method instead to get the EDID, to > cover a wider range of hardware. Unfortunately, it doesn't seem > available on GPD Win Max, so I think this work should be done > independently, and this patch series considered separately. > > [1]: https://gitlab.freedesktop.org/drm/intel/-/issues/3454 > [2]: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ > [3]: https://patchwork.kernel.org/project/intel-gfx/patch/20210531204642.4907-2-anisse@astier.eu/ > > > Anisse Astier (2): > drm/i915/opregion: add support for mailbox #5 EDID > drm: Add orientation quirk for GPD Win Max > > .../gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > drivers/gpu/drm/i915/display/intel_dp.c | 3 + > drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ > 4 files changed, 85 insertions(+), 1 deletion(-) Would it be possible to have this series reviewed ? Kind regards, Anisse ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier ` (6 preceding siblings ...) 2021-08-30 13:49 ` [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier @ 2021-08-31 9:33 ` Jani Nikula 2021-08-31 9:51 ` Anisse Astier 7 siblings, 1 reply; 12+ messages in thread From: Jani Nikula @ 2021-08-31 9:33 UTC (permalink / raw) To: Anisse Astier, intel-gfx, dri-devel Cc: Ville Syrjälä, Hans de Goede, Uma Shankar, Daniel Dadap, Anisse Astier On Tue, 17 Aug 2021, Anisse Astier <anisse@astier.eu> wrote: > This patch series is for making the GPD Win Max display usable with > Linux. > > The GPD Win Max is a small laptop, and its eDP panel does not send an > EDID over DPCD; the EDID is instead available in the intel opregion, in > mailbox #5 [1] > > The first patch is based on Jani's patch series [2] adding support for > the opregion, with changes. I've changed authorship, but I'd be glad to > revert it If you don't mind, please just add: Co-developed-by: Jani Nikula <jani.nikula@intel.com> Thanks, Jani. > > The second patch is just to fix the orientation of the panel. > > Changes since v1: > - rebased on drm-tip > - squashed patch 1 & 2 > - picked up Reviewed-by from Hans de Goede (thanks for the review) > > Changes since v2: > - rebased on drm-tip > - updated commit message > > When v2 was initially sent [3] Ville Syrjälä suggested that it might be > a good idea to use the ACPI _DDC method instead to get the EDID, to > cover a wider range of hardware. Unfortunately, it doesn't seem > available on GPD Win Max, so I think this work should be done > independently, and this patch series considered separately. > > [1]: https://gitlab.freedesktop.org/drm/intel/-/issues/3454 > [2]: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ > [3]: https://patchwork.kernel.org/project/intel-gfx/patch/20210531204642.4907-2-anisse@astier.eu/ > > > Anisse Astier (2): > drm/i915/opregion: add support for mailbox #5 EDID > drm: Add orientation quirk for GPD Win Max > > .../gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > drivers/gpu/drm/i915/display/intel_dp.c | 3 + > drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ > 4 files changed, 85 insertions(+), 1 deletion(-) -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes 2021-08-31 9:33 ` Jani Nikula @ 2021-08-31 9:51 ` Anisse Astier 0 siblings, 0 replies; 12+ messages in thread From: Anisse Astier @ 2021-08-31 9:51 UTC (permalink / raw) To: Jani Nikula Cc: intel-gfx, dri-devel, Ville Syrjälä, Hans de Goede, Uma Shankar, Daniel Dadap On Tue, Aug 31, 2021 at 11:33 AM Jani Nikula <jani.nikula@intel.com> wrote: > > On Tue, 17 Aug 2021, Anisse Astier <anisse@astier.eu> wrote: > > This patch series is for making the GPD Win Max display usable with > > Linux. > > > > The GPD Win Max is a small laptop, and its eDP panel does not send an > > EDID over DPCD; the EDID is instead available in the intel opregion, in > > mailbox #5 [1] > > > > The first patch is based on Jani's patch series [2] adding support for > > the opregion, with changes. I've changed authorship, but I'd be glad to > > revert it > > If you don't mind, please just add: > > Co-developed-by: Jani Nikula <jani.nikula@intel.com> I don't mind at all, I think you should be first author for this series, I just didn't feel like giving you the blame for the bugs after this many modifications, without asking first. Will be in next iteration. Anisse > > > Thanks, > Jani. > > > > > The second patch is just to fix the orientation of the panel. > > > > Changes since v1: > > - rebased on drm-tip > > - squashed patch 1 & 2 > > - picked up Reviewed-by from Hans de Goede (thanks for the review) > > > > Changes since v2: > > - rebased on drm-tip > > - updated commit message > > > > When v2 was initially sent [3] Ville Syrjälä suggested that it might be > > a good idea to use the ACPI _DDC method instead to get the EDID, to > > cover a wider range of hardware. Unfortunately, it doesn't seem > > available on GPD Win Max, so I think this work should be done > > independently, and this patch series considered separately. > > > > [1]: https://gitlab.freedesktop.org/drm/intel/-/issues/3454 > > [2]: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/ > > [3]: https://patchwork.kernel.org/project/intel-gfx/patch/20210531204642.4907-2-anisse@astier.eu/ > > > > > > Anisse Astier (2): > > drm/i915/opregion: add support for mailbox #5 EDID > > drm: Add orientation quirk for GPD Win Max > > > > .../gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > > drivers/gpu/drm/i915/display/intel_dp.c | 3 + > > drivers/gpu/drm/i915/display/intel_opregion.c | 69 ++++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_opregion.h | 8 +++ > > 4 files changed, 85 insertions(+), 1 deletion(-) > > -- > Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-09-01 12:06 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-17 20:43 [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier 2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/opregion: add support for mailbox #5 EDID Anisse Astier 2021-08-31 9:30 ` Jani Nikula 2021-09-01 12:06 ` Anisse Astier 2021-08-17 20:43 ` [Intel-gfx] [PATCH v3 2/2] drm: Add orientation quirk for GPD Win Max Anisse Astier 2021-08-17 21:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev4) Patchwork 2021-08-17 21:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-08-17 22:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-08-17 23:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-08-30 13:49 ` [Intel-gfx] [PATCH v3 0/2] GPD Win Max display fixes Anisse Astier 2021-08-31 9:33 ` Jani Nikula 2021-08-31 9:51 ` Anisse Astier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).