From: Matthew Auld <matthew.william.auld@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool
Date: Tue, 28 Jul 2020 19:08:35 +0100 [thread overview]
Message-ID: <CAM0jSHM3Ncf31NSwQkXBNXu-C_Jb9fZ7_tz-pQVEYbdnWoyO2A@mail.gmail.com> (raw)
In-Reply-To: <20200728155935.17708-1-chris@chris-wilson.co.uk>
On Tue, 28 Jul 2020 at 16:59, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Some very low hanging fruit, but contention on the pool->lock is
> noticeable between intel_gt_get_buffer_pool() and pool_retire(), with
> the majority of the hold time due to the locked list iteration. If we
> make the node itself RCU protected, we can perform the search for an
> suitable node just under RCU, reserving taking the lock itself for
> claiming the node and manipulating the list.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-28 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 15:59 [Intel-gfx] [PATCH] drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool Chris Wilson
2020-07-28 18:08 ` Matthew Auld [this message]
2020-07-28 18:36 ` Chris Wilson
2020-07-28 19:36 ` Chris Wilson
2020-07-28 21:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool (rev5) Patchwork
2020-07-28 21:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-29 7:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-07-24 16:37 [Intel-gfx] [PATCH] drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool Chris Wilson
2020-07-24 17:51 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHM3Ncf31NSwQkXBNXu-C_Jb9fZ7_tz-pQVEYbdnWoyO2A@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).