From: Matthew Auld <matthew.william.auld@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Use igt_random_offset()
Date: Thu, 12 Mar 2020 17:00:58 +0000 [thread overview]
Message-ID: <CAM0jSHPoomPxh-fZrr7QOSeGDz_riqeicsJZKKqX5rTx3xunLQ@mail.gmail.com> (raw)
In-Reply-To: <20200312154708.1720-1-chris@chris-wilson.co.uk>
On Thu, 12 Mar 2020 at 15:47, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Switch igt_vm_isolation() to using igt_random_offset().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
> ---
> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index 77c7e65de7c3..62157e7567da 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1809,7 +1809,6 @@ static int igt_vm_isolation(void *arg)
>
> vm_total = ctx_vm(ctx_a)->total;
> GEM_BUG_ON(ctx_vm(ctx_b)->total != vm_total);
> - vm_total -= I915_GTT_PAGE_SIZE;
>
> count = 0;
> num_engines = 0;
> @@ -1828,10 +1827,9 @@ static int igt_vm_isolation(void *arg)
> u32 value = 0xc5c5c5c5;
> u64 offset;
>
> - div64_u64_rem(i915_prandom_u64_state(&prng),
> - vm_total, &offset);
> - offset = round_down(offset, alignof_dword);
> - offset += I915_GTT_PAGE_SIZE;
> + offset = igt_random_offset(&prng, 0, vm_total,
> + I915_GTT_PAGE_SIZE,
> + I915_GTT_PAGE_SIZE);
Further down is: GEM_BUG_ON(offset < I915_GTT_PAGE_SIZE);
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-12 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 15:47 [Intel-gfx] [PATCH] drm/i915/selftests: Use igt_random_offset() Chris Wilson
2020-03-12 16:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-12 17:00 ` Matthew Auld [this message]
2020-03-12 18:23 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-03-13 7:53 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHPoomPxh-fZrr7QOSeGDz_riqeicsJZKKqX5rTx3xunLQ@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).