* [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
@ 2022-11-15 8:08 Himal Prasad Ghimiray
2022-11-15 14:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] " Patchwork
` (4 more replies)
0 siblings, 5 replies; 15+ messages in thread
From: Himal Prasad Ghimiray @ 2022-11-15 8:08 UTC (permalink / raw)
To: intel-gfx
Export lmem maximum memory bandwidth to the userspace via sysfs.
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 2 ++
drivers/gpu/drm/i915/i915_sysfs.c | 27 +++++++++++++++++++++++++++
2 files changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index c4921c9a60770..3ba1efa995ca9 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -6603,6 +6603,8 @@
#define POWER_SETUP_I1_WATTS REG_BIT(31)
#define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed point format */
#define POWER_SETUP_I1_DATA_MASK REG_GENMASK(15, 0)
+#define PCODE_MEMORY_CONFIG 0x70
+#define MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
#define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv, pvc */
/* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */
diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
index 595e8b5749907..0a6efc300998b 100644
--- a/drivers/gpu/drm/i915/i915_sysfs.c
+++ b/drivers/gpu/drm/i915/i915_sysfs.c
@@ -37,7 +37,10 @@
#include "i915_drv.h"
#include "i915_sysfs.h"
+#include "i915_reg.h"
#include "intel_pm.h"
+#include "intel_pcode.h"
+
struct drm_i915_private *kdev_minor_to_i915(struct device *kdev)
{
@@ -231,11 +234,35 @@ static void i915_setup_error_capture(struct device *kdev) {}
static void i915_teardown_error_capture(struct device *kdev) {}
#endif
+static ssize_t
+prelim_lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute *attr, char *buff)
+{
+ struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
+ u32 val;
+ int err;
+
+ err = snb_pcode_read_p(&i915->uncore, PCODE_MEMORY_CONFIG,
+ MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
+ 0x0, &val);
+ if (err)
+ return err;
+
+ return sysfs_emit(buff, "%u\n", val);
+}
+
+static DEVICE_ATTR_RO(prelim_lmem_max_bw_Mbps);
+
void i915_setup_sysfs(struct drm_i915_private *dev_priv)
{
struct device *kdev = dev_priv->drm.primary->kdev;
int ret;
+ if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
+ ret = sysfs_create_file(&kdev->kobj, &dev_attr_prelim_lmem_max_bw_Mbps.attr);
+ if (ret)
+ drm_err(&dev_priv->drm, "Setting up sysfs to read max B/W failed\n");
+ }
+
if (HAS_L3_DPF(dev_priv)) {
ret = device_create_bin_file(kdev, &dpf_attrs);
if (ret)
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
2022-11-15 8:08 [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs Himal Prasad Ghimiray
@ 2022-11-15 14:53 ` Patchwork
2022-11-15 15:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-11-15 14:53 UTC (permalink / raw)
To: Himal Prasad Ghimiray; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
URL : https://patchwork.freedesktop.org/series/110902/
State : warning
== Summary ==
Error: dim checkpatch failed
b196769302e7 drm/i915: Export LMEM max memory bandwidth via sysfs.
-:43: CHECK:CAMELCASE: Avoid CamelCase: <prelim_lmem_max_bw_Mbps_show>
#43: FILE: drivers/gpu/drm/i915/i915_sysfs.c:238:
+prelim_lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute *attr, char *buff)
-:58: CHECK:CAMELCASE: Avoid CamelCase: <prelim_lmem_max_bw_Mbps>
#58: FILE: drivers/gpu/drm/i915/i915_sysfs.c:253:
+static DEVICE_ATTR_RO(prelim_lmem_max_bw_Mbps);
-:66: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_prelim_lmem_max_bw_Mbps>
#66: FILE: drivers/gpu/drm/i915/i915_sysfs.c:261:
+ ret = sysfs_create_file(&kdev->kobj, &dev_attr_prelim_lmem_max_bw_Mbps.attr);
total: 0 errors, 0 warnings, 3 checks, 53 lines checked
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
2022-11-15 8:08 [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs Himal Prasad Ghimiray
2022-11-15 14:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] " Patchwork
@ 2022-11-15 15:47 ` Patchwork
2022-11-15 19:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-11-15 15:47 UTC (permalink / raw)
To: Himal Prasad Ghimiray; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7111 bytes --]
== Series Details ==
Series: series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
URL : https://patchwork.freedesktop.org/series/110902/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12382 -> Patchwork_110902v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/index.html
Participating hosts (40 -> 39)
------------------------------
Missing (1): bat-dg2-11
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110902v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_suspend@basic-s3-without-i915:
- {bat-rpls-1}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
Known issues
------------
Here are the changes found in Patchwork_110902v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [PASS][3] -> [SKIP][4] ([fdo#109271]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/fi-pnv-d510/igt@gem_tiled_blits@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/fi-pnv-d510/igt@gem_tiled_blits@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][5] -> [INCOMPLETE][6] ([i915#6972] / [i915#7120])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-ilk-650: [PASS][7] -> [DMESG-WARN][8] ([i915#164])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/fi-ilk-650/igt@i915_suspend@basic-s2idle-without-i915.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/fi-ilk-650/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_flip@basic-plain-flip:
- bat-dg1-6: NOTRUN -> [SKIP][9] ([i915#4078])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-dg1-6/igt@kms_flip@basic-plain-flip.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][10] ([fdo#109271] / [i915#4312])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@fbdev@nullptr:
- {bat-rpls-1}: [SKIP][11] ([i915#2582]) -> [PASS][12] +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-rpls-1/igt@fbdev@nullptr.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-rpls-1/igt@fbdev@nullptr.html
* igt@fbdev@read:
- {bat-rpls-2}: [SKIP][13] ([i915#2582]) -> [PASS][14] +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-rpls-2/igt@fbdev@read.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-rpls-2/igt@fbdev@read.html
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rpls-2}: [DMESG-WARN][15] ([i915#6434]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@mman:
- {bat-rpls-1}: [TIMEOUT][17] ([i915#6794]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-rpls-1/igt@i915_selftest@live@mman.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-rpls-1/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@slpc:
- {bat-adln-1}: [DMESG-FAIL][19] ([i915#6997]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-adln-1/igt@i915_selftest@live@slpc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-adln-1/igt@i915_selftest@live@slpc.html
* igt@kms_frontbuffer_tracking@basic:
- {bat-rpls-1}: [SKIP][21] ([i915#1849]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-rpls-1/igt@kms_frontbuffer_tracking@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-rpls-1/igt@kms_frontbuffer_tracking@basic.html
* igt@prime_vgem@basic-fence-flip:
- {bat-rpls-1}: [SKIP][23] ([fdo#109295] / [i915#1845] / [i915#3708]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/bat-rpls-1/igt@prime_vgem@basic-fence-flip.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/bat-rpls-1/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[i915#164]: https://gitlab.freedesktop.org/drm/intel/issues/164
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6972]: https://gitlab.freedesktop.org/drm/intel/issues/6972
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7120]: https://gitlab.freedesktop.org/drm/intel/issues/7120
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
Build changes
-------------
* Linux: CI_DRM_12382 -> Patchwork_110902v1
CI-20190529: 20190529
CI_DRM_12382: cb74864693414b221b3601572e75449558126e8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7057: e2138d48c2c506816868c16cf3ba64f81bdead41 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110902v1: cb74864693414b221b3601572e75449558126e8b @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
4c29a7357cee drm/i915: Export LMEM max memory bandwidth via sysfs.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/index.html
[-- Attachment #2: Type: text/html, Size: 7899 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
2022-11-15 8:08 [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs Himal Prasad Ghimiray
2022-11-15 14:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] " Patchwork
2022-11-15 15:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-11-15 19:24 ` Patchwork
2022-11-16 9:39 ` [Intel-gfx] [PATCH 1/1] " Iddamsetty, Aravind
2022-11-16 10:08 ` Gupta, Anshuman
4 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-11-15 19:24 UTC (permalink / raw)
To: Himal Prasad Ghimiray; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 36402 bytes --]
== Series Details ==
Series: series starting with [1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
URL : https://patchwork.freedesktop.org/series/110902/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12382_full -> Patchwork_110902v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110902v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110902v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110902v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-valid-mode:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-tglb8/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-valid-mode.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-tglb8/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-valid-mode.html
Known issues
------------
Here are the changes found in Patchwork_110902v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27]) -> ([PASS][28], [PASS][29], [FAIL][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52]) ([i915#4392])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk9/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk9/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk8/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk8/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk8/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk5/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk3/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk3/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk3/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk1/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk9/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk9/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk8/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk8/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk7/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk7/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk3/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk2/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk1/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk1/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-hang:
- shard-snb: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#1099])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-snb7/igt@gem_ctx_persistence@legacy-engines-hang.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][54] ([i915#3354])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-snb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][55] -> [FAIL][56] ([i915#2842])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][57] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_set_tiling_vs_gtt:
- shard-skl: [PASS][58] -> [DMESG-WARN][59] ([i915#1982]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-skl1/igt@gem_set_tiling_vs_gtt.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl7/igt@gem_set_tiling_vs_gtt.html
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][60] -> [FAIL][61] ([i915#4171])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-tglb6/igt@gem_softpin@evict-single-offset.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-tglb8/igt@gem_softpin@evict-single-offset.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][62] -> [SKIP][63] ([i915#4281])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [PASS][64] -> [DMESG-FAIL][65] ([i915#5334])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-skl4/igt@i915_selftest@live@gt_heartbeat.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl2/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][66] -> [DMESG-WARN][67] ([i915#180]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_chamelium@dp-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl10/igt@kms_chamelium@dp-hpd-after-suspend.html
* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-snb: NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-snb7/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
* igt@kms_cursor_legacy@torture-bo@pipe-a:
- shard-glk: [PASS][70] -> [DMESG-WARN][71] ([i915#118])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk2/igt@kms_cursor_legacy@torture-bo@pipe-a.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk1/igt@kms_cursor_legacy@torture-bo@pipe-a.html
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-edp1:
- shard-skl: [PASS][72] -> [FAIL][73] ([i915#2122])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-skl1/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-edp1.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl4/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#2672]) +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#6375])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#3555]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#2587] / [i915#2672]) +4 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-skl: NOTRUN -> [SKIP][78] ([fdo#109271]) +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl10/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][79] ([fdo#109271]) +53 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-snb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-c-edp-1:
- shard-skl: NOTRUN -> [FAIL][80] ([i915#4573]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl10/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-c-edp-1.html
* igt@kms_plane_lowres@tiling-yf@pipe-b-hdmi-a-1:
- shard-glk: [PASS][81] -> [FAIL][82] ([i915#7307])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk1/igt@kms_plane_lowres@tiling-yf@pipe-b-hdmi-a-1.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk6/igt@kms_plane_lowres@tiling-yf@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [PASS][83] -> [SKIP][84] ([i915#5176]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109642] / [fdo#111068] / [i915#658])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb8/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][86] -> [SKIP][87] ([fdo#109441]) +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][88] -> [SKIP][89] ([i915#5519])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb5/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb3/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- shard-snb: [DMESG-WARN][90] ([i915#4528]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-snb6/igt@core_hotunplug@unbind-rebind.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-snb7/igt@core_hotunplug@unbind-rebind.html
* igt@fbdev@eof:
- {shard-rkl}: [SKIP][92] ([i915#2582]) -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-5/igt@fbdev@eof.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-6/igt@fbdev@eof.html
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][94] ([fdo#103375]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-4/igt@gem_eio@in-flight-suspend.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-5/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][96] ([i915#5784]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-dg1-19/igt@gem_eio@unwedge-stress.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-dg1-18/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][98] ([i915#4525]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb6/igt@gem_exec_balancer@parallel-out-fence.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb1/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][100] ([i915#2842]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][102] ([i915#2842]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_fence@basic-busy@bcs0:
- {shard-rkl}: [SKIP][104] ([i915#6251]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-5/igt@gem_exec_fence@basic-busy@bcs0.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-2/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_reloc@basic-cpu-read:
- {shard-rkl}: [SKIP][106] ([i915#3281]) -> [PASS][107] +5 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-4/igt@gem_exec_reloc@basic-cpu-read.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-5/igt@gem_exec_reloc@basic-cpu-read.html
* igt@gem_mmap_gtt@coherency:
- {shard-rkl}: [SKIP][108] ([fdo#111656]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-4/igt@gem_mmap_gtt@coherency.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-5/igt@gem_mmap_gtt@coherency.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][110] ([i915#3282]) -> [PASS][111] +4 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-4/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gen9_exec_parse@batch-invalid-length:
- {shard-rkl}: [SKIP][112] ([i915#2527]) -> [PASS][113] +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-4/igt@gen9_exec_parse@batch-invalid-length.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-5/igt@gen9_exec_parse@batch-invalid-length.html
* igt@i915_pm_backlight@fade:
- {shard-rkl}: [SKIP][114] ([i915#3012]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-1/igt@i915_pm_backlight@fade.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-6/igt@i915_pm_backlight@fade.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: [WARN][116] ([i915#1804]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-skl7/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl9/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_sseu@full-enable:
- shard-skl: [FAIL][118] ([i915#6991]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-skl10/igt@i915_pm_sseu@full-enable.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl4/igt@i915_pm_sseu@full-enable.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-iclb: [SKIP][120] -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb5/igt@i915_suspend@fence-restore-tiled2untiled.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb5/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][122] ([i915#2346]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@single-move@all-pipes:
- {shard-rkl}: [INCOMPLETE][124] -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-4/igt@kms_cursor_legacy@single-move@all-pipes.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-5/igt@kms_cursor_legacy@single-move@all-pipes.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][126] ([i915#79]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-rkl}: [SKIP][128] ([i915#1849] / [i915#4098]) -> [PASS][129] +21 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
* igt@kms_plane_lowres@tiling-yf@pipe-c-hdmi-a-1:
- shard-glk: [FAIL][130] ([i915#7307]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-glk1/igt@kms_plane_lowres@tiling-yf@pipe-c-hdmi-a-1.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-glk6/igt@kms_plane_lowres@tiling-yf@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][132] ([i915#5235]) -> [PASS][133] +2 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@cursor_render:
- {shard-rkl}: [SKIP][134] ([i915#1072]) -> [PASS][135] +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-2/igt@kms_psr@cursor_render.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-6/igt@kms_psr@cursor_render.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][136] ([fdo#109441]) -> [PASS][137] +3 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [SKIP][138] ([i915#5519]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-tglb2/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-tglb3/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_universal_plane@universal-plane-pipe-a-sanity:
- {shard-rkl}: [SKIP][140] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-1/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- {shard-rkl}: [SKIP][142] ([i915#1845] / [i915#4098]) -> [PASS][143] +21 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-1/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-6/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][144] ([i915#1982]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-skl7/igt@perf_pmu@module-unload.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-skl9/igt@perf_pmu@module-unload.html
* igt@prime_vgem@coherency-gtt:
- {shard-rkl}: [SKIP][146] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-rkl-4/igt@prime_vgem@coherency-gtt.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-rkl-5/igt@prime_vgem@coherency-gtt.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][148] ([i915#6117]) -> [SKIP][149] ([i915#4525])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb8/igt@gem_exec_balancer@parallel-ordering.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][150] ([i915#658]) -> [SKIP][151] ([i915#588])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb1/igt@i915_pm_dc@dc3co-vpb-simulation.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [DMESG-FAIL][152] ([IGT#6]) -> [FAIL][153] ([i915#4573]) +1 similar issue
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-apl8/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-apl7/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][154] ([i915#658]) -> [SKIP][155] ([i915#2920])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb1/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][156] ([i915#2920]) -> [SKIP][157] ([fdo#111068] / [i915#658])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb3/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][158] ([i915#2920]) -> [SKIP][159] ([i915#658])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][160], [FAIL][161]) ([i915#3002] / [i915#4312]) -> ([FAIL][162], [FAIL][163], [FAIL][164], [FAIL][165]) ([i915#180] / [i915#3002] / [i915#4312])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-apl8/igt@runner@aborted.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12382/shard-apl1/igt@runner@aborted.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-apl8/igt@runner@aborted.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-apl1/igt@runner@aborted.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-apl3/igt@runner@aborted.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/shard-apl2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6991]: https://gitlab.freedesktop.org/drm/intel/issues/6991
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7142]: https://gitlab.freedesktop.org/drm/intel/issues/7142
[i915#7307]: https://gitlab.freedesktop.org/drm/intel/issues/7307
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12382 -> Patchwork_110902v1
CI-20190529: 20190529
CI_DRM_12382: cb74864693414b221b3601572e75449558126e8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7057: e2138d48c2c506816868c16cf3ba64f81bdead41 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110902v1: cb74864693414b221b3601572e75449558126e8b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110902v1/index.html
[-- Attachment #2: Type: text/html, Size: 37640 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
2022-11-15 8:08 [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs Himal Prasad Ghimiray
` (2 preceding siblings ...)
2022-11-15 19:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-11-16 9:39 ` Iddamsetty, Aravind
2022-11-16 10:08 ` Gupta, Anshuman
4 siblings, 0 replies; 15+ messages in thread
From: Iddamsetty, Aravind @ 2022-11-16 9:39 UTC (permalink / raw)
To: Himal Prasad Ghimiray, intel-gfx
On 15-11-2022 13:38, Himal Prasad Ghimiray wrote:
> Export lmem maximum memory bandwidth to the userspace via sysfs.
>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 ++
> drivers/gpu/drm/i915/i915_sysfs.c | 27 +++++++++++++++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index c4921c9a60770..3ba1efa995ca9 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -6603,6 +6603,8 @@
> #define POWER_SETUP_I1_WATTS REG_BIT(31)
> #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed point format */
> #define POWER_SETUP_I1_DATA_MASK REG_GENMASK(15, 0)
> +#define PCODE_MEMORY_CONFIG 0x70
> +#define MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv, pvc */
> /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 595e8b5749907..0a6efc300998b 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -37,7 +37,10 @@
>
> #include "i915_drv.h"
> #include "i915_sysfs.h"
> +#include "i915_reg.h"
> #include "intel_pm.h"
> +#include "intel_pcode.h"
> +
>
> struct drm_i915_private *kdev_minor_to_i915(struct device *kdev)
> {
> @@ -231,11 +234,35 @@ static void i915_setup_error_capture(struct device *kdev) {}
> static void i915_teardown_error_capture(struct device *kdev) {}
> #endif
>
prelim naming shall not be used.
Thanks,
Aravind.
> +static ssize_t
> +prelim_lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute *attr, char *buff)
> +{
> + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> + u32 val;
> + int err;
> +
> + err = snb_pcode_read_p(&i915->uncore, PCODE_MEMORY_CONFIG,
> + MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> + 0x0, &val);
> + if (err)
> + return err;
> +
> + return sysfs_emit(buff, "%u\n", val);
> +}
> +
> +static DEVICE_ATTR_RO(prelim_lmem_max_bw_Mbps);
> +
> void i915_setup_sysfs(struct drm_i915_private *dev_priv)
> {
> struct device *kdev = dev_priv->drm.primary->kdev;
> int ret;
>
> + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
> + ret = sysfs_create_file(&kdev->kobj, &dev_attr_prelim_lmem_max_bw_Mbps.attr);
> + if (ret)
> + drm_err(&dev_priv->drm, "Setting up sysfs to read max B/W failed\n");
> + }
> +
> if (HAS_L3_DPF(dev_priv)) {
> ret = device_create_bin_file(kdev, &dpf_attrs);
> if (ret)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
2022-11-15 8:08 [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs Himal Prasad Ghimiray
` (3 preceding siblings ...)
2022-11-16 9:39 ` [Intel-gfx] [PATCH 1/1] " Iddamsetty, Aravind
@ 2022-11-16 10:08 ` Gupta, Anshuman
2022-11-16 10:48 ` Ghimiray, Himal Prasad
4 siblings, 1 reply; 15+ messages in thread
From: Gupta, Anshuman @ 2022-11-16 10:08 UTC (permalink / raw)
To: Ghimiray, Himal Prasad, intel-gfx
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Himal Prasad Ghimiray
> Sent: Tuesday, November 15, 2022 1:39 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> bandwidth via sysfs.
>
> Export lmem maximum memory bandwidth to the userspace via sysfs.
>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 ++
> drivers/gpu/drm/i915/i915_sysfs.c | 27 +++++++++++++++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h index c4921c9a60770..3ba1efa995ca9
> 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -6603,6 +6603,8 @@
> #define POWER_SETUP_I1_WATTS REG_BIT(31)
> #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed
> point format */
> #define POWER_SETUP_I1_DATA_MASK
> REG_GENMASK(15, 0)
> +#define PCODE_MEMORY_CONFIG 0x70
Please re-arrange the macros in increasing order of pcode command.
> +#define
> MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv,
> pvc */
> /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ diff --git
> a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 595e8b5749907..0a6efc300998b 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -37,7 +37,10 @@
>
> #include "i915_drv.h"
> #include "i915_sysfs.h"
> +#include "i915_reg.h"
> #include "intel_pm.h"
> +#include "intel_pcode.h"
> +
>
> struct drm_i915_private *kdev_minor_to_i915(struct device *kdev) { @@ -
> 231,11 +234,35 @@ static void i915_setup_error_capture(struct device
> *kdev) {} static void i915_teardown_error_capture(struct device *kdev) {}
> #endif
>
> +static ssize_t
> +prelim_lmem_max_bw_Mbps_show(struct device *dev, struct
Please don't use mixed case here,
How about i915_lmem_max_bw_mbps_show ?
> +device_attribute *attr, char *buff) {
> + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> + u32 val;
> + int err;
> +
> + err = snb_pcode_read_p(&i915->uncore,
> PCODE_MEMORY_CONFIG,
> +
> MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> + 0x0, &val);
> + if (err)
> + return err;
> +
> + return sysfs_emit(buff, "%u\n", val);
> +}
> +
> +static DEVICE_ATTR_RO(prelim_lmem_max_bw_Mbps);
> +
> void i915_setup_sysfs(struct drm_i915_private *dev_priv) {
> struct device *kdev = dev_priv->drm.primary->kdev;
> int ret;
>
> + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
This seems to discrete agnostic.
How about HAS_LMEM ?
> + ret = sysfs_create_file(&kdev->kobj,
> &dev_attr_prelim_lmem_max_bw_Mbps.attr);
> + if (ret)
> + drm_err(&dev_priv->drm, "Setting up sysfs to read
> max B/W failed\n");
Why this sys fs is outside gt directory ?
Thanks,
Anshuman.
> + }
> +
> if (HAS_L3_DPF(dev_priv)) {
> ret = device_create_bin_file(kdev, &dpf_attrs);
> if (ret)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
2022-11-16 10:08 ` Gupta, Anshuman
@ 2022-11-16 10:48 ` Ghimiray, Himal Prasad
2022-11-21 6:49 ` Ghimiray, Himal Prasad
0 siblings, 1 reply; 15+ messages in thread
From: Ghimiray, Himal Prasad @ 2022-11-16 10:48 UTC (permalink / raw)
To: Gupta, Anshuman, intel-gfx
> -----Original Message-----
> From: Gupta, Anshuman <anshuman.gupta@intel.com>
> Sent: 16 November 2022 15:38
> To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Iddamsetty, Aravind <aravind.iddamsetty@intel.com>
> Subject: RE: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> bandwidth via sysfs.
>
>
>
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> > Himal Prasad Ghimiray
> > Sent: Tuesday, November 15, 2022 1:39 PM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> > bandwidth via sysfs.
> >
> > Export lmem maximum memory bandwidth to the userspace via sysfs.
> >
> > Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 2 ++
> > drivers/gpu/drm/i915/i915_sysfs.c | 27 +++++++++++++++++++++++++++
> > 2 files changed, 29 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > b/drivers/gpu/drm/i915/i915_reg.h index c4921c9a60770..3ba1efa995ca9
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -6603,6 +6603,8 @@
> > #define POWER_SETUP_I1_WATTS REG_BIT(31)
> > #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed
> > point format */
> > #define POWER_SETUP_I1_DATA_MASK
> > REG_GENMASK(15, 0)
> > +#define PCODE_MEMORY_CONFIG 0x70
> Please re-arrange the macros in increasing order of pcode command.
> > +#define
> > MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> > #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> > #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /*
> xehpsdv,
> > pvc */
> > /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ diff --
> git
> > a/drivers/gpu/drm/i915/i915_sysfs.c
> > b/drivers/gpu/drm/i915/i915_sysfs.c
> > index 595e8b5749907..0a6efc300998b 100644
> > --- a/drivers/gpu/drm/i915/i915_sysfs.c
> > +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> > @@ -37,7 +37,10 @@
> >
> > #include "i915_drv.h"
> > #include "i915_sysfs.h"
> > +#include "i915_reg.h"
> > #include "intel_pm.h"
> > +#include "intel_pcode.h"
> > +
> >
> > struct drm_i915_private *kdev_minor_to_i915(struct device *kdev) {
> > @@ -
> > 231,11 +234,35 @@ static void i915_setup_error_capture(struct device
> > *kdev) {} static void i915_teardown_error_capture(struct device
> > *kdev) {} #endif
> >
> > +static ssize_t
> > +prelim_lmem_max_bw_Mbps_show(struct device *dev, struct
> Please don't use mixed case here,
> How about i915_lmem_max_bw_mbps_show ?
[Ghimiray, Himal Prasad]
We need to differentiate between Mb (Mega bit) vs MB(MegaByte) ,Hence I used camelCase.
Using i915_lmem_max_bw_mbps_show will not give clarity whether the value is in Mb or MB.
BR
Himal Ghimiray
> > +device_attribute *attr, char *buff) {
> > + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> > + u32 val;
> > + int err;
> > +
> > + err = snb_pcode_read_p(&i915->uncore,
> > PCODE_MEMORY_CONFIG,
> > +
> > MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> > + 0x0, &val);
> > + if (err)
> > + return err;
> > +
> > + return sysfs_emit(buff, "%u\n", val); }
> > +
> > +static DEVICE_ATTR_RO(prelim_lmem_max_bw_Mbps);
> > +
> > void i915_setup_sysfs(struct drm_i915_private *dev_priv) {
> > struct device *kdev = dev_priv->drm.primary->kdev;
> > int ret;
> >
> > + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
> This seems to discrete agnostic.
> How about HAS_LMEM ?
> > + ret = sysfs_create_file(&kdev->kobj,
> > &dev_attr_prelim_lmem_max_bw_Mbps.attr);
>
> > + if (ret)
> > + drm_err(&dev_priv->drm, "Setting up sysfs to read
> > max B/W failed\n");
> Why this sys fs is outside gt directory ?
> Thanks,
> Anshuman.
> > + }
> > +
> > if (HAS_L3_DPF(dev_priv)) {
> > ret = device_create_bin_file(kdev, &dpf_attrs);
> > if (ret)
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs.
2022-11-16 10:48 ` Ghimiray, Himal Prasad
@ 2022-11-21 6:49 ` Ghimiray, Himal Prasad
0 siblings, 0 replies; 15+ messages in thread
From: Ghimiray, Himal Prasad @ 2022-11-21 6:49 UTC (permalink / raw)
To: Gupta, Anshuman, intel-gfx
> -----Original Message-----
> From: Ghimiray, Himal Prasad
> Sent: 16 November 2022 16:18
> To: Gupta, Anshuman <Anshuman.Gupta@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Iddamsetty, Aravind <Aravind.Iddamsetty@intel.com>
> Subject: RE: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> bandwidth via sysfs.
>
>
>
> > -----Original Message-----
> > From: Gupta, Anshuman <anshuman.gupta@intel.com>
> > Sent: 16 November 2022 15:38
> > To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Cc: Iddamsetty, Aravind <aravind.iddamsetty@intel.com>
> > Subject: RE: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> > bandwidth via sysfs.
> >
> >
> >
> > > -----Original Message-----
> > > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf
> > > Of Himal Prasad Ghimiray
> > > Sent: Tuesday, November 15, 2022 1:39 PM
> > > To: intel-gfx@lists.freedesktop.org
> > > Subject: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> > > bandwidth via sysfs.
> > >
> > > Export lmem maximum memory bandwidth to the userspace via sysfs.
> > >
> > > Signed-off-by: Himal Prasad Ghimiray
> > > <himal.prasad.ghimiray@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/i915_reg.h | 2 ++
> > > drivers/gpu/drm/i915/i915_sysfs.c | 27 +++++++++++++++++++++++++++
> > > 2 files changed, 29 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > > b/drivers/gpu/drm/i915/i915_reg.h index
> c4921c9a60770..3ba1efa995ca9
> > > 100644
> > > --- a/drivers/gpu/drm/i915/i915_reg.h
> > > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > > @@ -6603,6 +6603,8 @@
> > > #define POWER_SETUP_I1_WATTS REG_BIT(31)
> > > #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed
> > > point format */
> > > #define POWER_SETUP_I1_DATA_MASK
> > > REG_GENMASK(15, 0)
> > > +#define PCODE_MEMORY_CONFIG 0x70
> > Please re-arrange the macros in increasing order of pcode command.
> > > +#define
> > > MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> > > #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> > > #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /*
> > xehpsdv,
> > > pvc */
> > > /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ diff --
> > git
> > > a/drivers/gpu/drm/i915/i915_sysfs.c
> > > b/drivers/gpu/drm/i915/i915_sysfs.c
> > > index 595e8b5749907..0a6efc300998b 100644
> > > --- a/drivers/gpu/drm/i915/i915_sysfs.c
> > > +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> > > @@ -37,7 +37,10 @@
> > >
> > > #include "i915_drv.h"
> > > #include "i915_sysfs.h"
> > > +#include "i915_reg.h"
> > > #include "intel_pm.h"
> > > +#include "intel_pcode.h"
> > > +
> > >
> > > struct drm_i915_private *kdev_minor_to_i915(struct device *kdev) {
> > > @@ -
> > > 231,11 +234,35 @@ static void i915_setup_error_capture(struct device
> > > *kdev) {} static void i915_teardown_error_capture(struct device
> > > *kdev) {} #endif
> > >
> > > +static ssize_t
> > > +prelim_lmem_max_bw_Mbps_show(struct device *dev, struct
> > Please don't use mixed case here,
> > How about i915_lmem_max_bw_mbps_show ?
> [Ghimiray, Himal Prasad]
> We need to differentiate between Mb (Mega bit) vs MB(MegaByte) ,Hence I
> used camelCase.
> Using i915_lmem_max_bw_mbps_show will not give clarity whether the
> value is in Mb or MB.
>
> BR
> Himal Ghimiray
> > > +device_attribute *attr, char *buff) {
> > > + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> > > + u32 val;
> > > + int err;
> > > +
> > > + err = snb_pcode_read_p(&i915->uncore,
> > > PCODE_MEMORY_CONFIG,
> > > +
> > > MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> > > + 0x0, &val);
> > > + if (err)
> > > + return err;
> > > +
> > > + return sysfs_emit(buff, "%u\n", val); }
> > > +
> > > +static DEVICE_ATTR_RO(prelim_lmem_max_bw_Mbps);
> > > +
> > > void i915_setup_sysfs(struct drm_i915_private *dev_priv) {
> > > struct device *kdev = dev_priv->drm.primary->kdev;
> > > int ret;
> > >
> > > + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
> > This seems to discrete agnostic.
> > How about HAS_LMEM ?
[Ghimiray, Himal Prasad]
The changes are not applicable to all the discrete platforms. Example PVC.
> > > + ret = sysfs_create_file(&kdev->kobj,
> > > &dev_attr_prelim_lmem_max_bw_Mbps.attr);
> >
> > > + if (ret)
> > > + drm_err(&dev_priv->drm, "Setting up sysfs to read
> > > max B/W failed\n");
> > Why this sys fs is outside gt directory ?
> > Thanks,
> > Anshuman.
[Ghimiray, Himal Prasad]
Had put up the query in https://jira.devtools.intel.com/browse/VLK-39793 before implementation.
Query: sysfs entry should be associated with gt or the card ?
As per answer: Individual tiles can't currently have a different frequency so would be talking about card level entry for now, next to the other frequency items.
> > > + }
> > > +
> > > if (HAS_L3_DPF(dev_priv)) {
> > > ret = device_create_bin_file(kdev, &dpf_attrs);
> > > if (ret)
> > > --
> > > 2.25.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs
2022-11-23 5:59 ` Dixit, Ashutosh
@ 2022-11-23 6:01 ` Ghimiray, Himal Prasad
0 siblings, 0 replies; 15+ messages in thread
From: Ghimiray, Himal Prasad @ 2022-11-23 6:01 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
Thanks Ashutosh for the clarification.
BR
Himal Ghimiray
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: 23 November 2022 11:29
> To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> bandwidth via sysfs
>
> On Tue, 22 Nov 2022 21:10:01 -0800, Ghimiray, Himal Prasad wrote:
> >
> > > -----Original Message-----
> > > From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > > Sent: 21 November 2022 17:17
> > > To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>; intel-
> > > gfx@lists.freedesktop.org
> > > Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max
> > > memory bandwidth via sysfs
> > >
> > >
> > > On 21/11/2022 10:01, Himal Prasad Ghimiray wrote:
> > > > Export lmem maximum memory bandwidth to the userspace via sysfs
> > > >
> > > > (v2)
> > > > Add TODO comment to have client parts specific condition
> > > > (Anshuman) Remove prelim prefix from the sysfs node name (Aravind)
> > >
> > > Link to userspace consumer?
> > [Ghimiray, Himal Prasad]
> >
> > Does above comment means stating name of sysfs node in commit
> message ?
>
> No. It means that there has to be a "real" open source userspace program
> (like Mesa, Level-0/OneApi or another accepted program or UMD) which is
> actually reading the sysfs file exposed. Without such a consumer, the sysfs
> addition will not be accepted upstream.
>
> E.g. see cover letter here:
>
> https://patchwork.freedesktop.org/series/106460/
>
> "An approved Level-0/oneAPI UMD pull request which consumes the
> exposed defaults can be seen here:
> https://github.com/intel/compute-runtime/pull/552
> "
>
> Thanks.
> --
> Ashutosh
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs
2022-11-23 5:10 ` Ghimiray, Himal Prasad
@ 2022-11-23 5:59 ` Dixit, Ashutosh
2022-11-23 6:01 ` Ghimiray, Himal Prasad
0 siblings, 1 reply; 15+ messages in thread
From: Dixit, Ashutosh @ 2022-11-23 5:59 UTC (permalink / raw)
To: Ghimiray, Himal Prasad; +Cc: intel-gfx
On Tue, 22 Nov 2022 21:10:01 -0800, Ghimiray, Himal Prasad wrote:
>
> > -----Original Message-----
> > From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Sent: 21 November 2022 17:17
> > To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> > bandwidth via sysfs
> >
> >
> > On 21/11/2022 10:01, Himal Prasad Ghimiray wrote:
> > > Export lmem maximum memory bandwidth to the userspace via sysfs
> > >
> > > (v2)
> > > Add TODO comment to have client parts specific condition (Anshuman)
> > > Remove prelim prefix from the sysfs node name (Aravind)
> >
> > Link to userspace consumer?
> [Ghimiray, Himal Prasad]
>
> Does above comment means stating name of sysfs node in commit message ?
No. It means that there has to be a "real" open source userspace program
(like Mesa, Level-0/OneApi or another accepted program or UMD) which is
actually reading the sysfs file exposed. Without such a consumer, the sysfs
addition will not be accepted upstream.
E.g. see cover letter here:
https://patchwork.freedesktop.org/series/106460/
"An approved Level-0/oneAPI UMD pull request which consumes the exposed
defaults can be seen here:
https://github.com/intel/compute-runtime/pull/552
"
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs
2022-11-21 11:47 ` Tvrtko Ursulin
@ 2022-11-23 5:10 ` Ghimiray, Himal Prasad
2022-11-23 5:59 ` Dixit, Ashutosh
0 siblings, 1 reply; 15+ messages in thread
From: Ghimiray, Himal Prasad @ 2022-11-23 5:10 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: 21 November 2022 17:17
> To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> bandwidth via sysfs
>
>
> On 21/11/2022 10:01, Himal Prasad Ghimiray wrote:
> > Export lmem maximum memory bandwidth to the userspace via sysfs
> >
> > (v2)
> > Add TODO comment to have client parts specific condition (Anshuman)
> > Remove prelim prefix from the sysfs node name (Aravind)
>
> Link to userspace consumer?
[Ghimiray, Himal Prasad]
Does above comment means stating name of sysfs node in commit message ?
>
> > Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 2 ++
> > drivers/gpu/drm/i915/i915_sysfs.c | 28 ++++++++++++++++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > b/drivers/gpu/drm/i915/i915_reg.h index 8e1892d147741..1d59b84b86ad2
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -6606,6 +6606,8 @@
> > #define POWER_SETUP_I1_WATTS REG_BIT(31)
> > #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed
> point format */
> > #define POWER_SETUP_I1_DATA_MASK
> REG_GENMASK(15, 0)
> > +#define PCODE_MEMORY_CONFIG 0x70
> > +#define
> MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> > #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> > #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv,
> pvc */
> > /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ diff --git
> > a/drivers/gpu/drm/i915/i915_sysfs.c
> > b/drivers/gpu/drm/i915/i915_sysfs.c
> > index 595e8b5749907..69df2012bd10e 100644
> > --- a/drivers/gpu/drm/i915/i915_sysfs.c
> > +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> > @@ -37,7 +37,10 @@
> >
> > #include "i915_drv.h"
> > #include "i915_sysfs.h"
> > +#include "i915_reg.h"
> > #include "intel_pm.h"
> > +#include "intel_pcode.h"
> > +
>
> Please don't do whitespace changes if there isn't a good reason.
[Ghimiray, Himal Prasad]
Will address this.
>
> >
> > struct drm_i915_private *kdev_minor_to_i915(struct device *kdev)
> > {
> > @@ -231,11 +234,36 @@ static void i915_setup_error_capture(struct device
> *kdev) {}
> > static void i915_teardown_error_capture(struct device *kdev) {}
> > #endif
> >
> > +static ssize_t
> > +lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute
> > +*attr, char *buff) {
> > + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> > + u32 val;
> > + int err;
> > +
> > + err = snb_pcode_read_p(&i915->uncore, PCODE_MEMORY_CONFIG,
> > +
> MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> > + 0x0, &val);
> > + if (err)
> > + return err;
> > +
> > + return sysfs_emit(buff, "%u\n", val); }
> > +
> > +static DEVICE_ATTR_RO(lmem_max_bw_Mbps);
> > +
> > void i915_setup_sysfs(struct drm_i915_private *dev_priv)
> > {
> > struct device *kdev = dev_priv->drm.primary->kdev;
> > int ret;
> >
> > + /*TODO: Need to add client Parts condition check. */
>
> What does this mean? Are DG1 and DG2 not client parts?
>
[Ghimiray, Himal Prasad]
DG1 and Dg2 are client parts. Rather than adding individual platforms we need an identifier to
differentiate client parts from server part.
> > + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
> > + ret = sysfs_create_file(&kdev->kobj,
> &dev_attr_lmem_max_bw_Mbps.attr);
> > + if (ret)
> > + drm_err(&dev_priv->drm, "Setting up sysfs to read
> max B/W
> > +failed\n");
>
> I suggest at most drm_warn since error is ignored.
[Ghimiray, Himal Prasad]
Will address this.
>
> I also suggest expanding B/W to memory bandwidth. Maybe "Failed to create
> maximum memory bandwidth sysfs file"?
[Ghimiray, Himal Prasad]
Will address this. "Failed to create maximum memory bandwidth sysfs file" looks better.
>
> Regards,
>
> Tvrtko
>
> > + }
> > +
> > if (HAS_L3_DPF(dev_priv)) {
> > ret = device_create_bin_file(kdev, &dpf_attrs);
> > if (ret)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs
2022-11-21 11:29 ` Gupta, Anshuman
@ 2022-11-23 5:04 ` Ghimiray, Himal Prasad
0 siblings, 0 replies; 15+ messages in thread
From: Ghimiray, Himal Prasad @ 2022-11-23 5:04 UTC (permalink / raw)
To: Gupta, Anshuman, intel-gfx; +Cc: Auld, Matthew
> -----Original Message-----
> From: Gupta, Anshuman <anshuman.gupta@intel.com>
> Sent: 21 November 2022 16:59
> To: Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Auld, Matthew <matthew.auld@intel.com>
> Subject: RE: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> bandwidth via sysfs
>
>
>
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> > Himal Prasad Ghimiray
> > Sent: Monday, November 21, 2022 3:32 PM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> > bandwidth via sysfs
> >
> > Export lmem maximum memory bandwidth to the userspace via sysfs
> >
> > (v2)
> > Add TODO comment to have client parts specific condition (Anshuman)
> > Remove prelim prefix from the sysfs node name (Aravind)
> >
> > Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 2 ++
> > drivers/gpu/drm/i915/i915_sysfs.c | 28 ++++++++++++++++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > b/drivers/gpu/drm/i915/i915_reg.h index 8e1892d147741..1d59b84b86ad2
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -6606,6 +6606,8 @@
> > #define POWER_SETUP_I1_WATTS REG_BIT(31)
> > #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed
> > point format */
> > #define POWER_SETUP_I1_DATA_MASK
> > REG_GENMASK(15, 0)
> > +#define PCODE_MEMORY_CONFIG 0x70
> Please use DG1_ prefix as this mbox started from DG1 onwards.
[Ghimiray, Himal Prasad]
Will address this.
> And please try to follow the ascending order for commands attest for the new
> command we are adding.
[Ghimiray, Himal Prasad]
Ok.
> > +#define
> > MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> Here as well use DG1_ prefix.
[Ghimiray, Himal Prasad] OK.
> > #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> > #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv,
> > pvc */
> > /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ diff --git
> > a/drivers/gpu/drm/i915/i915_sysfs.c
> > b/drivers/gpu/drm/i915/i915_sysfs.c
> > index 595e8b5749907..69df2012bd10e 100644
> > --- a/drivers/gpu/drm/i915/i915_sysfs.c
> > +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> > @@ -37,7 +37,10 @@
> >
> > #include "i915_drv.h"
> > #include "i915_sysfs.h"
> > +#include "i915_reg.h"
> > #include "intel_pm.h"
> > +#include "intel_pcode.h"
> > +
> >
> > struct drm_i915_private *kdev_minor_to_i915(struct device *kdev) {
> > @@ -
> > 231,11 +234,36 @@ static void i915_setup_error_capture(struct device
> > *kdev) {} static void i915_teardown_error_capture(struct device
> > *kdev) {} #endif
> >
> > +static ssize_t
> > +lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute
> > +*attr, char *buff) {
> > + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> > + u32 val;
> > + int err;
> > +
> > + err = snb_pcode_read_p(&i915->uncore,
> > PCODE_MEMORY_CONFIG,
> > +
> > MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> > + 0x0, &val);
> > + if (err)
> > + return err;
> > +
> > + return sysfs_emit(buff, "%u\n", val); }
> > +
> > +static DEVICE_ATTR_RO(lmem_max_bw_Mbps);
> > +
> > void i915_setup_sysfs(struct drm_i915_private *dev_priv) {
> > struct device *kdev = dev_priv->drm.primary->kdev;
> > int ret;
> >
> > + /*TODO: Need to add client Parts condition check. */
> Nit use space after '/*'
[Ghimiray, Himal Prasad]
Will address this.
> /* TODO: Need to add client parts specific conditional check */ would be good.
> BR,
> Anshuman Gupta.
>
> > + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
> > + ret = sysfs_create_file(&kdev->kobj,
> > &dev_attr_lmem_max_bw_Mbps.attr);
> > + if (ret)
> > + drm_err(&dev_priv->drm, "Setting up sysfs to read
> > max B/W failed\n");
> > + }
> > +
> > if (HAS_L3_DPF(dev_priv)) {
> > ret = device_create_bin_file(kdev, &dpf_attrs);
> > if (ret)
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs
2022-11-21 10:01 Himal Prasad Ghimiray
2022-11-21 11:29 ` Gupta, Anshuman
@ 2022-11-21 11:47 ` Tvrtko Ursulin
2022-11-23 5:10 ` Ghimiray, Himal Prasad
1 sibling, 1 reply; 15+ messages in thread
From: Tvrtko Ursulin @ 2022-11-21 11:47 UTC (permalink / raw)
To: Himal Prasad Ghimiray, intel-gfx
On 21/11/2022 10:01, Himal Prasad Ghimiray wrote:
> Export lmem maximum memory bandwidth to the userspace via sysfs
>
> (v2)
> Add TODO comment to have client parts specific condition (Anshuman)
> Remove prelim prefix from the sysfs node name (Aravind)
Link to userspace consumer?
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 ++
> drivers/gpu/drm/i915/i915_sysfs.c | 28 ++++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 8e1892d147741..1d59b84b86ad2 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -6606,6 +6606,8 @@
> #define POWER_SETUP_I1_WATTS REG_BIT(31)
> #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed point format */
> #define POWER_SETUP_I1_DATA_MASK REG_GENMASK(15, 0)
> +#define PCODE_MEMORY_CONFIG 0x70
> +#define MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv, pvc */
> /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 595e8b5749907..69df2012bd10e 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -37,7 +37,10 @@
>
> #include "i915_drv.h"
> #include "i915_sysfs.h"
> +#include "i915_reg.h"
> #include "intel_pm.h"
> +#include "intel_pcode.h"
> +
Please don't do whitespace changes if there isn't a good reason.
>
> struct drm_i915_private *kdev_minor_to_i915(struct device *kdev)
> {
> @@ -231,11 +234,36 @@ static void i915_setup_error_capture(struct device *kdev) {}
> static void i915_teardown_error_capture(struct device *kdev) {}
> #endif
>
> +static ssize_t
> +lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute *attr, char *buff)
> +{
> + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> + u32 val;
> + int err;
> +
> + err = snb_pcode_read_p(&i915->uncore, PCODE_MEMORY_CONFIG,
> + MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> + 0x0, &val);
> + if (err)
> + return err;
> +
> + return sysfs_emit(buff, "%u\n", val);
> +}
> +
> +static DEVICE_ATTR_RO(lmem_max_bw_Mbps);
> +
> void i915_setup_sysfs(struct drm_i915_private *dev_priv)
> {
> struct device *kdev = dev_priv->drm.primary->kdev;
> int ret;
>
> + /*TODO: Need to add client Parts condition check. */
What does this mean? Are DG1 and DG2 not client parts?
> + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
> + ret = sysfs_create_file(&kdev->kobj, &dev_attr_lmem_max_bw_Mbps.attr);
> + if (ret)
> + drm_err(&dev_priv->drm, "Setting up sysfs to read max B/W failed\n");
I suggest at most drm_warn since error is ignored.
I also suggest expanding B/W to memory bandwidth. Maybe "Failed to
create maximum memory bandwidth sysfs file"?
Regards,
Tvrtko
> + }
> +
> if (HAS_L3_DPF(dev_priv)) {
> ret = device_create_bin_file(kdev, &dpf_attrs);
> if (ret)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs
2022-11-21 10:01 Himal Prasad Ghimiray
@ 2022-11-21 11:29 ` Gupta, Anshuman
2022-11-23 5:04 ` Ghimiray, Himal Prasad
2022-11-21 11:47 ` Tvrtko Ursulin
1 sibling, 1 reply; 15+ messages in thread
From: Gupta, Anshuman @ 2022-11-21 11:29 UTC (permalink / raw)
To: Ghimiray, Himal Prasad, intel-gfx; +Cc: Auld, Matthew
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Himal Prasad Ghimiray
> Sent: Monday, November 21, 2022 3:32 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory
> bandwidth via sysfs
>
> Export lmem maximum memory bandwidth to the userspace via sysfs
>
> (v2)
> Add TODO comment to have client parts specific condition (Anshuman)
> Remove prelim prefix from the sysfs node name (Aravind)
>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 ++
> drivers/gpu/drm/i915/i915_sysfs.c | 28 ++++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h index 8e1892d147741..1d59b84b86ad2
> 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -6606,6 +6606,8 @@
> #define POWER_SETUP_I1_WATTS REG_BIT(31)
> #define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed
> point format */
> #define POWER_SETUP_I1_DATA_MASK
> REG_GENMASK(15, 0)
> +#define PCODE_MEMORY_CONFIG 0x70
Please use DG1_ prefix as this mbox started from DG1 onwards.
And please try to follow the ascending order for commands attest for the new command we are adding.
> +#define
> MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
Here as well use DG1_ prefix.
> #define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
> #define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv,
> pvc */
> /* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ diff --git
> a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 595e8b5749907..69df2012bd10e 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -37,7 +37,10 @@
>
> #include "i915_drv.h"
> #include "i915_sysfs.h"
> +#include "i915_reg.h"
> #include "intel_pm.h"
> +#include "intel_pcode.h"
> +
>
> struct drm_i915_private *kdev_minor_to_i915(struct device *kdev) { @@ -
> 231,11 +234,36 @@ static void i915_setup_error_capture(struct device
> *kdev) {} static void i915_teardown_error_capture(struct device *kdev) {}
> #endif
>
> +static ssize_t
> +lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute
> +*attr, char *buff) {
> + struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
> + u32 val;
> + int err;
> +
> + err = snb_pcode_read_p(&i915->uncore,
> PCODE_MEMORY_CONFIG,
> +
> MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
> + 0x0, &val);
> + if (err)
> + return err;
> +
> + return sysfs_emit(buff, "%u\n", val);
> +}
> +
> +static DEVICE_ATTR_RO(lmem_max_bw_Mbps);
> +
> void i915_setup_sysfs(struct drm_i915_private *dev_priv) {
> struct device *kdev = dev_priv->drm.primary->kdev;
> int ret;
>
> + /*TODO: Need to add client Parts condition check. */
Nit use space after '/*'
/* TODO: Need to add client parts specific conditional check */ would be good.
BR,
Anshuman Gupta.
> + if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
> + ret = sysfs_create_file(&kdev->kobj,
> &dev_attr_lmem_max_bw_Mbps.attr);
> + if (ret)
> + drm_err(&dev_priv->drm, "Setting up sysfs to read
> max B/W failed\n");
> + }
> +
> if (HAS_L3_DPF(dev_priv)) {
> ret = device_create_bin_file(kdev, &dpf_attrs);
> if (ret)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs
@ 2022-11-21 10:01 Himal Prasad Ghimiray
2022-11-21 11:29 ` Gupta, Anshuman
2022-11-21 11:47 ` Tvrtko Ursulin
0 siblings, 2 replies; 15+ messages in thread
From: Himal Prasad Ghimiray @ 2022-11-21 10:01 UTC (permalink / raw)
To: intel-gfx
Export lmem maximum memory bandwidth to the userspace via sysfs
(v2)
Add TODO comment to have client parts specific condition (Anshuman)
Remove prelim prefix from the sysfs node name (Aravind)
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 2 ++
drivers/gpu/drm/i915/i915_sysfs.c | 28 ++++++++++++++++++++++++++++
2 files changed, 30 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8e1892d147741..1d59b84b86ad2 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -6606,6 +6606,8 @@
#define POWER_SETUP_I1_WATTS REG_BIT(31)
#define POWER_SETUP_I1_SHIFT 6 /* 10.6 fixed point format */
#define POWER_SETUP_I1_DATA_MASK REG_GENMASK(15, 0)
+#define PCODE_MEMORY_CONFIG 0x70
+#define MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
#define XEHP_PCODE_FREQUENCY_CONFIG 0x6e /* xehpsdv, pvc */
/* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */
diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
index 595e8b5749907..69df2012bd10e 100644
--- a/drivers/gpu/drm/i915/i915_sysfs.c
+++ b/drivers/gpu/drm/i915/i915_sysfs.c
@@ -37,7 +37,10 @@
#include "i915_drv.h"
#include "i915_sysfs.h"
+#include "i915_reg.h"
#include "intel_pm.h"
+#include "intel_pcode.h"
+
struct drm_i915_private *kdev_minor_to_i915(struct device *kdev)
{
@@ -231,11 +234,36 @@ static void i915_setup_error_capture(struct device *kdev) {}
static void i915_teardown_error_capture(struct device *kdev) {}
#endif
+static ssize_t
+lmem_max_bw_Mbps_show(struct device *dev, struct device_attribute *attr, char *buff)
+{
+ struct drm_i915_private *i915 = kdev_minor_to_i915(dev);
+ u32 val;
+ int err;
+
+ err = snb_pcode_read_p(&i915->uncore, PCODE_MEMORY_CONFIG,
+ MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH,
+ 0x0, &val);
+ if (err)
+ return err;
+
+ return sysfs_emit(buff, "%u\n", val);
+}
+
+static DEVICE_ATTR_RO(lmem_max_bw_Mbps);
+
void i915_setup_sysfs(struct drm_i915_private *dev_priv)
{
struct device *kdev = dev_priv->drm.primary->kdev;
int ret;
+ /*TODO: Need to add client Parts condition check. */
+ if (IS_DG1(dev_priv) || IS_DG2(dev_priv)) {
+ ret = sysfs_create_file(&kdev->kobj, &dev_attr_lmem_max_bw_Mbps.attr);
+ if (ret)
+ drm_err(&dev_priv->drm, "Setting up sysfs to read max B/W failed\n");
+ }
+
if (HAS_L3_DPF(dev_priv)) {
ret = device_create_bin_file(kdev, &dpf_attrs);
if (ret)
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-11-23 6:01 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-15 8:08 [Intel-gfx] [PATCH 1/1] drm/i915: Export LMEM max memory bandwidth via sysfs Himal Prasad Ghimiray
2022-11-15 14:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] " Patchwork
2022-11-15 15:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-15 19:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-16 9:39 ` [Intel-gfx] [PATCH 1/1] " Iddamsetty, Aravind
2022-11-16 10:08 ` Gupta, Anshuman
2022-11-16 10:48 ` Ghimiray, Himal Prasad
2022-11-21 6:49 ` Ghimiray, Himal Prasad
2022-11-21 10:01 Himal Prasad Ghimiray
2022-11-21 11:29 ` Gupta, Anshuman
2022-11-23 5:04 ` Ghimiray, Himal Prasad
2022-11-21 11:47 ` Tvrtko Ursulin
2022-11-23 5:10 ` Ghimiray, Himal Prasad
2022-11-23 5:59 ` Dixit, Ashutosh
2022-11-23 6:01 ` Ghimiray, Himal Prasad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).