From: "Robert Lowery" <rglowery@exemail.com.au>
To: Mike Isely <isely@isely.net>
Cc: Dave Airlied <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org,
Mike Isely at pobox <isely@pobox.com>
Subject: Re: [PATCH] drm/i915: Fix unset margins flag in drm_mode_parse_command_line_for_connector
Date: Thu, 5 May 2011 12:40:47 +1000 [thread overview]
Message-ID: <b24883264738b07b38c981875d260a43.squirrel@webmail.exetel.com.au> (raw)
In-Reply-To: <alpine.DEB.1.10.1105041714320.8641@cnc.isely.net>
>
> The drm function which parses a mode into a standard mode line is
> computing the "margins" flag but then failing to copy that parameter
> into the parsed structure output. This seems to leave the field in a
> random state, which unfortunately influences the results when the
> parsed results are then subsequently used to calculate a mode line.
> The fix here is obvious: ensure the the margins flag is properly
> initialized in the result structure at the end of the parse operation.
Is this to fix Bug 25430 - [GM965 KMS] TV margins ignored in xorg.conf
(https://bugs.freedesktop.org/show_bug.cgi?id=25430) or am I completely
off base here?
> Signed-off-by: Mike Isely <isely@pobox.com>
> ---
> drivers/gpu/drm/drm_modes.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 207b7eb..3697c56 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -1094,6 +1094,7 @@ done:
> mode->bpp_specified = true;
> mode->bpp = bpp;
> }
> + mode->margins = margins ? true : false;
> mode->rb = rb ? true : false;
> mode->cvt = cvt ? true : false;
> mode->interlace = interlace ? true : false;
> --
> 1.7.2.5
>
>
> --
>
> Mike Isely
> isely @ isely (dot) net
> PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
prev parent reply other threads:[~2011-05-05 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 6:43 [PATCH 1/2] drm: Export the command-line mode parser Chris Wilson
2011-04-17 6:43 ` [PATCH 2/2] drm/i915/lvds: Use i915.lvds_fixed_mode= as a last resort Chris Wilson
2011-04-18 16:46 ` Mike Isely
2011-04-18 17:46 ` Mike Isely
2011-04-20 19:48 ` Mike Isely
2011-04-20 19:56 ` Chris Wilson
2011-04-20 20:09 ` Mike Isely
2011-04-21 22:30 ` Mike Isely
2011-04-21 22:37 ` Chris Wilson
2011-04-21 22:46 ` Mike Isely
2011-05-04 22:14 ` Mike Isely
2011-05-04 22:18 ` [PATCH] drm/i915: Fix unset margins flag in drm_mode_parse_command_line_for_connector Mike Isely
2011-05-05 2:40 ` Robert Lowery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b24883264738b07b38c981875d260a43.squirrel@webmail.exetel.com.au \
--to=rglowery@exemail.com.au \
--cc=airlied@linux.ie \
--cc=intel-gfx@lists.freedesktop.org \
--cc=isely@isely.net \
--cc=isely@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).