intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH v2] drm/i915: Use pci_resource functions for BARs.
Date: Mon, 19 Nov 2012 21:27:13 +0000	[thread overview]
Message-ID: <b94cdc$7e1tdv@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1353356624-15873-1-git-send-email-ben@bwidawsk.net>

On Mon, 19 Nov 2012 12:23:44 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> This was leftover crap from kill-agp. The current code is theoretically
> broken for 64b bars. (I resist removing theoretically because I am too
> lazy to test).
> 
> We still need to ioremap things ourselves because we want to ioremap_wc
> the PTEs.
> 
> v2: Forgot to kill the tmp variable in v1
> 
> CC: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Nice.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-11-19 21:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 20:04 [PATCH] drm/i915: Use pci_resource functions for BARs Ben Widawsky
2012-11-19 20:23 ` [PATCH v2] " Ben Widawsky
2012-11-19 21:27   ` Chris Wilson [this message]
2012-11-21 14:58     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='b94cdc$7e1tdv@fmsmga001.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).