* [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines
@ 2020-06-04 10:21 Chris Wilson
2020-06-04 10:55 ` Matthew Auld
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Chris Wilson @ 2020-06-04 10:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld, Chris Wilson
Just to remove an obnoxious HAS_ENGINES(), and in the process make the
code agnostic to the available of any particular engine by making it
exercise any and all such engines declared on the system.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
.../i915/gem/selftests/i915_gem_client_blt.c | 3 -
.../i915/gem/selftests/i915_gem_object_blt.c | 55 ++++++++++++-------
.../gpu/drm/i915/gem/selftests/mock_context.c | 34 ++++++++++++
.../gpu/drm/i915/gem/selftests/mock_context.h | 4 ++
drivers/gpu/drm/i915/i915_drv.h | 5 ++
5 files changed, 77 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
index 8fe3ad2ee34e..299c29e9ad86 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
@@ -702,8 +702,5 @@ int i915_gem_client_blt_live_selftests(struct drm_i915_private *i915)
if (intel_gt_is_wedged(&i915->gt))
return 0;
- if (!HAS_ENGINE(i915, BCS0))
- return 0;
-
return i915_live_subtests(tests, i915);
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 31549ad83fa6..23b6e11bbc3e 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -193,7 +193,7 @@ static int perf_copy_blt(void *arg)
}
struct igt_thread_arg {
- struct drm_i915_private *i915;
+ struct intel_engine_cs *engine;
struct i915_gem_context *ctx;
struct file *file;
struct rnd_state prng;
@@ -203,7 +203,7 @@ struct igt_thread_arg {
static int igt_fill_blt_thread(void *arg)
{
struct igt_thread_arg *thread = arg;
- struct drm_i915_private *i915 = thread->i915;
+ struct intel_engine_cs *engine = thread->engine;
struct rnd_state *prng = &thread->prng;
struct drm_i915_gem_object *obj;
struct i915_gem_context *ctx;
@@ -215,7 +215,7 @@ static int igt_fill_blt_thread(void *arg)
ctx = thread->ctx;
if (!ctx) {
- ctx = live_context(i915, thread->file);
+ ctx = live_context_for_engine(engine, thread->file);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
@@ -223,7 +223,7 @@ static int igt_fill_blt_thread(void *arg)
ctx->sched.priority = I915_USER_PRIORITY(prio);
}
- ce = i915_gem_context_get_engine(ctx, BCS0);
+ ce = i915_gem_context_get_engine(ctx, 0);
GEM_BUG_ON(IS_ERR(ce));
/*
@@ -256,7 +256,7 @@ static int igt_fill_blt_thread(void *arg)
pr_debug("%s with phys_sz= %x, sz=%x, val=%x\n", __func__,
phys_sz, sz, val);
- obj = huge_gem_object(i915, phys_sz, sz);
+ obj = huge_gem_object(engine->i915, phys_sz, sz);
if (IS_ERR(obj)) {
err = PTR_ERR(obj);
goto err_flush;
@@ -321,7 +321,7 @@ static int igt_fill_blt_thread(void *arg)
static int igt_copy_blt_thread(void *arg)
{
struct igt_thread_arg *thread = arg;
- struct drm_i915_private *i915 = thread->i915;
+ struct intel_engine_cs *engine = thread->engine;
struct rnd_state *prng = &thread->prng;
struct drm_i915_gem_object *src, *dst;
struct i915_gem_context *ctx;
@@ -333,7 +333,7 @@ static int igt_copy_blt_thread(void *arg)
ctx = thread->ctx;
if (!ctx) {
- ctx = live_context(i915, thread->file);
+ ctx = live_context_for_engine(engine, thread->file);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
@@ -341,7 +341,7 @@ static int igt_copy_blt_thread(void *arg)
ctx->sched.priority = I915_USER_PRIORITY(prio);
}
- ce = i915_gem_context_get_engine(ctx, BCS0);
+ ce = i915_gem_context_get_engine(ctx, 0);
GEM_BUG_ON(IS_ERR(ce));
/*
@@ -374,7 +374,7 @@ static int igt_copy_blt_thread(void *arg)
pr_debug("%s with phys_sz= %x, sz=%x, val=%x\n", __func__,
phys_sz, sz, val);
- src = huge_gem_object(i915, phys_sz, sz);
+ src = huge_gem_object(engine->i915, phys_sz, sz);
if (IS_ERR(src)) {
err = PTR_ERR(src);
goto err_flush;
@@ -394,7 +394,7 @@ static int igt_copy_blt_thread(void *arg)
if (!(src->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ))
src->cache_dirty = true;
- dst = huge_gem_object(i915, phys_sz, sz);
+ dst = huge_gem_object(engine->i915, phys_sz, sz);
if (IS_ERR(dst)) {
err = PTR_ERR(dst);
goto err_put_src;
@@ -456,7 +456,7 @@ static int igt_copy_blt_thread(void *arg)
return err;
}
-static int igt_threaded_blt(struct drm_i915_private *i915,
+static int igt_threaded_blt(struct intel_engine_cs *engine,
int (*blt_fn)(void *arg),
unsigned int flags)
#define SINGLE_CTX BIT(0)
@@ -477,14 +477,14 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
if (!thread)
goto out_tsk;
- thread[0].file = mock_file(i915);
+ thread[0].file = mock_file(engine->i915);
if (IS_ERR(thread[0].file)) {
err = PTR_ERR(thread[0].file);
goto out_thread;
}
if (flags & SINGLE_CTX) {
- thread[0].ctx = live_context(i915, thread[0].file);
+ thread[0].ctx = live_context_for_engine(engine, thread[0].file);
if (IS_ERR(thread[0].ctx)) {
err = PTR_ERR(thread[0].ctx);
goto out_file;
@@ -492,7 +492,7 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
}
for (i = 0; i < n_cpus; ++i) {
- thread[i].i915 = i915;
+ thread[i].engine = engine;
thread[i].file = thread[0].file;
thread[i].ctx = thread[0].ctx;
thread[i].n_cpus = n_cpus;
@@ -532,24 +532,40 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
return err;
}
+static int test_copy_engines(struct drm_i915_private *i915,
+ int (*fn)(void *arg),
+ unsigned int flags)
+{
+ struct intel_engine_cs *engine;
+ int ret;
+
+ for_each_uabi_class_engine(engine, I915_ENGINE_CLASS_COPY, i915) {
+ ret = igt_threaded_blt(engine, fn, flags);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
static int igt_fill_blt(void *arg)
{
- return igt_threaded_blt(arg, igt_fill_blt_thread, 0);
+ return test_copy_engines(arg, igt_fill_blt_thread, 0);
}
static int igt_fill_blt_ctx0(void *arg)
{
- return igt_threaded_blt(arg, igt_fill_blt_thread, SINGLE_CTX);
+ return test_copy_engines(arg, igt_fill_blt_thread, SINGLE_CTX);
}
static int igt_copy_blt(void *arg)
{
- return igt_threaded_blt(arg, igt_copy_blt_thread, 0);
+ return test_copy_engines(arg, igt_copy_blt_thread, 0);
}
static int igt_copy_blt_ctx0(void *arg)
{
- return igt_threaded_blt(arg, igt_copy_blt_thread, SINGLE_CTX);
+ return test_copy_engines(arg, igt_copy_blt_thread, SINGLE_CTX);
}
int i915_gem_object_blt_live_selftests(struct drm_i915_private *i915)
@@ -564,9 +580,6 @@ int i915_gem_object_blt_live_selftests(struct drm_i915_private *i915)
if (intel_gt_is_wedged(&i915->gt))
return 0;
- if (!HAS_ENGINE(i915, BCS0))
- return 0;
-
return i915_live_subtests(tests, i915);
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index e7e3c620f542..987918ca35ef 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -99,6 +99,40 @@ live_context(struct drm_i915_private *i915, struct file *file)
return ERR_PTR(err);
}
+struct i915_gem_context *
+live_context_for_engine(struct intel_engine_cs *engine, struct file *file)
+{
+ struct i915_gem_engines *engines;
+ struct i915_gem_context *ctx;
+ struct intel_context *ce;
+
+ engines = alloc_engines(1);
+ if (!engines)
+ return ERR_PTR(-ENOMEM);
+
+ ctx = live_context(engine->i915, file);
+ if (IS_ERR(ctx))
+ return ctx;
+
+ ce = intel_context_create(engine);
+ if (IS_ERR(ce)) {
+ __free_engines(engines, 0);
+ return ERR_CAST(ce);
+ }
+
+ intel_context_set_gem(ce, ctx);
+ engines->engines[0] = ce;
+
+ mutex_lock(&ctx->engines_mutex);
+ i915_gem_context_set_user_engines(ctx);
+ engines = rcu_replace_pointer(ctx->engines, engines, 1);
+ mutex_unlock(&ctx->engines_mutex);
+
+ engines_idle_release(ctx, engines);
+
+ return ctx;
+}
+
struct i915_gem_context *
kernel_context(struct drm_i915_private *i915)
{
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.h b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
index fb83d2f09212..2a6121d33352 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.h
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
@@ -9,6 +9,7 @@
struct file;
struct drm_i915_private;
+struct intel_engine_cs;
void mock_init_contexts(struct drm_i915_private *i915);
@@ -21,6 +22,9 @@ void mock_context_close(struct i915_gem_context *ctx);
struct i915_gem_context *
live_context(struct drm_i915_private *i915, struct file *file);
+struct i915_gem_context *
+live_context_for_engine(struct intel_engine_cs *engine, struct file *file);
+
struct i915_gem_context *kernel_context(struct drm_i915_private *i915);
void kernel_context_close(struct i915_gem_context *ctx);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index e99255e17eb7..1e49abc5a342 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1264,6 +1264,11 @@ static inline struct drm_i915_private *pdev_to_i915(struct pci_dev *pdev)
(engine__); \
(engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
+#define for_each_uabi_class_engine(engine__, class__, i915__) \
+ for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
+ (engine__) && (engine__)->uabi_class == (class__); \
+ (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
+
#define I915_GTT_OFFSET_NONE ((u32)-1)
/*
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
@ 2020-06-04 10:55 ` Matthew Auld
2020-06-04 11:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Matthew Auld @ 2020-06-04 10:55 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 04/06/2020 11:21, Chris Wilson wrote:
> Just to remove an obnoxious HAS_ENGINES(), and in the process make the
> code agnostic to the available of any particular engine by making it
> exercise any and all such engines declared on the system.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise all copy engines with the blt routines
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
2020-06-04 10:55 ` Matthew Auld
@ 2020-06-04 11:08 ` Patchwork
2020-06-04 12:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-06-04 11:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Exercise all copy engines with the blt routines
URL : https://patchwork.freedesktop.org/series/77994/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dbd180308199 drm/i915/selftests: Exercise all copy engines with the blt routines
-:288: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#288: FILE: drivers/gpu/drm/i915/i915_drv.h:1267:
+#define for_each_uabi_class_engine(engine__, class__, i915__) \
+ for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
+ (engine__) && (engine__)->uabi_class == (class__); \
+ (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
-:288: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'class__' - possible side-effects?
#288: FILE: drivers/gpu/drm/i915/i915_drv.h:1267:
+#define for_each_uabi_class_engine(engine__, class__, i915__) \
+ for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
+ (engine__) && (engine__)->uabi_class == (class__); \
+ (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
total: 0 errors, 0 warnings, 2 checks, 240 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Exercise all copy engines with the blt routines
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
2020-06-04 10:55 ` Matthew Auld
2020-06-04 11:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-06-04 12:02 ` Patchwork
2020-06-04 12:36 ` [Intel-gfx] [PATCH] " Chris Wilson
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-06-04 12:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Exercise all copy engines with the blt routines
URL : https://patchwork.freedesktop.org/series/77994/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8581 -> Patchwork_17865
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17865 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17865, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17865:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@blt:
- fi-cml-u2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-cml-u2/igt@i915_selftest@live@blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-cml-u2/igt@i915_selftest@live@blt.html
- fi-whl-u: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-whl-u/igt@i915_selftest@live@blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-whl-u/igt@i915_selftest@live@blt.html
- fi-bxt-dsi: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-bxt-dsi/igt@i915_selftest@live@blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-bxt-dsi/igt@i915_selftest@live@blt.html
- fi-cfl-8700k: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-cfl-8700k/igt@i915_selftest@live@blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-cfl-8700k/igt@i915_selftest@live@blt.html
- fi-skl-6600u: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-skl-6600u/igt@i915_selftest@live@blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-skl-6600u/igt@i915_selftest@live@blt.html
- fi-cfl-8109u: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-cfl-8109u/igt@i915_selftest@live@blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-cfl-8109u/igt@i915_selftest@live@blt.html
- fi-icl-u2: [PASS][13] -> [INCOMPLETE][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-icl-u2/igt@i915_selftest@live@blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-icl-u2/igt@i915_selftest@live@blt.html
- fi-snb-2520m: [PASS][15] -> [INCOMPLETE][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-snb-2520m/igt@i915_selftest@live@blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-snb-2520m/igt@i915_selftest@live@blt.html
- fi-icl-y: [PASS][17] -> [INCOMPLETE][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-icl-y/igt@i915_selftest@live@blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-icl-y/igt@i915_selftest@live@blt.html
- fi-kbl-8809g: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-8809g/igt@i915_selftest@live@blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-8809g/igt@i915_selftest@live@blt.html
- fi-apl-guc: [PASS][21] -> [INCOMPLETE][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-apl-guc/igt@i915_selftest@live@blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-apl-guc/igt@i915_selftest@live@blt.html
- fi-kbl-r: [PASS][23] -> [INCOMPLETE][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-r/igt@i915_selftest@live@blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-r/igt@i915_selftest@live@blt.html
- fi-skl-guc: [PASS][25] -> [INCOMPLETE][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-skl-guc/igt@i915_selftest@live@blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-skl-guc/igt@i915_selftest@live@blt.html
- fi-bdw-5557u: [PASS][27] -> [INCOMPLETE][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-bdw-5557u/igt@i915_selftest@live@blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-bdw-5557u/igt@i915_selftest@live@blt.html
- fi-kbl-7500u: [PASS][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-7500u/igt@i915_selftest@live@blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-7500u/igt@i915_selftest@live@blt.html
- fi-kbl-x1275: [PASS][31] -> [INCOMPLETE][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-x1275/igt@i915_selftest@live@blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-x1275/igt@i915_selftest@live@blt.html
- fi-kbl-guc: [PASS][33] -> [INCOMPLETE][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-guc/igt@i915_selftest@live@blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-guc/igt@i915_selftest@live@blt.html
- fi-ivb-3770: [PASS][35] -> [INCOMPLETE][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-ivb-3770/igt@i915_selftest@live@blt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-ivb-3770/igt@i915_selftest@live@blt.html
- fi-skl-lmem: [PASS][37] -> [INCOMPLETE][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-skl-lmem/igt@i915_selftest@live@blt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-skl-lmem/igt@i915_selftest@live@blt.html
- fi-cml-s: [PASS][39] -> [INCOMPLETE][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-cml-s/igt@i915_selftest@live@blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-cml-s/igt@i915_selftest@live@blt.html
- fi-icl-guc: [PASS][41] -> [INCOMPLETE][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-icl-guc/igt@i915_selftest@live@blt.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-icl-guc/igt@i915_selftest@live@blt.html
- fi-kbl-soraka: [PASS][43] -> [INCOMPLETE][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-soraka/igt@i915_selftest@live@blt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-soraka/igt@i915_selftest@live@blt.html
- fi-cfl-guc: [PASS][45] -> [INCOMPLETE][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-cfl-guc/igt@i915_selftest@live@blt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-cfl-guc/igt@i915_selftest@live@blt.html
- fi-hsw-4770: [PASS][47] -> [INCOMPLETE][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-hsw-4770/igt@i915_selftest@live@blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-hsw-4770/igt@i915_selftest@live@blt.html
- fi-skl-6700k2: [PASS][49] -> [INCOMPLETE][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-skl-6700k2/igt@i915_selftest@live@blt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-skl-6700k2/igt@i915_selftest@live@blt.html
* igt@runner@aborted:
- fi-snb-2520m: NOTRUN -> [FAIL][51]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-snb-2520m/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][52]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-bdw-5557u/igt@runner@aborted.html
- fi-byt-n2820: NOTRUN -> [FAIL][53]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-byt-n2820/igt@runner@aborted.html
- fi-snb-2600: NOTRUN -> [FAIL][54]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-snb-2600/igt@runner@aborted.html
- fi-ivb-3770: NOTRUN -> [FAIL][55]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-ivb-3770/igt@runner@aborted.html
- fi-byt-j1900: NOTRUN -> [FAIL][56]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-byt-j1900/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@blt:
- {fi-ehl-1}: [PASS][57] -> [INCOMPLETE][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-ehl-1/igt@i915_selftest@live@blt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-ehl-1/igt@i915_selftest@live@blt.html
Known issues
------------
Here are the changes found in Patchwork_17865 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_render_linear_blits@basic:
- fi-tgl-y: [PASS][59] -> [DMESG-WARN][60] ([i915#402])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-tgl-y/igt@gem_render_linear_blits@basic.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-tgl-y/igt@gem_render_linear_blits@basic.html
* igt@i915_module_load@reload:
- fi-kbl-soraka: [PASS][61] -> [DMESG-WARN][62] ([i915#1982])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-soraka/igt@i915_module_load@reload.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-soraka/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [PASS][63] -> [DMESG-WARN][64] ([i915#1982])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@blt:
- fi-byt-j1900: [PASS][65] -> [INCOMPLETE][66] ([i915#45])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-byt-j1900/igt@i915_selftest@live@blt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-byt-j1900/igt@i915_selftest@live@blt.html
- fi-bsw-nick: [PASS][67] -> [INCOMPLETE][68] ([i915#392])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-bsw-nick/igt@i915_selftest@live@blt.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-bsw-nick/igt@i915_selftest@live@blt.html
- fi-bsw-kefka: [PASS][69] -> [INCOMPLETE][70] ([i915#392])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-bsw-kefka/igt@i915_selftest@live@blt.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-bsw-kefka/igt@i915_selftest@live@blt.html
- fi-tgl-y: [PASS][71] -> [INCOMPLETE][72] ([i915#750])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-tgl-y/igt@i915_selftest@live@blt.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-tgl-y/igt@i915_selftest@live@blt.html
- fi-snb-2600: [PASS][73] -> [INCOMPLETE][74] ([i915#82])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-snb-2600/igt@i915_selftest@live@blt.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-snb-2600/igt@i915_selftest@live@blt.html
- fi-glk-dsi: [PASS][75] -> [INCOMPLETE][76] ([i915#58] / [k.org#198133])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-glk-dsi/igt@i915_selftest@live@blt.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-glk-dsi/igt@i915_selftest@live@blt.html
- fi-byt-n2820: [PASS][77] -> [INCOMPLETE][78] ([i915#45])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-byt-n2820/igt@i915_selftest@live@blt.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-byt-n2820/igt@i915_selftest@live@blt.html
- fi-bsw-n3050: [PASS][79] -> [INCOMPLETE][80] ([i915#392])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-bsw-n3050/igt@i915_selftest@live@blt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-bsw-n3050/igt@i915_selftest@live@blt.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][81] -> [DMESG-WARN][82] ([i915#62] / [i915#92] / [i915#95])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-x1275/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-guc: [PASS][83] -> [DMESG-WARN][84] ([i915#1982])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-icl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-icl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [DMESG-WARN][85] ([i915#1982]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* {igt@kms_flip@basic-plain-flip@d-dsi1}:
- {fi-tgl-dsi}: [DMESG-WARN][87] ([i915#1982]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-tgl-dsi/igt@kms_flip@basic-plain-flip@d-dsi1.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-tgl-dsi/igt@kms_flip@basic-plain-flip@d-dsi1.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-tgl-y: [DMESG-WARN][89] ([i915#1982]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-x1275: [DMESG-WARN][91] ([i915#62] / [i915#92]) -> [DMESG-WARN][92] ([i915#62] / [i915#92] / [i915#95])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][93] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][94] ([i915#62] / [i915#92]) +6 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#392]: https://gitlab.freedesktop.org/drm/intel/issues/392
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#750]: https://gitlab.freedesktop.org/drm/intel/issues/750
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (50 -> 44)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8581 -> Patchwork_17865
CI-20190529: 20190529
CI_DRM_8581: a3ae560b4c2a6dfb0d550cc40471a7b0c7043500 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5694: a9b6c4c74bfddf7d3d2da3be08804fe315945cea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17865: dbd180308199326bb193a078f3e4a407c58fa046 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dbd180308199 drm/i915/selftests: Exercise all copy engines with the blt routines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17865/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
` (2 preceding siblings ...)
2020-06-04 12:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-06-04 12:36 ` Chris Wilson
2020-06-04 12:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise all copy engines with the blt routines (rev2) Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2020-06-04 12:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld, Chris Wilson
Just to remove an obnoxious HAS_ENGINES(), and in the process make the
code agnostic to the availabilty of any particular engine by making it
exercise any and all such engines declared on the system.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
---
.../i915/gem/selftests/i915_gem_client_blt.c | 3 -
.../i915/gem/selftests/i915_gem_object_blt.c | 55 ++++++++++++-------
.../gpu/drm/i915/gem/selftests/mock_context.c | 37 +++++++++++++
.../gpu/drm/i915/gem/selftests/mock_context.h | 4 ++
drivers/gpu/drm/i915/i915_drv.h | 5 ++
5 files changed, 80 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
index 8fe3ad2ee34e..299c29e9ad86 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
@@ -702,8 +702,5 @@ int i915_gem_client_blt_live_selftests(struct drm_i915_private *i915)
if (intel_gt_is_wedged(&i915->gt))
return 0;
- if (!HAS_ENGINE(i915, BCS0))
- return 0;
-
return i915_live_subtests(tests, i915);
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 31549ad83fa6..23b6e11bbc3e 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -193,7 +193,7 @@ static int perf_copy_blt(void *arg)
}
struct igt_thread_arg {
- struct drm_i915_private *i915;
+ struct intel_engine_cs *engine;
struct i915_gem_context *ctx;
struct file *file;
struct rnd_state prng;
@@ -203,7 +203,7 @@ struct igt_thread_arg {
static int igt_fill_blt_thread(void *arg)
{
struct igt_thread_arg *thread = arg;
- struct drm_i915_private *i915 = thread->i915;
+ struct intel_engine_cs *engine = thread->engine;
struct rnd_state *prng = &thread->prng;
struct drm_i915_gem_object *obj;
struct i915_gem_context *ctx;
@@ -215,7 +215,7 @@ static int igt_fill_blt_thread(void *arg)
ctx = thread->ctx;
if (!ctx) {
- ctx = live_context(i915, thread->file);
+ ctx = live_context_for_engine(engine, thread->file);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
@@ -223,7 +223,7 @@ static int igt_fill_blt_thread(void *arg)
ctx->sched.priority = I915_USER_PRIORITY(prio);
}
- ce = i915_gem_context_get_engine(ctx, BCS0);
+ ce = i915_gem_context_get_engine(ctx, 0);
GEM_BUG_ON(IS_ERR(ce));
/*
@@ -256,7 +256,7 @@ static int igt_fill_blt_thread(void *arg)
pr_debug("%s with phys_sz= %x, sz=%x, val=%x\n", __func__,
phys_sz, sz, val);
- obj = huge_gem_object(i915, phys_sz, sz);
+ obj = huge_gem_object(engine->i915, phys_sz, sz);
if (IS_ERR(obj)) {
err = PTR_ERR(obj);
goto err_flush;
@@ -321,7 +321,7 @@ static int igt_fill_blt_thread(void *arg)
static int igt_copy_blt_thread(void *arg)
{
struct igt_thread_arg *thread = arg;
- struct drm_i915_private *i915 = thread->i915;
+ struct intel_engine_cs *engine = thread->engine;
struct rnd_state *prng = &thread->prng;
struct drm_i915_gem_object *src, *dst;
struct i915_gem_context *ctx;
@@ -333,7 +333,7 @@ static int igt_copy_blt_thread(void *arg)
ctx = thread->ctx;
if (!ctx) {
- ctx = live_context(i915, thread->file);
+ ctx = live_context_for_engine(engine, thread->file);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
@@ -341,7 +341,7 @@ static int igt_copy_blt_thread(void *arg)
ctx->sched.priority = I915_USER_PRIORITY(prio);
}
- ce = i915_gem_context_get_engine(ctx, BCS0);
+ ce = i915_gem_context_get_engine(ctx, 0);
GEM_BUG_ON(IS_ERR(ce));
/*
@@ -374,7 +374,7 @@ static int igt_copy_blt_thread(void *arg)
pr_debug("%s with phys_sz= %x, sz=%x, val=%x\n", __func__,
phys_sz, sz, val);
- src = huge_gem_object(i915, phys_sz, sz);
+ src = huge_gem_object(engine->i915, phys_sz, sz);
if (IS_ERR(src)) {
err = PTR_ERR(src);
goto err_flush;
@@ -394,7 +394,7 @@ static int igt_copy_blt_thread(void *arg)
if (!(src->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ))
src->cache_dirty = true;
- dst = huge_gem_object(i915, phys_sz, sz);
+ dst = huge_gem_object(engine->i915, phys_sz, sz);
if (IS_ERR(dst)) {
err = PTR_ERR(dst);
goto err_put_src;
@@ -456,7 +456,7 @@ static int igt_copy_blt_thread(void *arg)
return err;
}
-static int igt_threaded_blt(struct drm_i915_private *i915,
+static int igt_threaded_blt(struct intel_engine_cs *engine,
int (*blt_fn)(void *arg),
unsigned int flags)
#define SINGLE_CTX BIT(0)
@@ -477,14 +477,14 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
if (!thread)
goto out_tsk;
- thread[0].file = mock_file(i915);
+ thread[0].file = mock_file(engine->i915);
if (IS_ERR(thread[0].file)) {
err = PTR_ERR(thread[0].file);
goto out_thread;
}
if (flags & SINGLE_CTX) {
- thread[0].ctx = live_context(i915, thread[0].file);
+ thread[0].ctx = live_context_for_engine(engine, thread[0].file);
if (IS_ERR(thread[0].ctx)) {
err = PTR_ERR(thread[0].ctx);
goto out_file;
@@ -492,7 +492,7 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
}
for (i = 0; i < n_cpus; ++i) {
- thread[i].i915 = i915;
+ thread[i].engine = engine;
thread[i].file = thread[0].file;
thread[i].ctx = thread[0].ctx;
thread[i].n_cpus = n_cpus;
@@ -532,24 +532,40 @@ static int igt_threaded_blt(struct drm_i915_private *i915,
return err;
}
+static int test_copy_engines(struct drm_i915_private *i915,
+ int (*fn)(void *arg),
+ unsigned int flags)
+{
+ struct intel_engine_cs *engine;
+ int ret;
+
+ for_each_uabi_class_engine(engine, I915_ENGINE_CLASS_COPY, i915) {
+ ret = igt_threaded_blt(engine, fn, flags);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
static int igt_fill_blt(void *arg)
{
- return igt_threaded_blt(arg, igt_fill_blt_thread, 0);
+ return test_copy_engines(arg, igt_fill_blt_thread, 0);
}
static int igt_fill_blt_ctx0(void *arg)
{
- return igt_threaded_blt(arg, igt_fill_blt_thread, SINGLE_CTX);
+ return test_copy_engines(arg, igt_fill_blt_thread, SINGLE_CTX);
}
static int igt_copy_blt(void *arg)
{
- return igt_threaded_blt(arg, igt_copy_blt_thread, 0);
+ return test_copy_engines(arg, igt_copy_blt_thread, 0);
}
static int igt_copy_blt_ctx0(void *arg)
{
- return igt_threaded_blt(arg, igt_copy_blt_thread, SINGLE_CTX);
+ return test_copy_engines(arg, igt_copy_blt_thread, SINGLE_CTX);
}
int i915_gem_object_blt_live_selftests(struct drm_i915_private *i915)
@@ -564,9 +580,6 @@ int i915_gem_object_blt_live_selftests(struct drm_i915_private *i915)
if (intel_gt_is_wedged(&i915->gt))
return 0;
- if (!HAS_ENGINE(i915, BCS0))
- return 0;
-
return i915_live_subtests(tests, i915);
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index e7e3c620f542..aa0d06cf1903 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -99,6 +99,43 @@ live_context(struct drm_i915_private *i915, struct file *file)
return ERR_PTR(err);
}
+struct i915_gem_context *
+live_context_for_engine(struct intel_engine_cs *engine, struct file *file)
+{
+ struct i915_gem_engines *engines;
+ struct i915_gem_context *ctx;
+ struct intel_context *ce;
+
+ engines = alloc_engines(1);
+ if (!engines)
+ return ERR_PTR(-ENOMEM);
+
+ ctx = live_context(engine->i915, file);
+ if (IS_ERR(ctx)) {
+ __free_engines(engines, 0);
+ return ctx;
+ }
+
+ ce = intel_context_create(engine);
+ if (IS_ERR(ce)) {
+ __free_engines(engines, 0);
+ return ERR_CAST(ce);
+ }
+
+ intel_context_set_gem(ce, ctx);
+ engines->engines[0] = ce;
+ engines->num_engines = 1;
+
+ mutex_lock(&ctx->engines_mutex);
+ i915_gem_context_set_user_engines(ctx);
+ engines = rcu_replace_pointer(ctx->engines, engines, 1);
+ mutex_unlock(&ctx->engines_mutex);
+
+ engines_idle_release(ctx, engines);
+
+ return ctx;
+}
+
struct i915_gem_context *
kernel_context(struct drm_i915_private *i915)
{
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.h b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
index fb83d2f09212..2a6121d33352 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.h
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
@@ -9,6 +9,7 @@
struct file;
struct drm_i915_private;
+struct intel_engine_cs;
void mock_init_contexts(struct drm_i915_private *i915);
@@ -21,6 +22,9 @@ void mock_context_close(struct i915_gem_context *ctx);
struct i915_gem_context *
live_context(struct drm_i915_private *i915, struct file *file);
+struct i915_gem_context *
+live_context_for_engine(struct intel_engine_cs *engine, struct file *file);
+
struct i915_gem_context *kernel_context(struct drm_i915_private *i915);
void kernel_context_close(struct i915_gem_context *ctx);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index e99255e17eb7..1e49abc5a342 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1264,6 +1264,11 @@ static inline struct drm_i915_private *pdev_to_i915(struct pci_dev *pdev)
(engine__); \
(engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
+#define for_each_uabi_class_engine(engine__, class__, i915__) \
+ for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
+ (engine__) && (engine__)->uabi_class == (class__); \
+ (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
+
#define I915_GTT_OFFSET_NONE ((u32)-1)
/*
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise all copy engines with the blt routines (rev2)
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
` (3 preceding siblings ...)
2020-06-04 12:36 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-06-04 12:54 ` Patchwork
2020-06-04 13:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-04 15:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-06-04 12:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Exercise all copy engines with the blt routines (rev2)
URL : https://patchwork.freedesktop.org/series/77994/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9edabff31b22 drm/i915/selftests: Exercise all copy engines with the blt routines
-:292: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#292: FILE: drivers/gpu/drm/i915/i915_drv.h:1267:
+#define for_each_uabi_class_engine(engine__, class__, i915__) \
+ for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
+ (engine__) && (engine__)->uabi_class == (class__); \
+ (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
-:292: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'class__' - possible side-effects?
#292: FILE: drivers/gpu/drm/i915/i915_drv.h:1267:
+#define for_each_uabi_class_engine(engine__, class__, i915__) \
+ for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
+ (engine__) && (engine__)->uabi_class == (class__); \
+ (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
total: 0 errors, 0 warnings, 2 checks, 243 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Exercise all copy engines with the blt routines (rev2)
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
` (4 preceding siblings ...)
2020-06-04 12:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise all copy engines with the blt routines (rev2) Patchwork
@ 2020-06-04 13:15 ` Patchwork
2020-06-04 15:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-06-04 13:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Exercise all copy engines with the blt routines (rev2)
URL : https://patchwork.freedesktop.org/series/77994/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8581 -> Patchwork_17868
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/index.html
Known issues
------------
Here are the changes found in Patchwork_17868 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][3] -> [DMESG-WARN][4] ([i915#62] / [i915#92] / [i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/fi-kbl-x1275/igt@kms_busy@basic@flip.html
#### Possible fixes ####
* {igt@kms_flip@basic-plain-flip@d-dsi1}:
- {fi-tgl-dsi}: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-tgl-dsi/igt@kms_flip@basic-plain-flip@d-dsi1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/fi-tgl-dsi/igt@kms_flip@basic-plain-flip@d-dsi1.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-tgl-y: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
#### Warnings ####
* igt@debugfs_test@read_all_entries:
- fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92]) -> [DMESG-WARN][10] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (50 -> 44)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8581 -> Patchwork_17868
CI-20190529: 20190529
CI_DRM_8581: a3ae560b4c2a6dfb0d550cc40471a7b0c7043500 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5694: a9b6c4c74bfddf7d3d2da3be08804fe315945cea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17868: 9edabff31b225d1b8b4860cf92c7f19a1645c079 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9edabff31b22 drm/i915/selftests: Exercise all copy engines with the blt routines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Exercise all copy engines with the blt routines (rev2)
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
` (5 preceding siblings ...)
2020-06-04 13:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-06-04 15:03 ` Patchwork
6 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-06-04 15:03 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Exercise all copy engines with the blt routines (rev2)
URL : https://patchwork.freedesktop.org/series/77994/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8581_full -> Patchwork_17868_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
New tests
---------
New tests have been introduced between CI_DRM_8581_full and Patchwork_17868_full:
### New IGT tests (11) ###
* igt@gem_ctx_engines@execute-allforone:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.04] s
* igt@gem_ctx_engines@execute-one:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.20, 4.60] s
* igt@gem_ctx_engines@execute-oneforall:
- Statuses : 7 pass(s)
- Exec time: [0.06, 1.19] s
* igt@gem_ctx_engines@idempotent:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_ctx_engines@independent:
- Statuses : 1 dmesg-warn(s) 5 pass(s) 1 skip(s)
- Exec time: [0.0, 0.32] s
* igt@gem_ctx_engines@invalid-engines:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_ctx_shared@create-shared-gtt:
- Statuses : 6 pass(s)
- Exec time: [2.15, 2.16] s
* igt@gem_ctx_shared@detached-shared-gtt:
- Statuses : 7 pass(s)
- Exec time: [2.15, 2.16] s
* igt@gem_ctx_shared@disjoint-timelines:
- Statuses : 2 dmesg-warn(s) 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.09] s
* igt@gem_ctx_shared@q-smoketest-all:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 32.47] s
* igt@gem_ctx_shared@single-timeline:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.03] s
Known issues
------------
Here are the changes found in Patchwork_17868_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [PASS][1] -> [DMESG-WARN][2] ([i915#402])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-tglb8/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-tglb7/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-iclb: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-iclb8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-iclb3/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-apl6/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-apl6/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
* igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl5/igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl9/igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge.html
* igt@kms_draw_crc@fill-fb:
- shard-snb: [PASS][9] -> [SKIP][10] ([fdo#109271]) +6 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-snb2/igt@kms_draw_crc@fill-fb.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-snb2/igt@kms_draw_crc@fill-fb.html
* igt@kms_flip_tiling@flip-yf-tiled:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108145])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl6/igt@kms_flip_tiling@flip-yf-tiled.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl4/igt@kms_flip_tiling@flip-yf-tiled.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#93] / [i915#95]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#49])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#95]) +12 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-iclb3/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][25] -> [FAIL][26] ([i915#31])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-apl6/igt@kms_setmode@basic.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-apl6/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][27] ([i915#118] / [i915#95]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-glk9/igt@gem_exec_whisper@basic-contexts-forked-all.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-glk8/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-kbl: [INCOMPLETE][29] ([i915#1318]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-kbl7/igt@gem_exec_whisper@basic-fds-forked-all.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-kbl1/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-skl: [DMESG-WARN][31] ([i915#1982]) -> [PASS][32] +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl6/igt@kms_big_fb@linear-32bpp-rotate-180.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl4/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-glk: [DMESG-FAIL][33] ([i915#118] / [i915#95]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-glk9/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-apl: [DMESG-WARN][35] ([i915#1982]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-apl8/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-apl4/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][37] ([i915#300]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
- shard-apl: [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* {igt@kms_flip@flip-vs-suspend@a-dp1}:
- shard-kbl: [DMESG-WARN][41] ([i915#180]) -> [PASS][42] +5 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-kbl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-kbl1/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-apl: [DMESG-WARN][43] ([i915#95]) -> [PASS][44] +15 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [INCOMPLETE][45] ([i915#69]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][47] ([fdo#108145] / [i915#265]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-iclb: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-iclb3/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-iclb5/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][51] ([i915#173]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-iclb1/igt@kms_psr@no_drrs.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-iclb6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-iclb6/igt@kms_psr@psr2_sprite_blt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][55] ([i915#31]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-kbl2/igt@kms_setmode@basic.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-kbl1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-wait-busy:
- shard-tglb: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-tglb8/igt@kms_vblank@pipe-c-wait-busy.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-tglb7/igt@kms_vblank@pipe-c-wait-busy.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: [FAIL][59] ([i915#49]) -> [DMESG-FAIL][60] ([i915#49] / [i915#95])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8581/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1318]: https://gitlab.freedesktop.org/drm/intel/issues/1318
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#1780]: https://gitlab.freedesktop.org/drm/intel/issues/1780
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8581 -> Patchwork_17868
CI-20190529: 20190529
CI_DRM_8581: a3ae560b4c2a6dfb0d550cc40471a7b0c7043500 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5694: a9b6c4c74bfddf7d3d2da3be08804fe315945cea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17868: 9edabff31b225d1b8b4860cf92c7f19a1645c079 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17868/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-06-04 15:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 10:21 [Intel-gfx] [PATCH] drm/i915/selftests: Exercise all copy engines with the blt routines Chris Wilson
2020-06-04 10:55 ` Matthew Auld
2020-06-04 11:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-06-04 12:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-06-04 12:36 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-06-04 12:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise all copy engines with the blt routines (rev2) Patchwork
2020-06-04 13:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-04 15:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).