From: "Souza, Jose" <jose.souza@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915: Move encoder variable to tighter scope
Date: Thu, 16 Jan 2020 00:20:41 +0000 [thread overview]
Message-ID: <d1106a4cd44129aff4c1f6c018c43fa3205cd697.camel@intel.com> (raw)
In-Reply-To: <20200115190813.17971-5-ville.syrjala@linux.intel.com>
On Wed, 2020-01-15 at 21:08 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Let's not pollute the function scope with variables when they're
> only needed inside some loops.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 97cf8457c956..76c17341df2b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -13070,7 +13070,6 @@ intel_modeset_pipe_config(struct
> intel_crtc_state *pipe_config)
> {
> struct drm_crtc *crtc = pipe_config->uapi.crtc;
> struct drm_atomic_state *state = pipe_config->uapi.state;
> - struct intel_encoder *encoder;
> struct drm_connector *connector;
> struct drm_connector_state *connector_state;
> int base_bpp, ret;
> @@ -13113,11 +13112,12 @@ intel_modeset_pipe_config(struct
> intel_crtc_state *pipe_config)
> &pipe_config->pipe_src_h);
>
> for_each_new_connector_in_state(state, connector,
> connector_state, i) {
> + struct intel_encoder *encoder =
> + to_intel_encoder(connector_state-
> >best_encoder);
> +
> if (connector_state->crtc != crtc)
> continue;
>
> - encoder = to_intel_encoder(connector_state-
> >best_encoder);
> -
> if (!check_single_encoder_cloning(state,
> to_intel_crtc(crtc), encoder)) {
> DRM_DEBUG_KMS("rejecting invalid cloning
> configuration\n");
> return -EINVAL;
> @@ -13167,6 +13167,9 @@ intel_modeset_pipe_config(struct
> intel_crtc_state *pipe_config)
> * a chance to reject the mode entirely.
> */
> for_each_new_connector_in_state(state, connector,
> connector_state, i) {
> + struct intel_encoder *encoder =
> + to_intel_encoder(connector_state-
> >best_encoder);
> +
> if (connector_state->crtc != crtc)
> continue;
>
> @@ -13178,7 +13181,6 @@ intel_modeset_pipe_config(struct
> intel_crtc_state *pipe_config)
> return ret;
> }
>
> - encoder = to_intel_encoder(connector_state-
> >best_encoder);
> ret = encoder->compute_config(encoder, pipe_config,
> connector_state);
> if (ret < 0) {
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-16 0:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 19:08 [Intel-gfx] [PATCH 1/5] drm/i915: Fix post-fastset modeset check for port sync Ville Syrjala
2020-01-15 19:08 ` [Intel-gfx] [PATCH 2/5] drm/i915: Clear most of crtc state when disabling the crtc Ville Syrjala
2020-01-16 0:14 ` Souza, Jose
2020-01-15 19:08 ` [Intel-gfx] [PATCH 3/5] drm/i915: Prefer to use the pipe to index the ddb entries Ville Syrjala
2020-01-16 0:19 ` Souza, Jose
2020-01-15 19:08 ` [Intel-gfx] [PATCH 4/5] drm/i915: Use PIPE_CONF_CHECK_X() for sync_mode_slaves_mask Ville Syrjala
2020-01-16 0:19 ` Souza, Jose
2020-01-16 0:37 ` Manasi Navare
2020-01-15 19:08 ` [Intel-gfx] [PATCH 5/5] drm/i915: Move encoder variable to tighter scope Ville Syrjala
2020-01-16 0:20 ` Souza, Jose [this message]
2020-01-15 19:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Fix post-fastset modeset check for port sync Patchwork
2020-01-15 19:48 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-16 0:05 ` [Intel-gfx] [PATCH 1/5] " Souza, Jose
2020-01-16 10:56 ` Ville Syrjälä
2020-01-16 18:15 ` Souza, Jose
2020-01-18 8:05 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1106a4cd44129aff4c1f6c018c43fa3205cd697.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).