* [Intel-gfx] [PATCH] drm/i915/gt: Add arbitration check before semaphore wait
@ 2021-01-17 11:04 Chris Wilson
2021-01-17 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-17 11:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
Similar to commit 49b20dbf7497 ("drm/i915/gt: Perform an arbitration
check before busywaiting"), also add a check prior to the busywait
on gen8+, as we have now seen (because we added a selftest to add fault
injection into the engine resets) the same engine reset failure leading
to an indefinite wait on the ring-stop semaphore. So not a Tigerlake
specific bug after all, though it still seems odd behaviour for the
busywait as we do get the arbitration point elsewhere on a miss.
Testcase: igt_reset_fail_engine
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
index 5b932d2dbfd3..07ba524da90b 100644
--- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
@@ -488,6 +488,7 @@ static u32 *gen8_emit_wa_tail(struct i915_request *rq, u32 *cs)
static u32 *emit_preempt_busywait(struct i915_request *rq, u32 *cs)
{
+ *cs++ = MI_ARB_CHECK; /* trigger IDLE->ACTIVE first */
*cs++ = MI_SEMAPHORE_WAIT |
MI_SEMAPHORE_GLOBAL_GTT |
MI_SEMAPHORE_POLL |
@@ -495,6 +496,7 @@ static u32 *emit_preempt_busywait(struct i915_request *rq, u32 *cs)
*cs++ = 0;
*cs++ = preempt_address(rq->engine);
*cs++ = 0;
+ *cs++ = MI_NOOP;
return cs;
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Add arbitration check before semaphore wait
2021-01-17 11:04 [Intel-gfx] [PATCH] drm/i915/gt: Add arbitration check before semaphore wait Chris Wilson
@ 2021-01-17 11:45 ` Patchwork
2021-01-17 15:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-18 12:25 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-17 11:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2731 bytes --]
== Series Details ==
Series: drm/i915/gt: Add arbitration check before semaphore wait
URL : https://patchwork.freedesktop.org/series/85964/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9628 -> Patchwork_19383
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/index.html
Known issues
------------
Here are the changes found in Patchwork_19383 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-snb-2600: [PASS][1] -> [DMESG-WARN][2] ([i915#2772])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
* igt@runner@aborted:
- fi-snb-2600: NOTRUN -> [FAIL][5] ([i915#698])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/fi-snb-2600/igt@runner@aborted.html
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [DMESG-WARN][6] ([i915#402]) -> [PASS][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[i915#2772]: https://gitlab.freedesktop.org/drm/intel/issues/2772
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#698]: https://gitlab.freedesktop.org/drm/intel/issues/698
Participating hosts (41 -> 37)
------------------------------
Missing (4): fi-cml-u2 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9628 -> Patchwork_19383
CI-20190529: 20190529
CI_DRM_9628: 91c011a990e7f7176fa4619a4cd01653674a57f4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5959: c5cf0734c4f6c1fa17a6a15b5aa721c3a0b8c494 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19383: a057606a4fde15cbfdf30573db4ca312d22d6658 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a057606a4fde drm/i915/gt: Add arbitration check before semaphore wait
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/index.html
[-- Attachment #1.2: Type: text/html, Size: 3484 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Add arbitration check before semaphore wait
2021-01-17 11:04 [Intel-gfx] [PATCH] drm/i915/gt: Add arbitration check before semaphore wait Chris Wilson
2021-01-17 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-01-17 15:33 ` Patchwork
2021-01-18 12:25 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-17 15:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 22693 bytes --]
== Series Details ==
Series: drm/i915/gt: Add arbitration check before semaphore wait
URL : https://patchwork.freedesktop.org/series/85964/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9628_full -> Patchwork_19383_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_19383_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19383_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19383_full:
### IGT changes ###
#### Warnings ####
* igt@gem_exec_reloc@basic-many-active@vcs1:
- shard-iclb: [FAIL][1] ([i915#2389]) -> [FAIL][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-iclb1/igt@gem_exec_reloc@basic-many-active@vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-iclb2/igt@gem_exec_reloc@basic-many-active@vcs1.html
Known issues
------------
Here are the changes found in Patchwork_19383_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@deep@rcs0:
- shard-glk: [PASS][3] -> [SKIP][4] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk6/igt@gem_exec_schedule@deep@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk6/igt@gem_exec_schedule@deep@rcs0.html
- shard-skl: [PASS][5] -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl1/igt@gem_exec_schedule@deep@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl6/igt@gem_exec_schedule@deep@rcs0.html
- shard-kbl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-kbl2/igt@gem_exec_schedule@deep@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-kbl1/igt@gem_exec_schedule@deep@rcs0.html
- shard-apl: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-apl2/igt@gem_exec_schedule@deep@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-apl6/igt@gem_exec_schedule@deep@rcs0.html
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk4/igt@gem_exec_whisper@basic-queues-forked.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][13] -> [SKIP][14] ([i915#2190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-tglb2/igt@gem_huc_copy@huc-copy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [INCOMPLETE][15] ([i915#2502] / [i915#2667])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl9/igt@gem_userptr_blits@vma-merge.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][16] ([i915#454])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl7/igt@i915_pm_dc@dc6-psr.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [PASS][17] -> [DMESG-FAIL][18] ([i915#118] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk5/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl5/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl7/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen:
- shard-skl: [PASS][22] -> [FAIL][23] ([i915#54]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-128x128-sliding:
- shard-skl: NOTRUN -> [FAIL][24] ([i915#54])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-128x128-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: NOTRUN -> [INCOMPLETE][25] ([i915#146] / [i915#300])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-glk: [PASS][26] -> [FAIL][27] ([i915#2346])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [PASS][28] -> [FAIL][29] ([i915#2346])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-skl: NOTRUN -> [FAIL][30] ([i915#2346])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#533])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl3/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271]) +62 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl3/igt@kms_flip@2x-flip-vs-panning-vs-hang.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#79]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#2122]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-skl: NOTRUN -> [FAIL][39] ([i915#2628])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl9/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#2642])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl1/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_flip_tiling@flip-x-tiled:
- shard-snb: NOTRUN -> [SKIP][41] ([fdo#109271])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-snb6/igt@kms_flip_tiling@flip-x-tiled.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [PASS][42] -> [INCOMPLETE][43] ([i915#198]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [PASS][44] -> [DMESG-WARN][45] ([i915#180])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][46] ([fdo#108145] / [i915#265]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109441]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_psr@sprite_blt:
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271]) +5 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk1/igt@kms_psr@sprite_blt.html
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- shard-snb: [PASS][50] -> [SKIP][51] ([fdo#109271]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-snb5/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-snb6/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
* igt@sysfs_heartbeat_interval@mixed@bcs0:
- shard-skl: NOTRUN -> [FAIL][52] ([i915#1731])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl1/igt@sysfs_heartbeat_interval@mixed@bcs0.html
#### Possible fixes ####
* {igt@gem_exec_fair@basic-deadline}:
- shard-glk: [FAIL][53] ([i915#2846]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk2/igt@gem_exec_fair@basic-deadline.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk1/igt@gem_exec_fair@basic-deadline.html
* {igt@gem_exec_fair@basic-none@vcs0}:
- shard-apl: [FAIL][55] ([i915#2842]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-apl4/igt@gem_exec_fair@basic-none@vcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-apl1/igt@gem_exec_fair@basic-none@vcs0.html
* {igt@gem_exec_fair@basic-pace@vecs0}:
- shard-kbl: [SKIP][57] ([fdo#109271]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html
- shard-tglb: [FAIL][59] ([i915#2842]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-tglb8/igt@gem_exec_fair@basic-pace@vecs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-tglb1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][61] ([i915#118] / [i915#95]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk9/igt@gem_exec_whisper@basic-contexts-forked-all.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk8/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][63] ([i915#1436] / [i915#716]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk2/igt@gen9_exec_parse@allowed-all.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk1/igt@gen9_exec_parse@allowed-all.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][65] ([i915#1436] / [i915#1982] / [i915#716]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl7/igt@gen9_exec_parse@allowed-single.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl9/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
- shard-skl: [FAIL][67] ([i915#54]) -> [PASS][68] +8 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
* igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge:
- shard-skl: [DMESG-WARN][69] ([i915#1982]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl3/igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl4/igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][71] ([i915#2346]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [FAIL][73] ([i915#2598]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-tglb3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][75] ([i915#2122]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][77] ([i915#1188]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][79] ([fdo#108145] / [i915#265]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][81] ([fdo#109441]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][83] ([i915#1542]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-glk4/igt@perf@polling-parameterized.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-glk9/igt@perf@polling-parameterized.html
* igt@sysfs_timeslice_duration@timeout@bcs0:
- shard-skl: [FAIL][85] -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl10/igt@sysfs_timeslice_duration@timeout@bcs0.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl5/igt@sysfs_timeslice_duration@timeout@bcs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][87] ([i915#2684]) -> [WARN][88] ([i915#1804] / [i915#2684])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][89] ([i915#2681] / [i915#2684]) -> [WARN][90] ([i915#2684])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][91], [FAIL][92]) ([i915#1814] / [i915#2295]) -> ([FAIL][93], [FAIL][94], [FAIL][95]) ([i915#1814] / [i915#2295] / [i915#2505])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-kbl2/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-kbl7/igt@runner@aborted.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-kbl6/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-kbl4/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-kbl3/igt@runner@aborted.html
- shard-skl: [FAIL][96] ([i915#1436] / [i915#2295]) -> [FAIL][97] ([i915#2295])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9628/shard-skl7/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/shard-skl9/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#2628]: https://gitlab.freedesktop.org/drm/intel/issues/2628
[i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9628 -> Patchwork_19383
CI-20190529: 20190529
CI_DRM_9628: 91c011a990e7f7176fa4619a4cd01653674a57f4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5959: c5cf0734c4f6c1fa17a6a15b5aa721c3a0b8c494 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19383: a057606a4fde15cbfdf30573db4ca312d22d6658 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19383/index.html
[-- Attachment #1.2: Type: text/html, Size: 26914 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Add arbitration check before semaphore wait
2021-01-17 11:04 [Intel-gfx] [PATCH] drm/i915/gt: Add arbitration check before semaphore wait Chris Wilson
2021-01-17 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-17 15:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-01-18 12:25 ` Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2021-01-18 12:25 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 17/01/2021 11:04, Chris Wilson wrote:
> Similar to commit 49b20dbf7497 ("drm/i915/gt: Perform an arbitration
> check before busywaiting"), also add a check prior to the busywait
> on gen8+, as we have now seen (because we added a selftest to add fault
> injection into the engine resets) the same engine reset failure leading
> to an indefinite wait on the ring-stop semaphore. So not a Tigerlake
> specific bug after all, though it still seems odd behaviour for the
> busywait as we do get the arbitration point elsewhere on a miss.
>
> Testcase: igt_reset_fail_engine
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
> index 5b932d2dbfd3..07ba524da90b 100644
> --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
> @@ -488,6 +488,7 @@ static u32 *gen8_emit_wa_tail(struct i915_request *rq, u32 *cs)
>
> static u32 *emit_preempt_busywait(struct i915_request *rq, u32 *cs)
> {
> + *cs++ = MI_ARB_CHECK; /* trigger IDLE->ACTIVE first */
> *cs++ = MI_SEMAPHORE_WAIT |
> MI_SEMAPHORE_GLOBAL_GTT |
> MI_SEMAPHORE_POLL |
> @@ -495,6 +496,7 @@ static u32 *emit_preempt_busywait(struct i915_request *rq, u32 *cs)
> *cs++ = 0;
> *cs++ = preempt_address(rq->engine);
> *cs++ = 0;
> + *cs++ = MI_NOOP;
>
> return cs;
> }
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-18 12:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17 11:04 [Intel-gfx] [PATCH] drm/i915/gt: Add arbitration check before semaphore wait Chris Wilson
2021-01-17 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-17 15:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-18 12:25 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).