* [Intel-wired-lan] [tnguy-net-queue:dev-queue 2/17] drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err'
@ 2022-12-29 8:58 Dan Carpenter
2022-12-29 22:27 ` Tony Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-12-29 8:58 UTC (permalink / raw)
To: oe-kbuild, Paul M Stillwell Jr
Cc: Tony Nguyen, Intel Wired LAN, oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
head: c342bc11f5a438cf39e2280bafda39ec2c6953f1
commit: e51d0e34580892d22107a85390d1752fa7a7d56a [2/17] ice: move devlink port creation/deletion
config: powerpc-randconfig-m031-20221226
compiler: powerpc-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err'
vim +/err +4921 drivers/net/ethernet/intel/ice/ice_main.c
df006dd4b1dca8 Dave Ertman 2020-11-20 4908 if (ice_init_lag(pf))
df006dd4b1dca8 Dave Ertman 2020-11-20 4909 dev_warn(dev, "Failed to init link aggregation support\n");
df006dd4b1dca8 Dave Ertman 2020-11-20 4910
e18ff118181bca Paul Greenwalt 2019-10-09 4911 /* print PCI link speed and width */
e18ff118181bca Paul Greenwalt 2019-10-09 4912 pcie_print_link_status(pf->pdev);
e18ff118181bca Paul Greenwalt 2019-10-09 4913
de75135b5c04c9 Anirudh Venkataramanan 2020-05-07 4914 probe_done:
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4915 err = ice_devlink_create_pf_port(pf);
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4916 if (err)
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4917 goto err_create_pf_port;
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4918
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4919 vsi = ice_get_main_vsi(pf);
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4920 if (!vsi || !vsi->netdev)
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 @4921 goto err_netdev_reg;
This seems like an error path so "err = -EINVAL;"
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4922
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4923 SET_NETDEV_DEVLINK_PORT(vsi->netdev, &pf->devlink_port);
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4924
1e23f076b25424 Anirudh Venkataramanan 2021-03-02 4925 err = ice_register_netdev(pf);
1e23f076b25424 Anirudh Venkataramanan 2021-03-02 4926 if (err)
1e23f076b25424 Anirudh Venkataramanan 2021-03-02 4927 goto err_netdev_reg;
1e23f076b25424 Anirudh Venkataramanan 2021-03-02 4928
e523af4ee56090 Shiraz Saleem 2021-10-18 4929 err = ice_devlink_register_params(pf);
e523af4ee56090 Shiraz Saleem 2021-10-18 4930 if (err)
e523af4ee56090 Shiraz Saleem 2021-10-18 4931 goto err_netdev_reg;
e523af4ee56090 Shiraz Saleem 2021-10-18 4932
de75135b5c04c9 Anirudh Venkataramanan 2020-05-07 4933 /* ready to go, so clear down state bit */
7e408e07b42dce Anirudh Venkataramanan 2021-03-02 4934 clear_bit(ICE_DOWN, pf->state);
88f62aea1cff0c Dave Ertman 2022-02-11 4935 if (ice_is_rdma_ena(pf)) {
d25a0fc41c1f92 Dave Ertman 2021-05-20 4936 pf->aux_idx = ida_alloc(&ice_aux_ida, GFP_KERNEL);
d25a0fc41c1f92 Dave Ertman 2021-05-20 4937 if (pf->aux_idx < 0) {
d25a0fc41c1f92 Dave Ertman 2021-05-20 4938 dev_err(dev, "Failed to allocate device ID for AUX driver\n");
d25a0fc41c1f92 Dave Ertman 2021-05-20 4939 err = -ENOMEM;
e523af4ee56090 Shiraz Saleem 2021-10-18 4940 goto err_devlink_reg_param;
d25a0fc41c1f92 Dave Ertman 2021-05-20 4941 }
d25a0fc41c1f92 Dave Ertman 2021-05-20 4942
d25a0fc41c1f92 Dave Ertman 2021-05-20 4943 err = ice_init_rdma(pf);
d25a0fc41c1f92 Dave Ertman 2021-05-20 4944 if (err) {
d25a0fc41c1f92 Dave Ertman 2021-05-20 4945 dev_err(dev, "Failed to initialize RDMA: %d\n", err);
d25a0fc41c1f92 Dave Ertman 2021-05-20 4946 err = -EIO;
d25a0fc41c1f92 Dave Ertman 2021-05-20 4947 goto err_init_aux_unroll;
d25a0fc41c1f92 Dave Ertman 2021-05-20 4948 }
d25a0fc41c1f92 Dave Ertman 2021-05-20 4949 } else {
d25a0fc41c1f92 Dave Ertman 2021-05-20 4950 dev_warn(dev, "RDMA is not supported on this device\n");
d25a0fc41c1f92 Dave Ertman 2021-05-20 4951 }
d25a0fc41c1f92 Dave Ertman 2021-05-20 4952
838cefd5e52c4a Leon Romanovsky 2021-09-25 4953 ice_devlink_register(pf);
837f08fdecbe4b Anirudh Venkataramanan 2018-03-20 4954 return 0;
f31e4b6fe227df Anirudh Venkataramanan 2018-03-20 4955
d25a0fc41c1f92 Dave Ertman 2021-05-20 4956 err_init_aux_unroll:
d25a0fc41c1f92 Dave Ertman 2021-05-20 4957 pf->adev = NULL;
d25a0fc41c1f92 Dave Ertman 2021-05-20 4958 ida_free(&ice_aux_ida, pf->aux_idx);
e523af4ee56090 Shiraz Saleem 2021-10-18 4959 err_devlink_reg_param:
e523af4ee56090 Shiraz Saleem 2021-10-18 4960 ice_devlink_unregister_params(pf);
1e23f076b25424 Anirudh Venkataramanan 2021-03-02 4961 err_netdev_reg:
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4962 ice_devlink_destroy_pf_port(pf);
e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4963 err_create_pf_port:
78116e979ddc49 Marcin Szycik 2020-07-13 4964 err_send_version_unroll:
78116e979ddc49 Marcin Szycik 2020-07-13 4965 ice_vsi_release_all(pf);
3a858ba392c3b1 Anirudh Venkataramanan 2018-03-20 4966 err_alloc_sw_unroll:
7e408e07b42dce Anirudh Venkataramanan 2021-03-02 4967 set_bit(ICE_SERVICE_DIS, pf->state);
7e408e07b42dce Anirudh Venkataramanan 2021-03-02 4968 set_bit(ICE_DOWN, pf->state);
4015d11e4b9720 Brett Creeley 2019-11-08 4969 devm_kfree(dev, pf->first_sw);
940b61af02f497 Anirudh Venkataramanan 2018-03-20 4970 err_msix_misc_unroll:
940b61af02f497 Anirudh Venkataramanan 2018-03-20 4971 ice_free_irq_msix_misc(pf);
940b61af02f497 Anirudh Venkataramanan 2018-03-20 4972 err_init_interrupt_unroll:
940b61af02f497 Anirudh Venkataramanan 2018-03-20 4973 ice_clear_interrupt_scheme(pf);
288ecf491b1654 Benjamin Mikailenko 2022-11-18 4974 err_init_vsi_stats_unroll:
288ecf491b1654 Benjamin Mikailenko 2022-11-18 4975 devm_kfree(dev, pf->vsi_stats);
288ecf491b1654 Benjamin Mikailenko 2022-11-18 4976 pf->vsi_stats = NULL;
bc3a024101ca49 Jacob Keller 2020-05-15 4977 err_init_vsi_unroll:
77ed84f49aeed1 Bruce Allan 2019-02-08 4978 devm_kfree(dev, pf->vsi);
940b61af02f497 Anirudh Venkataramanan 2018-03-20 4979 err_init_pf_unroll:
940b61af02f497 Anirudh Venkataramanan 2018-03-20 4980 ice_deinit_pf(pf);
dce730f17825f4 Jacob Keller 2020-03-26 4981 ice_devlink_destroy_regions(pf);
940b61af02f497 Anirudh Venkataramanan 2018-03-20 4982 ice_deinit_hw(hw);
f31e4b6fe227df Anirudh Venkataramanan 2018-03-20 4983 err_exit_unroll:
f31e4b6fe227df Anirudh Venkataramanan 2018-03-20 4984 pci_disable_pcie_error_reporting(pdev);
769c500dcc1edb Akeem G Abodunrin 2020-07-09 4985 pci_disable_device(pdev);
f31e4b6fe227df Anirudh Venkataramanan 2018-03-20 4986 return err;
837f08fdecbe4b Anirudh Venkataramanan 2018-03-20 4987 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Intel-wired-lan] [tnguy-net-queue:dev-queue 2/17] drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err'
2022-12-29 8:58 [Intel-wired-lan] [tnguy-net-queue:dev-queue 2/17] drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err' Dan Carpenter
@ 2022-12-29 22:27 ` Tony Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Tony Nguyen @ 2022-12-29 22:27 UTC (permalink / raw)
To: Dan Carpenter, oe-kbuild, Paul M Stillwell Jr
Cc: Intel Wired LAN, oe-kbuild-all
On 12/29/2022 12:58 AM, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
> head: c342bc11f5a438cf39e2280bafda39ec2c6953f1
> commit: e51d0e34580892d22107a85390d1752fa7a7d56a [2/17] ice: move devlink port creation/deletion
> config: powerpc-randconfig-m031-20221226
> compiler: powerpc-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <error27@gmail.com>
>
> smatch warnings:
> drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err'
>
> vim +/err +4921 drivers/net/ethernet/intel/ice/ice_main.c
>
> df006dd4b1dca8 Dave Ertman 2020-11-20 4908 if (ice_init_lag(pf))
> df006dd4b1dca8 Dave Ertman 2020-11-20 4909 dev_warn(dev, "Failed to init link aggregation support\n");
> df006dd4b1dca8 Dave Ertman 2020-11-20 4910
> e18ff118181bca Paul Greenwalt 2019-10-09 4911 /* print PCI link speed and width */
> e18ff118181bca Paul Greenwalt 2019-10-09 4912 pcie_print_link_status(pf->pdev);
> e18ff118181bca Paul Greenwalt 2019-10-09 4913
> de75135b5c04c9 Anirudh Venkataramanan 2020-05-07 4914 probe_done:
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4915 err = ice_devlink_create_pf_port(pf);
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4916 if (err)
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4917 goto err_create_pf_port;
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4918
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4919 vsi = ice_get_main_vsi(pf);
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 4920 if (!vsi || !vsi->netdev)
> e51d0e34580892 Paul M Stillwell Jr 2022-11-18 @4921 goto err_netdev_reg;
>
> This seems like an error path so "err = -EINVAL;"
Thanks for the report Dan. We'll get this fixed.
Thanks,
Tony
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-29 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-29 8:58 [Intel-wired-lan] [tnguy-net-queue:dev-queue 2/17] drivers/net/ethernet/intel/ice/ice_main.c:4921 ice_probe() warn: missing error code 'err' Dan Carpenter
2022-12-29 22:27 ` Tony Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).