intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-xe] [PATCH] drm/xe: don't auto fall back to execlist mode if guc failed to init
@ 2023-03-23 20:23 Chang, Bruce
  2023-03-23 20:25 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 16+ messages in thread
From: Chang, Bruce @ 2023-03-23 20:23 UTC (permalink / raw)
  To: intel-xe

In general, this is due to FW load failure, should just report
error and fail the probe so that user can easily retry again.

Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
---
 drivers/gpu/drm/xe/xe_gt.c | 4 ++--
 drivers/gpu/drm/xe/xe_uc.c | 3 ---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index daa433d0f2f5..8a436c95591e 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -455,9 +455,9 @@ static int gt_fw_domain_init(struct xe_gt *gt)
 			goto err_force_wake;
 	}
 
-	/* Allow driver to load if uC init fails (likely missing firmware) */
 	err = xe_uc_init(&gt->uc);
-	XE_WARN_ON(err);
+	if (err)
+		goto err_force_wake;
 
 	err = xe_uc_init_hwconfig(&gt->uc);
 	if (err)
diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 4ccf2b3435e1..70eabf567156 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -54,9 +54,6 @@ int xe_uc_init(struct xe_uc *uc)
 	return 0;
 
 err:
-	/* If any uC firmwares not found, fall back to execlists */
-	xe_device_guc_submission_disable(uc_to_xe(uc));
-
 	return ret;
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2023-03-29 20:16 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 20:23 [Intel-xe] [PATCH] drm/xe: don't auto fall back to execlist mode if guc failed to init Chang, Bruce
2023-03-23 20:25 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-03-23 20:26 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-23 20:30 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-03-23 20:52 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-03-23 22:52 ` [Intel-xe] [PATCH] " Matthew Brost
2023-03-23 23:08   ` Chang, Yu bruce
2023-03-24  7:37     ` Mauro Carvalho Chehab
2023-03-24 15:15       ` Lucas De Marchi
2023-03-24 16:15     ` Rodrigo Vivi
2023-03-29 19:13       ` Rodrigo Vivi
2023-03-29 20:00         ` Chang, Yu bruce
2023-03-29 20:11           ` Rodrigo Vivi
2023-03-29 20:16             ` Chang, Yu bruce
2023-03-24  7:14 ` Lucas De Marchi
2023-03-24 15:57   ` Chang, Yu bruce

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).