* [PATCH] io-wq: use put instead of revert creds
@ 2020-01-29 10:10 Pavel Begunkov
2020-01-29 13:39 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2020-01-29 10:10 UTC (permalink / raw)
To: Jens Axboe, io-uring, linux-kernel
There is no need to publish creds twice in io_wq_switch_creds() (in
revert_creds() and override_creds()). Just do override_creds() and
put_creds() if needed.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io-wq.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/io-wq.c b/fs/io-wq.c
index 8fbbadf04cc3..f7eb577ccd2d 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -425,11 +425,13 @@ static void io_wq_switch_mm(struct io_worker *worker, struct io_wq_work *work)
static void io_wq_switch_creds(struct io_worker *worker,
struct io_wq_work *work)
{
- if (worker->saved_creds)
- revert_creds(worker->saved_creds);
+ const struct cred *old_creds = override_creds(work->creds);
- worker->saved_creds = override_creds(work->creds);
worker->cur_creds = work->creds;
+ if (worker->saved_creds)
+ put_cred(old_creds); /* creds set by previous switch */
+ else
+ worker->saved_creds = old_creds;
}
static void io_worker_handle_work(struct io_worker *worker)
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io-wq: use put instead of revert creds
2020-01-29 10:10 [PATCH] io-wq: use put instead of revert creds Pavel Begunkov
@ 2020-01-29 13:39 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-01-29 13:39 UTC (permalink / raw)
To: Pavel Begunkov, io-uring, linux-kernel
On 1/29/20 3:10 AM, Pavel Begunkov wrote:
> There is no need to publish creds twice in io_wq_switch_creds() (in
> revert_creds() and override_creds()). Just do override_creds() and
> put_creds() if needed.
Thanks, looks good. Applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-29 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 10:10 [PATCH] io-wq: use put instead of revert creds Pavel Begunkov
2020-01-29 13:39 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).