* [PATCH -next] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy
@ 2022-10-04 12:39 Geert Uytterhoeven
2022-10-04 14:06 ` Jens Axboe
2022-10-04 16:41 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-10-04 12:39 UTC (permalink / raw)
To: Jens Axboe, Pavel Begunkov, Anuj Gupta, Kanchan Joshi
Cc: io-uring, linux-kernel, Geert Uytterhoeven
If CONFIG_IO_URING is not set:
include/linux/io_uring.h:65:12: error: ‘io_uring_cmd_import_fixed’ defined but not used [-Werror=unused-function]
65 | static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Fix this by adding the missing "inline" keyword.
Fixes: a9216fac3ed8819c ("io_uring: add io_uring_cmd_import_fixed")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
include/linux/io_uring.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/io_uring.h b/include/linux/io_uring.h
index e10c5cc810827ab8..43bc8a2edccf5aa3 100644
--- a/include/linux/io_uring.h
+++ b/include/linux/io_uring.h
@@ -62,7 +62,7 @@ static inline void io_uring_free(struct task_struct *tsk)
__io_uring_free(tsk);
}
#else
-static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
+static inline int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
struct iov_iter *iter, void *ioucmd)
{
return -EOPNOTSUPP;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy
2022-10-04 12:39 [PATCH -next] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy Geert Uytterhoeven
@ 2022-10-04 14:06 ` Jens Axboe
2022-10-04 16:41 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-10-04 14:06 UTC (permalink / raw)
To: Geert Uytterhoeven, Pavel Begunkov, Anuj Gupta, Kanchan Joshi
Cc: io-uring, linux-kernel
On 10/4/22 6:39 AM, Geert Uytterhoeven wrote:
> If CONFIG_IO_URING is not set:
>
> include/linux/io_uring.h:65:12: error: ‘io_uring_cmd_import_fixed’ defined but not used [-Werror=unused-function]
> 65 | static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by adding the missing "inline" keyword.
Thanks Geert, I'll get this added.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy
2022-10-04 12:39 [PATCH -next] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy Geert Uytterhoeven
2022-10-04 14:06 ` Jens Axboe
@ 2022-10-04 16:41 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-10-04 16:41 UTC (permalink / raw)
To: Kanchan Joshi, Anuj Gupta, Pavel Begunkov, Geert Uytterhoeven
Cc: io-uring, linux-kernel
On Tue, 4 Oct 2022 14:39:10 +0200, Geert Uytterhoeven wrote:
> If CONFIG_IO_URING is not set:
>
> include/linux/io_uring.h:65:12: error: ‘io_uring_cmd_import_fixed’ defined but not used [-Werror=unused-function]
> 65 | static int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by adding the missing "inline" keyword.
>
> [...]
Applied, thanks!
[1/1] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy
(no commit info)
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-04 16:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 12:39 [PATCH -next] io_uring: Add missing inline to io_uring_cmd_import_fixed() dummy Geert Uytterhoeven
2022-10-04 14:06 ` Jens Axboe
2022-10-04 16:41 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).