io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] io_uring/timeout: remove duplicate initialization of the io_timeout list.
       [not found] <CGME20240411060014epcas5p1658ee85070dfc22544e4fbff9436cb46@epcas5p1.samsung.com>
@ 2024-04-11  5:59 ` Ruyi Zhang
  2024-04-11 13:34   ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Ruyi Zhang @ 2024-04-11  5:59 UTC (permalink / raw)
  To: axboe
  Cc: asml.silence, io-uring, linux-kernel, peiwei.li, ruyi.zhang, xue01.he

In the __io_timeout_prep function, the io_timeout list is initialized
twice, removing the meaningless second initialization.

Signed-off-by: Ruyi Zhang <ruyi.zhang@samsung.com>
---
 io_uring/timeout.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/io_uring/timeout.c b/io_uring/timeout.c
index 7fd7dbb211d6..93ff94e82fd4 100644
--- a/io_uring/timeout.c
+++ b/io_uring/timeout.c
@@ -541,7 +541,6 @@ static int __io_timeout_prep(struct io_kiocb *req,
 	if (data->ts.tv_sec < 0 || data->ts.tv_nsec < 0)
 		return -EINVAL;
 
-	INIT_LIST_HEAD(&timeout->list);
 	data->mode = io_translate_timeout_mode(flags);
 	hrtimer_init(&data->timer, io_timeout_get_clock(data), data->mode);
 
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] io_uring/timeout: remove duplicate initialization of the io_timeout list.
  2024-04-11  5:59 ` [PATCH] io_uring/timeout: remove duplicate initialization of the io_timeout list Ruyi Zhang
@ 2024-04-11 13:34   ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2024-04-11 13:34 UTC (permalink / raw)
  To: Ruyi Zhang; +Cc: asml.silence, io-uring, linux-kernel, peiwei.li, xue01.he


On Thu, 11 Apr 2024 13:59:53 +0800, Ruyi Zhang wrote:
> In the __io_timeout_prep function, the io_timeout list is initialized
> twice, removing the meaningless second initialization.
> 
> 

Applied, thanks!

[1/1] io_uring/timeout: remove duplicate initialization of the io_timeout list.
      commit: 99e440c5b1d70084eeb2097bd035e50c2de62884

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-11 13:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20240411060014epcas5p1658ee85070dfc22544e4fbff9436cb46@epcas5p1.samsung.com>
2024-04-11  5:59 ` [PATCH] io_uring/timeout: remove duplicate initialization of the io_timeout list Ruyi Zhang
2024-04-11 13:34   ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).