From: Andres Freund <andres@anarazel.de>
To: Matteo Rizzo <matteorizzo@google.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
io-uring@vger.kernel.org, axboe@kernel.dk,
asml.silence@gmail.com, corbet@lwn.net,
akpm@linux-foundation.org, keescook@chromium.org,
ribalda@chromium.org, rostedt@goodmis.org, jannh@google.com,
chenhuacai@kernel.org, gpiccoli@igalia.com,
ldufour@linux.ibm.com, evn@google.com, poprdi@google.com,
jordyzomer@google.com, jmoyer@redhat.com, krisman@suse.de
Subject: Re: [PATCH v3 1/1] io_uring: add a sysctl to disable io_uring system-wide
Date: Wed, 26 Jul 2023 10:45:49 -0700 [thread overview]
Message-ID: <20230726174549.cg4jgx2d33fom4rb@awork3.anarazel.de> (raw)
In-Reply-To: <20230630151003.3622786-2-matteorizzo@google.com>
Hi,
On 2023-06-30 15:10:03 +0000, Matteo Rizzo wrote:
> Introduce a new sysctl (io_uring_disabled) which can be either 0, 1,
> or 2. When 0 (the default), all processes are allowed to create io_uring
> instances, which is the current behavior. When 1, all calls to
> io_uring_setup fail with -EPERM unless the calling process has
> CAP_SYS_ADMIN. When 2, calls to io_uring_setup fail with -EPERM
> regardless of privilege.
Hm, is there a chance that instead of requiring CAP_SYS_ADMIN, a certain group
could be required (similar to hugetlb_shm_group)? Requiring CAP_SYS_ADMIN
could have the unintended consequence of io_uring requiring tasks being run
with more privileges than needed... Or some other more granular way of
granting the right to use io_uring?
ISTM that it'd be nice if e.g. a systemd service specification could allow
some services to use io_uring, without allowing it for everyone, or requiring
to run services effectively as root.
Greetings,
Andres Freund
next prev parent reply other threads:[~2023-07-26 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 15:10 [PATCH v3 0/1] Add a sysctl to disable io_uring system-wide Matteo Rizzo
2023-06-30 15:10 ` [PATCH v3 1/1] io_uring: add " Matteo Rizzo
2023-06-30 15:15 ` Jann Horn
2023-07-26 17:45 ` Andres Freund [this message]
2023-07-26 20:02 ` Jeff Moyer
2023-08-09 15:09 ` Andres Freund
2023-08-09 16:45 ` Jens Axboe
2023-08-09 18:38 ` Gabriel Krisman Bertazi
2023-07-11 20:51 ` [PATCH v3 0/1] Add " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726174549.cg4jgx2d33fom4rb@awork3.anarazel.de \
--to=andres@anarazel.de \
--cc=akpm@linux-foundation.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=evn@google.com \
--cc=gpiccoli@igalia.com \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=jmoyer@redhat.com \
--cc=jordyzomer@google.com \
--cc=keescook@chromium.org \
--cc=krisman@suse.de \
--cc=ldufour@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matteorizzo@google.com \
--cc=poprdi@google.com \
--cc=ribalda@chromium.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).