IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
* delete unneeded int-type
@ 2019-11-29  8:19 liming wu
  2019-11-29  8:25 ` Jackie Liu
  2019-11-29 17:18 ` Jens Axboe
  0 siblings, 2 replies; 4+ messages in thread
From: liming wu @ 2019-11-29  8:19 UTC (permalink / raw)
  To: io-uring

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Hi

It can't buid successfully except use c99.


Subject: [PATCH] delete unneede int-type

---
 test/accept-link.c | 2 +-
 test/poll-link.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/accept-link.c b/test/accept-link.c
index 2fbc12e..91dbc2b 100644
--- a/test/accept-link.c
+++ b/test/accept-link.c
@@ -131,7 +131,7 @@ void *recv_thread(void *arg)

        assert(io_uring_submit(&ring) == 2);

-       for (int i = 0; i < 2; i++) {
+       for (i = 0; i < 2; i++) {
                struct io_uring_cqe *cqe;
                int idx;

diff --git a/test/poll-link.c b/test/poll-link.c
index 3cc2ca7..abddb71 100644
--- a/test/poll-link.c
+++ b/test/poll-link.c
@@ -127,7 +127,7 @@ void *recv_thread(void *arg)

        assert(io_uring_submit(&ring) == 2);

-       for (int i = 0; i < 2; i++) {
+       for (i = 0; i < 2; i++) {
                struct io_uring_cqe *cqe;
                int idx;

--

[-- Attachment #2: delete-unneede-int-type.patch --]
[-- Type: application/octet-stream, Size: 958 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: delete unneeded int-type
  2019-11-29  8:19 delete unneeded int-type liming wu
@ 2019-11-29  8:25 ` Jackie Liu
  2019-11-29 17:21   ` Jens Axboe
  2019-11-29 17:18 ` Jens Axboe
  1 sibling, 1 reply; 4+ messages in thread
From: Jackie Liu @ 2019-11-29  8:25 UTC (permalink / raw)
  To: liming wu; +Cc: io-uring

2019年11月29日 16:19,liming wu <wu860403@gmail.com> 写道:
> 
> Hi
> 
> It can't buid successfully except use c99.
> 
> 
> Subject: [PATCH] delete unneede int-type
> 
> ---
> test/accept-link.c | 2 +-
> test/poll-link.c   | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/accept-link.c b/test/accept-link.c
> index 2fbc12e..91dbc2b 100644
> --- a/test/accept-link.c
> +++ b/test/accept-link.c
> @@ -131,7 +131,7 @@ void *recv_thread(void *arg)
> 
>        assert(io_uring_submit(&ring) == 2);
> 
> -       for (int i = 0; i < 2; i++) {
> +       for (i = 0; i < 2; i++) {
>                struct io_uring_cqe *cqe;
>                int idx;
> 
> diff --git a/test/poll-link.c b/test/poll-link.c
> index 3cc2ca7..abddb71 100644
> --- a/test/poll-link.c
> +++ b/test/poll-link.c
> @@ -127,7 +127,7 @@ void *recv_thread(void *arg)
> 
>        assert(io_uring_submit(&ring) == 2);
> 
> -       for (int i = 0; i < 2; i++) {
> +       for (i = 0; i < 2; i++) {
>                struct io_uring_cqe *cqe;
>                int idx;
> 
> --
> <delete-unneede-int-type.patch>

I think it would be better for you to send patches using git send-email
instead of using attachments.

--
Jackie Liu

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: delete unneeded int-type
  2019-11-29  8:19 delete unneeded int-type liming wu
  2019-11-29  8:25 ` Jackie Liu
@ 2019-11-29 17:18 ` Jens Axboe
  1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2019-11-29 17:18 UTC (permalink / raw)
  To: liming wu, io-uring

On 11/29/19 12:19 AM, liming wu wrote:
> Hi
> 
> It can't buid successfully except use c99.

Thanks, I'll apply this a bit sanitized.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: delete unneeded int-type
  2019-11-29  8:25 ` Jackie Liu
@ 2019-11-29 17:21   ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2019-11-29 17:21 UTC (permalink / raw)
  To: Jackie Liu, liming wu; +Cc: io-uring

On 11/29/19 12:25 AM, Jackie Liu wrote:
> 2019年11月29日 16:19,liming wu <wu860403@gmail.com> 写道:
>>
>> Hi
>>
>> It can't buid successfully except use c99.
>>
>>
>> Subject: [PATCH] delete unneede int-type
>>
>> ---
>> test/accept-link.c | 2 +-
>> test/poll-link.c   | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/test/accept-link.c b/test/accept-link.c
>> index 2fbc12e..91dbc2b 100644
>> --- a/test/accept-link.c
>> +++ b/test/accept-link.c
>> @@ -131,7 +131,7 @@ void *recv_thread(void *arg)
>>
>>         assert(io_uring_submit(&ring) == 2);
>>
>> -       for (int i = 0; i < 2; i++) {
>> +       for (i = 0; i < 2; i++) {
>>                 struct io_uring_cqe *cqe;
>>                 int idx;
>>
>> diff --git a/test/poll-link.c b/test/poll-link.c
>> index 3cc2ca7..abddb71 100644
>> --- a/test/poll-link.c
>> +++ b/test/poll-link.c
>> @@ -127,7 +127,7 @@ void *recv_thread(void *arg)
>>
>>         assert(io_uring_submit(&ring) == 2);
>>
>> -       for (int i = 0; i < 2; i++) {
>> +       for (i = 0; i < 2; i++) {
>>                 struct io_uring_cqe *cqe;
>>                 int idx;
>>
>> --
>> <delete-unneede-int-type.patch>
> 
> I think it would be better for you to send patches using git send-email
> instead of using attachments.

Yeah, this one is small enough that I just hand apply it, but the
patches are clearly mangled.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29  8:19 delete unneeded int-type liming wu
2019-11-29  8:25 ` Jackie Liu
2019-11-29 17:21   ` Jens Axboe
2019-11-29 17:18 ` Jens Axboe

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git