* [PATCH] io_uring: comment on kfree(iovec) checks
@ 2020-08-20 8:34 Pavel Begunkov
2020-08-20 11:50 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2020-08-20 8:34 UTC (permalink / raw)
To: Jens Axboe, io-uring
kfree() handles NULL pointers well, but io_{read,write}() checks it
because of performance reasons. Leave a comment there for those who are
tempted to patch it.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io_uring.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 938112826dd1..ea2d1cb5c422 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -3204,6 +3204,7 @@ static int io_read(struct io_kiocb *req, bool force_nonblock,
kiocb_done(kiocb, ret, cs);
ret = 0;
out_free:
+ /* it's reportedly faster than delegating the null check to kfree() */
if (iovec)
kfree(iovec);
return ret;
@@ -3300,6 +3301,7 @@ static int io_write(struct io_kiocb *req, bool force_nonblock,
return -EAGAIN;
}
out_free:
+ /* it's reportedly faster than delegating the null check to kfree() */
if (iovec)
kfree(iovec);
return ret;
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io_uring: comment on kfree(iovec) checks
2020-08-20 8:34 [PATCH] io_uring: comment on kfree(iovec) checks Pavel Begunkov
@ 2020-08-20 11:50 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-08-20 11:50 UTC (permalink / raw)
To: Pavel Begunkov, io-uring
On 8/20/20 1:34 AM, Pavel Begunkov wrote:
> kfree() handles NULL pointers well, but io_{read,write}() checks it
> because of performance reasons. Leave a comment there for those who are
> tempted to patch it.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-20 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-20 8:34 [PATCH] io_uring: comment on kfree(iovec) checks Pavel Begunkov
2020-08-20 11:50 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).