IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] io-wq: remove extra space characters
@ 2019-11-19  6:22 Dan Carpenter
  2019-11-19 15:45 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-11-19  6:22 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Alexander Viro, io-uring, linux-fsdevel, linux-kernel, kernel-janitors

These lines are indented an extra space character.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
We often see this where the lines after a comment are indented one
space extra.  I don't know if it's an editor thing maybe?

 fs/io-wq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/io-wq.c b/fs/io-wq.c
index fcb6c74209da..6d8f5e6c8167 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -333,9 +333,9 @@ static void __io_worker_busy(struct io_wqe *wqe, struct io_worker *worker,
 	 * If worker is moving from bound to unbound (or vice versa), then
 	 * ensure we update the running accounting.
 	 */
-	 worker_bound = (worker->flags & IO_WORKER_F_BOUND) != 0;
-	 work_bound = (work->flags & IO_WQ_WORK_UNBOUND) == 0;
-	 if (worker_bound != work_bound) {
+	worker_bound = (worker->flags & IO_WORKER_F_BOUND) != 0;
+	work_bound = (work->flags & IO_WQ_WORK_UNBOUND) == 0;
+	if (worker_bound != work_bound) {
 		io_wqe_dec_running(wqe, worker);
 		if (work_bound) {
 			worker->flags |= IO_WORKER_F_BOUND;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] io-wq: remove extra space characters
  2019-11-19  6:22 [PATCH] io-wq: remove extra space characters Dan Carpenter
@ 2019-11-19 15:45 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-11-19 15:45 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Alexander Viro, io-uring, linux-fsdevel, linux-kernel, kernel-janitors

On 11/18/19 11:22 PM, Dan Carpenter wrote:
> These lines are indented an extra space character.

Thanks, applied.

> We often see this where the lines after a comment are indented one
> space extra.  I don't know if it's an editor thing maybe?

I think I can explain that. I recently decided to try and use the
vim auto-indent, to see if it'd make my life a little easier to
save on typing. Unfortunately it has a bug where it indents that
extra space following a comment form like:

/*
 * bla bla
 */

which is exactly what happened here. As diff doesn't show that
as extra whitespace you can miss that it happened.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19  6:22 [PATCH] io-wq: remove extra space characters Dan Carpenter
2019-11-19 15:45 ` Jens Axboe

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git