[PATCH] band: fix HT40+/- checks when creating chandef

[PATCH] band: fix HT40+/- checks when creating chandef

[James Prestwood]

The HT40+/- flags were reversed when checking against the 802.11
behavior flags.

HT40+ means the secondary channel is above (+) the primary channel
therefore corresponds to the PRIMARY_CHANNEL_LOWER behavior. And
the opposite for HT40-.

Reported-By: Alagu Sankar <alagusankar@gmail.com>
---
 src/band.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/band.c b/src/band.c
index 27b4d174..486df6e1 100644
--- a/src/band.c
+++ b/src/band.c
@@ -1229,11 +1229,11 @@ int band_freq_to_ht_chandef(uint32_t freq, const struct band_freq_attrs *attr,
 			if (band == BAND_FREQ_6_GHZ)
 				break;
 
-			if (info->flags & PRIMARY_CHANNEL_UPPER &&
+			if (info->flags & PRIMARY_CHANNEL_LOWER &&
 						attr->no_ht40_plus)
 				continue;
 
-			if (info->flags & PRIMARY_CHANNEL_LOWER &&
+			if (info->flags & PRIMARY_CHANNEL_UPPER &&
 						attr->no_ht40_minus)
 				continue;
 
-- 
2.25.1

Re: [PATCH] band: fix HT40+/- checks when creating chandef

[Denis Kenzior]

Hi James,

On 4/4/23 10:56, James Prestwood wrote:
> The HT40+/- flags were reversed when checking against the 802.11
> behavior flags.
> 
> HT40+ means the secondary channel is above (+) the primary channel
> therefore corresponds to the PRIMARY_CHANNEL_LOWER behavior. And
> the opposite for HT40-.
> 
> Reported-By: Alagu Sankar <alagusankar@gmail.com>
> ---
>   src/band.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Regards,
-Denis