iwd.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] iwmon: fix incorrect mask printing HE capabilities
@ 2024-03-15 11:18 James Prestwood
  2024-03-15 13:47 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2024-03-15 11:18 UTC (permalink / raw)
  To: iwd; +Cc: James Prestwood

This was changed from too large of a mask (0xff) in an earlier
commit but was masking 5 bits instead of 6.

Fixes: 121c2c5653 ("monitor: properly mask HE capabilities bitfield")
---
 monitor/nlmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/nlmon.c b/monitor/nlmon.c
index 6fe63b8d..9fee5bde 100644
--- a/monitor/nlmon.c
+++ b/monitor/nlmon.c
@@ -1689,7 +1689,7 @@ static void print_ie_he_capabilities(unsigned int level,
 {
 	const uint8_t *ptr = data;
 	uint8_t width_set = bit_field((ptr + 6)[0], 1, 7);
-	uint8_t mask = 0x1f;
+	uint8_t mask = 0x3f;
 
 	const char *he_channel_width_bitfield[] = {
 		[0] = "40MHz supported (2.4GHz)",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iwmon: fix incorrect mask printing HE capabilities
  2024-03-15 11:18 [PATCH] iwmon: fix incorrect mask printing HE capabilities James Prestwood
@ 2024-03-15 13:47 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2024-03-15 13:47 UTC (permalink / raw)
  To: James Prestwood, iwd

Hi James,

On 3/15/24 06:18, James Prestwood wrote:
> This was changed from too large of a mask (0xff) in an earlier
> commit but was masking 5 bits instead of 6.
> 
> Fixes: 121c2c5653 ("monitor: properly mask HE capabilities bitfield")
> ---
>   monitor/nlmon.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-15 13:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15 11:18 [PATCH] iwmon: fix incorrect mask printing HE capabilities James Prestwood
2024-03-15 13:47 ` Denis Kenzior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).