iwd.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
       [not found] <CA+iibzC0O-v+Rk+799=QYmzyAZo_3XcN1mfAsM-QtnA8zc6wpw@mail.gmail.com>
@ 2023-04-22 18:32 ` Marcel Holtmann
  2023-04-23  2:32   ` James Prestwood
  2023-04-24  5:46 ` Daniel Wagner
  1 sibling, 1 reply; 16+ messages in thread
From: Marcel Holtmann @ 2023-04-22 18:32 UTC (permalink / raw)
  To: daniel antoine; +Cc: iwd

Hi Daniel,

changing the mailing list ;)

> I have tried to build iwd to the last commit "Allow building with
> libedit instead readline". The Pkgfile seems to need the option
> --enable-libedit to remove readline but it fails with
>  CC       wired/dbus.o
>  CCLD     ell/libell-internal.la
>  CCLD     client/iwctl
>  CCLD     src/iwd
>  CCLD     wired/ead
> /usr/bin/ld: client/command.o: in function `command_completion':
> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
> /usr/bin/ld: client/display.o: in function `save_input':
> display.c:(.text+0x32): undefined reference to `rl_copy_text'
> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_text':
> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_completion_matches':
> display.c:(.text+0x834): undefined reference to `rl_copy_text'
> /usr/bin/ld: client/display.o: in function `timeout_callback':
> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_table_footer':
> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
> `rl_restore_prompt'
> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
> `rl_erase_empty_line'
> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
> `rl_erase_empty_line'
> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_init':
> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:1895: client/iwctl] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1595: all] Error 2
> =======> ERROR: Building
> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
> 
> It looks like some readline commands are always taken in count
> 
> I have my Pkgfile and the compilation log

It does build for me just fine. What distro is this?

What does pkg-config --cflags --libs libedit show?

Regards

Marcel


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-22 18:32 ` commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error Marcel Holtmann
@ 2023-04-23  2:32   ` James Prestwood
  2023-04-24  7:39     ` Marcel Holtmann
  2023-04-24 10:14     ` Marcel Holtmann
  0 siblings, 2 replies; 16+ messages in thread
From: James Prestwood @ 2023-04-23  2:32 UTC (permalink / raw)
  To: Marcel Holtmann, daniel antoine; +Cc: iwd

Hi Marcel,

On 4/22/23 11:32 AM, Marcel Holtmann wrote:
> Hi Daniel,
> 
> changing the mailing list ;)
> 
>> I have tried to build iwd to the last commit "Allow building with
>> libedit instead readline". The Pkgfile seems to need the option
>> --enable-libedit to remove readline but it fails with
>>   CC       wired/dbus.o
>>   CCLD     ell/libell-internal.la
>>   CCLD     client/iwctl
>>   CCLD     src/iwd
>>   CCLD     wired/ead
>> /usr/bin/ld: client/command.o: in function `command_completion':
>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
>> /usr/bin/ld: client/display.o: in function `save_input':
>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
>> /usr/bin/ld: client/display.o: in function `display_text':
>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
>> /usr/bin/ld: client/display.o: in function `timeout_callback':
>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
>> /usr/bin/ld: client/display.o: in function `display_table_footer':
>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
>> `rl_restore_prompt'
>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
>> `rl_erase_empty_line'
>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
>> `rl_erase_empty_line'
>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
>> /usr/bin/ld: client/display.o: in function `display_init':
>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1595: all] Error 2
>> =======> ERROR: Building
>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
>>
>> It looks like some readline commands are always taken in count
>>
>> I have my Pkgfile and the compilation log
> 
> It does build for me just fine. What distro is this?
> 
> What does pkg-config --cflags --libs libedit show?

I'm seeing the same build problem, Ubuntu 20.04:

$ pkg-config --cflags --libs libedit
-I/usr/include/editline -ledit

> 
> Regards
> 
> Marcel
> 
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
       [not found] <CA+iibzC0O-v+Rk+799=QYmzyAZo_3XcN1mfAsM-QtnA8zc6wpw@mail.gmail.com>
  2023-04-22 18:32 ` commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error Marcel Holtmann
@ 2023-04-24  5:46 ` Daniel Wagner
  2023-04-24  8:19   ` daniel antoine
  1 sibling, 1 reply; 16+ messages in thread
From: Daniel Wagner @ 2023-04-24  5:46 UTC (permalink / raw)
  To: daniel antoine; +Cc: connman, iwd

Add iwd mailing list

On Sat, Apr 22, 2023 at 05:03:00PM +0200, daniel antoine wrote:
> I have tried to build iwd to the last commit "Allow building with
> libedit instead readline". The Pkgfile seems to need the option
> --enable-libedit to remove readline but it fails with
>   CC       wired/dbus.o
>   CCLD     ell/libell-internal.la
>   CCLD     client/iwctl
>   CCLD     src/iwd
>   CCLD     wired/ead
> /usr/bin/ld: client/command.o: in function `command_completion':
> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
> /usr/bin/ld: client/display.o: in function `save_input':
> display.c:(.text+0x32): undefined reference to `rl_copy_text'
> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_text':
> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_completion_matches':
> display.c:(.text+0x834): undefined reference to `rl_copy_text'
> /usr/bin/ld: client/display.o: in function `timeout_callback':
> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_table_footer':
> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
> `rl_restore_prompt'
> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
> `rl_erase_empty_line'
> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
> `rl_erase_empty_line'
> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
> /usr/bin/ld: client/display.o: in function `display_init':
> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:1895: client/iwctl] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1595: all] Error 2
> =======> ERROR: Building
> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
> 
> It looks like some readline commands are always taken in count
> 
> I have my Pkgfile and the compilation log
> 
> 
> best regards
> Dania




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-23  2:32   ` James Prestwood
@ 2023-04-24  7:39     ` Marcel Holtmann
  2023-04-24 10:14     ` Marcel Holtmann
  1 sibling, 0 replies; 16+ messages in thread
From: Marcel Holtmann @ 2023-04-24  7:39 UTC (permalink / raw)
  To: James Prestwood; +Cc: daniel antoine, iwd

Hi James,

>>> I have tried to build iwd to the last commit "Allow building with
>>> libedit instead readline". The Pkgfile seems to need the option
>>> --enable-libedit to remove readline but it fails with
>>>  CC       wired/dbus.o
>>>  CCLD     ell/libell-internal.la
>>>  CCLD     client/iwctl
>>>  CCLD     src/iwd
>>>  CCLD     wired/ead
>>> /usr/bin/ld: client/command.o: in function `command_completion':
>>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: client/display.o: in function `save_input':
>>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
>>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_text':
>>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
>>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
>>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: client/display.o: in function `timeout_callback':
>>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
>>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_table_footer':
>>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
>>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
>>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
>>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
>>> `rl_restore_prompt'
>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
>>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
>>> `rl_erase_empty_line'
>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
>>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
>>> `rl_erase_empty_line'
>>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_init':
>>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
>>> collect2: error: ld returned 1 exit status
>>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [Makefile:1595: all] Error 2
>>> =======> ERROR: Building
>>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
>>> 
>>> It looks like some readline commands are always taken in count
>>> 
>>> I have my Pkgfile and the compilation log
>> It does build for me just fine. What distro is this?
>> What does pkg-config --cflags --libs libedit show?
> 
> I'm seeing the same build problem, Ubuntu 20.04:
> 
> $ pkg-config --cflags --libs libedit
> -I/usr/include/editline -ledit

so Fedora 38 has the same and it links just fine:

# ldd client/iwctl
	linux-vdso.so.1 (0x00007ffc1d884000)
	libedit.so.0 => /lib64/libedit.so.0 (0x00007fd5ce18e000)
	libc.so.6 => /lib64/libc.so.6 (0x00007fd5cdfaf000)
	libtinfo.so.6 => /lib64/libtinfo.so.6 (0x00007fd5cdf7c000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fd5ce1d3000)

# rpm -qi libedit-devel
Name        : libedit-devel
Version     : 3.1
Release     : 45.20221030cvs.fc38
Architecture: x86_64
Install Date: Fri 21 Apr 2023 02:00:12 PM CEST
Group       : Unspecified
Size        : 60383
License     : BSD-3-Clause AND BSD-2-Clause AND ISC
Signature   : RSA/SHA256, Thu 19 Jan 2023 11:13:49 PM CET, Key ID 809a8d7ceb10b464
Source RPM  : libedit-3.1-45.20221030cvs.fc38.src.rpm
Build Date  : Thu 19 Jan 2023 06:09:35 PM CET
Build Host  : buildhw-x86-15.iad2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://www.thrysoee.dk/editline/

The GCC 13 is having some fun on Fedora 38, but that is a different story:

  CC       src/eap.o
In function ‘eap_handle_response’,
    inlined from ‘eap_rx_packet’ at src/eap.c:570:3:
src/eap.c:421:49: error: ‘vendor_id’ may be used uninitialized [-Werror=maybe-uninitialized]
  421 |         (type == EAP_TYPE_EXPANDED && vendor_id == (id) && vendor_type == (t))
      |                                       ~~~~~~~~~~^~~~~~~
src/eap.c:533:20: note: in expansion of macro ‘IS_EXPANDED_RESPONSE’
  533 |         } else if (IS_EXPANDED_RESPONSE(our_vendor_id, our_vendor_type))
      |                    ^~~~~~~~~~~~~~~~~~~~
src/eap.c: In function ‘eap_rx_packet’:
src/eap.c:431:18: note: ‘vendor_id’ was declared here
  431 |         uint32_t vendor_id;
      |                  ^~~~~~~~~
In function ‘eap_handle_response’,
    inlined from ‘eap_rx_packet’ at src/eap.c:570:3:
src/eap.c:421:57: error: ‘vendor_type’ may be used uninitialized [-Werror=maybe-uninitialized]
  421 |         (type == EAP_TYPE_EXPANDED && vendor_id == (id) && vendor_type == (t))
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
src/eap.c:533:20: note: in expansion of macro ‘IS_EXPANDED_RESPONSE’
  533 |         } else if (IS_EXPANDED_RESPONSE(our_vendor_id, our_vendor_type))
      |                    ^~~~~~~~~~~~~~~~~~~~
src/eap.c: In function ‘eap_rx_packet’:
src/eap.c:432:18: note: ‘vendor_type’ was declared here
  432 |         uint32_t vendor_type;
      |                  ^~~~~~~~~~~
cc1: all warnings being treated as errors

Regards

Marcel


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-24  5:46 ` Daniel Wagner
@ 2023-04-24  8:19   ` daniel antoine
  2023-04-24 16:00     ` daniel antoine
  0 siblings, 1 reply; 16+ messages in thread
From: daniel antoine @ 2023-04-24  8:19 UTC (permalink / raw)
  To: marcel, iwd

[-- Attachment #1: Type: text/plain, Size: 4475 bytes --]

Hi Marcel

The distribution is Great-OS, a fork of Nutyx based on Linux from
Scratch. Nutyx is on SysVinit, Grat-OS is on Systemd. It's an
"unofficial" distribution.
I compile the package in a chroot environment

******************************
Chroot path: /mnt/hd
******************************
root@grat-os1:/# cards search pkg-config
(base) pkg-config 0.29.2 A system for managing library compile/link flags.
(base) pkg-config.doc 0.29.2 A system for managing library compile/link flags.
(base) pkg-config.man 0.29.2 A system for managing library compile/link flags.
root@grat-os1:/# pkg-config --cflags --libs libedit
-I/usr/include/editline -ledit

to add some information the first try i cloned the iwd git at the last
commit with readline in the makedepends. The option --enable--libedit
was not added in the Pkgfile. The build failed with an error that the
readline dependency was needed. I added the first log iwd.error.txt
After I have done a second try with the option --enable-libedit and
the dependency readline removed. The log is iwd.error 2.txt

Best regards

Daniel


Daniel

Le lun. 24 avr. 2023 à 07:46, Daniel Wagner <wagi@monom.org> a écrit :
>
> Add iwd mailing list
>
> On Sat, Apr 22, 2023 at 05:03:00PM +0200, daniel antoine wrote:
> > I have tried to build iwd to the last commit "Allow building with
> > libedit instead readline". The Pkgfile seems to need the option
> > --enable-libedit to remove readline but it fails with
> >   CC       wired/dbus.o
> >   CCLD     ell/libell-internal.la
> >   CCLD     client/iwctl
> >   CCLD     src/iwd
> >   CCLD     wired/ead
> > /usr/bin/ld: client/command.o: in function `command_completion':
> > command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
> > /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
> > /usr/bin/ld: client/display.o: in function `save_input':
> > display.c:(.text+0x32): undefined reference to `rl_copy_text'
> > /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
> > /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
> > /usr/bin/ld: client/display.o: in function `display_text':
> > display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
> > /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
> > /usr/bin/ld: client/display.o: in function `display_completion_matches':
> > display.c:(.text+0x834): undefined reference to `rl_copy_text'
> > /usr/bin/ld: client/display.o: in function `timeout_callback':
> > display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
> > /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
> > /usr/bin/ld: client/display.o: in function `display_table_footer':
> > display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
> > /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
> > /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
> > display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
> > /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
> > `rl_restore_prompt'
> > /usr/bin/ld: client/display.o: in function `display_agent_prompt':
> > display.c:(.text+0x177d): undefined reference to `rl_copy_text'
> > /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
> > /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
> > `rl_erase_empty_line'
> > /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
> > display.c:(.text+0x1889): undefined reference to `rl_copy_text'
> > /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
> > `rl_erase_empty_line'
> > /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
> > /usr/bin/ld: client/display.o: in function `display_init':
> > display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
> > collect2: error: ld returned 1 exit status
> > make[1]: *** [Makefile:1895: client/iwctl] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [Makefile:1595: all] Error 2
> > =======> ERROR: Building
> > '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
> >
> > It looks like some readline commands are always taken in count
> >
> > I have my Pkgfile and the compilation log
> >
> >
> > best regards
> > Dania
>
>
>

[-- Attachment #2: iwd.error.txt --]
[-- Type: text/plain, Size: 8400 bytes --]

cards create: /usr/ports/perso/iwd package(s) starting build Sat Apr 22 09:12:00 2023

=======> PKGMK_INSTALL: no
=======> PKGMK_WORK_DIR: /tmp/work
=======> PKGMK_SOURCE_DIR: /tmp
=======> WARNING: CLEAN IGNORED
=======> PKGMK_IGNORE_REPO: no
=======> PKGMK_UPDATE_REPO: 
=======> PKGMK_IGNORE_FOOTPRINT: yes
=======> PKGMK_IGNORE_MD5SUM: yes
=======> PKGMK_COMPRESS_PACKAGE: yes
=======> PKGMK_COMPRESSION_MODE: xz
=======> name: iwd
=======> version: 2.4
=======> release: 1
=======> Building starting...
+ prepare
+ git clone https://git.kernel.org/pub/scm/libs/ell/ell.git ell
Cloning into 'ell'...
+ cd ell
+ git checkout fc2ea65818a797166c3528fe8c5d36fd7021b311
Note: switching to 'fc2ea65818a797166c3528fe8c5d36fd7021b311'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at fc2ea65 build: Have clang warn about zero-length array use
+ cd ..
+ git clone https://git.kernel.org/pub/scm/network/wireless/iwd.git iwd
Cloning into 'iwd'...
+ cd iwd
+ git checkout 8f0420c533ae6a49c4f2803afe32d5922a5236ad
Note: switching to '8f0420c533ae6a49c4f2803afe32d5922a5236ad'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8f0420c5 build: Allow building with libedit instead readline
+ autoreconf -fiv
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I build-aux
aclocal: warning: couldn't open directory 'build-aux': No such file or directory
autoreconf: configure.ac: tracing
autoreconf: configure.ac: creating directory build-aux
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux'.
libtoolize: copying file 'build-aux/libtool.m4'
libtoolize: copying file 'build-aux/ltoptions.m4'
libtoolize: copying file 'build-aux/ltsugar.m4'
libtoolize: copying file 'build-aux/ltversion.m4'
libtoolize: copying file 'build-aux/lt~obsolete.m4'
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force -I build-aux
autoreconf: running: /usr/bin/autoconf --force
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:23: installing 'build-aux/compile'
configure.ac:35: installing 'build-aux/config.guess'
configure.ac:35: installing 'build-aux/config.sub'
configure.ac:8: installing 'build-aux/install-sh'
configure.ac:8: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
autoreconf: Leaving directory '.'
+ build
+ cd iwd
+ ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libexecdir=/usr/lib/iwd --enable-wired --enable-ofono --enable-hwsim --disable-tools
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking how to create a pax tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of gcc... gcc3
checking whether gcc accepts -fPIE... yes
checking whether gcc accepts -fsanitize=address... yes
checking whether gcc accepts -fsanitize=leak... yes
checking whether gcc accepts -fsanitize=undefined... yes
checking whether ln -s works... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for file... file
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for mt... mt
checking if mt is a manifest tool... no
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for _init in -lasan... yes
checking for _init in -llsan... yes
checking for _init in -lubsan... yes
checking for explicit_bzero... yes
checking for rawmemchr... yes
checking for reallocarray... yes
checking for linux/types.h... yes
checking for linux/if_alg.h... yes
checking for readline... no
configure: error: Readline library is required
=======> ERROR: Building '/usr/ports/perso/iwd/iwd1682154720x86_64.cards.tar.xz' failed.

[-- Attachment #3: iwd.error2.txt --]
[-- Type: text/plain, Size: 15983 bytes --]

cards create: /usr/ports/perso/iwd package(s) starting build Sat Apr 22 09:27:57 2023

=======> PKGMK_INSTALL: no
=======> PKGMK_WORK_DIR: /tmp/work
=======> PKGMK_SOURCE_DIR: /tmp
=======> WARNING: CLEAN IGNORED
=======> PKGMK_IGNORE_REPO: no
=======> PKGMK_UPDATE_REPO: 
=======> PKGMK_IGNORE_FOOTPRINT: yes
=======> PKGMK_IGNORE_MD5SUM: yes
=======> PKGMK_COMPRESS_PACKAGE: yes
=======> PKGMK_COMPRESSION_MODE: xz
=======> name: iwd
=======> version: 2.4
=======> release: 1
=======> Building starting...
+ prepare
+ git clone https://git.kernel.org/pub/scm/libs/ell/ell.git ell
Cloning into 'ell'...
+ cd ell
+ git checkout fc2ea65818a797166c3528fe8c5d36fd7021b311
Note: switching to 'fc2ea65818a797166c3528fe8c5d36fd7021b311'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at fc2ea65 build: Have clang warn about zero-length array use
+ cd ..
+ git clone https://git.kernel.org/pub/scm/network/wireless/iwd.git iwd
Cloning into 'iwd'...
+ cd iwd
+ git checkout 8f0420c533ae6a49c4f2803afe32d5922a5236ad
Note: switching to '8f0420c533ae6a49c4f2803afe32d5922a5236ad'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8f0420c5 build: Allow building with libedit instead readline
+ autoreconf -fiv
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I build-aux
aclocal: warning: couldn't open directory 'build-aux': No such file or directory
autoreconf: configure.ac: tracing
autoreconf: configure.ac: creating directory build-aux
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux'.
libtoolize: copying file 'build-aux/libtool.m4'
libtoolize: copying file 'build-aux/ltoptions.m4'
libtoolize: copying file 'build-aux/ltsugar.m4'
libtoolize: copying file 'build-aux/ltversion.m4'
libtoolize: copying file 'build-aux/lt~obsolete.m4'
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force -I build-aux
autoreconf: running: /usr/bin/autoconf --force
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:23: installing 'build-aux/compile'
configure.ac:35: installing 'build-aux/config.guess'
configure.ac:35: installing 'build-aux/config.sub'
configure.ac:8: installing 'build-aux/install-sh'
configure.ac:8: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
autoreconf: Leaving directory '.'
+ build
+ cd iwd
+ ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libexecdir=/usr/lib/iwd --enable-wired --enable-ofono --enable-hwsim --enable-libedit --disable-tools
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking how to create a pax tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of gcc... gcc3
checking whether gcc accepts -fPIE... yes
checking whether gcc accepts -fsanitize=address... yes
checking whether gcc accepts -fsanitize=leak... yes
checking whether gcc accepts -fsanitize=undefined... yes
checking whether ln -s works... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for file... file
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for mt... mt
checking if mt is a manifest tool... no
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for _init in -lasan... yes
checking for _init in -llsan... yes
checking for _init in -lubsan... yes
checking for explicit_bzero... yes
checking for rawmemchr... yes
checking for reallocarray... yes
checking for linux/types.h... yes
checking for linux/if_alg.h... yes
checking for libedit... yes
checking D-Bus data directory... /usr/share
checking for rst2man... rst2man
checking D-Bus bus services directory... /usr/share/dbus-1/system-services
checking systemd unit directory... /lib/systemd/system
checking systemd network directory... /lib/systemd/network
checking systemd modules load directory... /lib/modules-load.d
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands

	iwd 2.4

+ make
  GEN      ell/shared
  GEN      ell/internal
  GEN      src/builtin.h
  GEN      ell/ell.h
make --no-print-directory all-am
  CC       src/ie.o
  CC       src/wscutil.o
  CC       src/mpdu.o
  CC       src/crypto.o
  CC       src/watchlist.o
  CC       src/eapolutil.o
  CC       src/nl80211cmd.o
  CC       src/p2putil.o
  CC       src/anqputil.o
  CC       src/nl80211util.o
  CC       src/storage.o
  CC       src/common.o
  CC       src/main.o
  CC       src/netdev.o
  CC       src/wiphy.o
  CC       src/device.o
  CC       src/station.o
  CC       src/dbus.o
  CC       src/eapol.o
  CC       src/handshake.o
  CC       src/scan.o
  CC       src/agent.o
  CC       src/network.o
  CC       src/wsc.o
  CC       src/backtrace.o
  CC       src/knownnetworks.o
  CC       src/rfkill.o
  CC       src/ft.o
  CC       src/ap.o
  CC       src/adhoc.o
  CC       src/sae.o
  CC       src/owe.o
  CC       src/blacklist.o
  CC       src/manager.o
  CC       src/erp.o
  CC       src/fils.o
  CC       src/anqp.o
  CC       src/netconfig.o
  CC       src/netconfig-commit.o
  CC       src/resolve.o
  CC       src/hotspot.o
  CC       src/p2p.o
  CC       src/module.o
  CC       src/rrm.o
  CC       src/frame-xchg.o
  CC       src/eap-wsc.o
  CC       src/diagnostic.o
  CC       src/ip-pool.o
  CC       src/sysfs.o
  CC       src/offchannel.o
  CC       src/dpp-util.o
  CC       src/json.o
  CC       src/dpp.o
  CC       src/eap.o
  CC       src/eap-md5.o
  CC       src/eap-tls.o
  CC       src/eap-ttls.o
  CC       src/eap-mschapv2.o
  CC       src/eap-sim.o
  CC       src/eap-aka.o
  CC       src/eap-peap.o
  CC       src/eap-gtc.o
  CC       src/eap-pwd.o
  CC       src/simutil.o
  CC       src/simauth.o
  CC       src/eap-tls-common.o
  CC       src/mschaputil.o
  CC       src/ofono.o
  GEN      src/iwd.service
  GEN      wired/ead.service
  CC       tools/probe-req.o
  CC       tools/iwd-decrypt-profile.o
  GEN      src/iwd.8
  GEN      src/iwd.debug.7
  GEN      src/iwd.config.5
  GEN      src/iwd.network.5
  GEN      src/iwd.ap.5
  GEN      client/iwctl.1
  GEN      monitor/iwmon.1
  GEN      wired/ead.8
  GEN      tools/hwsim.1
  CC       client/main.o
  CC       client/adapter.o
  CC       client/agent.o
  CC       client/agent-manager.o
  CC       client/ad-hoc.o
  CC       client/ap.o
  CC       client/command.o
  CC       client/dbus-proxy.o
  CC       client/device.o
  CC       client/display.o
  CC       client/known-networks.o
  CC       client/network.o
  CC       client/properties.o
  CC       client/wsc.o
  CC       client/station.o
  CC       client/diagnostic.o
  CC       client/daemon.o
  CC       client/dpp.o
  CC       client/station-debug.o
  CC       src/util.o
  CC       src/band.o
  CC       ell/util.lo
  CC       ell/test.lo
  CC       ell/strv.lo
  CC       ell/utf8.lo
  CC       ell/queue.lo
  CC       ell/hashmap.lo
  CC       ell/string.lo
  CC       ell/settings.lo
  CC       ell/main.lo
  CC       ell/idle.lo
  CC       ell/signal.lo
  CC       ell/timeout.lo
  CC       ell/io.lo
  CC       ell/ringbuf.lo
  CC       ell/log.lo
  CC       ell/checksum.lo
  CC       ell/netlink.lo
  CC       ell/genl.lo
  CC       ell/rtnl.lo
  CC       ell/dbus.lo
  CC       ell/dbus-message.lo
  CC       ell/dbus-util.lo
  CC       ell/dbus-service.lo
  CC       ell/dbus-client.lo
  CC       ell/dbus-name-cache.lo
  CC       ell/dbus-filter.lo
  CC       ell/gvariant-util.lo
  CC       ell/siphash.lo
  CC       ell/hwdb.lo
  CC       ell/cipher.lo
  CC       ell/random.lo
  CC       ell/uintset.lo
  CC       ell/base64.lo
  CC       ell/pem.lo
  CC       ell/tls.lo
  CC       ell/tls-record.lo
  CC       ell/tls-suites.lo
  CC       ell/tls-extensions.lo
  CC       ell/uuid.lo
  CC       ell/key.lo
  CC       ell/file.lo
  CC       ell/dir.lo
  CC       ell/net.lo
  CC       ell/dhcp.lo
  CC       ell/dhcp-transport.lo
  CC       ell/dhcp-lease.lo
  CC       ell/dhcp-util.lo
  CC       ell/dhcp-server.lo
  CC       ell/cert.lo
  CC       ell/cert-crypto.lo
  CC       ell/ecc-external.lo
  CC       ell/ecc.lo
  CC       ell/ecdh.lo
  CC       ell/time.lo
  CC       ell/path.lo
  CC       ell/dhcp6.lo
  CC       ell/icmp6.lo
  CC       ell/dhcp6-lease.lo
  CC       ell/dhcp6-transport.lo
  CC       ell/acd.lo
  CC       ell/netconfig.lo
  CC       monitor/main.o
  CC       monitor/nlmon.o
  CC       monitor/pcap.o
  CC       monitor/display.o
  CC       tools/hwsim.o
  CC       wired/main.o
  CC       wired/ethdev.o
  CC       wired/network.o
  CC       wired/dbus.o
  CCLD     ell/libell-internal.la
  CCLD     client/iwctl
  CCLD     src/iwd
  CCLD     wired/ead
/usr/bin/ld: client/command.o: in function `command_completion':
command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
/usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
/usr/bin/ld: client/display.o: in function `save_input':
display.c:(.text+0x32): undefined reference to `rl_copy_text'
/usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
/usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_text':
display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
/usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_completion_matches':
display.c:(.text+0x834): undefined reference to `rl_copy_text'
/usr/bin/ld: client/display.o: in function `timeout_callback':
display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
/usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_table_footer':
display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
/usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
/usr/bin/ld: display.c:(.text+0x1698): undefined reference to `rl_restore_prompt'
/usr/bin/ld: client/display.o: in function `display_agent_prompt':
display.c:(.text+0x177d): undefined reference to `rl_copy_text'
/usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
/usr/bin/ld: display.c:(.text+0x17a5): undefined reference to `rl_erase_empty_line'
/usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
display.c:(.text+0x1889): undefined reference to `rl_copy_text'
/usr/bin/ld: display.c:(.text+0x18cd): undefined reference to `rl_erase_empty_line'
/usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_init':
display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:1895: client/iwctl] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1595: all] Error 2
=======> ERROR: Building '/usr/ports/perso/iwd/iwd1682155677x86_64.cards.tar.xz' failed.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-23  2:32   ` James Prestwood
  2023-04-24  7:39     ` Marcel Holtmann
@ 2023-04-24 10:14     ` Marcel Holtmann
  2023-04-25 21:46       ` James Prestwood
  1 sibling, 1 reply; 16+ messages in thread
From: Marcel Holtmann @ 2023-04-24 10:14 UTC (permalink / raw)
  To: James Prestwood; +Cc: daniel antoine, iwd

Hi James,

>>> I have tried to build iwd to the last commit "Allow building with
>>> libedit instead readline". The Pkgfile seems to need the option
>>> --enable-libedit to remove readline but it fails with
>>>  CC       wired/dbus.o
>>>  CCLD     ell/libell-internal.la
>>>  CCLD     client/iwctl
>>>  CCLD     src/iwd
>>>  CCLD     wired/ead
>>> /usr/bin/ld: client/command.o: in function `command_completion':
>>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: client/display.o: in function `save_input':
>>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
>>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_text':
>>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
>>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
>>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: client/display.o: in function `timeout_callback':
>>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
>>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_table_footer':
>>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
>>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
>>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
>>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
>>> `rl_restore_prompt'
>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
>>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
>>> `rl_erase_empty_line'
>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
>>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
>>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
>>> `rl_erase_empty_line'
>>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
>>> /usr/bin/ld: client/display.o: in function `display_init':
>>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
>>> collect2: error: ld returned 1 exit status
>>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [Makefile:1595: all] Error 2
>>> =======> ERROR: Building
>>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
>>> 
>>> It looks like some readline commands are always taken in count
>>> 
>>> I have my Pkgfile and the compilation log
>> It does build for me just fine. What distro is this?
>> What does pkg-config --cflags --libs libedit show?
> 
> I'm seeing the same build problem, Ubuntu 20.04:
> 
> $ pkg-config --cflags --libs libedit
> -I/usr/include/editline -ledit

so Ubuntu seems to have libeditreadline-dev and maybe it has
Its own pkg-config file for a library with the rl_ symbols.

Regards

Marcel


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-24  8:19   ` daniel antoine
@ 2023-04-24 16:00     ` daniel antoine
  2023-04-24 17:21       ` Marcel Holtmann
  0 siblings, 1 reply; 16+ messages in thread
From: daniel antoine @ 2023-04-24 16:00 UTC (permalink / raw)
  To: marcel, iwd, James Prestwood

[-- Attachment #1: Type: text/plain, Size: 7026 bytes --]

Hi gents
Sorry to send the same mail but I have been clumsy with the mailing list.

The distribution is Grat-OS, a fork of Nutyx based on Linux from
Scratch. Nutyx is on SysVinit, Grat-OS is on Systemd. It's an
"unofficial" distribution.
I compile the package in a chroot environment

******************************
Chroot path: /mnt/hd
******************************
root@grat-os1:/# cards search pkg-config
(base) pkg-config 0.29.2 A system for managing library compile/link flags.
(base) pkg-config.doc 0.29.2 A system for managing library compile/link flags.
(base) pkg-config.man 0.29.2 A system for managing library compile/link flags.

root@grat-os1:/# pkg-config --cflags --libs libedit
-I/usr/include/editline -ledit

to add some information the first try i cloned the iwd git at the
lastThe distribution is Great-OS, a fork of Nutyx based on Linux from

Scratch. Nutyx is on SysVinit, Grat-OS is on Systemd. It's an
"unofficial" distribution.
I compile the package in a chroot environment

******************************
Chroot path: /mnt/hd
******************************
root@grat-os1:/# cards search pkg-config
(base) pkg-config 0.29.2 A system for managing library compile/link flags.
(base) pkg-config.doc 0.29.2 A system for managing library compile/link flags.
(base) pkg-config.man 0.29.2 A system for managing library compile/link flags.
root@grat-os1:/# pkg-config --cflags --libs libedit
-I/usr/include/editline -ledit

to add some information the first try i cloned the iwd git at the last
commit with readline in the makedepends. The option --enable--libedit
was not added in the Pkgfile. The build failed with an error that the
readline dependency was needed. I added the first log iwd.error.txt
After I have done a second try with the option --enable-libedit and
the dependency readline removed. The log is iwd.error 2.txt

Best regards

Daniel

commit with readline in the makedepends. The option --enable--libedit
was not added in the Pkgfile. The build failed with an error that the
readline dependency was needed. I added the first log iwd.error.txt
After I have done a second try with the option --enable-libedit and
the dependency readline removed. The log is iwd.error 2.txt

Best regards

Daniel

Le lun. 24 avr. 2023 à 10:19, daniel antoine <univac55@gmail.com> a écrit :
>
> Hi Marcel
>
> The distribution is Great-OS, a fork of Nutyx based on Linux from
> Scratch. Nutyx is on SysVinit, Grat-OS is on Systemd. It's an
> "unofficial" distribution.
> I compile the package in a chroot environment
>
> ******************************
> Chroot path: /mnt/hd
> ******************************
> root@grat-os1:/# cards search pkg-config
> (base) pkg-config 0.29.2 A system for managing library compile/link flags.
> (base) pkg-config.doc 0.29.2 A system for managing library compile/link flags.
> (base) pkg-config.man 0.29.2 A system for managing library compile/link flags.
> root@grat-os1:/# pkg-config --cflags --libs libedit
> -I/usr/include/editline -ledit
>
> to add some information the first try i cloned the iwd git at the last
> commit with readline in the makedepends. The option --enable--libedit
> was not added in the Pkgfile. The build failed with an error that the
> readline dependency was needed. I added the first log iwd.error.txt
> After I have done a second try with the option --enable-libedit and
> the dependency readline removed. The log is iwd.error 2.txt
>
> Best regards
>
> Daniel
>
>
> Daniel
>
> Le lun. 24 avr. 2023 à 07:46, Daniel Wagner <wagi@monom.org> a écrit :
> >
> > Add iwd mailing list
> >
> > On Sat, Apr 22, 2023 at 05:03:00PM +0200, daniel antoine wrote:
> > > I have tried to build iwd to the last commit "Allow building with
> > > libedit instead readline". The Pkgfile seems to need the option
> > > --enable-libedit to remove readline but it fails with
> > >   CC       wired/dbus.o
> > >   CCLD     ell/libell-internal.la
> > >   CCLD     client/iwctl
> > >   CCLD     src/iwd
> > >   CCLD     wired/ead
> > > /usr/bin/ld: client/command.o: in function `command_completion':
> > > command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
> > > /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
> > > /usr/bin/ld: client/display.o: in function `save_input':
> > > display.c:(.text+0x32): undefined reference to `rl_copy_text'
> > > /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
> > > /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
> > > /usr/bin/ld: client/display.o: in function `display_text':
> > > display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
> > > /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
> > > /usr/bin/ld: client/display.o: in function `display_completion_matches':
> > > display.c:(.text+0x834): undefined reference to `rl_copy_text'
> > > /usr/bin/ld: client/display.o: in function `timeout_callback':
> > > display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
> > > /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
> > > /usr/bin/ld: client/display.o: in function `display_table_footer':
> > > display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
> > > /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
> > > /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
> > > display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
> > > /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
> > > `rl_restore_prompt'
> > > /usr/bin/ld: client/display.o: in function `display_agent_prompt':
> > > display.c:(.text+0x177d): undefined reference to `rl_copy_text'
> > > /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
> > > /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
> > > `rl_erase_empty_line'
> > > /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
> > > display.c:(.text+0x1889): undefined reference to `rl_copy_text'
> > > /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
> > > `rl_erase_empty_line'
> > > /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
> > > /usr/bin/ld: client/display.o: in function `display_init':
> > > display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
> > > collect2: error: ld returned 1 exit status
> > > make[1]: *** [Makefile:1895: client/iwctl] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1595: all] Error 2
> > > =======> ERROR: Building
> > > '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
> > >
> > > It looks like some readline commands are always taken in count
> > >
> > > I have my Pkgfile and the compilation log
> > >
> > >
> > > best regards
> > > Dania
> >
> >
> >

[-- Attachment #2: iwd.error.txt --]
[-- Type: text/plain, Size: 8400 bytes --]

cards create: /usr/ports/perso/iwd package(s) starting build Sat Apr 22 09:12:00 2023

=======> PKGMK_INSTALL: no
=======> PKGMK_WORK_DIR: /tmp/work
=======> PKGMK_SOURCE_DIR: /tmp
=======> WARNING: CLEAN IGNORED
=======> PKGMK_IGNORE_REPO: no
=======> PKGMK_UPDATE_REPO: 
=======> PKGMK_IGNORE_FOOTPRINT: yes
=======> PKGMK_IGNORE_MD5SUM: yes
=======> PKGMK_COMPRESS_PACKAGE: yes
=======> PKGMK_COMPRESSION_MODE: xz
=======> name: iwd
=======> version: 2.4
=======> release: 1
=======> Building starting...
+ prepare
+ git clone https://git.kernel.org/pub/scm/libs/ell/ell.git ell
Cloning into 'ell'...
+ cd ell
+ git checkout fc2ea65818a797166c3528fe8c5d36fd7021b311
Note: switching to 'fc2ea65818a797166c3528fe8c5d36fd7021b311'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at fc2ea65 build: Have clang warn about zero-length array use
+ cd ..
+ git clone https://git.kernel.org/pub/scm/network/wireless/iwd.git iwd
Cloning into 'iwd'...
+ cd iwd
+ git checkout 8f0420c533ae6a49c4f2803afe32d5922a5236ad
Note: switching to '8f0420c533ae6a49c4f2803afe32d5922a5236ad'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8f0420c5 build: Allow building with libedit instead readline
+ autoreconf -fiv
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I build-aux
aclocal: warning: couldn't open directory 'build-aux': No such file or directory
autoreconf: configure.ac: tracing
autoreconf: configure.ac: creating directory build-aux
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux'.
libtoolize: copying file 'build-aux/libtool.m4'
libtoolize: copying file 'build-aux/ltoptions.m4'
libtoolize: copying file 'build-aux/ltsugar.m4'
libtoolize: copying file 'build-aux/ltversion.m4'
libtoolize: copying file 'build-aux/lt~obsolete.m4'
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force -I build-aux
autoreconf: running: /usr/bin/autoconf --force
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:23: installing 'build-aux/compile'
configure.ac:35: installing 'build-aux/config.guess'
configure.ac:35: installing 'build-aux/config.sub'
configure.ac:8: installing 'build-aux/install-sh'
configure.ac:8: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
autoreconf: Leaving directory '.'
+ build
+ cd iwd
+ ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libexecdir=/usr/lib/iwd --enable-wired --enable-ofono --enable-hwsim --disable-tools
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking how to create a pax tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of gcc... gcc3
checking whether gcc accepts -fPIE... yes
checking whether gcc accepts -fsanitize=address... yes
checking whether gcc accepts -fsanitize=leak... yes
checking whether gcc accepts -fsanitize=undefined... yes
checking whether ln -s works... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for file... file
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for mt... mt
checking if mt is a manifest tool... no
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for _init in -lasan... yes
checking for _init in -llsan... yes
checking for _init in -lubsan... yes
checking for explicit_bzero... yes
checking for rawmemchr... yes
checking for reallocarray... yes
checking for linux/types.h... yes
checking for linux/if_alg.h... yes
checking for readline... no
configure: error: Readline library is required
=======> ERROR: Building '/usr/ports/perso/iwd/iwd1682154720x86_64.cards.tar.xz' failed.

[-- Attachment #3: iwd.error2.txt --]
[-- Type: text/plain, Size: 15983 bytes --]

cards create: /usr/ports/perso/iwd package(s) starting build Sat Apr 22 09:27:57 2023

=======> PKGMK_INSTALL: no
=======> PKGMK_WORK_DIR: /tmp/work
=======> PKGMK_SOURCE_DIR: /tmp
=======> WARNING: CLEAN IGNORED
=======> PKGMK_IGNORE_REPO: no
=======> PKGMK_UPDATE_REPO: 
=======> PKGMK_IGNORE_FOOTPRINT: yes
=======> PKGMK_IGNORE_MD5SUM: yes
=======> PKGMK_COMPRESS_PACKAGE: yes
=======> PKGMK_COMPRESSION_MODE: xz
=======> name: iwd
=======> version: 2.4
=======> release: 1
=======> Building starting...
+ prepare
+ git clone https://git.kernel.org/pub/scm/libs/ell/ell.git ell
Cloning into 'ell'...
+ cd ell
+ git checkout fc2ea65818a797166c3528fe8c5d36fd7021b311
Note: switching to 'fc2ea65818a797166c3528fe8c5d36fd7021b311'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at fc2ea65 build: Have clang warn about zero-length array use
+ cd ..
+ git clone https://git.kernel.org/pub/scm/network/wireless/iwd.git iwd
Cloning into 'iwd'...
+ cd iwd
+ git checkout 8f0420c533ae6a49c4f2803afe32d5922a5236ad
Note: switching to '8f0420c533ae6a49c4f2803afe32d5922a5236ad'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8f0420c5 build: Allow building with libedit instead readline
+ autoreconf -fiv
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I build-aux
aclocal: warning: couldn't open directory 'build-aux': No such file or directory
autoreconf: configure.ac: tracing
autoreconf: configure.ac: creating directory build-aux
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux'.
libtoolize: copying file 'build-aux/libtool.m4'
libtoolize: copying file 'build-aux/ltoptions.m4'
libtoolize: copying file 'build-aux/ltsugar.m4'
libtoolize: copying file 'build-aux/ltversion.m4'
libtoolize: copying file 'build-aux/lt~obsolete.m4'
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force -I build-aux
autoreconf: running: /usr/bin/autoconf --force
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:23: installing 'build-aux/compile'
configure.ac:35: installing 'build-aux/config.guess'
configure.ac:35: installing 'build-aux/config.sub'
configure.ac:8: installing 'build-aux/install-sh'
configure.ac:8: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
autoreconf: Leaving directory '.'
+ build
+ cd iwd
+ ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libexecdir=/usr/lib/iwd --enable-wired --enable-ofono --enable-hwsim --enable-libedit --disable-tools
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking how to create a pax tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of gcc... gcc3
checking whether gcc accepts -fPIE... yes
checking whether gcc accepts -fsanitize=address... yes
checking whether gcc accepts -fsanitize=leak... yes
checking whether gcc accepts -fsanitize=undefined... yes
checking whether ln -s works... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for file... file
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for mt... mt
checking if mt is a manifest tool... no
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for _init in -lasan... yes
checking for _init in -llsan... yes
checking for _init in -lubsan... yes
checking for explicit_bzero... yes
checking for rawmemchr... yes
checking for reallocarray... yes
checking for linux/types.h... yes
checking for linux/if_alg.h... yes
checking for libedit... yes
checking D-Bus data directory... /usr/share
checking for rst2man... rst2man
checking D-Bus bus services directory... /usr/share/dbus-1/system-services
checking systemd unit directory... /lib/systemd/system
checking systemd network directory... /lib/systemd/network
checking systemd modules load directory... /lib/modules-load.d
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands

	iwd 2.4

+ make
  GEN      ell/shared
  GEN      ell/internal
  GEN      src/builtin.h
  GEN      ell/ell.h
make --no-print-directory all-am
  CC       src/ie.o
  CC       src/wscutil.o
  CC       src/mpdu.o
  CC       src/crypto.o
  CC       src/watchlist.o
  CC       src/eapolutil.o
  CC       src/nl80211cmd.o
  CC       src/p2putil.o
  CC       src/anqputil.o
  CC       src/nl80211util.o
  CC       src/storage.o
  CC       src/common.o
  CC       src/main.o
  CC       src/netdev.o
  CC       src/wiphy.o
  CC       src/device.o
  CC       src/station.o
  CC       src/dbus.o
  CC       src/eapol.o
  CC       src/handshake.o
  CC       src/scan.o
  CC       src/agent.o
  CC       src/network.o
  CC       src/wsc.o
  CC       src/backtrace.o
  CC       src/knownnetworks.o
  CC       src/rfkill.o
  CC       src/ft.o
  CC       src/ap.o
  CC       src/adhoc.o
  CC       src/sae.o
  CC       src/owe.o
  CC       src/blacklist.o
  CC       src/manager.o
  CC       src/erp.o
  CC       src/fils.o
  CC       src/anqp.o
  CC       src/netconfig.o
  CC       src/netconfig-commit.o
  CC       src/resolve.o
  CC       src/hotspot.o
  CC       src/p2p.o
  CC       src/module.o
  CC       src/rrm.o
  CC       src/frame-xchg.o
  CC       src/eap-wsc.o
  CC       src/diagnostic.o
  CC       src/ip-pool.o
  CC       src/sysfs.o
  CC       src/offchannel.o
  CC       src/dpp-util.o
  CC       src/json.o
  CC       src/dpp.o
  CC       src/eap.o
  CC       src/eap-md5.o
  CC       src/eap-tls.o
  CC       src/eap-ttls.o
  CC       src/eap-mschapv2.o
  CC       src/eap-sim.o
  CC       src/eap-aka.o
  CC       src/eap-peap.o
  CC       src/eap-gtc.o
  CC       src/eap-pwd.o
  CC       src/simutil.o
  CC       src/simauth.o
  CC       src/eap-tls-common.o
  CC       src/mschaputil.o
  CC       src/ofono.o
  GEN      src/iwd.service
  GEN      wired/ead.service
  CC       tools/probe-req.o
  CC       tools/iwd-decrypt-profile.o
  GEN      src/iwd.8
  GEN      src/iwd.debug.7
  GEN      src/iwd.config.5
  GEN      src/iwd.network.5
  GEN      src/iwd.ap.5
  GEN      client/iwctl.1
  GEN      monitor/iwmon.1
  GEN      wired/ead.8
  GEN      tools/hwsim.1
  CC       client/main.o
  CC       client/adapter.o
  CC       client/agent.o
  CC       client/agent-manager.o
  CC       client/ad-hoc.o
  CC       client/ap.o
  CC       client/command.o
  CC       client/dbus-proxy.o
  CC       client/device.o
  CC       client/display.o
  CC       client/known-networks.o
  CC       client/network.o
  CC       client/properties.o
  CC       client/wsc.o
  CC       client/station.o
  CC       client/diagnostic.o
  CC       client/daemon.o
  CC       client/dpp.o
  CC       client/station-debug.o
  CC       src/util.o
  CC       src/band.o
  CC       ell/util.lo
  CC       ell/test.lo
  CC       ell/strv.lo
  CC       ell/utf8.lo
  CC       ell/queue.lo
  CC       ell/hashmap.lo
  CC       ell/string.lo
  CC       ell/settings.lo
  CC       ell/main.lo
  CC       ell/idle.lo
  CC       ell/signal.lo
  CC       ell/timeout.lo
  CC       ell/io.lo
  CC       ell/ringbuf.lo
  CC       ell/log.lo
  CC       ell/checksum.lo
  CC       ell/netlink.lo
  CC       ell/genl.lo
  CC       ell/rtnl.lo
  CC       ell/dbus.lo
  CC       ell/dbus-message.lo
  CC       ell/dbus-util.lo
  CC       ell/dbus-service.lo
  CC       ell/dbus-client.lo
  CC       ell/dbus-name-cache.lo
  CC       ell/dbus-filter.lo
  CC       ell/gvariant-util.lo
  CC       ell/siphash.lo
  CC       ell/hwdb.lo
  CC       ell/cipher.lo
  CC       ell/random.lo
  CC       ell/uintset.lo
  CC       ell/base64.lo
  CC       ell/pem.lo
  CC       ell/tls.lo
  CC       ell/tls-record.lo
  CC       ell/tls-suites.lo
  CC       ell/tls-extensions.lo
  CC       ell/uuid.lo
  CC       ell/key.lo
  CC       ell/file.lo
  CC       ell/dir.lo
  CC       ell/net.lo
  CC       ell/dhcp.lo
  CC       ell/dhcp-transport.lo
  CC       ell/dhcp-lease.lo
  CC       ell/dhcp-util.lo
  CC       ell/dhcp-server.lo
  CC       ell/cert.lo
  CC       ell/cert-crypto.lo
  CC       ell/ecc-external.lo
  CC       ell/ecc.lo
  CC       ell/ecdh.lo
  CC       ell/time.lo
  CC       ell/path.lo
  CC       ell/dhcp6.lo
  CC       ell/icmp6.lo
  CC       ell/dhcp6-lease.lo
  CC       ell/dhcp6-transport.lo
  CC       ell/acd.lo
  CC       ell/netconfig.lo
  CC       monitor/main.o
  CC       monitor/nlmon.o
  CC       monitor/pcap.o
  CC       monitor/display.o
  CC       tools/hwsim.o
  CC       wired/main.o
  CC       wired/ethdev.o
  CC       wired/network.o
  CC       wired/dbus.o
  CCLD     ell/libell-internal.la
  CCLD     client/iwctl
  CCLD     src/iwd
  CCLD     wired/ead
/usr/bin/ld: client/command.o: in function `command_completion':
command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
/usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
/usr/bin/ld: client/display.o: in function `save_input':
display.c:(.text+0x32): undefined reference to `rl_copy_text'
/usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
/usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_text':
display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
/usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_completion_matches':
display.c:(.text+0x834): undefined reference to `rl_copy_text'
/usr/bin/ld: client/display.o: in function `timeout_callback':
display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
/usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_table_footer':
display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
/usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
/usr/bin/ld: display.c:(.text+0x1698): undefined reference to `rl_restore_prompt'
/usr/bin/ld: client/display.o: in function `display_agent_prompt':
display.c:(.text+0x177d): undefined reference to `rl_copy_text'
/usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
/usr/bin/ld: display.c:(.text+0x17a5): undefined reference to `rl_erase_empty_line'
/usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
display.c:(.text+0x1889): undefined reference to `rl_copy_text'
/usr/bin/ld: display.c:(.text+0x18cd): undefined reference to `rl_erase_empty_line'
/usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
/usr/bin/ld: client/display.o: in function `display_init':
display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:1895: client/iwctl] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1595: all] Error 2
=======> ERROR: Building '/usr/ports/perso/iwd/iwd1682155677x86_64.cards.tar.xz' failed.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-24 16:00     ` daniel antoine
@ 2023-04-24 17:21       ` Marcel Holtmann
  0 siblings, 0 replies; 16+ messages in thread
From: Marcel Holtmann @ 2023-04-24 17:21 UTC (permalink / raw)
  To: daniel antoine; +Cc: iwd, James Prestwood

Hi Daniel,

> Sorry to send the same mail but I have been clumsy with the mailing list.
> 
> The distribution is Grat-OS, a fork of Nutyx based on Linux from
> Scratch. Nutyx is on SysVinit, Grat-OS is on Systemd. It's an
> "unofficial" distribution.
> I compile the package in a chroot environment
> 
> ******************************
> Chroot path: /mnt/hd
> ******************************
> root@grat-os1:/# cards search pkg-config
> (base) pkg-config 0.29.2 A system for managing library compile/link flags.
> (base) pkg-config.doc 0.29.2 A system for managing library compile/link flags.
> (base) pkg-config.man 0.29.2 A system for managing library compile/link flags.
> 
> root@grat-os1:/# pkg-config --cflags --libs libedit
> -I/usr/include/editline -ledit
> 
> to add some information the first try i cloned the iwd git at the
> lastThe distribution is Great-OS, a fork of Nutyx based on Linux from
> 
> Scratch. Nutyx is on SysVinit, Grat-OS is on Systemd. It's an
> "unofficial" distribution.
> I compile the package in a chroot environment
> 
> ******************************
> Chroot path: /mnt/hd
> ******************************
> root@grat-os1:/# cards search pkg-config
> (base) pkg-config 0.29.2 A system for managing library compile/link flags.
> (base) pkg-config.doc 0.29.2 A system for managing library compile/link flags.
> (base) pkg-config.man 0.29.2 A system for managing library compile/link flags.
> root@grat-os1:/# pkg-config --cflags --libs libedit
> -I/usr/include/editline -ledit
> 
> to add some information the first try i cloned the iwd git at the last
> commit with readline in the makedepends. The option --enable--libedit
> was not added in the Pkgfile. The build failed with an error that the
> readline dependency was needed. I added the first log iwd.error.txt
> After I have done a second try with the option --enable-libedit and
> the dependency readline removed. The log is iwd.error 2.txt
> 
> Best regards
> 
> Daniel
> 
> commit with readline in the makedepends. The option --enable--libedit
> was not added in the Pkgfile. The build failed with an error that the
> readline dependency was needed. I added the first log iwd.error.txt
> After I have done a second try with the option --enable-libedit and
> the dependency readline removed. The log is iwd.error 2.txt

since Debian shows this:

# apt-get install libeditreadline-dev
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  libbsd-dev libedit-dev libmd-dev
The following packages will be REMOVED:
  libreadline-dev
The following NEW packages will be installed:
  libbsd-dev libedit-dev libeditreadline-dev libmd-dev
0 upgraded, 4 newly installed, 1 to remove and 0 not upgraded.
Need to get 419 kB of archives.
After this operation, 766 kB of additional disk space will be used.

I have the feeling that they are being stupid and do some funky tricks
between and libedit and libedit with Readline rl_* exports. You need
to have a look what is on your system.

If you install libeditreadline-dev, then use --disable-libedit and let
it look for Readline. My guess is pkg-config --libs --cflags readline
will then give you the libedit version.

Regards

Marcel


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-24 10:14     ` Marcel Holtmann
@ 2023-04-25 21:46       ` James Prestwood
  2023-04-26 10:14         ` daniel antoine
  0 siblings, 1 reply; 16+ messages in thread
From: James Prestwood @ 2023-04-25 21:46 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: daniel antoine, iwd

Hi Marcel,

On 4/24/23 3:14 AM, Marcel Holtmann wrote:
> Hi James,
> 
>>>> I have tried to build iwd to the last commit "Allow building with
>>>> libedit instead readline". The Pkgfile seems to need the option
>>>> --enable-libedit to remove readline but it fails with
>>>>   CC       wired/dbus.o
>>>>   CCLD     ell/libell-internal.la
>>>>   CCLD     client/iwctl
>>>>   CCLD     src/iwd
>>>>   CCLD     wired/ead
>>>> /usr/bin/ld: client/command.o: in function `command_completion':
>>>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
>>>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
>>>> /usr/bin/ld: client/display.o: in function `save_input':
>>>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
>>>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
>>>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
>>>> /usr/bin/ld: client/display.o: in function `display_text':
>>>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
>>>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
>>>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
>>>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
>>>> /usr/bin/ld: client/display.o: in function `timeout_callback':
>>>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
>>>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
>>>> /usr/bin/ld: client/display.o: in function `display_table_footer':
>>>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
>>>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
>>>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
>>>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
>>>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
>>>> `rl_restore_prompt'
>>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
>>>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
>>>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
>>>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
>>>> `rl_erase_empty_line'
>>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
>>>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
>>>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
>>>> `rl_erase_empty_line'
>>>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
>>>> /usr/bin/ld: client/display.o: in function `display_init':
>>>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
>>>> collect2: error: ld returned 1 exit status
>>>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
>>>> make[1]: *** Waiting for unfinished jobs....
>>>> make: *** [Makefile:1595: all] Error 2
>>>> =======> ERROR: Building
>>>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
>>>>
>>>> It looks like some readline commands are always taken in count
>>>>
>>>> I have my Pkgfile and the compilation log
>>> It does build for me just fine. What distro is this?
>>> What does pkg-config --cflags --libs libedit show?
>>
>> I'm seeing the same build problem, Ubuntu 20.04:
>>
>> $ pkg-config --cflags --libs libedit
>> -I/usr/include/editline -ledit
> 
> so Ubuntu seems to have libeditreadline-dev and maybe it has
> Its own pkg-config file for a library with the rl_ symbols.

I see that Debian package, but Ubuntu doesn't have it (or my Ubuntu 
distro doesn't). It does have libedit-dev which is what I installed. It 
appears the libedit package just doesn't include ALL the rl_* symbols 
that iwctl uses:

jprestwood@LOCLAP699:~/iwd$ objdump -TC 
/lib/x86_64-linux-gnu/libedit.so.2 | grep rl_ | cut -d' ' -f17
rl_getc_function
rl_pre_input_hook
rl_inhibit_completion
rl_readline_name
rl_redisplay
rl_deprep_terminal
rl_completer_quote_characters
rl_completer_word_break_characters
rl_filename_completion_desired
rl_prep_terminal
rl_free_line_state
rl_set_keymap
rl_newline
rl_resize_terminal
rl_callback_handler_remove
_rl_qsort_string_compare
rl_completion_word_break_hook
rl_instream
rl_basic_word_break_characters
rl_forced_update_display
rl_readline_version
rl_kill_text
rl_startup_hook
rl_set_screen_size
rl_point
rl_special_prefixes
rl_startup1_hook
rl_get_previous_history
rl_stuff_char
rl_completion_entry_function
rl_completion_display_matches_hook
rl_did_startup_hook
rl_generic_bind
rl_set_keyboard_input_timeout
rl_event_hook
rl_callback_handler_install
rl_parse_and_bind
rl_line_buffer
rl_linefunc
rl_variable_bind
rl_terminal_name
rl_deprep_term_function
rl_on_new_line
rl_done
rl_redisplay_function
rl_prep_term_function
rl_outstream
rl_end
rl_read_key
rl_catch_sigwinch
rl_catch_signals
rl_insert
rl_completion_append_character
rl_attempted_completion_over
rl_reset_after_signal
rl_completion_query_items
rl_reset_terminal
rl_library_version
rl_already_prompted
rl_bind_key
rl_completion_matches
rl_callback_read_char
rl_set_prompt
rl_get_screen_size
rl_cleanup_after_signal
rl_bind_key_in_map
rl_make_bare_keymap
rl_prompt
rl_read_init_file
rl_insert_text
rl_add_defun
_rl_print_completions_horizontally
rl_echo_signal_char
rl_display_match_list
rl_ignore_completion_duplicates
rl_filename_completion_function
rl_completion_type
rl_attempted_completion_function
rl_get_keymap
rl_initialize
_rl_abort_internal
rl_complete

Why this would be different on Fedora is beyond me, very weird.

Thanks,
James

> 
> Regards
> 
> Marcel
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-25 21:46       ` James Prestwood
@ 2023-04-26 10:14         ` daniel antoine
  2023-04-26 12:36           ` daniel antoine
  0 siblings, 1 reply; 16+ messages in thread
From: daniel antoine @ 2023-04-26 10:14 UTC (permalink / raw)
  To: James Prestwood; +Cc: Marcel Holtmann, iwd

Hi James, Hi Marcel

I got this in my chroot
Chroot path: /mnt/hd
******************************
root@grat-os1:/# cards search libedit
(base) libedit 20210910-3.1 Command line editor library providing
generic line editing, history, and tokenization functions.
(base) libedit.devel 20210910-3.1 Command line editor library
providing generic line editing, history, and tokenization functions.
(base) libedit.man 20210910-3.1 Command line editor library providing
generic line editing, history, and tokenization functions.

root@grat-os1:/# find / -name libedit.so*
/usr/lib/libedit.so
/usr/lib/libedit.so.0
/usr/lib/libedit.so.0.0.68

root@grat-os1:/# objdump -TC /usr/lib/libedit.so | grep rl_ | cut -d' ' -f17
rl_sort_completion_matches
rl_completion_query_items
rl_resize_terminal
rl_parse_and_bind
rl_deprep_terminal
rl_basic_word_break_characters
rl_pre_input_hook
rl_set_keyboard_input_timeout
rl_startup1_hook
rl_completer_word_break_characters
rl_initialize
rl_directory_completion_hook
rl_add_defun
rl_readline_version
rl_free_line_state
rl_attempted_completion_over
rl_basic_quote_characters
_rl_echoing_p
rl_prep_terminal
rl_outstream
rl_already_prompted
rl_line_buffer
rl_completion_word_break_hook
rl_abort
rl_redisplay
_rl_abort_internal
rl_echo_signal_char
rl_display_match_list
rl_ignore_completion_duplicates
rl_on_new_line
_rl_complete_mark_directories
rl_instream
rl_completion_matches
rl_bind_key_in_map
rl_generic_bind
rl_deprep_term_function
rl_filename_completion_desired
rl_forced_update_display
rl_completion_type
rl_insert
rl_inhibit_completion
rl_reset_after_signal
rl_set_screen_size
_rl_qsort_string_compare
rl_point
rl_make_bare_keymap
rl_newline
rl_get_keymap
rl_library_version
rl_startup_hook
_rl_completion_prefix_display_length
rl_event_hook
rl_callback_read_char
rl_getc_function
rl_display_prompt
rl_crlf
rl_set_keymap
rl_ding
rl_bind_key
rl_completion_append_character
rl_catch_sigwinch
rl_insert_text
rl_variable_bind
rl_get_screen_size
rl_read_init_file
rl_redisplay_function
rl_completer_quote_characters
_rl_print_completions_horizontally
_rl_erase_entire_line
rl_readline_state
rl_callback_handler_install
rl_cleanup_after_signal
rl_catch_signals
rl_terminal_name
rl_set_prompt
rl_done
rl_filename_completion_function
rl_readline_name
rl_completion_entry_function
rl_complete
rl_special_prefixes
rl_linefunc
rl_set_keymap_name
rl_get_previous_history
rl_attempted_completion_function
rl_kill_text
rl_read_key
rl_reset_terminal
rl_stuff_char
rl_completion_display_matches_hook
rl_end
rl_prep_term_function
rl_callback_handler_remove
rl_completion_suppress_append
rl_prompt
root@grat-os1:/#

Is my version of libedit too old --> 20221030-3.1 ?

Best regards

Daniel

Le mar. 25 avr. 2023 à 23:46, James Prestwood <prestwoj@gmail.com> a écrit :
>
> Hi Marcel,
>
> On 4/24/23 3:14 AM, Marcel Holtmann wrote:
> > Hi James,
> >
> >>>> I have tried to build iwd to the last commit "Allow building with
> >>>> libedit instead readline". The Pkgfile seems to need the option
> >>>> --enable-libedit to remove readline but it fails with
> >>>>   CC       wired/dbus.o
> >>>>   CCLD     ell/libell-internal.la
> >>>>   CCLD     client/iwctl
> >>>>   CCLD     src/iwd
> >>>>   CCLD     wired/ead
> >>>> /usr/bin/ld: client/command.o: in function `command_completion':
> >>>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
> >>>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
> >>>> /usr/bin/ld: client/display.o: in function `save_input':
> >>>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
> >>>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
> >>>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
> >>>> /usr/bin/ld: client/display.o: in function `display_text':
> >>>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
> >>>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
> >>>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
> >>>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
> >>>> /usr/bin/ld: client/display.o: in function `timeout_callback':
> >>>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
> >>>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
> >>>> /usr/bin/ld: client/display.o: in function `display_table_footer':
> >>>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
> >>>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
> >>>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
> >>>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
> >>>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
> >>>> `rl_restore_prompt'
> >>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
> >>>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
> >>>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
> >>>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
> >>>> `rl_erase_empty_line'
> >>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
> >>>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
> >>>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
> >>>> `rl_erase_empty_line'
> >>>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
> >>>> /usr/bin/ld: client/display.o: in function `display_init':
> >>>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
> >>>> collect2: error: ld returned 1 exit status
> >>>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
> >>>> make[1]: *** Waiting for unfinished jobs....
> >>>> make: *** [Makefile:1595: all] Error 2
> >>>> =======> ERROR: Building
> >>>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
> >>>>
> >>>> It looks like some readline commands are always taken in count
> >>>>
> >>>> I have my Pkgfile and the compilation log
> >>> It does build for me just fine. What distro is this?
> >>> What does pkg-config --cflags --libs libedit show?
> >>
> >> I'm seeing the same build problem, Ubuntu 20.04:
> >>
> >> $ pkg-config --cflags --libs libedit
> >> -I/usr/include/editline -ledit
> >
> > so Ubuntu seems to have libeditreadline-dev and maybe it has
> > Its own pkg-config file for a library with the rl_ symbols.
>
> I see that Debian package, but Ubuntu doesn't have it (or my Ubuntu
> distro doesn't). It does have libedit-dev which is what I installed. It
> appears the libedit package just doesn't include ALL the rl_* symbols
> that iwctl uses:
>
> jprestwood@LOCLAP699:~/iwd$ objdump -TC
> /lib/x86_64-linux-gnu/libedit.so.2 | grep rl_ | cut -d' ' -f17
> rl_getc_function
> rl_pre_input_hook
> rl_inhibit_completion
> rl_readline_name
> rl_redisplay
> rl_deprep_terminal
> rl_completer_quote_characters
> rl_completer_word_break_characters
> rl_filename_completion_desired
> rl_prep_terminal
> rl_free_line_state
> rl_set_keymap
> rl_newline
> rl_resize_terminal
> rl_callback_handler_remove
> _rl_qsort_string_compare
> rl_completion_word_break_hook
> rl_instream
> rl_basic_word_break_characters
> rl_forced_update_display
> rl_readline_version
> rl_kill_text
> rl_startup_hook
> rl_set_screen_size
> rl_point
> rl_special_prefixes
> rl_startup1_hook
> rl_get_previous_history
> rl_stuff_char
> rl_completion_entry_function
> rl_completion_display_matches_hook
> rl_did_startup_hook
> rl_generic_bind
> rl_set_keyboard_input_timeout
> rl_event_hook
> rl_callback_handler_install
> rl_parse_and_bind
> rl_line_buffer
> rl_linefunc
> rl_variable_bind
> rl_terminal_name
> rl_deprep_term_function
> rl_on_new_line
> rl_done
> rl_redisplay_function
> rl_prep_term_function
> rl_outstream
> rl_end
> rl_read_key
> rl_catch_sigwinch
> rl_catch_signals
> rl_insert
> rl_completion_append_character
> rl_attempted_completion_over
> rl_reset_after_signal
> rl_completion_query_items
> rl_reset_terminal
> rl_library_version
> rl_already_prompted
> rl_bind_key
> rl_completion_matches
> rl_callback_read_char
> rl_set_prompt
> rl_get_screen_size
> rl_cleanup_after_signal
> rl_bind_key_in_map
> rl_make_bare_keymap
> rl_prompt
> rl_read_init_file
> rl_insert_text
> rl_add_defun
> _rl_print_completions_horizontally
> rl_echo_signal_char
> rl_display_match_list
> rl_ignore_completion_duplicates
> rl_filename_completion_function
> rl_completion_type
> rl_attempted_completion_function
> rl_get_keymap
> rl_initialize
> _rl_abort_internal
> rl_complete
>
> Why this would be different on Fedora is beyond me, very weird.
>
> Thanks,
> James
>
> >
> > Regards
> >
> > Marcel
> >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-26 10:14         ` daniel antoine
@ 2023-04-26 12:36           ` daniel antoine
  2023-04-27  9:37             ` daniel antoine
  0 siblings, 1 reply; 16+ messages in thread
From: daniel antoine @ 2023-04-26 12:36 UTC (permalink / raw)
  To: James Prestwood; +Cc: Marcel Holtmann, iwd

Hi gents

I suppose that my problem is here
http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/readline.c

Revision 1.169 / (download) - annotate - [select for diffs], Tue Jan
11 18:30:15 2022 UTC (15 months, 1 week ago) by christos
Branch: MAIN
Changes since 1.168: +70 -2 lines
Diff to previous 1.168 (colored)

PR/56618: Walter Lozano: Improve libedit compatibility with readline by
implementing:

    rl_copy_text, rl_erase_empty_line, rl_message, rl_on_new_line,
    rl_replace_line, rl_restore_prompt, rl_save_prompt

________________________________

the patch is 20221101 after libedit 20210910-3.1
I have also a debian (bullseye) system with libedit 20191231-3.1
without libedit-dev

I hope that if I have to compile on my LFS system it will not break it
,it's a base package

Best regards

Danial

Le mer. 26 avr. 2023 à 12:14, daniel antoine <univac55@gmail.com> a écrit :
>
> Hi James, Hi Marcel
>
> I got this in my chroot
> Chroot path: /mnt/hd
> ******************************
> root@grat-os1:/# cards search libedit
> (base) libedit 20210910-3.1 Command line editor library providing
> generic line editing, history, and tokenization functions.
> (base) libedit.devel 20210910-3.1 Command line editor library
> providing generic line editing, history, and tokenization functions.
> (base) libedit.man 20210910-3.1 Command line editor library providing
> generic line editing, history, and tokenization functions.
>
> root@grat-os1:/# find / -name libedit.so*
> /usr/lib/libedit.so
> /usr/lib/libedit.so.0
> /usr/lib/libedit.so.0.0.68
>
> root@grat-os1:/# objdump -TC /usr/lib/libedit.so | grep rl_ | cut -d' ' -f17
> rl_sort_completion_matches
> rl_completion_query_items
> rl_resize_terminal
> rl_parse_and_bind
> rl_deprep_terminal
> rl_basic_word_break_characters
> rl_pre_input_hook
> rl_set_keyboard_input_timeout
> rl_startup1_hook
> rl_completer_word_break_characters
> rl_initialize
> rl_directory_completion_hook
> rl_add_defun
> rl_readline_version
> rl_free_line_state
> rl_attempted_completion_over
> rl_basic_quote_characters
> _rl_echoing_p
> rl_prep_terminal
> rl_outstream
> rl_already_prompted
> rl_line_buffer
> rl_completion_word_break_hook
> rl_abort
> rl_redisplay
> _rl_abort_internal
> rl_echo_signal_char
> rl_display_match_list
> rl_ignore_completion_duplicates
> rl_on_new_line
> _rl_complete_mark_directories
> rl_instream
> rl_completion_matches
> rl_bind_key_in_map
> rl_generic_bind
> rl_deprep_term_function
> rl_filename_completion_desired
> rl_forced_update_display
> rl_completion_type
> rl_insert
> rl_inhibit_completion
> rl_reset_after_signal
> rl_set_screen_size
> _rl_qsort_string_compare
> rl_point
> rl_make_bare_keymap
> rl_newline
> rl_get_keymap
> rl_library_version
> rl_startup_hook
> _rl_completion_prefix_display_length
> rl_event_hook
> rl_callback_read_char
> rl_getc_function
> rl_display_prompt
> rl_crlf
> rl_set_keymap
> rl_ding
> rl_bind_key
> rl_completion_append_character
> rl_catch_sigwinch
> rl_insert_text
> rl_variable_bind
> rl_get_screen_size
> rl_read_init_file
> rl_redisplay_function
> rl_completer_quote_characters
> _rl_print_completions_horizontally
> _rl_erase_entire_line
> rl_readline_state
> rl_callback_handler_install
> rl_cleanup_after_signal
> rl_catch_signals
> rl_terminal_name
> rl_set_prompt
> rl_done
> rl_filename_completion_function
> rl_readline_name
> rl_completion_entry_function
> rl_complete
> rl_special_prefixes
> rl_linefunc
> rl_set_keymap_name
> rl_get_previous_history
> rl_attempted_completion_function
> rl_kill_text
> rl_read_key
> rl_reset_terminal
> rl_stuff_char
> rl_completion_display_matches_hook
> rl_end
> rl_prep_term_function
> rl_callback_handler_remove
> rl_completion_suppress_append
> rl_prompt
> root@grat-os1:/#
>
> Is my version of libedit too old --> 20221030-3.1 ?
>
> Best regards
>
> Daniel
>
> Le mar. 25 avr. 2023 à 23:46, James Prestwood <prestwoj@gmail.com> a écrit :
> >
> > Hi Marcel,
> >
> > On 4/24/23 3:14 AM, Marcel Holtmann wrote:
> > > Hi James,
> > >
> > >>>> I have tried to build iwd to the last commit "Allow building with
> > >>>> libedit instead readline". The Pkgfile seems to need the option
> > >>>> --enable-libedit to remove readline but it fails with
> > >>>>   CC       wired/dbus.o
> > >>>>   CCLD     ell/libell-internal.la
> > >>>>   CCLD     client/iwctl
> > >>>>   CCLD     src/iwd
> > >>>>   CCLD     wired/ead
> > >>>> /usr/bin/ld: client/command.o: in function `command_completion':
> > >>>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
> > >>>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
> > >>>> /usr/bin/ld: client/display.o: in function `save_input':
> > >>>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
> > >>>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
> > >>>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
> > >>>> /usr/bin/ld: client/display.o: in function `display_text':
> > >>>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
> > >>>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
> > >>>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
> > >>>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
> > >>>> /usr/bin/ld: client/display.o: in function `timeout_callback':
> > >>>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
> > >>>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
> > >>>> /usr/bin/ld: client/display.o: in function `display_table_footer':
> > >>>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
> > >>>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
> > >>>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
> > >>>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
> > >>>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
> > >>>> `rl_restore_prompt'
> > >>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
> > >>>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
> > >>>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
> > >>>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
> > >>>> `rl_erase_empty_line'
> > >>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
> > >>>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
> > >>>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
> > >>>> `rl_erase_empty_line'
> > >>>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
> > >>>> /usr/bin/ld: client/display.o: in function `display_init':
> > >>>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
> > >>>> collect2: error: ld returned 1 exit status
> > >>>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
> > >>>> make[1]: *** Waiting for unfinished jobs....
> > >>>> make: *** [Makefile:1595: all] Error 2
> > >>>> =======> ERROR: Building
> > >>>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
> > >>>>
> > >>>> It looks like some readline commands are always taken in count
> > >>>>
> > >>>> I have my Pkgfile and the compilation log
> > >>> It does build for me just fine. What distro is this?
> > >>> What does pkg-config --cflags --libs libedit show?
> > >>
> > >> I'm seeing the same build problem, Ubuntu 20.04:
> > >>
> > >> $ pkg-config --cflags --libs libedit
> > >> -I/usr/include/editline -ledit
> > >
> > > so Ubuntu seems to have libeditreadline-dev and maybe it has
> > > Its own pkg-config file for a library with the rl_ symbols.
> >
> > I see that Debian package, but Ubuntu doesn't have it (or my Ubuntu
> > distro doesn't). It does have libedit-dev which is what I installed. It
> > appears the libedit package just doesn't include ALL the rl_* symbols
> > that iwctl uses:
> >
> > jprestwood@LOCLAP699:~/iwd$ objdump -TC
> > /lib/x86_64-linux-gnu/libedit.so.2 | grep rl_ | cut -d' ' -f17
> > rl_getc_function
> > rl_pre_input_hook
> > rl_inhibit_completion
> > rl_readline_name
> > rl_redisplay
> > rl_deprep_terminal
> > rl_completer_quote_characters
> > rl_completer_word_break_characters
> > rl_filename_completion_desired
> > rl_prep_terminal
> > rl_free_line_state
> > rl_set_keymap
> > rl_newline
> > rl_resize_terminal
> > rl_callback_handler_remove
> > _rl_qsort_string_compare
> > rl_completion_word_break_hook
> > rl_instream
> > rl_basic_word_break_characters
> > rl_forced_update_display
> > rl_readline_version
> > rl_kill_text
> > rl_startup_hook
> > rl_set_screen_size
> > rl_point
> > rl_special_prefixes
> > rl_startup1_hook
> > rl_get_previous_history
> > rl_stuff_char
> > rl_completion_entry_function
> > rl_completion_display_matches_hook
> > rl_did_startup_hook
> > rl_generic_bind
> > rl_set_keyboard_input_timeout
> > rl_event_hook
> > rl_callback_handler_install
> > rl_parse_and_bind
> > rl_line_buffer
> > rl_linefunc
> > rl_variable_bind
> > rl_terminal_name
> > rl_deprep_term_function
> > rl_on_new_line
> > rl_done
> > rl_redisplay_function
> > rl_prep_term_function
> > rl_outstream
> > rl_end
> > rl_read_key
> > rl_catch_sigwinch
> > rl_catch_signals
> > rl_insert
> > rl_completion_append_character
> > rl_attempted_completion_over
> > rl_reset_after_signal
> > rl_completion_query_items
> > rl_reset_terminal
> > rl_library_version
> > rl_already_prompted
> > rl_bind_key
> > rl_completion_matches
> > rl_callback_read_char
> > rl_set_prompt
> > rl_get_screen_size
> > rl_cleanup_after_signal
> > rl_bind_key_in_map
> > rl_make_bare_keymap
> > rl_prompt
> > rl_read_init_file
> > rl_insert_text
> > rl_add_defun
> > _rl_print_completions_horizontally
> > rl_echo_signal_char
> > rl_display_match_list
> > rl_ignore_completion_duplicates
> > rl_filename_completion_function
> > rl_completion_type
> > rl_attempted_completion_function
> > rl_get_keymap
> > rl_initialize
> > _rl_abort_internal
> > rl_complete
> >
> > Why this would be different on Fedora is beyond me, very weird.
> >
> > Thanks,
> > James
> >
> > >
> > > Regards
> > >
> > > Marcel
> > >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-26 12:36           ` daniel antoine
@ 2023-04-27  9:37             ` daniel antoine
  2023-04-27 14:28               ` James Prestwood
  0 siblings, 1 reply; 16+ messages in thread
From: daniel antoine @ 2023-04-27  9:37 UTC (permalink / raw)
  To: James Prestwood, Marcel Holtmann, iwd

Hi James Hi Marcel

I have updated libedit to 20221030-3.1 et the compilation off iwd is OK now
may be you have to specify that the level of libedit must be
20221030-3.1 to build with libedit instead of readline

I am sorry for the convenience the problem was on my side I was not at
the last level of libeditt

Best regard

Daniel

Le mer. 26 avr. 2023 à 14:36, daniel antoine <univac55@gmail.com> a écrit :
>
> Hi gents
>
> I suppose that my problem is here
> http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/readline.c
>
> Revision 1.169 / (download) - annotate - [select for diffs], Tue Jan
> 11 18:30:15 2022 UTC (15 months, 1 week ago) by christos
> Branch: MAIN
> Changes since 1.168: +70 -2 lines
> Diff to previous 1.168 (colored)
>
> PR/56618: Walter Lozano: Improve libedit compatibility with readline by
> implementing:
>
>     rl_copy_text, rl_erase_empty_line, rl_message, rl_on_new_line,
>     rl_replace_line, rl_restore_prompt, rl_save_prompt
>
> ________________________________
>
> the patch is 20221101 after libedit 20210910-3.1
> I have also a debian (bullseye) system with libedit 20191231-3.1
> without libedit-dev
>
> I hope that if I have to compile on my LFS system it will not break it
> ,it's a base package
>
> Best regards
>
> Danial
>
> Le mer. 26 avr. 2023 à 12:14, daniel antoine <univac55@gmail.com> a écrit :
> >
> > Hi James, Hi Marcel
> >
> > I got this in my chroot
> > Chroot path: /mnt/hd
> > ******************************
> > root@grat-os1:/# cards search libedit
> > (base) libedit 20210910-3.1 Command line editor library providing
> > generic line editing, history, and tokenization functions.
> > (base) libedit.devel 20210910-3.1 Command line editor library
> > providing generic line editing, history, and tokenization functions.
> > (base) libedit.man 20210910-3.1 Command line editor library providing
> > generic line editing, history, and tokenization functions.
> >
> > root@grat-os1:/# find / -name libedit.so*
> > /usr/lib/libedit.so
> > /usr/lib/libedit.so.0
> > /usr/lib/libedit.so.0.0.68
> >
> > root@grat-os1:/# objdump -TC /usr/lib/libedit.so | grep rl_ | cut -d' ' -f17
> > rl_sort_completion_matches
> > rl_completion_query_items
> > rl_resize_terminal
> > rl_parse_and_bind
> > rl_deprep_terminal
> > rl_basic_word_break_characters
> > rl_pre_input_hook
> > rl_set_keyboard_input_timeout
> > rl_startup1_hook
> > rl_completer_word_break_characters
> > rl_initialize
> > rl_directory_completion_hook
> > rl_add_defun
> > rl_readline_version
> > rl_free_line_state
> > rl_attempted_completion_over
> > rl_basic_quote_characters
> > _rl_echoing_p
> > rl_prep_terminal
> > rl_outstream
> > rl_already_prompted
> > rl_line_buffer
> > rl_completion_word_break_hook
> > rl_abort
> > rl_redisplay
> > _rl_abort_internal
> > rl_echo_signal_char
> > rl_display_match_list
> > rl_ignore_completion_duplicates
> > rl_on_new_line
> > _rl_complete_mark_directories
> > rl_instream
> > rl_completion_matches
> > rl_bind_key_in_map
> > rl_generic_bind
> > rl_deprep_term_function
> > rl_filename_completion_desired
> > rl_forced_update_display
> > rl_completion_type
> > rl_insert
> > rl_inhibit_completion
> > rl_reset_after_signal
> > rl_set_screen_size
> > _rl_qsort_string_compare
> > rl_point
> > rl_make_bare_keymap
> > rl_newline
> > rl_get_keymap
> > rl_library_version
> > rl_startup_hook
> > _rl_completion_prefix_display_length
> > rl_event_hook
> > rl_callback_read_char
> > rl_getc_function
> > rl_display_prompt
> > rl_crlf
> > rl_set_keymap
> > rl_ding
> > rl_bind_key
> > rl_completion_append_character
> > rl_catch_sigwinch
> > rl_insert_text
> > rl_variable_bind
> > rl_get_screen_size
> > rl_read_init_file
> > rl_redisplay_function
> > rl_completer_quote_characters
> > _rl_print_completions_horizontally
> > _rl_erase_entire_line
> > rl_readline_state
> > rl_callback_handler_install
> > rl_cleanup_after_signal
> > rl_catch_signals
> > rl_terminal_name
> > rl_set_prompt
> > rl_done
> > rl_filename_completion_function
> > rl_readline_name
> > rl_completion_entry_function
> > rl_complete
> > rl_special_prefixes
> > rl_linefunc
> > rl_set_keymap_name
> > rl_get_previous_history
> > rl_attempted_completion_function
> > rl_kill_text
> > rl_read_key
> > rl_reset_terminal
> > rl_stuff_char
> > rl_completion_display_matches_hook
> > rl_end
> > rl_prep_term_function
> > rl_callback_handler_remove
> > rl_completion_suppress_append
> > rl_prompt
> > root@grat-os1:/#
> >
> > Is my version of libedit too old --> 20221030-3.1 ?
> >
> > Best regards
> >
> > Daniel
> >
> > Le mar. 25 avr. 2023 à 23:46, James Prestwood <prestwoj@gmail.com> a écrit :
> > >
> > > Hi Marcel,
> > >
> > > On 4/24/23 3:14 AM, Marcel Holtmann wrote:
> > > > Hi James,
> > > >
> > > >>>> I have tried to build iwd to the last commit "Allow building with
> > > >>>> libedit instead readline". The Pkgfile seems to need the option
> > > >>>> --enable-libedit to remove readline but it fails with
> > > >>>>   CC       wired/dbus.o
> > > >>>>   CCLD     ell/libell-internal.la
> > > >>>>   CCLD     client/iwctl
> > > >>>>   CCLD     src/iwd
> > > >>>>   CCLD     wired/ead
> > > >>>> /usr/bin/ld: client/command.o: in function `command_completion':
> > > >>>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
> > > >>>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
> > > >>>> /usr/bin/ld: client/display.o: in function `save_input':
> > > >>>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
> > > >>>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
> > > >>>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
> > > >>>> /usr/bin/ld: client/display.o: in function `display_text':
> > > >>>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
> > > >>>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
> > > >>>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
> > > >>>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
> > > >>>> /usr/bin/ld: client/display.o: in function `timeout_callback':
> > > >>>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
> > > >>>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
> > > >>>> /usr/bin/ld: client/display.o: in function `display_table_footer':
> > > >>>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
> > > >>>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
> > > >>>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
> > > >>>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
> > > >>>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
> > > >>>> `rl_restore_prompt'
> > > >>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
> > > >>>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
> > > >>>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
> > > >>>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
> > > >>>> `rl_erase_empty_line'
> > > >>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
> > > >>>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
> > > >>>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
> > > >>>> `rl_erase_empty_line'
> > > >>>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
> > > >>>> /usr/bin/ld: client/display.o: in function `display_init':
> > > >>>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
> > > >>>> collect2: error: ld returned 1 exit status
> > > >>>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
> > > >>>> make[1]: *** Waiting for unfinished jobs....
> > > >>>> make: *** [Makefile:1595: all] Error 2
> > > >>>> =======> ERROR: Building
> > > >>>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
> > > >>>>
> > > >>>> It looks like some readline commands are always taken in count
> > > >>>>
> > > >>>> I have my Pkgfile and the compilation log
> > > >>> It does build for me just fine. What distro is this?
> > > >>> What does pkg-config --cflags --libs libedit show?
> > > >>
> > > >> I'm seeing the same build problem, Ubuntu 20.04:
> > > >>
> > > >> $ pkg-config --cflags --libs libedit
> > > >> -I/usr/include/editline -ledit
> > > >
> > > > so Ubuntu seems to have libeditreadline-dev and maybe it has
> > > > Its own pkg-config file for a library with the rl_ symbols.
> > >
> > > I see that Debian package, but Ubuntu doesn't have it (or my Ubuntu
> > > distro doesn't). It does have libedit-dev which is what I installed. It
> > > appears the libedit package just doesn't include ALL the rl_* symbols
> > > that iwctl uses:
> > >
> > > jprestwood@LOCLAP699:~/iwd$ objdump -TC
> > > /lib/x86_64-linux-gnu/libedit.so.2 | grep rl_ | cut -d' ' -f17
> > > rl_getc_function
> > > rl_pre_input_hook
> > > rl_inhibit_completion
> > > rl_readline_name
> > > rl_redisplay
> > > rl_deprep_terminal
> > > rl_completer_quote_characters
> > > rl_completer_word_break_characters
> > > rl_filename_completion_desired
> > > rl_prep_terminal
> > > rl_free_line_state
> > > rl_set_keymap
> > > rl_newline
> > > rl_resize_terminal
> > > rl_callback_handler_remove
> > > _rl_qsort_string_compare
> > > rl_completion_word_break_hook
> > > rl_instream
> > > rl_basic_word_break_characters
> > > rl_forced_update_display
> > > rl_readline_version
> > > rl_kill_text
> > > rl_startup_hook
> > > rl_set_screen_size
> > > rl_point
> > > rl_special_prefixes
> > > rl_startup1_hook
> > > rl_get_previous_history
> > > rl_stuff_char
> > > rl_completion_entry_function
> > > rl_completion_display_matches_hook
> > > rl_did_startup_hook
> > > rl_generic_bind
> > > rl_set_keyboard_input_timeout
> > > rl_event_hook
> > > rl_callback_handler_install
> > > rl_parse_and_bind
> > > rl_line_buffer
> > > rl_linefunc
> > > rl_variable_bind
> > > rl_terminal_name
> > > rl_deprep_term_function
> > > rl_on_new_line
> > > rl_done
> > > rl_redisplay_function
> > > rl_prep_term_function
> > > rl_outstream
> > > rl_end
> > > rl_read_key
> > > rl_catch_sigwinch
> > > rl_catch_signals
> > > rl_insert
> > > rl_completion_append_character
> > > rl_attempted_completion_over
> > > rl_reset_after_signal
> > > rl_completion_query_items
> > > rl_reset_terminal
> > > rl_library_version
> > > rl_already_prompted
> > > rl_bind_key
> > > rl_completion_matches
> > > rl_callback_read_char
> > > rl_set_prompt
> > > rl_get_screen_size
> > > rl_cleanup_after_signal
> > > rl_bind_key_in_map
> > > rl_make_bare_keymap
> > > rl_prompt
> > > rl_read_init_file
> > > rl_insert_text
> > > rl_add_defun
> > > _rl_print_completions_horizontally
> > > rl_echo_signal_char
> > > rl_display_match_list
> > > rl_ignore_completion_duplicates
> > > rl_filename_completion_function
> > > rl_completion_type
> > > rl_attempted_completion_function
> > > rl_get_keymap
> > > rl_initialize
> > > _rl_abort_internal
> > > rl_complete
> > >
> > > Why this would be different on Fedora is beyond me, very weird.
> > >
> > > Thanks,
> > > James
> > >
> > > >
> > > > Regards
> > > >
> > > > Marcel
> > > >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-27  9:37             ` daniel antoine
@ 2023-04-27 14:28               ` James Prestwood
  2023-05-03 10:07                 ` Marcel Holtmann
  0 siblings, 1 reply; 16+ messages in thread
From: James Prestwood @ 2023-04-27 14:28 UTC (permalink / raw)
  To: daniel antoine, Marcel Holtmann, iwd

Hi Daniel/Marcel,

On 4/27/23 2:37 AM, daniel antoine wrote:
> Hi James Hi Marcel
> 
> I have updated libedit to 20221030-3.1 et the compilation off iwd is OK now
> may be you have to specify that the level of libedit must be
> 20221030-3.1 to build with libedit instead of readline
> 
> I am sorry for the convenience the problem was on my side I was not at
> the last level of libeditt

No problem, I ran into the same thing :) Marcel, is there a way to do a 
version check on libedit so configure can detect these unsupported versions?

> 
> Best regard
> 
> Daniel
> 
> Le mer. 26 avr. 2023 à 14:36, daniel antoine <univac55@gmail.com> a écrit :
>>
>> Hi gents
>>
>> I suppose that my problem is here
>> http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/readline.c
>>
>> Revision 1.169 / (download) - annotate - [select for diffs], Tue Jan
>> 11 18:30:15 2022 UTC (15 months, 1 week ago) by christos
>> Branch: MAIN
>> Changes since 1.168: +70 -2 lines
>> Diff to previous 1.168 (colored)
>>
>> PR/56618: Walter Lozano: Improve libedit compatibility with readline by
>> implementing:
>>
>>      rl_copy_text, rl_erase_empty_line, rl_message, rl_on_new_line,
>>      rl_replace_line, rl_restore_prompt, rl_save_prompt
>>
>> ________________________________
>>
>> the patch is 20221101 after libedit 20210910-3.1
>> I have also a debian (bullseye) system with libedit 20191231-3.1
>> without libedit-dev
>>
>> I hope that if I have to compile on my LFS system it will not break it
>> ,it's a base package
>>
>> Best regards
>>
>> Danial
>>
>> Le mer. 26 avr. 2023 à 12:14, daniel antoine <univac55@gmail.com> a écrit :
>>>
>>> Hi James, Hi Marcel
>>>
>>> I got this in my chroot
>>> Chroot path: /mnt/hd
>>> ******************************
>>> root@grat-os1:/# cards search libedit
>>> (base) libedit 20210910-3.1 Command line editor library providing
>>> generic line editing, history, and tokenization functions.
>>> (base) libedit.devel 20210910-3.1 Command line editor library
>>> providing generic line editing, history, and tokenization functions.
>>> (base) libedit.man 20210910-3.1 Command line editor library providing
>>> generic line editing, history, and tokenization functions.
>>>
>>> root@grat-os1:/# find / -name libedit.so*
>>> /usr/lib/libedit.so
>>> /usr/lib/libedit.so.0
>>> /usr/lib/libedit.so.0.0.68
>>>
>>> root@grat-os1:/# objdump -TC /usr/lib/libedit.so | grep rl_ | cut -d' ' -f17
>>> rl_sort_completion_matches
>>> rl_completion_query_items
>>> rl_resize_terminal
>>> rl_parse_and_bind
>>> rl_deprep_terminal
>>> rl_basic_word_break_characters
>>> rl_pre_input_hook
>>> rl_set_keyboard_input_timeout
>>> rl_startup1_hook
>>> rl_completer_word_break_characters
>>> rl_initialize
>>> rl_directory_completion_hook
>>> rl_add_defun
>>> rl_readline_version
>>> rl_free_line_state
>>> rl_attempted_completion_over
>>> rl_basic_quote_characters
>>> _rl_echoing_p
>>> rl_prep_terminal
>>> rl_outstream
>>> rl_already_prompted
>>> rl_line_buffer
>>> rl_completion_word_break_hook
>>> rl_abort
>>> rl_redisplay
>>> _rl_abort_internal
>>> rl_echo_signal_char
>>> rl_display_match_list
>>> rl_ignore_completion_duplicates
>>> rl_on_new_line
>>> _rl_complete_mark_directories
>>> rl_instream
>>> rl_completion_matches
>>> rl_bind_key_in_map
>>> rl_generic_bind
>>> rl_deprep_term_function
>>> rl_filename_completion_desired
>>> rl_forced_update_display
>>> rl_completion_type
>>> rl_insert
>>> rl_inhibit_completion
>>> rl_reset_after_signal
>>> rl_set_screen_size
>>> _rl_qsort_string_compare
>>> rl_point
>>> rl_make_bare_keymap
>>> rl_newline
>>> rl_get_keymap
>>> rl_library_version
>>> rl_startup_hook
>>> _rl_completion_prefix_display_length
>>> rl_event_hook
>>> rl_callback_read_char
>>> rl_getc_function
>>> rl_display_prompt
>>> rl_crlf
>>> rl_set_keymap
>>> rl_ding
>>> rl_bind_key
>>> rl_completion_append_character
>>> rl_catch_sigwinch
>>> rl_insert_text
>>> rl_variable_bind
>>> rl_get_screen_size
>>> rl_read_init_file
>>> rl_redisplay_function
>>> rl_completer_quote_characters
>>> _rl_print_completions_horizontally
>>> _rl_erase_entire_line
>>> rl_readline_state
>>> rl_callback_handler_install
>>> rl_cleanup_after_signal
>>> rl_catch_signals
>>> rl_terminal_name
>>> rl_set_prompt
>>> rl_done
>>> rl_filename_completion_function
>>> rl_readline_name
>>> rl_completion_entry_function
>>> rl_complete
>>> rl_special_prefixes
>>> rl_linefunc
>>> rl_set_keymap_name
>>> rl_get_previous_history
>>> rl_attempted_completion_function
>>> rl_kill_text
>>> rl_read_key
>>> rl_reset_terminal
>>> rl_stuff_char
>>> rl_completion_display_matches_hook
>>> rl_end
>>> rl_prep_term_function
>>> rl_callback_handler_remove
>>> rl_completion_suppress_append
>>> rl_prompt
>>> root@grat-os1:/#
>>>
>>> Is my version of libedit too old --> 20221030-3.1 ?
>>>
>>> Best regards
>>>
>>> Daniel
>>>
>>> Le mar. 25 avr. 2023 à 23:46, James Prestwood <prestwoj@gmail.com> a écrit :
>>>>
>>>> Hi Marcel,
>>>>
>>>> On 4/24/23 3:14 AM, Marcel Holtmann wrote:
>>>>> Hi James,
>>>>>
>>>>>>>> I have tried to build iwd to the last commit "Allow building with
>>>>>>>> libedit instead readline". The Pkgfile seems to need the option
>>>>>>>> --enable-libedit to remove readline but it fails with
>>>>>>>>    CC       wired/dbus.o
>>>>>>>>    CCLD     ell/libell-internal.la
>>>>>>>>    CCLD     client/iwctl
>>>>>>>>    CCLD     src/iwd
>>>>>>>>    CCLD     wired/ead
>>>>>>>> /usr/bin/ld: client/command.o: in function `command_completion':
>>>>>>>> command.c:(.text+0x6cc): undefined reference to `rl_copy_text'
>>>>>>>> /usr/bin/ld: command.c:(.text+0x8b0): undefined reference to `rl_copy_text'
>>>>>>>> /usr/bin/ld: client/display.o: in function `save_input':
>>>>>>>> display.c:(.text+0x32): undefined reference to `rl_copy_text'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x3a): undefined reference to `rl_save_prompt'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x46): undefined reference to `rl_replace_line'
>>>>>>>> /usr/bin/ld: client/display.o: in function `display_text':
>>>>>>>> display.c:(.text+0x796): undefined reference to `rl_restore_prompt'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x7a0): undefined reference to `rl_replace_line'
>>>>>>>> /usr/bin/ld: client/display.o: in function `display_completion_matches':
>>>>>>>> display.c:(.text+0x834): undefined reference to `rl_copy_text'
>>>>>>>> /usr/bin/ld: client/display.o: in function `timeout_callback':
>>>>>>>> display.c:(.text+0x9d0): undefined reference to `rl_restore_prompt'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x9da): undefined reference to `rl_replace_line'
>>>>>>>> /usr/bin/ld: client/display.o: in function `display_table_footer':
>>>>>>>> display.c:(.text+0x11a6): undefined reference to `rl_restore_prompt'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x11b1): undefined reference to `rl_replace_line'
>>>>>>>> /usr/bin/ld: client/display.o: in function `display_enable_cmd_prompt':
>>>>>>>> display.c:(.text+0x168e): undefined reference to `rl_save_prompt'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x1698): undefined reference to
>>>>>>>> `rl_restore_prompt'
>>>>>>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt':
>>>>>>>> display.c:(.text+0x177d): undefined reference to `rl_copy_text'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x1797): undefined reference to `rl_replace_line'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x17a5): undefined reference to
>>>>>>>> `rl_erase_empty_line'
>>>>>>>> /usr/bin/ld: client/display.o: in function `display_agent_prompt_release':
>>>>>>>> display.c:(.text+0x1889): undefined reference to `rl_copy_text'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x18cd): undefined reference to
>>>>>>>> `rl_erase_empty_line'
>>>>>>>> /usr/bin/ld: display.c:(.text+0x18db): undefined reference to `rl_replace_line'
>>>>>>>> /usr/bin/ld: client/display.o: in function `display_init':
>>>>>>>> display.c:(.text+0x1a3e): undefined reference to `rl_erase_empty_line'
>>>>>>>> collect2: error: ld returned 1 exit status
>>>>>>>> make[1]: *** [Makefile:1895: client/iwctl] Error 1
>>>>>>>> make[1]: *** Waiting for unfinished jobs....
>>>>>>>> make: *** [Makefile:1595: all] Error 2
>>>>>>>> =======> ERROR: Building
>>>>>>>> '/usr/ports/perso/iwd/iwd1682174379x86_64.cards.tar.xz' failed.
>>>>>>>>
>>>>>>>> It looks like some readline commands are always taken in count
>>>>>>>>
>>>>>>>> I have my Pkgfile and the compilation log
>>>>>>> It does build for me just fine. What distro is this?
>>>>>>> What does pkg-config --cflags --libs libedit show?
>>>>>>
>>>>>> I'm seeing the same build problem, Ubuntu 20.04:
>>>>>>
>>>>>> $ pkg-config --cflags --libs libedit
>>>>>> -I/usr/include/editline -ledit
>>>>>
>>>>> so Ubuntu seems to have libeditreadline-dev and maybe it has
>>>>> Its own pkg-config file for a library with the rl_ symbols.
>>>>
>>>> I see that Debian package, but Ubuntu doesn't have it (or my Ubuntu
>>>> distro doesn't). It does have libedit-dev which is what I installed. It
>>>> appears the libedit package just doesn't include ALL the rl_* symbols
>>>> that iwctl uses:
>>>>
>>>> jprestwood@LOCLAP699:~/iwd$ objdump -TC
>>>> /lib/x86_64-linux-gnu/libedit.so.2 | grep rl_ | cut -d' ' -f17
>>>> rl_getc_function
>>>> rl_pre_input_hook
>>>> rl_inhibit_completion
>>>> rl_readline_name
>>>> rl_redisplay
>>>> rl_deprep_terminal
>>>> rl_completer_quote_characters
>>>> rl_completer_word_break_characters
>>>> rl_filename_completion_desired
>>>> rl_prep_terminal
>>>> rl_free_line_state
>>>> rl_set_keymap
>>>> rl_newline
>>>> rl_resize_terminal
>>>> rl_callback_handler_remove
>>>> _rl_qsort_string_compare
>>>> rl_completion_word_break_hook
>>>> rl_instream
>>>> rl_basic_word_break_characters
>>>> rl_forced_update_display
>>>> rl_readline_version
>>>> rl_kill_text
>>>> rl_startup_hook
>>>> rl_set_screen_size
>>>> rl_point
>>>> rl_special_prefixes
>>>> rl_startup1_hook
>>>> rl_get_previous_history
>>>> rl_stuff_char
>>>> rl_completion_entry_function
>>>> rl_completion_display_matches_hook
>>>> rl_did_startup_hook
>>>> rl_generic_bind
>>>> rl_set_keyboard_input_timeout
>>>> rl_event_hook
>>>> rl_callback_handler_install
>>>> rl_parse_and_bind
>>>> rl_line_buffer
>>>> rl_linefunc
>>>> rl_variable_bind
>>>> rl_terminal_name
>>>> rl_deprep_term_function
>>>> rl_on_new_line
>>>> rl_done
>>>> rl_redisplay_function
>>>> rl_prep_term_function
>>>> rl_outstream
>>>> rl_end
>>>> rl_read_key
>>>> rl_catch_sigwinch
>>>> rl_catch_signals
>>>> rl_insert
>>>> rl_completion_append_character
>>>> rl_attempted_completion_over
>>>> rl_reset_after_signal
>>>> rl_completion_query_items
>>>> rl_reset_terminal
>>>> rl_library_version
>>>> rl_already_prompted
>>>> rl_bind_key
>>>> rl_completion_matches
>>>> rl_callback_read_char
>>>> rl_set_prompt
>>>> rl_get_screen_size
>>>> rl_cleanup_after_signal
>>>> rl_bind_key_in_map
>>>> rl_make_bare_keymap
>>>> rl_prompt
>>>> rl_read_init_file
>>>> rl_insert_text
>>>> rl_add_defun
>>>> _rl_print_completions_horizontally
>>>> rl_echo_signal_char
>>>> rl_display_match_list
>>>> rl_ignore_completion_duplicates
>>>> rl_filename_completion_function
>>>> rl_completion_type
>>>> rl_attempted_completion_function
>>>> rl_get_keymap
>>>> rl_initialize
>>>> _rl_abort_internal
>>>> rl_complete
>>>>
>>>> Why this would be different on Fedora is beyond me, very weird.
>>>>
>>>> Thanks,
>>>> James
>>>>
>>>>>
>>>>> Regards
>>>>>
>>>>> Marcel
>>>>>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-04-27 14:28               ` James Prestwood
@ 2023-05-03 10:07                 ` Marcel Holtmann
  2023-05-03 13:50                   ` James Prestwood
  0 siblings, 1 reply; 16+ messages in thread
From: Marcel Holtmann @ 2023-05-03 10:07 UTC (permalink / raw)
  To: James Prestwood; +Cc: daniel antoine, iwd

Hi James,

>> I have updated libedit to 20221030-3.1 et the compilation off iwd is OK now
>> may be you have to specify that the level of libedit must be
>> 20221030-3.1 to build with libedit instead of readline
>> I am sorry for the convenience the problem was on my side I was not at
>> the last level of libeditt
> 
> No problem, I ran into the same thing :) Marcel, is there a way to do a version check on libedit so configure can detect these unsupported versions?

I can check for version >= 3.1 when looking for libedit. Is that enough?

Regards

Marcel


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-05-03 10:07                 ` Marcel Holtmann
@ 2023-05-03 13:50                   ` James Prestwood
  2023-05-03 16:30                     ` daniel antoine
  0 siblings, 1 reply; 16+ messages in thread
From: James Prestwood @ 2023-05-03 13:50 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: daniel antoine, iwd

Hi Marcel,

I really am not sure. Daniel pointed to the change logs which indicate 
libedit 1.169+, but obviously that isn't the version numbering Debian uses.

So maybe its just not possible. At least we have this thread in case 
anyone else encounters this.

Thanks,
James

On 5/3/23 3:07 AM, Marcel Holtmann wrote:
> Hi James,
> 
>>> I have updated libedit to 20221030-3.1 et the compilation off iwd is OK now
>>> may be you have to specify that the level of libedit must be
>>> 20221030-3.1 to build with libedit instead of readline
>>> I am sorry for the convenience the problem was on my side I was not at
>>> the last level of libeditt
>>
>> No problem, I ran into the same thing :) Marcel, is there a way to do a version check on libedit so configure can detect these unsupported versions?
> 
> I can check for version >= 3.1 when looking for libedit. Is that enough?
> 
> Regards
> 
> Marcel
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error
  2023-05-03 13:50                   ` James Prestwood
@ 2023-05-03 16:30                     ` daniel antoine
  0 siblings, 0 replies; 16+ messages in thread
From: daniel antoine @ 2023-05-03 16:30 UTC (permalink / raw)
  To: James Prestwood, Marcel Holtmann, iwd

Hi
version 0.169 was the version of the file /sr/readline.c in the
libedit package that have the corrections for the readline commands;
Now with libedit 20221030-3.1 the version of readline.c is 1.176
I suppose that libedit is at the version 3.1 and the level of patch is
indicated by the date 20221030. When the compilation of IWD was not OK
the level of patch was 20210910. If you go on the libedit site the
only available downloadable version is 20222130-3.1

Best regards

Daniel

Le mer. 3 mai 2023 à 15:50, James Prestwood <prestwoj@gmail.com> a écrit :
>
> Hi Marcel,
>
> I really am not sure. Daniel pointed to the change logs which indicate
> libedit 1.169+, but obviously that isn't the version numbering Debian uses.
>
> So maybe its just not possible. At least we have this thread in case
> anyone else encounters this.
>
> Thanks,
> James
>
> On 5/3/23 3:07 AM, Marcel Holtmann wrote:
> > Hi James,
> >
> >>> I have updated libedit to 20221030-3.1 et the compilation off iwd is OK now
> >>> may be you have to specify that the level of libedit must be
> >>> 20221030-3.1 to build with libedit instead of readline
> >>> I am sorry for the convenience the problem was on my side I was not at
> >>> the last level of libeditt
> >>
> >> No problem, I ran into the same thing :) Marcel, is there a way to do a version check on libedit so configure can detect these unsupported versions?
> >
> > I can check for version >= 3.1 when looking for libedit. Is that enough?
> >
> > Regards
> >
> > Marcel
> >

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2023-05-03 16:30 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CA+iibzC0O-v+Rk+799=QYmzyAZo_3XcN1mfAsM-QtnA8zc6wpw@mail.gmail.com>
2023-04-22 18:32 ` commit IWD 8f0420c533ae6a49c4f2803afe32d5922a5236ad build error Marcel Holtmann
2023-04-23  2:32   ` James Prestwood
2023-04-24  7:39     ` Marcel Holtmann
2023-04-24 10:14     ` Marcel Holtmann
2023-04-25 21:46       ` James Prestwood
2023-04-26 10:14         ` daniel antoine
2023-04-26 12:36           ` daniel antoine
2023-04-27  9:37             ` daniel antoine
2023-04-27 14:28               ` James Prestwood
2023-05-03 10:07                 ` Marcel Holtmann
2023-05-03 13:50                   ` James Prestwood
2023-05-03 16:30                     ` daniel antoine
2023-04-24  5:46 ` Daniel Wagner
2023-04-24  8:19   ` daniel antoine
2023-04-24 16:00     ` daniel antoine
2023-04-24 17:21       ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).