From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 5/9] ie: Add FILS IP Address Assignment parsers and builders
Date: Wed, 25 Aug 2021 23:34:52 +0200 [thread overview]
Message-ID: <CAOq732LtRF+Nze+u02jTFg4=S9iC0JFi_XMwP93ur=9J8_rjAg@mail.gmail.com> (raw)
In-Reply-To: <611d1fd3-fd8e-3b42-0e9f-32f0edcc4ac7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
Hi Denis.
On Wed, 25 Aug 2021 at 15:49, Denis Kenzior <denkenz@gmail.com> wrote:
> On 8/23/21 9:14 AM, Andrew Zaborowski wrote:
> > ---
> > src/ie.c | 347 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > src/ie.h | 38 ++++++
> > 2 files changed, 385 insertions(+)
> >
>
> <snip>
>
> > + if (*resp_ctrl & IE_FILS_IP_ADDR_RESP_CTRL_IPV4_GW_INCLUDED) {
> > + ptr = NEXT_FIELD(data, len, 10);
> > + info.ipv4_gateway = l_get_u32(ptr);
> > + memcpy(info.ipv4_gateway_mac, ptr + 4, 6);
> > +
> > + /* Check gateway is on the same subnet */
> > + if (info.ipv4_addr && (ntohl(info.ipv4_addr ^ info.ipv4_gateway) &
> > + util_netmask_from_prefix(info.ipv4_prefix_len)))
>
> This line is over 80 chars. Also, it seems you're repeating this pattern in
> many places by now. Please add a utility function so one doesn't wonder what
> this is doing on every reading ;)
Ok, makes sense.
Best regards
next prev parent reply other threads:[~2021-08-25 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 14:14 [PATCH 1/9] handshake: Add HANDSHAKE_EVENT_P2P_IP_REQUEST Andrew Zaborowski
2021-08-23 14:14 ` [PATCH 2/9] ap: Implement P2P GO-side 4-way handshake IP Allocation Andrew Zaborowski
2021-08-23 14:14 ` [PATCH 3/9] autotests: Test GO-side IP Allocation in testP2P Andrew Zaborowski
2021-08-23 14:14 ` [PATCH 4/9] ap: Expire client's leases on disconnect Andrew Zaborowski
2021-08-23 14:14 ` [PATCH 5/9] ie: Add FILS IP Address Assignment parsers and builders Andrew Zaborowski
2021-08-25 13:47 ` Denis Kenzior
2021-08-25 21:34 ` Andrew Zaborowski [this message]
2021-08-23 14:14 ` [PATCH 6/9] ap: Support FILS IP Address Assignment IE Andrew Zaborowski
2021-08-23 14:14 ` [PATCH 7/9] netconfig: Move loading settings to new method, refactor Andrew Zaborowski
2021-08-25 13:50 ` Denis Kenzior
2021-08-25 22:17 ` Andrew Zaborowski
2021-08-25 22:37 ` Denis Kenzior
2021-08-25 22:56 ` Andrew Zaborowski
2021-08-23 14:14 ` [PATCH 8/9] netconfig: FILS IP assigment API Andrew Zaborowski
2021-08-23 14:14 ` [PATCH 9/9] station, netdev: Enable FILS IP Address Assignment Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOq732LtRF+Nze+u02jTFg4=S9iC0JFi_XMwP93ur=9J8_rjAg@mail.gmail.com' \
--to=andrew.zaborowski@intel.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).