* [PATCH v2 1/2] client: fix extra newlines in station show
@ 2022-11-02 20:22 Neehar Vijay
2022-11-02 20:22 ` [PATCH v2 2/2] gitignore: add .cache Neehar Vijay
2022-11-02 21:41 ` [PATCH v2 1/2] client: fix extra newlines in station show Denis Kenzior
0 siblings, 2 replies; 3+ messages in thread
From: Neehar Vijay @ 2022-11-02 20:22 UTC (permalink / raw)
To: iwd; +Cc: Neehar Vijay
This change removes duplicate calls to display_table_footer(), in
station show.
Before this change, the bug caused an extra newline to be output every
time the table updated. This only occurred when the network was
disconnected.
$ iwctl
[iwd]# station wlan0 show
---
client/station.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/client/station.c b/client/station.c
index b070807b..1d958ef2 100644
--- a/client/station.c
+++ b/client/station.c
@@ -217,15 +217,9 @@ static void display_station(const char *device_name,
47, network_get_name(station->connected_network));
display_addresses(device_name);
-
- /*
- * If connected the diagnostic interface is presumably up so
- * don't add the table footer just yet.
- */
- return;
}
- display_table_footer();
+ /* The table footer is handled by cmd_show. */
}
static void display_station_inline(const char *margin, const void *data)
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] gitignore: add .cache
2022-11-02 20:22 [PATCH v2 1/2] client: fix extra newlines in station show Neehar Vijay
@ 2022-11-02 20:22 ` Neehar Vijay
2022-11-02 21:41 ` [PATCH v2 1/2] client: fix extra newlines in station show Denis Kenzior
1 sibling, 0 replies; 3+ messages in thread
From: Neehar Vijay @ 2022-11-02 20:22 UTC (permalink / raw)
To: iwd; +Cc: Neehar Vijay
This directory is used by clangd.
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index cde22889..61b3638d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,6 +4,7 @@
.libs
.deps
.dirstamp
+.cache
tags
cscope.*
Makefile
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] client: fix extra newlines in station show
2022-11-02 20:22 [PATCH v2 1/2] client: fix extra newlines in station show Neehar Vijay
2022-11-02 20:22 ` [PATCH v2 2/2] gitignore: add .cache Neehar Vijay
@ 2022-11-02 21:41 ` Denis Kenzior
1 sibling, 0 replies; 3+ messages in thread
From: Denis Kenzior @ 2022-11-02 21:41 UTC (permalink / raw)
To: Neehar Vijay, iwd
Hi Neehar,
On 11/2/22 15:22, Neehar Vijay wrote:
> This change removes duplicate calls to display_table_footer(), in
> station show.
>
> Before this change, the bug caused an extra newline to be output every
> time the table updated. This only occurred when the network was
> disconnected.
>
> $ iwctl
> [iwd]# station wlan0 show
> ---
> client/station.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
Both applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-02 21:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 20:22 [PATCH v2 1/2] client: fix extra newlines in station show Neehar Vijay
2022-11-02 20:22 ` [PATCH v2 2/2] gitignore: add .cache Neehar Vijay
2022-11-02 21:41 ` [PATCH v2 1/2] client: fix extra newlines in station show Denis Kenzior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).