iwd.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] scan: remove early supported check for 6ghz in wiphy watch
@ 2022-12-12 22:08 James Prestwood
  2022-12-13 20:19 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2022-12-12 22:08 UTC (permalink / raw)
  To: iwd; +Cc: James Prestwood

If the regdom updates during a periodic scan the results will be
delayed until after the update in order to, potentially, add 6GHz
frequencies since they may become available. The delayed results
happen regardless of 6GHz support but scan_wiphy_watch() was
returning early if 6GHz was not supported causing the scan request
to never complete.
---
 src/scan.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/scan.c b/src/scan.c
index 5d2f2957..f63b3ed2 100644
--- a/src/scan.c
+++ b/src/scan.c
@@ -1933,12 +1933,9 @@ static void scan_wiphy_watch(struct wiphy *wiphy,
 	struct scan_freq_set *freqs_6ghz;
 	struct scan_freq_set *allowed;
 	bool allow_6g;
-	const struct scan_freq_set *supported =
-					wiphy_get_supported_freqs(wiphy);
 
-	/* Only care about regulatory events, and if 6GHz capable */
-	if (event != WIPHY_STATE_WATCH_EVENT_REGDOM_DONE ||
-			!(scan_freq_set_get_bands(supported) & BAND_FREQ_6_GHZ))
+	/* Only care about completed regulatory dumps */
+	if (event != WIPHY_STATE_WATCH_EVENT_REGDOM_DONE)
 		return;
 
 	if (!sc->sp.id)
-- 
2.34.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scan: remove early supported check for 6ghz in wiphy watch
  2022-12-12 22:08 [PATCH] scan: remove early supported check for 6ghz in wiphy watch James Prestwood
@ 2022-12-13 20:19 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2022-12-13 20:19 UTC (permalink / raw)
  To: James Prestwood, iwd

Hi James,

On 12/12/22 16:08, James Prestwood wrote:
> If the regdom updates during a periodic scan the results will be
> delayed until after the update in order to, potentially, add 6GHz
> frequencies since they may become available. The delayed results
> happen regardless of 6GHz support but scan_wiphy_watch() was
> returning early if 6GHz was not supported causing the scan request
> to never complete.
> ---
>   src/scan.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 

Applied, thanks.

Regards,
-Denis


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-13 20:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 22:08 [PATCH] scan: remove early supported check for 6ghz in wiphy watch James Prestwood
2022-12-13 20:19 ` Denis Kenzior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).