From: Simon Ser <contact@emersion.fr>
To: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org,
Martin Peres <martin.peres@free.fr>,
Jeremy Cline <jcline@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dave Airlie <airlied@redhat.com>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Takashi Iwai <tiwai@suse.de>, James Jones <jajones@nvidia.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Tue, 19 Jan 2021 10:22:15 +0000 [thread overview]
Message-ID: <iyiRYoTlFNd1Crgc673rDXnfqahsfhKFP89rA0kKYEFUpLGwsFtYL-x-Jwh1ZAo7vJerbikydEDSUFtAoewsGkh3WSYeykScJdKC2PVrKQs=@emersion.fr> (raw)
In-Reply-To: <20210119015415.2511028-2-lyude@redhat.com>
On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul <lyude@redhat.com> wrote:
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Jeremy Cline <jcline@redhat.com>
> Cc: Simon Ser <contact@emersion.fr>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index c6367035970e..5f4f09a601d4 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev)
> else
> nouveau_display(dev)->format_modifiers = disp50xx_modifiers;
>
> + if (disp->disp->object.oclass >= GK104_DISP) {
I can confirm this works fine on GK208B. Tested with wlroots. I don't
have older cards to test, though.
Tested-by: Simon Ser <contact@emersion.fr>
> + dev->mode_config.cursor_width = 256;
> + dev->mode_config.cursor_height = 256;
> + } else {
> + dev->mode_config.cursor_width = 64;
> + dev->mode_config.cursor_height = 64;
> + }
> +
> /* create crtc objects to represent the hw heads */
> if (disp->disp->object.oclass >= GV100_DISP)
> crtcs = nvif_rd32(&device->object, 0x610060) & 0xff;
> --
> 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Simon Ser <contact-sV0wSBM+kKVWj0EZb7rXcA@public.gmane.org>
To: Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
Pankaj Bharadiya
<pankaj.laxminarayan.bharadiya-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Dave Airlie <airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Tue, 19 Jan 2021 10:22:15 +0000 [thread overview]
Message-ID: <iyiRYoTlFNd1Crgc673rDXnfqahsfhKFP89rA0kKYEFUpLGwsFtYL-x-Jwh1ZAo7vJerbikydEDSUFtAoewsGkh3WSYeykScJdKC2PVrKQs=@emersion.fr> (raw)
In-Reply-To: <20210119015415.2511028-2-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Cc: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>
> Cc: Jeremy Cline <jcline-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Simon Ser <contact-sV0wSBM+kKVWj0EZb7rXcA@public.gmane.org>
> Signed-off-by: Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index c6367035970e..5f4f09a601d4 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev)
> else
> nouveau_display(dev)->format_modifiers = disp50xx_modifiers;
>
> + if (disp->disp->object.oclass >= GK104_DISP) {
I can confirm this works fine on GK208B. Tested with wlroots. I don't
have older cards to test, though.
Tested-by: Simon Ser <contact-sV0wSBM+kKVWj0EZb7rXcA@public.gmane.org>
> + dev->mode_config.cursor_width = 256;
> + dev->mode_config.cursor_height = 256;
> + } else {
> + dev->mode_config.cursor_width = 64;
> + dev->mode_config.cursor_height = 64;
> + }
> +
> /* create crtc objects to represent the hw heads */
> if (disp->disp->object.oclass >= GV100_DISP)
> crtcs = nvif_rd32(&device->object, 0x610060) & 0xff;
> --
> 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Simon Ser <contact@emersion.fr>
To: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, James Jones <jajones@nvidia.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jeremy Cline <jcline@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Tue, 19 Jan 2021 10:22:15 +0000 [thread overview]
Message-ID: <iyiRYoTlFNd1Crgc673rDXnfqahsfhKFP89rA0kKYEFUpLGwsFtYL-x-Jwh1ZAo7vJerbikydEDSUFtAoewsGkh3WSYeykScJdKC2PVrKQs=@emersion.fr> (raw)
In-Reply-To: <20210119015415.2511028-2-lyude@redhat.com>
On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul <lyude@redhat.com> wrote:
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Jeremy Cline <jcline@redhat.com>
> Cc: Simon Ser <contact@emersion.fr>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index c6367035970e..5f4f09a601d4 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev)
> else
> nouveau_display(dev)->format_modifiers = disp50xx_modifiers;
>
> + if (disp->disp->object.oclass >= GK104_DISP) {
I can confirm this works fine on GK208B. Tested with wlroots. I don't
have older cards to test, though.
Tested-by: Simon Ser <contact@emersion.fr>
> + dev->mode_config.cursor_width = 256;
> + dev->mode_config.cursor_height = 256;
> + } else {
> + dev->mode_config.cursor_width = 64;
> + dev->mode_config.cursor_height = 64;
> + }
> +
> /* create crtc objects to represent the hw heads */
> if (disp->disp->object.oclass >= GV100_DISP)
> crtcs = nvif_rd32(&device->object, 0x610060) & 0xff;
> --
> 2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-19 10:48 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 1:54 [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Lyude Paul
2021-01-19 1:54 ` Lyude Paul
2021-01-19 1:54 ` Lyude Paul
2021-01-19 1:54 ` [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Lyude Paul
2021-01-19 1:54 ` Lyude Paul
2021-01-19 1:54 ` Lyude Paul
2021-01-19 10:22 ` Simon Ser [this message]
2021-01-19 10:22 ` Simon Ser
2021-01-19 10:22 ` Simon Ser
2021-02-23 14:15 ` Alex Riesen
2021-02-23 14:15 ` Alex Riesen
2021-02-23 14:15 ` [Nouveau] " Alex Riesen
2021-02-23 14:56 ` Ilia Mirkin
2021-02-23 14:56 ` Ilia Mirkin
2021-02-23 14:56 ` [Nouveau] " Ilia Mirkin
2021-02-23 15:36 ` Alex Riesen
2021-02-23 15:36 ` Alex Riesen
2021-02-23 15:36 ` [Nouveau] " Alex Riesen
2021-02-23 15:46 ` Ilia Mirkin
2021-02-23 15:46 ` Ilia Mirkin
2021-02-23 15:46 ` [Nouveau] " Ilia Mirkin
2021-02-23 15:51 ` Alex Riesen
2021-02-23 15:51 ` Alex Riesen
2021-02-23 15:51 ` [Nouveau] " Alex Riesen
2021-02-23 16:22 ` Alex Riesen
2021-02-23 16:22 ` Alex Riesen
2021-02-23 16:22 ` [Nouveau] " Alex Riesen
2021-02-23 18:13 ` Ilia Mirkin
2021-02-23 18:13 ` Ilia Mirkin
2021-02-23 18:13 ` [Nouveau] " Ilia Mirkin
2021-02-24 9:08 ` Alex Riesen
2021-02-24 9:08 ` Alex Riesen
2021-02-24 9:08 ` [Nouveau] " Alex Riesen
2021-02-24 15:10 ` Ilia Mirkin
2021-02-24 15:10 ` Ilia Mirkin
2021-02-24 16:35 ` [Nouveau] " Alex Riesen
2021-02-24 16:35 ` Alex Riesen
2021-02-24 16:48 ` [Nouveau] " Ilia Mirkin
2021-02-24 16:48 ` Ilia Mirkin
2021-02-24 16:53 ` [Nouveau] " Alex Riesen
2021-02-24 16:53 ` Alex Riesen
2021-02-24 16:57 ` [Nouveau] " Ilia Mirkin
2021-02-24 16:57 ` Ilia Mirkin
2021-02-24 17:02 ` [Nouveau] " Alex Riesen
2021-02-24 17:02 ` Alex Riesen
2021-02-24 17:47 ` [Nouveau] " Ilia Mirkin
2021-02-24 17:47 ` Ilia Mirkin
2021-02-27 12:28 ` [Nouveau] " Uwe Sauter
2021-02-27 21:26 ` Ilia Mirkin
2021-02-28 15:10 ` Uwe Sauter
2021-02-28 17:02 ` Ilia Mirkin
2021-02-28 17:59 ` Uwe Sauter
2021-02-28 19:10 ` Ilia Mirkin
2021-02-28 19:24 ` Uwe Sauter
2021-02-28 20:38 ` Ilia Mirkin
2021-03-03 12:41 ` Alex Riesen
2021-03-03 13:12 ` Ilia Mirkin
2021-03-03 13:25 ` Uwe Sauter
2021-03-03 13:33 ` Ilia Mirkin
2021-03-03 17:02 ` Uwe Sauter
2021-03-03 17:11 ` Lyude Paul
2021-03-03 16:51 ` Lyude Paul
2021-03-03 17:05 ` James Jones
2021-01-19 1:54 ` [PATCH 3/3] drm/nouveau/kms/nve4-nv138: Fix > 64x64 cursors Lyude Paul
2021-01-19 1:54 ` Lyude Paul
2021-01-19 1:54 ` Lyude Paul
2021-01-19 10:18 ` [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Simon Ser
2021-01-19 10:18 ` Simon Ser
2021-01-19 10:18 ` Simon Ser
2021-01-19 15:50 ` Ville Syrjälä
2021-01-19 15:50 ` Ville Syrjälä
2021-01-19 15:50 ` Ville Syrjälä
2021-01-19 15:52 ` James Jones
2021-01-19 15:52 ` James Jones
2021-01-19 15:52 ` James Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='iyiRYoTlFNd1Crgc673rDXnfqahsfhKFP89rA0kKYEFUpLGwsFtYL-x-Jwh1ZAo7vJerbikydEDSUFtAoewsGkh3WSYeykScJdKC2PVrKQs=@emersion.fr' \
--to=contact@emersion.fr \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jajones@nvidia.com \
--cc=jcline@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=martin.peres@free.fr \
--cc=nouveau@lists.freedesktop.org \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.