From: Andi Shyti <andi.shyti@kernel.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: s3c64xx: Extract FIFO depth calculation to a dedicated macro
Date: Sun, 21 Jan 2024 21:23:54 +0100 [thread overview]
Message-ID: <k5ih3vurmzrirgfzy62r5nezm2sxp3zf2qa2bhzowybthkvduv@wjywn55v5hmj> (raw)
In-Reply-To: <20240120170001.3356-1-semen.protsenko@linaro.org>
Hi Sam,
> void __iomem *regs = sdd->regs;
> unsigned long val = 1;
> u32 status;
> -
> - /* max fifo depth available */
> - u32 max_fifo = (FIFO_LVL_MASK(sdd) >> 1) + 1;
> + u32 max_fifo = FIFO_DEPTH(sdd);
Why have you removed the comment? Perhaps you could place it on
the side in order to remove that awful space.
Not a biding comment, though:
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@kernel.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: s3c64xx: Extract FIFO depth calculation to a dedicated macro
Date: Sun, 21 Jan 2024 21:23:54 +0100 [thread overview]
Message-ID: <k5ih3vurmzrirgfzy62r5nezm2sxp3zf2qa2bhzowybthkvduv@wjywn55v5hmj> (raw)
In-Reply-To: <20240120170001.3356-1-semen.protsenko@linaro.org>
Hi Sam,
> void __iomem *regs = sdd->regs;
> unsigned long val = 1;
> u32 status;
> -
> - /* max fifo depth available */
> - u32 max_fifo = (FIFO_LVL_MASK(sdd) >> 1) + 1;
> + u32 max_fifo = FIFO_DEPTH(sdd);
Why have you removed the comment? Perhaps you could place it on
the side in order to remove that awful space.
Not a biding comment, though:
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-21 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 17:00 [PATCH] spi: s3c64xx: Extract FIFO depth calculation to a dedicated macro Sam Protsenko
2024-01-20 17:00 ` Sam Protsenko
2024-01-21 20:23 ` Andi Shyti [this message]
2024-01-21 20:23 ` Andi Shyti
2024-01-21 22:11 ` Sam Protsenko
2024-01-21 22:11 ` Sam Protsenko
2024-01-21 23:26 ` Andi Shyti
2024-01-21 23:26 ` Andi Shyti
2024-01-22 2:34 ` Sam Protsenko
2024-01-22 2:34 ` Sam Protsenko
2024-01-22 20:44 ` Mark Brown
2024-01-22 20:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k5ih3vurmzrirgfzy62r5nezm2sxp3zf2qa2bhzowybthkvduv@wjywn55v5hmj \
--to=andi.shyti@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.