* [PATCH 1/2] kconfig: remove unused variable in qconf.cc
@ 2020-03-25 3:14 Masahiro Yamada
2020-03-25 3:14 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada
2020-03-26 2:05 ` [PATCH 1/2] kconfig: remove unused variable in qconf.cc Kees Cook
0 siblings, 2 replies; 6+ messages in thread
From: Masahiro Yamada @ 2020-03-25 3:14 UTC (permalink / raw)
To: linux-kbuild; +Cc: Kees Cook, kernel-hardening, Masahiro Yamada, linux-kernel
If this file were compiled with -Wall, the following warning would be
reported:
scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable]
int i;
^
The commit prepares to turn on -Wall for C++ host programs.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/kconfig/qconf.cc | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 82773cc35d35..50a5245d87bb 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name)
showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt),
rootEntry(0), headerPopup(0)
{
- int i;
-
setObjectName(name);
setSortingEnabled(false);
setRootIsDecorated(true);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS 2020-03-25 3:14 [PATCH 1/2] kconfig: remove unused variable in qconf.cc Masahiro Yamada @ 2020-03-25 3:14 ` Masahiro Yamada 2020-03-26 2:06 ` Kees Cook 2020-03-26 2:05 ` [PATCH 1/2] kconfig: remove unused variable in qconf.cc Kees Cook 1 sibling, 1 reply; 6+ messages in thread From: Masahiro Yamada @ 2020-03-25 3:14 UTC (permalink / raw) To: linux-kbuild Cc: Kees Cook, kernel-hardening, Masahiro Yamada, Emese Revfy, Michal Marek, linux-kernel Add -Wall to catch more warnings for C++ host programs. When I submitted the previous version, the 0-day bot reported -Wc++11-compat warnings for old GCC: HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, from scripts/gcc-plugins/gcc-common.h:15, from scripts/gcc-plugins/latent_entropy_plugin.c:78: /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, from scripts/gcc-plugins/gcc-common.h:15, from scripts/gcc-plugins/latent_entropy_plugin.c:78: /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ The source of the warnings is in the plugin headers, so we have no control of it. I just suppressed them by adding -Wno-c++11-compat to scripts/gcc-plugins/Makefile. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Makefile | 2 +- scripts/gcc-plugins/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3b57ccab367b..593d8f1bbe90 100644 --- a/Makefile +++ b/Makefile @@ -400,7 +400,7 @@ HOSTCXX = g++ KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) \ $(HOSTCFLAGS) -KBUILD_HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) +KBUILD_HOSTCXXFLAGS := -Wall -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) KBUILD_HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) $(HOSTLDFLAGS) KBUILD_HOSTLDLIBS := $(HOST_LFS_LIBS) $(HOSTLDLIBS) diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile index f2ee8bd7abc6..efff00959a9c 100644 --- a/scripts/gcc-plugins/Makefile +++ b/scripts/gcc-plugins/Makefile @@ -10,7 +10,7 @@ else HOSTLIBS := hostcxxlibs HOST_EXTRACXXFLAGS += -I$(GCC_PLUGINS_DIR)/include -I$(src) -std=gnu++98 -fno-rtti HOST_EXTRACXXFLAGS += -fno-exceptions -fasynchronous-unwind-tables -ggdb - HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable + HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable -Wno-c++11-compat export HOST_EXTRACXXFLAGS endif -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS 2020-03-25 3:14 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada @ 2020-03-26 2:06 ` Kees Cook 2020-03-29 11:04 ` Masahiro Yamada 0 siblings, 1 reply; 6+ messages in thread From: Kees Cook @ 2020-03-26 2:06 UTC (permalink / raw) To: Masahiro Yamada Cc: linux-kbuild, kernel-hardening, Emese Revfy, Michal Marek, linux-kernel On Wed, Mar 25, 2020 at 12:14:32PM +0900, Masahiro Yamada wrote: > Add -Wall to catch more warnings for C++ host programs. > > When I submitted the previous version, the 0-day bot reported > -Wc++11-compat warnings for old GCC: > > HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, > from scripts/gcc-plugins/gcc-common.h:15, > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ > ^ > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > ^ > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, > from scripts/gcc-plugins/gcc-common.h:15, > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > ^ > > The source of the warnings is in the plugin headers, so we have no > control of it. I just suppressed them by adding -Wno-c++11-compat to > scripts/gcc-plugins/Makefile. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Acked-by: Kees Cook <keescook@chromium.org> -Kees > --- > > Makefile | 2 +- > scripts/gcc-plugins/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 3b57ccab367b..593d8f1bbe90 100644 > --- a/Makefile > +++ b/Makefile > @@ -400,7 +400,7 @@ HOSTCXX = g++ > KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ > -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) \ > $(HOSTCFLAGS) > -KBUILD_HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) > +KBUILD_HOSTCXXFLAGS := -Wall -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) > KBUILD_HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) $(HOSTLDFLAGS) > KBUILD_HOSTLDLIBS := $(HOST_LFS_LIBS) $(HOSTLDLIBS) > > diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile > index f2ee8bd7abc6..efff00959a9c 100644 > --- a/scripts/gcc-plugins/Makefile > +++ b/scripts/gcc-plugins/Makefile > @@ -10,7 +10,7 @@ else > HOSTLIBS := hostcxxlibs > HOST_EXTRACXXFLAGS += -I$(GCC_PLUGINS_DIR)/include -I$(src) -std=gnu++98 -fno-rtti > HOST_EXTRACXXFLAGS += -fno-exceptions -fasynchronous-unwind-tables -ggdb > - HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable > + HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable -Wno-c++11-compat > export HOST_EXTRACXXFLAGS > endif > > -- > 2.17.1 > -- Kees Cook ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS 2020-03-26 2:06 ` Kees Cook @ 2020-03-29 11:04 ` Masahiro Yamada 0 siblings, 0 replies; 6+ messages in thread From: Masahiro Yamada @ 2020-03-29 11:04 UTC (permalink / raw) To: Kees Cook Cc: Linux Kbuild mailing list, Kernel Hardening, Emese Revfy, Michal Marek, Linux Kernel Mailing List On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@chromium.org> wrote: > > On Wed, Mar 25, 2020 at 12:14:32PM +0900, Masahiro Yamada wrote: > > Add -Wall to catch more warnings for C++ host programs. > > > > When I submitted the previous version, the 0-day bot reported > > -Wc++11-compat warnings for old GCC: > > > > HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o > > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, > > from scripts/gcc-plugins/gcc-common.h:15, > > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ > > ^ > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > > ^ > > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, > > from scripts/gcc-plugins/gcc-common.h:15, > > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > > ^ > > > > The source of the warnings is in the plugin headers, so we have no > > control of it. I just suppressed them by adding -Wno-c++11-compat to > > scripts/gcc-plugins/Makefile. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Acked-by: Kees Cook <keescook@chromium.org> > > -Kees Applied to linux-kbuild. -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] kconfig: remove unused variable in qconf.cc 2020-03-25 3:14 [PATCH 1/2] kconfig: remove unused variable in qconf.cc Masahiro Yamada 2020-03-25 3:14 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada @ 2020-03-26 2:05 ` Kees Cook 2020-03-29 11:03 ` Masahiro Yamada 1 sibling, 1 reply; 6+ messages in thread From: Kees Cook @ 2020-03-26 2:05 UTC (permalink / raw) To: Masahiro Yamada; +Cc: linux-kbuild, kernel-hardening, linux-kernel On Wed, Mar 25, 2020 at 12:14:31PM +0900, Masahiro Yamada wrote: > If this file were compiled with -Wall, the following warning would be > reported: > > scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable] > int i; > ^ > > The commit prepares to turn on -Wall for C++ host programs. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > > scripts/kconfig/qconf.cc | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > index 82773cc35d35..50a5245d87bb 100644 > --- a/scripts/kconfig/qconf.cc > +++ b/scripts/kconfig/qconf.cc > @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name) > showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt), > rootEntry(0), headerPopup(0) > { > - int i; > - > setObjectName(name); > setSortingEnabled(false); > setRootIsDecorated(true); > -- > 2.17.1 > -- Kees Cook ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] kconfig: remove unused variable in qconf.cc 2020-03-26 2:05 ` [PATCH 1/2] kconfig: remove unused variable in qconf.cc Kees Cook @ 2020-03-29 11:03 ` Masahiro Yamada 0 siblings, 0 replies; 6+ messages in thread From: Masahiro Yamada @ 2020-03-29 11:03 UTC (permalink / raw) To: Kees Cook Cc: Linux Kbuild mailing list, Kernel Hardening, Linux Kernel Mailing List On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@chromium.org> wrote: > > On Wed, Mar 25, 2020 at 12:14:31PM +0900, Masahiro Yamada wrote: > > If this file were compiled with -Wall, the following warning would be > > reported: > > > > scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable] > > int i; > > ^ > > > > The commit prepares to turn on -Wall for C++ host programs. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Reviewed-by: Kees Cook <keescook@chromium.org> > Applied to linux-kbuild. > -Kees > > > --- > > > > scripts/kconfig/qconf.cc | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > > index 82773cc35d35..50a5245d87bb 100644 > > --- a/scripts/kconfig/qconf.cc > > +++ b/scripts/kconfig/qconf.cc > > @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name) > > showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt), > > rootEntry(0), headerPopup(0) > > { > > - int i; > > - > > setObjectName(name); > > setSortingEnabled(false); > > setRootIsDecorated(true); > > -- > > 2.17.1 > > > > -- > Kees Cook -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-29 11:12 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-25 3:14 [PATCH 1/2] kconfig: remove unused variable in qconf.cc Masahiro Yamada 2020-03-25 3:14 ` [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Masahiro Yamada 2020-03-26 2:06 ` Kees Cook 2020-03-29 11:04 ` Masahiro Yamada 2020-03-26 2:05 ` [PATCH 1/2] kconfig: remove unused variable in qconf.cc Kees Cook 2020-03-29 11:03 ` Masahiro Yamada
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).