From: Kees Cook <keescook@chromium.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
X86 ML <x86@kernel.org>
Subject: Re: [PATCH] x86/asm: Pin sensitive CR4 bits
Date: Wed, 20 Feb 2019 09:01:27 -0800 [thread overview]
Message-ID: <CAGXu5jKPtL4oSa_7QJEXVc++idNNH9GA1Y=z3tQrorRTs0fnsA@mail.gmail.com> (raw)
In-Reply-To: <20190220081451.GA2254@light.dominikbrodowski.net>
On Wed, Feb 20, 2019 at 12:15 AM Dominik Brodowski
<linux@dominikbrodowski.net> wrote:
>
> On Tue, Feb 19, 2019 at 04:54:49PM -0800, Kees Cook wrote:
> > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> > index cb28e98a0659..7e0ea4470f8e 100644
> > --- a/arch/x86/kernel/cpu/common.c
> > +++ b/arch/x86/kernel/cpu/common.c
> > @@ -312,10 +312,16 @@ static __init int setup_disable_smep(char *arg)
> > }
> > __setup("nosmep", setup_disable_smep);
> >
> > +volatile unsigned long cr4_pin __ro_after_init;
> > +EXPORT_SYMBOL_GPL(cr4_pin);
>
> Where is this export needed?
I use it in lkdtm (which I was going to land through the drivers tree,
but I haven't sent to Greg):
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=kspp/x86/cr4
--
Kees Cook
prev parent reply other threads:[~2019-02-20 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 0:54 [PATCH] x86/asm: Pin sensitive CR4 bits Kees Cook
2019-02-20 2:37 ` Jann Horn
2019-02-20 17:00 ` Kees Cook
2019-02-20 8:14 ` Dominik Brodowski
2019-02-20 17:01 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jKPtL4oSa_7QJEXVc++idNNH9GA1Y=z3tQrorRTs0fnsA@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).