Kernel-hardening archive on lore.kernel.org
 help / color / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Oscar Carter <oscar.carter@gmx.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	 Kees Cook <keescook@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	 Jason Cooper <jason@lakedaemon.net>, Len Brown <lenb@kernel.org>,
	 Kernel Hardening <kernel-hardening@lists.openwall.com>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] drivers/acpi: Remove function callback casts
Date: Fri, 26 Jun 2020 15:17:08 +0200
Message-ID: <CAJZ5v0gJJsLyWokpVT8Cy-h+GE5nyqGip_Log1L9i5z+x+nTwg@mail.gmail.com> (raw)
In-Reply-To: <07911cc62ef21900c43aeefbcbfc8d9f@kernel.org>

Hi,

On Fri, Jun 26, 2020 at 3:07 PM Marc Zyngier <maz@kernel.org> wrote:
>
> Hi Rafael,
>
> On 2020-05-30 15:34, Oscar Carter wrote:
> > In an effort to enable -Wcast-function-type in the top-level Makefile
> > to
> > support Control Flow Integrity builds, there are the need to remove all
> > the function callback casts in the acpi driver.
> >
> > The first patch creates a macro called
> > ACPI_DECLARE_SUBTABLE_PROBE_ENTRY
> > to initialize the acpi_probe_entry struct using the probe_subtbl field
> > instead of the probe_table field to avoid function cast mismatches.
> >
> > The second patch modifies the IRQCHIP_ACPI_DECLARE macro to use the new
> > defined macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY instead of the macro
> > ACPI_DECLARE_PROBE_ENTRY. Also, modifies the prototype of the functions
> > used by the invocation of the IRQCHIP_ACPI_DECLARE macro to match all
> > the
> > parameters.
> >
> > The third patch removes the function cast in the
> > ACPI_DECLARE_PROBE_ENTRY
> > macro to ensure that the functions passed as a last parameter to this
> > macro
> > have the right prototype. This macro is used only in another macro
> > called "TIMER_ACPI_DECLARE". An this is used only in the file:
> >
> > drivers/clocksource/arm_arch_timer.c
> >
> > In this file, the function used in the last parameter of the
> > TIMER_ACPI_DECLARE macro already has the right prototype. So there is
> > no
> > need to modify its prototype.
>
> I'd like to see this into 5.9. Can you please let me know if
> you are OK with the acpi.h changes?

Yes, I am.

> I can queue it via the irqchip tree.

Please do!  Also please feel free to add

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

to the patches.

Thanks!

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30 14:34 Oscar Carter
2020-05-30 14:34 ` [PATCH v5 1/3] drivers/acpi: Add new macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY Oscar Carter
2020-05-30 14:34 ` [PATCH v5 2/3] drivers/irqchip: Use " Oscar Carter
2020-05-30 14:34 ` [PATCH v5 3/3] drivers/acpi: Remove function cast Oscar Carter
2020-06-26 13:07 ` [PATCH v5 0/3] drivers/acpi: Remove function callback casts Marc Zyngier
2020-06-26 13:17   ` Rafael J. Wysocki [this message]
2020-06-27 11:08 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0gJJsLyWokpVT8Cy-h+GE5nyqGip_Log1L9i5z+x+nTwg@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oscar.carter@gmx.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Kernel-hardening archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernel-hardening/0 kernel-hardening/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernel-hardening kernel-hardening/ https://lore.kernel.org/kernel-hardening \
		kernel-hardening@lists.openwall.com
	public-inbox-index kernel-hardening

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.openwall.lists.kernel-hardening


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git