* Re: [PATCH] gpio: pxa: use devres for the clock struct
[not found] ` <CACRpkdZEcTD1A3tR=d4fDF89ECMDfchVPW921v6X6ARiPXHEMQ@mail.gmail.com>
@ 2022-08-26 12:18 ` Christophe JAILLET
2022-08-27 12:35 ` Marion & Christophe JAILLET
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-08-26 12:18 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko
Cc: Bartosz Golaszewski, Robert Jarzmik, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List, Hulk Robot, Yuan Can, Kernel Janitors
Le 26/08/2022 à 10:20, Linus Walleij a écrit :
> On Sat, Aug 20, 2022 at 12:15 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Mon, Aug 15, 2022 at 12:26 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>>
>>> The clock is never released after probe(). Use devres to not leak
>>> resources.
>>
>> ...
>>
>>> - clk = clk_get(&pdev->dev, NULL);
>>> + clk = devm_clk_get_enabled(&pdev->dev, NULL);
>>> if (IS_ERR(clk)) {
>>> dev_err(&pdev->dev, "Error %ld to get gpio clock\n",
>>> PTR_ERR(clk));
>>> return PTR_ERR(clk);
>>
>> Shouldn't we fix a potential log saturation issue first (by switching
>> to use dev_err_probe() helper)?
>
> Can be a separate patch, the clock mem leak is a bigger problem
> IMO so this should be applied first.
>
> Hm isn't it possible to toss the task of fixing a gazillion
> dev_err_probe() messages on Cocinelle scripts/coccinelle/? I bet it's something
> the kernel janitors could fix all over the place.
>
> Yours,
> Linus Walleij
>
Not perfect and certainly incomplete, but gives an idea:
@@
expression x, dev, e, str;
@@
(
x = devm_clk_get(dev, e);
|
x = clk_get(dev, e);
)
- if (IS_ERR(x)) {
- dev_err(dev, str);
- return PTR_ERR(x);
- }
+ if (IS_ERR(x))
+ return dev_err_probe(dev, PTR_ERR(x), str);
// This rule only: 291 files changed, 1233 insertions(+), 1634 deletions(-)
// The output of this rule needs to be adjusted to fix the 'str'. The
// error code and related text have to be manually removed
@@
expression x, dev, e, str;
@@
(
x = devm_clk_get(dev, e);
|
x = clk_get(dev, e);
)
- if (IS_ERR(x)) {
- dev_err(dev, str, PTR_ERR(x));
- return PTR_ERR(x);
- }
+ if (IS_ERR(x))
+ return dev_err_probe(dev, PTR_ERR(x), str);
// Both rules: 316 files changed, 1321 insertions(+), 1774 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: pxa: use devres for the clock struct
2022-08-26 12:18 ` [PATCH] gpio: pxa: use devres for the clock struct Christophe JAILLET
@ 2022-08-27 12:35 ` Marion & Christophe JAILLET
0 siblings, 0 replies; 2+ messages in thread
From: Marion & Christophe JAILLET @ 2022-08-27 12:35 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko
Cc: Bartosz Golaszewski, Robert Jarzmik, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List, Hulk Robot, Yuan Can, Kernel Janitors
Le 26/08/2022 à 14:18, Christophe JAILLET a écrit :
> Le 26/08/2022 à 10:20, Linus Walleij a écrit :
>> On Sat, Aug 20, 2022 at 12:15 AM Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>>> On Mon, Aug 15, 2022 at 12:26 PM Bartosz Golaszewski <brgl@bgdev.pl>
>>> wrote:
>>>>
>>>> The clock is never released after probe(). Use devres to not leak
>>>> resources.
>>>
>>> ...
>>>
>>>> - clk = clk_get(&pdev->dev, NULL);
>>>> + clk = devm_clk_get_enabled(&pdev->dev, NULL);
>>>> if (IS_ERR(clk)) {
>>>> dev_err(&pdev->dev, "Error %ld to get gpio clock\n",
>>>> PTR_ERR(clk));
>>>> return PTR_ERR(clk);
>>>
>>> Shouldn't we fix a potential log saturation issue first (by switching
>>> to use dev_err_probe() helper)?
>>
>> Can be a separate patch, the clock mem leak is a bigger problem
>> IMO so this should be applied first.
>>
>> Hm isn't it possible to toss the task of fixing a gazillion
>> dev_err_probe() messages on Cocinelle scripts/coccinelle/? I bet it's
>> something
>> the kernel janitors could fix all over the place.
>>
>> Yours,
>> Linus Walleij
>>
>
> // Both rules: 316 files changed, 1321 insertions(+), 1774 deletions(-)
>
With an updated script, I spot:
503 files changed, 1962 insertions(+), 2622 deletions(-)
(and 150-200 still needs some manual check or script adjustment)
Does this really make sense to send SO many patches for it?
If yes, should it be done on a per-system basis, or by driver basis?
CJ
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-27 12:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220815091929.130547-1-brgl@bgdev.pl>
[not found] ` <CAHp75Vc3dazcM1MLzjzPUmgMGNACUsOZ8aK4uauAJk0hzj9q-w@mail.gmail.com>
[not found] ` <CACRpkdZEcTD1A3tR=d4fDF89ECMDfchVPW921v6X6ARiPXHEMQ@mail.gmail.com>
2022-08-26 12:18 ` [PATCH] gpio: pxa: use devres for the clock struct Christophe JAILLET
2022-08-27 12:35 ` Marion & Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).