* [PATCH V2] nvmem: core: add a missing of_node_put
@ 2021-05-08 6:16 Christophe JAILLET
2021-05-17 9:19 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-05-08 6:16 UTC (permalink / raw)
To: srinivas.kandagatla, bgolaszewski, gregkh
Cc: linux-kernel, kernel-janitors, Christophe JAILLET
'for_each_child_of_node' performs an of_node_get on each iteration, so a
return from the middle of the loop requires an of_node_put.
Fixes: e888d445ac33 ("nvmem: resolve cells from DT at registration time")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v2: Reorder code to delay the 'cell->np = of_node_get(child);'
Without this change, we needed a double 'of_node_put' in the last
hunk which could be confusing to the reader
---
drivers/nvmem/core.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index bca671ff4e54..f9c9c9859919 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -686,15 +686,17 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
continue;
if (len < 2 * sizeof(u32)) {
dev_err(dev, "nvmem: invalid reg on %pOF\n", child);
+ of_node_put(child);
return -EINVAL;
}
cell = kzalloc(sizeof(*cell), GFP_KERNEL);
- if (!cell)
+ if (!cell) {
+ of_node_put(child);
return -ENOMEM;
+ }
cell->nvmem = nvmem;
- cell->np = of_node_get(child);
cell->offset = be32_to_cpup(addr++);
cell->bytes = be32_to_cpup(addr);
cell->name = kasprintf(GFP_KERNEL, "%pOFn", child);
@@ -715,11 +717,12 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
cell->name, nvmem->stride);
/* Cells already added will be freed later. */
kfree_const(cell->name);
- of_node_put(cell->np);
kfree(cell);
+ of_node_put(child);
return -EINVAL;
}
+ cell->np = of_node_get(child);
nvmem_cell_add(cell);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] nvmem: core: add a missing of_node_put
2021-05-08 6:16 [PATCH V2] nvmem: core: add a missing of_node_put Christophe JAILLET
@ 2021-05-17 9:19 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2021-05-17 9:19 UTC (permalink / raw)
To: Christophe JAILLET, bgolaszewski, gregkh; +Cc: linux-kernel, kernel-janitors
On 08/05/2021 07:16, Christophe JAILLET wrote:
> 'for_each_child_of_node' performs an of_node_get on each iteration, so a
> return from the middle of the loop requires an of_node_put.
>
> Fixes: e888d445ac33 ("nvmem: resolve cells from DT at registration time")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Applied thanks,
--srini
> v2: Reorder code to delay the 'cell->np = of_node_get(child);'
> Without this change, we needed a double 'of_node_put' in the last
> hunk which could be confusing to the reader
> ---
> drivers/nvmem/core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index bca671ff4e54..f9c9c9859919 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -686,15 +686,17 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
> continue;
> if (len < 2 * sizeof(u32)) {
> dev_err(dev, "nvmem: invalid reg on %pOF\n", child);
> + of_node_put(child);
> return -EINVAL;
> }
>
> cell = kzalloc(sizeof(*cell), GFP_KERNEL);
> - if (!cell)
> + if (!cell) {
> + of_node_put(child);
> return -ENOMEM;
> + }
>
> cell->nvmem = nvmem;
> - cell->np = of_node_get(child);
> cell->offset = be32_to_cpup(addr++);
> cell->bytes = be32_to_cpup(addr);
> cell->name = kasprintf(GFP_KERNEL, "%pOFn", child);
> @@ -715,11 +717,12 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
> cell->name, nvmem->stride);
> /* Cells already added will be freed later. */
> kfree_const(cell->name);
> - of_node_put(cell->np);
> kfree(cell);
> + of_node_put(child);
> return -EINVAL;
> }
>
> + cell->np = of_node_get(child);
> nvmem_cell_add(cell);
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-17 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 6:16 [PATCH V2] nvmem: core: add a missing of_node_put Christophe JAILLET
2021-05-17 9:19 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).