archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <>
To: Denis Efremov <>, Coccinelle <>
Cc: Gilles Muller <>,
	Julia Lawall <>,
	Masahiro Yamada <>,
	Michal Marek <>,
	Nicolas Palix <>,,,
	"Gustavo A. R. Silva" <>,
	Kees Cook <>
Subject: Re: [PATCH v2] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Thu, 18 Jun 2020 15:01:51 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> Where is the typo?

I tried to point a possible replacement out for the word “overlow” by “overflow”.

> I can't handle your suggestions

I hope that you got chances to take also my patch review comments into account.

> because your mails constantly break the threads. I just can't find them
> after due to missed/wrong In-Reply-To headers.

There are some factors involved for this undesirable effect.

* My software selection contains open issues in the handling of mail links
  according to the communication interface “public inbox”.

* Mailing list settings hinder more direct participation (for me).

* If you would specify more mail addresses for reviewers (like me) explicitly
  as recipients, the impression can hopefully become more positive again.

>>> +expression subE1 <= as.E1;
>>> +expression subE2 <= as.E2;
>>> +expression as.E1, as.E2, E3;
>> How do you think about to use the following SmPL code variant?
>> expression subE1 <= as.E1, subE2 <= as.E2, as.E1, as.E2, E3;
> It's less readable and harder to review.

Can a different code formatting help then?

expression subE1 <= as.E1, subE2 <= as.E2,
           as.E1, as.E2, E3;

>> I suggest to move the ampersand before the disjunction in such
>> SmPL code exclusion specifications.
>> +      when != & \(E1 \| E2 \| subE1 \| subE2\)
> Ok, I will fix this if there will be next version.

Other software extensions which you proposed recently were similarly affected
at a few places.

>> I would prefer an other code formatting at such places.
>> +                             f"WARNING: array_size is already used (line {p1[0].line}) to compute the same size.")
> No. It's pointless to break the line to save 5 chars this way.

Did we get used to function parameter alignment?

I suggest to reconsider potential concerns for line length limitations
according to such message strings.


  parent reply	other threads:[~2020-06-18 15:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 11:34 [PATCH v2] coccinelle: misc: add array_size_dup script to detect missed overflow checks Markus Elfring
2020-06-18 12:24 ` Denis Efremov
2020-06-18 15:01   ` Markus Elfring
2020-06-18 15:01   ` Markus Elfring [this message]
2020-06-19 11:15   ` Coccinelle: Improving convenience for message exchange Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).