archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <>
To: Denis Efremov <>,
	Coccinelle <>,
	Gilles Muller <>,
	Julia Lawall <>,
	Masahiro Yamada <>,
	Michal Marek <>,
	Nicolas Palix <>
	"Gustavo A. R. Silva" <>,
	Kees Cook <>
Subject: Re: [PATCH v2] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Thu, 18 Jun 2020 11:34:52 +0000	[thread overview]
Message-ID: <> (raw)

Why did you repeat a typo from the previous patch subject?

> Changes in v2:
> - assignment operator used

Did you add just a metavariable for this implementation detail?

> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;

How do you think about to use the following SmPL code variant?

expression subE1 <= as.E1, subE2 <= as.E2, as.E1, as.E2, E3;

> +      when != \(&E1\|&E2\|&subE1\|&subE2\)

I suggest to move the ampersand before the disjunction in such
SmPL code exclusion specifications.

+      when != & \(E1 \| E2 \| subE1 \| subE2\)

> +f"WARNING: array_size is already used (line {p1[0].line}) to compute \
> +the same size")

I would prefer an other code formatting at such places.[0],
+                             f"WARNING: array_size is already used (line {p1[0].line}) to compute the same size.")


             reply	other threads:[~2020-06-18 11:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 11:34 Markus Elfring [this message]
2020-06-18 12:24 ` [PATCH v2] coccinelle: misc: add array_size_dup script to detect missed overflow checks Denis Efremov
2020-06-18 15:01   ` Markus Elfring
2020-06-18 15:01   ` Markus Elfring
2020-06-19 11:15   ` Coccinelle: Improving convenience for message exchange Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).