From: Markus Elfring <Markus.Elfring@web.de>
To: Denis Efremov <efremov@linux.com>,
Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Julia Lawall <julia.lawall@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Thu, 18 Jun 2020 11:34:52 +0000 [thread overview]
Message-ID: <54ac89f1-5f38-8909-a652-c658a5a1f36b@web.de> (raw)
Why did you repeat a typo from the previous patch subject?
> Changes in v2:
…
> - assignment operator used
Did you add just a metavariable for this implementation detail?
…
> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;
How do you think about to use the following SmPL code variant?
expression subE1 <= as.E1, subE2 <= as.E2, as.E1, as.E2, E3;
> + when != \(&E1\|&E2\|&subE1\|&subE2\)
I suggest to move the ampersand before the disjunction in such
SmPL code exclusion specifications.
+ when != & \(E1 \| E2 \| subE1 \| subE2\)
> +coccilib.report.print_report(p2[0],
> +f"WARNING: array_size is already used (line {p1[0].line}) to compute \
> +the same size")
I would prefer an other code formatting at such places.
+coccilib.report.print_report(p2[0],
+ f"WARNING: array_size is already used (line {p1[0].line}) to compute the same size.")
Regards,
Markus
next reply other threads:[~2020-06-18 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 11:34 Markus Elfring [this message]
2020-06-18 12:24 ` [PATCH v2] coccinelle: misc: add array_size_dup script to detect missed overflow checks Denis Efremov
2020-06-18 15:01 ` Markus Elfring
2020-06-18 15:01 ` Markus Elfring
2020-06-19 11:15 ` Coccinelle: Improving convenience for message exchange Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ac89f1-5f38-8909-a652-c658a5a1f36b@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=garsilva@embeddedor.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).