From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mihai Carabas <mihai.carabas@oracle.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
pizhenwei@bytedance.com, Paolo Bonzini <pbonzini@redhat.com>,
bobo.shaobowang@huawei.com, linqiheng@huawei.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] misc/pvpanic: Make 'pvpanic_probe()' resource managed
Date: Sat, 22 May 2021 12:57:21 +0200 [thread overview]
Message-ID: <1217b537-57ea-dcf2-06d8-5b5bd7bcbd5f@wanadoo.fr> (raw)
In-Reply-To: <CAHp75Vct5cHgSDU4oQ8ScEoKviiZZgYCKN62AEy0MS=V4oGTiQ@mail.gmail.com>
Le 22/05/2021 à 12:09, Andy Shevchenko a écrit :
> On Sat, May 22, 2021 at 1:06 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Sat, May 22, 2021 at 9:56 AM Christophe JAILLET
>> <christophe.jaillet@wanadoo.fr> wrote:
>
> Hmm... Couple of (minor) comments though.
>
>>> Simplify code and turn 'pvpanic_probe()' into a managed resource version.
>>> This simplify callers that don't need to do some clean-up on error in the
>
> simplifies
> errors
>
Ok
>>> probe and on remove.
>>>
>>> Update pvpanic-mmio.c and pvpanic-pci.c accordingly.
>>>
>>> 'pvpanic_remove()' don't need to be exported anymore.
>>
>> LGTM, thanks!
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> ...
>
>>> +static void pvpanic_remove(void *param)
>>> {
>>> struct pvpanic_instance *pi_cur, *pi_next;
>>> + struct pvpanic_instance *pi = param;
>
>>> if (!pi)
>>> return;
>
> Looking at this I'm wondering why it's not a dead code.
>
Agreed.
I'll send a v3, but my turn to nitpick now:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Which one, should I use?
I guess the later.
CJ
next prev parent reply other threads:[~2021-05-22 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 6:52 [PATCH v2 0/5] misc/pvpanic: Fix some errro handling path and simplify code Christophe JAILLET
2021-05-22 6:54 ` [PATCH v2 1/5] misc/pvpanic-pci: Fix error handling in 'pvpanic_pci_probe()' Christophe JAILLET
2021-05-22 6:54 ` [PATCH v2 2/5] misc/pvpanic-pci: Use GFP_KERNEL instead of GFP_ATOMIC Christophe JAILLET
2021-05-22 6:55 ` [PATCH v2 3/5] misc/pvpanic-mmio: Fix error handling in 'pvpanic_mmio_probe()' Christophe JAILLET
2021-05-22 6:55 ` [PATCH v2 4/5] misc/pvpanic-mmio: Use GFP_KERNEL instead of GFP_ATOMIC Christophe JAILLET
2021-05-22 6:55 ` [PATCH v2 5/5] misc/pvpanic: Make 'pvpanic_probe()' resource managed Christophe JAILLET
2021-05-22 10:06 ` Andy Shevchenko
2021-05-22 10:09 ` Andy Shevchenko
2021-05-22 10:57 ` Christophe JAILLET [this message]
2021-05-22 11:06 ` Andy Shevchenko
2021-05-22 11:30 ` Christophe JAILLET
2021-05-22 10:03 ` [PATCH v2 0/5] misc/pvpanic: Fix some errro handling path and simplify code Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217b537-57ea-dcf2-06d8-5b5bd7bcbd5f@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bobo.shaobowang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linqiheng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).