kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mihai Carabas <mihai.carabas@oracle.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	pizhenwei@bytedance.com, Paolo Bonzini <pbonzini@redhat.com>,
	bobo.shaobowang@huawei.com, linqiheng@huawei.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] misc/pvpanic: Make 'pvpanic_probe()' resource managed
Date: Sat, 22 May 2021 14:06:22 +0300	[thread overview]
Message-ID: <CAHp75VfQHEU9C41Jrv-a4Vw9OHBtmOStrBMNtPCh-74mj1k9dA@mail.gmail.com> (raw)
In-Reply-To: <1217b537-57ea-dcf2-06d8-5b5bd7bcbd5f@wanadoo.fr>

On Sat, May 22, 2021 at 1:57 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> Le 22/05/2021 à 12:09, Andy Shevchenko a écrit :

...

> I'll send a v3, but my turn to nitpick now:
>
>     Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>     Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Which one, should I use?
> I guess the later.

Both. They have different meanings.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-05-22 11:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22  6:52 [PATCH v2 0/5] misc/pvpanic: Fix some errro handling path and simplify code Christophe JAILLET
2021-05-22  6:54 ` [PATCH v2 1/5] misc/pvpanic-pci: Fix error handling in 'pvpanic_pci_probe()' Christophe JAILLET
2021-05-22  6:54 ` [PATCH v2 2/5] misc/pvpanic-pci: Use GFP_KERNEL instead of GFP_ATOMIC Christophe JAILLET
2021-05-22  6:55 ` [PATCH v2 3/5] misc/pvpanic-mmio: Fix error handling in 'pvpanic_mmio_probe()' Christophe JAILLET
2021-05-22  6:55 ` [PATCH v2 4/5] misc/pvpanic-mmio: Use GFP_KERNEL instead of GFP_ATOMIC Christophe JAILLET
2021-05-22  6:55 ` [PATCH v2 5/5] misc/pvpanic: Make 'pvpanic_probe()' resource managed Christophe JAILLET
2021-05-22 10:06   ` Andy Shevchenko
2021-05-22 10:09     ` Andy Shevchenko
2021-05-22 10:57       ` Christophe JAILLET
2021-05-22 11:06         ` Andy Shevchenko [this message]
2021-05-22 11:30           ` Christophe JAILLET
2021-05-22 10:03 ` [PATCH v2 0/5] misc/pvpanic: Fix some errro handling path and simplify code Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VfQHEU9C41Jrv-a4Vw9OHBtmOStrBMNtPCh-74mj1k9dA@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=bobo.shaobowang@huawei.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linqiheng@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.carabas@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=pizhenwei@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).