* [PATCH 0/1] drop unneeded of_node_get
@ 2015-10-25 21:24 Julia Lawall
2015-10-25 21:24 ` [PATCH 1/1] MIPS: pci-rt3883: " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2015-10-25 21:24 UTC (permalink / raw)
To: linux-kernel
Cc: kernel-janitors, linux-mips, Ralf Baechle,
Russell King - ARM Linux, Thomas Petazzoni, Andrew Lunn,
Bjorn Helgaas, Jason Cooper
for_each_child_of_node performs an of_node_get on each iteration, so no
of_node_get is needed on breaking out of the loop when the device_node
structure is saved in another variable.
The complete semantic match that finds this problem is
(http://coccinelle.lip6.fr):
// <smpl>
@r@
local idexpression n;
expression e1,e2;
iterator name for_each_node_by_name, for_each_node_by_type,
for_each_compatible_node, for_each_matching_node,
for_each_matching_node_and_match, for_each_child_of_node,
for_each_available_child_of_node, for_each_node_with_property;
iterator i;
statement S;
expression list [n1] es;
@@
(
(
for_each_node_by_name(n,e1) S
|
for_each_node_by_type(n,e1) S
|
for_each_compatible_node(n,e1,e2) S
|
for_each_matching_node(n,e1) S
|
for_each_matching_node_and_match(n,e1,e2) S
|
for_each_child_of_node(e1,n) S
|
for_each_available_child_of_node(e1,n) S
|
for_each_node_with_property(n,e1) S
)
&
i(es,n,...) S
)
@@
local idexpression r.n;
iterator r.i;
expression list [r.n1] es;
@@
i(es,n,...) {
<...
* return (of_node_get(n));
...>
}
@@
local idexpression r.n;
iterator r.i;
expression list [r.n1] es;
identifier l;
@@
i(es,n,...) {
...
* of_node_get(n)
...
(
break;
|
goto l;
|
return ...;
)
}
// </smpl>
---
arch/mips/pci/pci-rt3883.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] MIPS: pci-rt3883: drop unneeded of_node_get
2015-10-25 21:24 [PATCH 0/1] drop unneeded of_node_get Julia Lawall
@ 2015-10-25 21:24 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2015-10-25 21:24 UTC (permalink / raw)
To: Ralf Baechle
Cc: kernel-janitors, linux-mips, linux-kernel,
Russell King - ARM Linux, Thomas Petazzoni, Andrew Lunn,
Bjorn Helgaas, Jason Cooper
for_each_child_of_node performs an of_node_get on each iteration, so no
of_node_get is needed on breaking out of the loop when the device_node
structure is saved in another variable.
A simplified semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
expression root;
local idexpression child;
@@
for_each_child_of_node(root, child) {
...
* of_node_get(child)
...
break;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/mips/pci/pci-rt3883.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c
index ed6732f..53a42b0 100644
--- a/arch/mips/pci/pci-rt3883.c
+++ b/arch/mips/pci/pci-rt3883.c
@@ -432,8 +432,7 @@ static int rt3883_pci_probe(struct platform_device *pdev)
/* find the interrupt controller child node */
for_each_child_of_node(np, child) {
- if (of_get_property(child, "interrupt-controller", NULL) &&
- of_node_get(child)) {
+ if (of_get_property(child, "interrupt-controller", NULL)) {
rpc->intc_of_node = child;
break;
}
@@ -449,8 +448,7 @@ static int rt3883_pci_probe(struct platform_device *pdev)
/* find the PCI host bridge child node */
for_each_child_of_node(np, child) {
if (child->type &&
- of_node_cmp(child->type, "pci") = 0 &&
- of_node_get(child)) {
+ of_node_cmp(child->type, "pci") = 0) {
rpc->pci_controller.of_node = child;
break;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-25 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-25 21:24 [PATCH 0/1] drop unneeded of_node_get Julia Lawall
2015-10-25 21:24 ` [PATCH 1/1] MIPS: pci-rt3883: " Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).