* [PATCH] PCI: constify pci_platform_pm_ops structure
@ 2015-12-06 16:33 Julia Lawall
2015-12-07 1:41 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2015-12-06 16:33 UTC (permalink / raw)
To: linux-kernel
Cc: kernel-janitors, linux-pci, linux-acpi, Bjorn Helgaas, Len Brown,
Rafael J. Wysocki
The pci_platform_pm_ops structure is never modified, so declare it as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/pci/pci-acpi.c | 2 +-
drivers/pci/pci.c | 4 ++--
drivers/pci/pci.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index a32ba75..8400f80 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -529,7 +529,7 @@ static bool acpi_pci_need_resume(struct pci_dev *dev)
return !!adev->power.flags.dsw_present;
}
-static struct pci_platform_pm_ops acpi_pci_platform_pm = {
+static const struct pci_platform_pm_ops acpi_pci_platform_pm = {
.is_manageable = acpi_pci_power_manageable,
.set_state = acpi_pci_set_power_state,
.choose_state = acpi_pci_choose_state,
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 314db8c..d1a7105 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -527,9 +527,9 @@ static void pci_restore_bars(struct pci_dev *dev)
pci_update_resource(dev, i);
}
-static struct pci_platform_pm_ops *pci_platform_pm;
+static const struct pci_platform_pm_ops *pci_platform_pm;
-int pci_set_platform_pm(struct pci_platform_pm_ops *ops)
+int pci_set_platform_pm(const struct pci_platform_pm_ops *ops)
{
if (!ops->is_manageable || !ops->set_state || !ops->choose_state
|| !ops->sleep_wake)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index d390fc1..f6f151a 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -68,7 +68,7 @@ struct pci_platform_pm_ops {
bool (*need_resume)(struct pci_dev *dev);
};
-int pci_set_platform_pm(struct pci_platform_pm_ops *ops);
+int pci_set_platform_pm(const struct pci_platform_pm_ops *ops);
void pci_update_current_state(struct pci_dev *dev, pci_power_t state);
void pci_power_up(struct pci_dev *dev);
void pci_disable_enabled_device(struct pci_dev *dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: constify pci_platform_pm_ops structure
2015-12-06 16:33 [PATCH] PCI: constify pci_platform_pm_ops structure Julia Lawall
@ 2015-12-07 1:41 ` Rafael J. Wysocki
2015-12-07 16:06 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2015-12-07 1:41 UTC (permalink / raw)
To: Julia Lawall, Bjorn Helgaas
Cc: linux-kernel, kernel-janitors, linux-pci, linux-acpi, Len Brown
On Sunday, December 06, 2015 05:33:45 PM Julia Lawall wrote:
> The pci_platform_pm_ops structure is never modified, so declare it as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
OK
Bjorn, do you want me to handle this one?
> ---
> drivers/pci/pci-acpi.c | 2 +-
> drivers/pci/pci.c | 4 ++--
> drivers/pci/pci.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index a32ba75..8400f80 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -529,7 +529,7 @@ static bool acpi_pci_need_resume(struct pci_dev *dev)
> return !!adev->power.flags.dsw_present;
> }
>
> -static struct pci_platform_pm_ops acpi_pci_platform_pm = {
> +static const struct pci_platform_pm_ops acpi_pci_platform_pm = {
> .is_manageable = acpi_pci_power_manageable,
> .set_state = acpi_pci_set_power_state,
> .choose_state = acpi_pci_choose_state,
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 314db8c..d1a7105 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -527,9 +527,9 @@ static void pci_restore_bars(struct pci_dev *dev)
> pci_update_resource(dev, i);
> }
>
> -static struct pci_platform_pm_ops *pci_platform_pm;
> +static const struct pci_platform_pm_ops *pci_platform_pm;
>
> -int pci_set_platform_pm(struct pci_platform_pm_ops *ops)
> +int pci_set_platform_pm(const struct pci_platform_pm_ops *ops)
> {
> if (!ops->is_manageable || !ops->set_state || !ops->choose_state
> || !ops->sleep_wake)
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index d390fc1..f6f151a 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -68,7 +68,7 @@ struct pci_platform_pm_ops {
> bool (*need_resume)(struct pci_dev *dev);
> };
>
> -int pci_set_platform_pm(struct pci_platform_pm_ops *ops);
> +int pci_set_platform_pm(const struct pci_platform_pm_ops *ops);
> void pci_update_current_state(struct pci_dev *dev, pci_power_t state);
> void pci_power_up(struct pci_dev *dev);
> void pci_disable_enabled_device(struct pci_dev *dev);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: constify pci_platform_pm_ops structure
2015-12-07 1:41 ` Rafael J. Wysocki
@ 2015-12-07 16:06 ` Bjorn Helgaas
2015-12-09 0:51 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2015-12-07 16:06 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Julia Lawall, Bjorn Helgaas, linux-kernel, kernel-janitors,
linux-pci, linux-acpi, Len Brown
On Mon, Dec 07, 2015 at 02:41:34AM +0100, Rafael J. Wysocki wrote:
> On Sunday, December 06, 2015 05:33:45 PM Julia Lawall wrote:
> > The pci_platform_pm_ops structure is never modified, so declare it as
> > const.
> >
> > Done with the help of Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> OK
>
> Bjorn, do you want me to handle this one?
Sure, sounds good to me.
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > drivers/pci/pci-acpi.c | 2 +-
> > drivers/pci/pci.c | 4 ++--
> > drivers/pci/pci.h | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> > index a32ba75..8400f80 100644
> > --- a/drivers/pci/pci-acpi.c
> > +++ b/drivers/pci/pci-acpi.c
> > @@ -529,7 +529,7 @@ static bool acpi_pci_need_resume(struct pci_dev *dev)
> > return !!adev->power.flags.dsw_present;
> > }
> >
> > -static struct pci_platform_pm_ops acpi_pci_platform_pm = {
> > +static const struct pci_platform_pm_ops acpi_pci_platform_pm = {
> > .is_manageable = acpi_pci_power_manageable,
> > .set_state = acpi_pci_set_power_state,
> > .choose_state = acpi_pci_choose_state,
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 314db8c..d1a7105 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -527,9 +527,9 @@ static void pci_restore_bars(struct pci_dev *dev)
> > pci_update_resource(dev, i);
> > }
> >
> > -static struct pci_platform_pm_ops *pci_platform_pm;
> > +static const struct pci_platform_pm_ops *pci_platform_pm;
> >
> > -int pci_set_platform_pm(struct pci_platform_pm_ops *ops)
> > +int pci_set_platform_pm(const struct pci_platform_pm_ops *ops)
> > {
> > if (!ops->is_manageable || !ops->set_state || !ops->choose_state
> > || !ops->sleep_wake)
> > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> > index d390fc1..f6f151a 100644
> > --- a/drivers/pci/pci.h
> > +++ b/drivers/pci/pci.h
> > @@ -68,7 +68,7 @@ struct pci_platform_pm_ops {
> > bool (*need_resume)(struct pci_dev *dev);
> > };
> >
> > -int pci_set_platform_pm(struct pci_platform_pm_ops *ops);
> > +int pci_set_platform_pm(const struct pci_platform_pm_ops *ops);
> > void pci_update_current_state(struct pci_dev *dev, pci_power_t state);
> > void pci_power_up(struct pci_dev *dev);
> > void pci_disable_enabled_device(struct pci_dev *dev);
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: constify pci_platform_pm_ops structure
2015-12-07 16:06 ` Bjorn Helgaas
@ 2015-12-09 0:51 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2015-12-09 0:51 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Julia Lawall, Bjorn Helgaas, linux-kernel, kernel-janitors,
linux-pci, linux-acpi, Len Brown
On Monday, December 07, 2015 10:06:49 AM Bjorn Helgaas wrote:
> On Mon, Dec 07, 2015 at 02:41:34AM +0100, Rafael J. Wysocki wrote:
> > On Sunday, December 06, 2015 05:33:45 PM Julia Lawall wrote:
> > > The pci_platform_pm_ops structure is never modified, so declare it as
> > > const.
> > >
> > > Done with the help of Coccinelle.
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > OK
> >
> > Bjorn, do you want me to handle this one?
>
> Sure, sounds good to me.
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
OK, queued up for 4.5, thanks!
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-09 0:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-06 16:33 [PATCH] PCI: constify pci_platform_pm_ops structure Julia Lawall
2015-12-07 1:41 ` Rafael J. Wysocki
2015-12-07 16:06 ` Bjorn Helgaas
2015-12-09 0:51 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).