* [PATCH] net: bridge: remove redundant assignment
@ 2021-05-25 4:05 Nigel Christian
2021-05-25 22:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Nigel Christian @ 2021-05-25 4:05 UTC (permalink / raw)
To: Roopa Prabhu, Nikolay Aleksandrov, David S. Miller, Jakub Kicinski
Cc: bridge, netdev, kernel-janitors
The variable br is assigned a value that is not being read after
exiting case IFLA_STATS_LINK_XSTATS_SLAVE. The assignment is
redundant and can be removed.
Addresses-Coverity ("Unused value")
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
net/bridge/br_netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index e4e6e991313e..8642e56059fb 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -1644,7 +1644,6 @@ static size_t br_get_linkxstats_size(const struct net_device *dev, int attr)
p = br_port_get_rtnl(dev);
if (!p)
return 0;
- br = p->br;
vg = nbp_vlan_group(p);
break;
default:
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: bridge: remove redundant assignment
2021-05-25 4:05 [PATCH] net: bridge: remove redundant assignment Nigel Christian
@ 2021-05-25 22:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-25 22:30 UTC (permalink / raw)
To: Nigel Christian
Cc: roopa, nikolay, davem, kuba, bridge, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 24 May 2021 23:05:58 -0500 you wrote:
> The variable br is assigned a value that is not being read after
> exiting case IFLA_STATS_LINK_XSTATS_SLAVE. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity ("Unused value")
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
>
> [...]
Here is the summary with links:
- net: bridge: remove redundant assignment
https://git.kernel.org/netdev/net-next/c/ccc882f0d838
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-25 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 4:05 [PATCH] net: bridge: remove redundant assignment Nigel Christian
2021-05-25 22:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).